)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6ea87c6e0758ddf8de2facf3a6a2f6e760ad7e6b","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Implements: blueprint centralize-config-options-pike"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- option\u0027s type was a list, while it should have been a bool"},{"line_number":20,"context_line":"- option\u0027s name indicated"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I9890f8ccb6c0f07a4c0ef5fce8d575c0da9d1995"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfeb2761_7a796291","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":25},"updated":"2017-04-03 15:14:38.000000000","message":"this is duplicate","commit_id":"fb1b59994ca1f575eaac54222d56a53565c3421a"}],"nova/conf/libvirt.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7e1c5aa8f1db7bf330371010151794f6c2a8c04","unresolved":false,"context_lines":[{"line_number":712,"context_line":"]"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"libvirt_volume_opts \u003d ["},{"line_number":715,"context_line":"    cfg.BoolOpt(\u0027qemu_enable_gluster_storage_driver\u0027,"},{"line_number":716,"context_line":"                default\u003dFalse,"},{"line_number":717,"context_line":"                deprecated_name\u003d\u0027qemu_allowed_storage_drivers\u0027,"},{"line_number":718,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_c8985f76","line":715,"range":{"start_line":715,"start_character":4,"end_line":715,"end_character":15},"updated":"2017-03-28 14:04:07.000000000","message":"I don\u0027t know if you can do this as it will break an existing configuration file on upgrade. What you could do instead is define a new option, deprecate the old one, and make use of the \u0027deprecated_opts\u0027 option [1].\n\n[1] https://github.com/openstack/oslo.config/blob/4624e969/oslo_config/cfg.py#L771","commit_id":"fb1b59994ca1f575eaac54222d56a53565c3421a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"967a355e247e6a25174401bc1c76d42d42a06afb","unresolved":false,"context_lines":[{"line_number":712,"context_line":"]"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"libvirt_volume_opts \u003d ["},{"line_number":715,"context_line":"    cfg.BoolOpt(\u0027qemu_enable_gluster_storage_driver\u0027,"},{"line_number":716,"context_line":"                default\u003dFalse,"},{"line_number":717,"context_line":"                deprecated_name\u003d\u0027qemu_allowed_storage_drivers\u0027,"},{"line_number":718,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_55643022","line":715,"range":{"start_line":715,"start_character":4,"end_line":715,"end_character":15},"in_reply_to":"dfeb2761_7a0842d8","updated":"2017-04-03 16:14:34.000000000","message":"No, no, stephen is correct.\n\nConfiguration from release N-1 is supported in release N. Sane defaults for new configuration variables are provided in such a way that deployed code from N can be expected to run without operator intervention.\n\nhttps://governance.openstack.org/tc/reference/tags/assert_supports-upgrade.html","commit_id":"fb1b59994ca1f575eaac54222d56a53565c3421a"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ff0bcfc39e4605e8a478bf6eb91548fb4e2c5b29","unresolved":false,"context_lines":[{"line_number":712,"context_line":"]"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"libvirt_volume_opts \u003d ["},{"line_number":715,"context_line":"    cfg.BoolOpt(\u0027qemu_enable_gluster_storage_driver\u0027,"},{"line_number":716,"context_line":"                default\u003dFalse,"},{"line_number":717,"context_line":"                deprecated_name\u003d\u0027qemu_allowed_storage_drivers\u0027,"},{"line_number":718,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_153c68e0","line":715,"range":{"start_line":715,"start_character":4,"end_line":715,"end_character":15},"in_reply_to":"dfeb2761_7a0842d8","updated":"2017-04-03 16:14:27.000000000","message":"Ok, so I take it back. https://governance.openstack.org/tc/reference/tags/assert_supports-upgrade.html#requirements. But I don\u0027t think you need to deprecate and add new cfg option. For this cycle just accept both types and log a warning that it will be changed to bool in next cycle.","commit_id":"fb1b59994ca1f575eaac54222d56a53565c3421a"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6ea87c6e0758ddf8de2facf3a6a2f6e760ad7e6b","unresolved":false,"context_lines":[{"line_number":712,"context_line":"]"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"libvirt_volume_opts \u003d ["},{"line_number":715,"context_line":"    cfg.BoolOpt(\u0027qemu_enable_gluster_storage_driver\u0027,"},{"line_number":716,"context_line":"                default\u003dFalse,"},{"line_number":717,"context_line":"                deprecated_name\u003d\u0027qemu_allowed_storage_drivers\u0027,"},{"line_number":718,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_7a0842d8","line":715,"range":{"start_line":715,"start_character":4,"end_line":715,"end_character":15},"in_reply_to":"ffe62b97_c8985f76","updated":"2017-04-03 15:14:38.000000000","message":"I think this should be fine, operators have to fix the cfg file before upgrades.","commit_id":"fb1b59994ca1f575eaac54222d56a53565c3421a"}],"releasenotes/notes/rename-qemu-allowed-storage-drivers-b37a6060fb38ff79.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7e1c5aa8f1db7bf330371010151794f6c2a8c04","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configuration option ``qemu_allowed_storage_drivers`` from ``libvirt``"},{"line_number":5,"context_line":"    group has been renamed to ``qemu_enable_gluster_storage_driver`` and it\u0027s"},{"line_number":6,"context_line":"    type has been changed to boolean to better match it\u0027s meaning."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffe62b97_6825d35b","line":6,"range":{"start_line":6,"start_character":53,"end_line":6,"end_character":57},"updated":"2017-03-28 14:04:07.000000000","message":"its","commit_id":"fb1b59994ca1f575eaac54222d56a53565c3421a"}]}