)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a65fdffe163e151e67b59f1cd527eb280a21c7a4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add description to policies in used_limits"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027discoverable\u0027 policy is not documented as it will be removed in a"},{"line_number":10,"context_line":"future change."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"blueprint policy-docs"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffe62b97_21f3efa0","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":14},"updated":"2017-03-24 12:01:48.000000000","message":"Ta :)","commit_id":"7408ec34c05f696ae9e453bb27434524e1dd7b5c"}],"nova/policies/used_limits.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d1a240915177de39dce526cb63b149c0e6678918","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    base.create_rule_default("},{"line_number":30,"context_line":"        BASE_POLICY_NAME,"},{"line_number":31,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":32,"context_line":"        \"Shows rate and absolute limits for the project.\","},{"line_number":33,"context_line":"        ["},{"line_number":34,"context_line":"            {"},{"line_number":35,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_20902543","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":58},"updated":"2017-03-21 02:34:11.000000000","message":"we need to add more in description as this policy is to verify whether to show the requested project specific used limits.","commit_id":"09f270de6e7e4f4d4d3d9fbbc2bbf8886b23db29"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a49e3389b25be5d95100a7e910eed5b69dd3733a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    base.create_rule_default("},{"line_number":30,"context_line":"        BASE_POLICY_NAME,"},{"line_number":31,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":32,"context_line":"        \"Shows rate and absolute limits for the project.\","},{"line_number":33,"context_line":"        ["},{"line_number":34,"context_line":"            {"},{"line_number":35,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_a2741068","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":58},"in_reply_to":"1a1ced50_20902543","updated":"2017-03-21 09:10:16.000000000","message":"Ah, yeah, this one is a bit funky:\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/used_limits.py#L80\n\nWe need to be clear this is checking if you have access to the requested project limits (rather than your own limits).\n\nAlso, we should probably note, this check is done after this check here:\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/limits.py#L58\n\ni.e. you must pass the above limits check before this policy is used.\n\nFWIW, we need to kill this policy rule once we do the proper scope checking, as this is only doing scope checking. But we first need to document it, so we know what we would be removing.","commit_id":"09f270de6e7e4f4d4d3d9fbbc2bbf8886b23db29"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9958a1edc88908d53a01b959eb785f53154e017e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    base.create_rule_default("},{"line_number":30,"context_line":"        BASE_POLICY_NAME,"},{"line_number":31,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":32,"context_line":"        \"Shows rate and absolute limits for the project.\","},{"line_number":33,"context_line":"        ["},{"line_number":34,"context_line":"            {"},{"line_number":35,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_15e409df","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":58},"in_reply_to":"1a1ced50_a2741068","updated":"2017-03-22 08:54:51.000000000","message":"yea, +1 to remove once scope things are in. it was even hidden kind of check tough.","commit_id":"09f270de6e7e4f4d4d3d9fbbc2bbf8886b23db29"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"0a0a848a433474f67f1bf165a7a6c6f2d16e335f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\"Shows rate and absolute limits for the project."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This policy only checks if the user has access to the requested"},{"line_number":37,"context_line":"project limits. And this check is performed only after the check"},{"line_number":38,"context_line":"os_compute_api:limits passes\"\"\","},{"line_number":39,"context_line":"        ["},{"line_number":40,"context_line":"            {"},{"line_number":41,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_31747a99","line":38,"range":{"start_line":37,"start_character":16,"end_line":38,"end_character":28},"updated":"2017-03-23 21:46:41.000000000","message":"Not sure if I can add this here, felt it is good to highlight this as it is a hidden rule.","commit_id":"7408ec34c05f696ae9e453bb27434524e1dd7b5c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a65fdffe163e151e67b59f1cd527eb280a21c7a4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\"Shows rate and absolute limits for the project."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This policy only checks if the user has access to the requested"},{"line_number":37,"context_line":"project limits. And this check is performed only after the check"},{"line_number":38,"context_line":"os_compute_api:limits passes\"\"\","},{"line_number":39,"context_line":"        ["},{"line_number":40,"context_line":"            {"},{"line_number":41,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_e14bc784","line":38,"range":{"start_line":37,"start_character":16,"end_line":38,"end_character":28},"in_reply_to":"ffe62b97_31747a99","updated":"2017-03-24 12:01:48.000000000","message":"Yeah, I\u0027m happy to include this personally","commit_id":"7408ec34c05f696ae9e453bb27434524e1dd7b5c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"200ead35448dfacb644e10660d9bdf92faf41af6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\"Shows rate and absolute limits for the project."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This policy only checks if the user has access to the requested"},{"line_number":37,"context_line":"project limits. And this check is performed only after the check"},{"line_number":38,"context_line":"os_compute_api:limits passes\"\"\","},{"line_number":39,"context_line":"        ["},{"line_number":40,"context_line":"            {"},{"line_number":41,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_ff5aff27","line":38,"range":{"start_line":37,"start_character":16,"end_line":38,"end_character":28},"in_reply_to":"ffe62b97_e14bc784","updated":"2017-03-27 10:45:44.000000000","message":"Makes sense to add that.","commit_id":"7408ec34c05f696ae9e453bb27434524e1dd7b5c"}]}