)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0428bb56b1a7e88b1cbc417c37f9e3bf4492cfc5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: add support for different firmwares"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support for UEFI images by taking hw_firmware_type into account."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"blueprint vmware-boot-uefi"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f91af0f_c61d3474","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":20},"updated":"2018-01-03 18:27:52.000000000","message":"and BIOS","commit_id":"9c643eb5b95ae39b1423334e649b5b29a4702d3c"}],"nova/tests/unit/virt/vmwareapi/test_vm_util.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3ba571d6fa8eb9dc5c2828c4f0e6eebc9081844f","unresolved":false,"context_lines":[{"line_number":890,"context_line":"        expected.version \u003d None"},{"line_number":891,"context_line":"        expected.memoryMB \u003d 2048"},{"line_number":892,"context_line":"        expected.guestId \u003d \u0027otherGuest\u0027"},{"line_number":893,"context_line":"        expected.firmware \u003d \u0027efi\u0027"},{"line_number":894,"context_line":"        expected.extraConfig \u003d []"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"        extra_config \u003d fake_factory.create(\"ns0:OptionValue\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_ce467d7d","line":893,"updated":"2018-01-05 15:53:16.000000000","message":"Note: this is where the specified firmware gets verified.","commit_id":"fc0c6d2f9ab55554299b2adcac2b08991a9683fd"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0428bb56b1a7e88b1cbc417c37f9e3bf4492cfc5","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            \u0027ns0:ResourceAllocationInfo\u0027)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    if extra_specs.firmware:"},{"line_number":248,"context_line":"        config_spec.firmware \u003d extra_specs.firmware"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    devices \u003d []"},{"line_number":251,"context_line":"    for vif_info in vif_infos:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_465b6453","line":248,"updated":"2018-01-03 18:27:52.000000000","message":"OK looking at https://www.vmware.com/support/developer/converter-sdk/conv60_apireference/vim.vm.ConfigSpec.html this has been around since the vSphere API 5.0, what is our minimum required version of vSphere? Looks like 5.1.0:\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/constants.py#L22","commit_id":"9c643eb5b95ae39b1423334e649b5b29a4702d3c"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0428bb56b1a7e88b1cbc417c37f9e3bf4492cfc5","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        extra_specs.memory_limits.validate()"},{"line_number":319,"context_line":"        extra_specs.disk_io_limits.validate()"},{"line_number":320,"context_line":"        extra_specs.vif_limits.validate()"},{"line_number":321,"context_line":"        hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":322,"context_line":"        if hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI:"},{"line_number":323,"context_line":"            extra_specs.firmware \u003d \u0027efi\u0027"},{"line_number":324,"context_line":"        elif hw_firmware_type \u003d\u003d fields.FirmwareType.BIOS:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_e659585a","line":321,"updated":"2018-01-03 18:27:52.000000000","message":"Looks like this is correctly handling the two available options:\n\nhttps://www.vmware.com/support/developer/converter-sdk/conv60_apireference/vim.vm.GuestOsDescriptor.FirmwareType.html","commit_id":"9c643eb5b95ae39b1423334e649b5b29a4702d3c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0428bb56b1a7e88b1cbc417c37f9e3bf4492cfc5","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        hw_firmware_type \u003d image_meta.properties.get(\u0027hw_firmware_type\u0027)"},{"line_number":322,"context_line":"        if hw_firmware_type \u003d\u003d fields.FirmwareType.UEFI:"},{"line_number":323,"context_line":"            extra_specs.firmware \u003d \u0027efi\u0027"},{"line_number":324,"context_line":"        elif hw_firmware_type \u003d\u003d fields.FirmwareType.BIOS:"},{"line_number":325,"context_line":"            extra_specs.firmware \u003d \u0027bios\u0027"},{"line_number":326,"context_line":"        hw_version \u003d flavor.extra_specs.get(\u0027vmware:hw_version\u0027)"},{"line_number":327,"context_line":"        extra_specs.hw_version \u003d hw_version"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_a64cb09e","line":324,"range":{"start_line":324,"start_character":53,"end_line":324,"end_character":57},"updated":"2018-01-03 18:27:52.000000000","message":"This isn\u0027t called out in the commit message, but you\u0027re adding support for another type of image.","commit_id":"9c643eb5b95ae39b1423334e649b5b29a4702d3c"}],"releasenotes/notes/vmware-boot-uefi-f26ab3b9bdecf24a.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b72f68e3d285aafc9a7fb1a0fb202fde50abf15d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The VMware vCenter now supports booting from images which specify they"},{"line_number":5,"context_line":"    require UEFI or BIOS firmware, using the ``hw_firmware_type`` image"},{"line_number":6,"context_line":"    metadata."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f91af0f_ec1cd76b","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":22},"updated":"2018-01-03 19:22:53.000000000","message":"compute driver","commit_id":"8e9cd3f356dc28acbe6f86d45fabbbc2f9159f51"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"59dc329c4cf1ad610f08103855a7bf3ec8d020e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The VMware vCenter now supports booting from images which specify they"},{"line_number":5,"context_line":"    require UEFI or BIOS firmware, using the ``hw_firmware_type`` image"},{"line_number":6,"context_line":"    metadata."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f91af0f_ac76cfa3","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":22},"in_reply_to":"9f91af0f_ec1cd76b","updated":"2018-01-03 19:25:06.000000000","message":"weird i totally had something like that in there, but must have removed it when I was vacillating on what vmware-y name to use. Thanks for fixing it.","commit_id":"8e9cd3f356dc28acbe6f86d45fabbbc2f9159f51"}]}