)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8e783101a8ed26788296f95c5073a1b695a24bbe","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-03-23 22:27:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add description to policies in cells_scheduler.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"blueprint policy-docs"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ie9d760924d83cd2b784fb42e7d309c2f7ca88b8d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ffe62b97_9c6fc4c4","line":8,"updated":"2017-03-24 12:05:09.000000000","message":"Could you add \n\n  The \u0027discoverable\u0027 policy is not documented as it will be removed in a\n  future change.","commit_id":"ab6d648fcf02c16e7a58b343b04f930edd833f10"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ce58fb4cf6df67e8e1ac3b66a6aef99da097972f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add description to policies in cells_scheduler.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027discoverable\u0027 policy is not documented as it will be removed in a"},{"line_number":10,"context_line":"future change."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"blueprint policy-docs"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ffe62b97_5d2d3efc","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":14},"updated":"2017-03-28 09:52:07.000000000","message":"Nit: this doesn\u0027t seem required here.","commit_id":"c0277e35e6aedce9c41861054b69c26b09e02d22"}],"nova/policies/cells_scheduler.py":[{"author":{"_account_id":17814,"name":"fengzhr","email":"fengzhr@awcloud.com","username":"space"},"change_message_id":"a9925670dafa6fcfdaf6ba3b014d3fc26508a01c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_policy import policy"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from nova.policies import base"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_8a01c208","line":16,"range":{"start_line":16,"start_character":24,"end_line":16,"end_character":30},"updated":"2017-03-22 02:13:46.000000000","message":"This module is not used.","commit_id":"3933c7450efc014acb8058c5bafde84a95fed84f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"aa5451d5a8b45f62fe4d6dd69dee68e07dac3a52","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    base.create_rule_default("},{"line_number":24,"context_line":"        POLICY_ROOT % \u0027DifferentCellFilter\u0027,"},{"line_number":25,"context_line":"        \u0027is_admin:True\u0027,"},{"line_number":26,"context_line":"        \u0027Different cell filter to route a build away from a particular cell\u0027,"},{"line_number":27,"context_line":"        []),"},{"line_number":28,"context_line":"    base.create_rule_default("},{"line_number":29,"context_line":"        POLICY_ROOT % \u0027TargetCellFilter\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_57a9dc23","line":26,"updated":"2017-03-23 16:35:46.000000000","message":"I think we should mention that this policy rule is read by the \"nova-scheduler\" process. We should raise a bug to turn this into configuration instead of policy.","commit_id":"26d55766cbda34817eb322a345fbe0817795a577"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"e901d0b1b323a16103feab63faf8752af02ee2e4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    base.create_rule_default("},{"line_number":24,"context_line":"        POLICY_ROOT % \u0027DifferentCellFilter\u0027,"},{"line_number":25,"context_line":"        \u0027is_admin:True\u0027,"},{"line_number":26,"context_line":"        \u0027Different cell filter to route a build away from a particular cell\u0027,"},{"line_number":27,"context_line":"        []),"},{"line_number":28,"context_line":"    base.create_rule_default("},{"line_number":29,"context_line":"        POLICY_ROOT % \u0027TargetCellFilter\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_cfd3705e","line":26,"in_reply_to":"1a1ced50_57a9dc23","updated":"2017-03-23 18:09:38.000000000","message":"Done. Also raised a bug for this:  https://bugs.launchpad.net/nova/+bug/1675518","commit_id":"26d55766cbda34817eb322a345fbe0817795a577"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8e783101a8ed26788296f95c5073a1b695a24bbe","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    base.create_rule_default("},{"line_number":24,"context_line":"        POLICY_ROOT % \u0027DifferentCellFilter\u0027,"},{"line_number":25,"context_line":"        \u0027is_admin:True\u0027,"},{"line_number":26,"context_line":"        \"\"\"Different cell filter to route a build away from a particular cell"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"This policy is read by nova-scheduler process."},{"line_number":29,"context_line":"\"\"\","}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_dc4c2c78","line":26,"updated":"2017-03-24 12:05:09.000000000","message":"full stop","commit_id":"ab6d648fcf02c16e7a58b343b04f930edd833f10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"444a22d05fbafe7f634252ffd7ebcb8f8061c148","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    base.create_rule_default("},{"line_number":24,"context_line":"        POLICY_ROOT % \u0027DifferentCellFilter\u0027,"},{"line_number":25,"context_line":"        \u0027is_admin:True\u0027,"},{"line_number":26,"context_line":"        \"\"\"Different cell filter to route a build away from a particular cell"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"This policy is read by nova-scheduler process."},{"line_number":29,"context_line":"\"\"\","}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_d4275564","line":26,"in_reply_to":"ffe62b97_dc4c2c78","updated":"2017-03-24 16:58:28.000000000","message":"Actually, this isn\u0027t done consistently elsewhere. Probably not necessary here either","commit_id":"ab6d648fcf02c16e7a58b343b04f930edd833f10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8e783101a8ed26788296f95c5073a1b695a24bbe","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    base.create_rule_default("},{"line_number":32,"context_line":"        POLICY_ROOT % \u0027TargetCellFilter\u0027,"},{"line_number":33,"context_line":"        \u0027is_admin:True\u0027,"},{"line_number":34,"context_line":"        \"\"\"Target cell filter to route a build to a particular cell"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This policy is read by nova-scheduler process."},{"line_number":37,"context_line":"\"\"\","}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_7c2640ba","line":34,"updated":"2017-03-24 12:05:09.000000000","message":"missing full stop","commit_id":"ab6d648fcf02c16e7a58b343b04f930edd833f10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8e783101a8ed26788296f95c5073a1b695a24bbe","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027is_admin:True\u0027,"},{"line_number":34,"context_line":"        \"\"\"Target cell filter to route a build to a particular cell"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This policy is read by nova-scheduler process."},{"line_number":37,"context_line":"\"\"\","},{"line_number":38,"context_line":"        [])"},{"line_number":39,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_fc46d04f","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":46},"updated":"2017-03-24 12:05:09.000000000","message":"Is this relevant? I note that we haven\u0027t done it elsewhere. Surely the name of the policy would give this away?","commit_id":"ab6d648fcf02c16e7a58b343b04f930edd833f10"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"da9272f2bd8bddae7e993dda940563bcf03348b7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027is_admin:True\u0027,"},{"line_number":34,"context_line":"        \"\"\"Target cell filter to route a build to a particular cell"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This policy is read by nova-scheduler process."},{"line_number":37,"context_line":"\"\"\","},{"line_number":38,"context_line":"        [])"},{"line_number":39,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_4de01397","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":46},"in_reply_to":"ffe62b97_fc46d04f","updated":"2017-03-27 15:50:39.000000000","message":"yes.this is needed. This policy is different from other policies as it is not used by any api. It is used by scheduler process. So we need to mention it.","commit_id":"ab6d648fcf02c16e7a58b343b04f930edd833f10"}]}