)]}'
{"nova/tests/unit/api/openstack/compute/test_virtual_interfaces.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"07ae3e4f0edca58c6672b7f9c7e687ca03dd1607","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        # the tests need to specifically run against nova-network unless"},{"line_number":77,"context_line":"        # otherwise setup to run with Neutron and expect failure."},{"line_number":78,"context_line":"        self.flags(use_neutron\u003dFalse)"},{"line_number":79,"context_line":"        self.stubs.Set(compute.api.API, \"get\","},{"line_number":80,"context_line":"                       compute_api_get)"},{"line_number":81,"context_line":"        self.stubs.Set(network.api.API, \"get_vifs_by_instance\","},{"line_number":82,"context_line":"                       get_vifs_by_instance)"},{"line_number":83,"context_line":"        self._set_controller()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _set_controller(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_45e05829","line":82,"range":{"start_line":79,"start_character":0,"end_line":82,"end_character":44},"updated":"2017-03-23 11:08:34.000000000","message":"These lines should be modified.","commit_id":"ad3d8a141b95c29c045999c21412dfeb76c702a2"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"07ae3e4f0edca58c6672b7f9c7e687ca03dd1607","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def test_list_vifs_neutron_notimplemented(self):"},{"line_number":118,"context_line":"        \"\"\"Tests that a 400 is returned when using neutron as the backend\"\"\""},{"line_number":119,"context_line":"        # unset the get_vifs_by_instance stub from setUp"},{"line_number":120,"context_line":"        self.mox.UnsetStubs()"},{"line_number":121,"context_line":"        self.flags(use_neutron\u003dTrue)"},{"line_number":122,"context_line":"        # reset the controller to use the neutron network API"},{"line_number":123,"context_line":"        self._set_controller()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_05402006","line":120,"range":{"start_line":120,"start_character":8,"end_line":120,"end_character":29},"updated":"2017-03-23 11:08:34.000000000","message":"ditto","commit_id":"ad3d8a141b95c29c045999c21412dfeb76c702a2"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"3bfb9f0a4b5130471d57f042ef5eb48abd24b09e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        self.flags(use_neutron\u003dTrue)"},{"line_number":121,"context_line":"        # reset the controller to use the neutron network API"},{"line_number":122,"context_line":"        self._set_controller()"},{"line_number":123,"context_line":"        self.stub_out(\u0027nova.compute.api.API.get\u0027, compute_api_get)"},{"line_number":124,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027, version\u003dself.wsgi_api_version)"},{"line_number":125,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":126,"context_line":"                          self.controller.index, req, FAKE_UUID)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_e310faaa","side":"PARENT","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":66},"updated":"2017-03-28 06:34:39.000000000","message":"This is good to use according to:\nhttp://lists.openstack.org/pipermail/openstack-dev/2017-March/114630.html","commit_id":"2a41eb8786fa1654bbecb50c2a15fdd96fdc4767"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"0e0801ad2da55e5201e95dfe7df7f0339378cc99","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        self.flags(use_neutron\u003dTrue)"},{"line_number":121,"context_line":"        # reset the controller to use the neutron network API"},{"line_number":122,"context_line":"        self._set_controller()"},{"line_number":123,"context_line":"        self.stub_out(\u0027nova.compute.api.API.get\u0027, compute_api_get)"},{"line_number":124,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027, version\u003dself.wsgi_api_version)"},{"line_number":125,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":126,"context_line":"                          self.controller.index, req, FAKE_UUID)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_a8293f9c","side":"PARENT","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":66},"in_reply_to":"ffe62b97_c98ab7bd","updated":"2017-03-30 09:29:45.000000000","message":"Thanks for the clarification","commit_id":"2a41eb8786fa1654bbecb50c2a15fdd96fdc4767"},{"author":{"_account_id":21363,"name":"Gao Yuan","email":"yuan.gao@easystack.cn","username":"gaoyuan"},"change_message_id":"a9084288f1fa0c688afa4d074375297826256601","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        self.flags(use_neutron\u003dTrue)"},{"line_number":121,"context_line":"        # reset the controller to use the neutron network API"},{"line_number":122,"context_line":"        self._set_controller()"},{"line_number":123,"context_line":"        self.stub_out(\u0027nova.compute.api.API.get\u0027, compute_api_get)"},{"line_number":124,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027, version\u003dself.wsgi_api_version)"},{"line_number":125,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":126,"context_line":"                          self.controller.index, req, FAKE_UUID)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_c98ab7bd","side":"PARENT","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":66},"in_reply_to":"ffe62b97_e310faaa","updated":"2017-03-28 07:39:24.000000000","message":"This one is not removed as a mox/mock exchange. I changed self.stubs.Set(compute.api.API, \"get\",\n                       compute_api_get)\nin the setup function to\nself.compute_api_get_patcher \u003d mock.patch.object(\n            compute.api.API, \"get\",\n            side_effect\u003dcompute_api_get)\nSo, this line is no longer necessary.\nI don\u0027t think there is anything that should be changed.","commit_id":"2a41eb8786fa1654bbecb50c2a15fdd96fdc4767"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"02cd207af08c0c6f82df7a670c3aa0dbed858b7c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import webob"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from nova.api.openstack import api_version_request"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_50a9428d","line":17,"updated":"2017-05-25 08:56:50.000000000","message":"nit: This blank line should be removed.\n\nhttps://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"df7e3dd37ed0ec59c14909ec43b0d61d2a4b5514"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"678380ed3deacbe3463fd4e99bb0089cdf2687c6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        # the tests need to specifically run against nova-network unless"},{"line_number":78,"context_line":"        # otherwise setup to run with Neutron and expect failure."},{"line_number":79,"context_line":"        self.flags(use_neutron\u003dFalse)"},{"line_number":80,"context_line":"        self.compute_api_get_patcher \u003d mock.patch.object("},{"line_number":81,"context_line":"            compute.api.API, \"get\","},{"line_number":82,"context_line":"            side_effect\u003dcompute_api_get)"},{"line_number":83,"context_line":"        self.get_vifs_by_instance_patcher \u003d mock.patch.object("},{"line_number":84,"context_line":"            network.api.API, \"get_vifs_by_instance\","},{"line_number":85,"context_line":"            side_effect\u003dget_vifs_by_instance)"},{"line_number":86,"context_line":"        self.compute_api_get_patcher.start()"},{"line_number":87,"context_line":"        self.get_vifs_by_instance_patcher.start()"},{"line_number":88,"context_line":"        self.addCleanup(self.compute_api_get_patcher.stop)"},{"line_number":89,"context_line":"        self.addCleanup(self.get_vifs_by_instance_patcher.stop)"},{"line_number":90,"context_line":"        self._set_controller()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _set_controller(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_7fbcb5db","line":89,"range":{"start_line":80,"start_character":0,"end_line":89,"end_character":63},"updated":"2017-05-19 14:50:39.000000000","message":"We don\u0027t use stub_out here to allow us to start/stop the patcher in one of the tests below. Fair enough","commit_id":"df7e3dd37ed0ec59c14909ec43b0d61d2a4b5514"}]}