)]}'
{"nova/tests/unit/consoleauth/test_consoleauth.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21eded45a7d6b4d0e113ae9299cbdbcb977fa807","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        def fake_validate_console_port(ctxt, instance, port, console_type):"},{"line_number":82,"context_line":"            return result"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        self.stubs.Set(self.manager.compute_rpcapi,"},{"line_number":85,"context_line":"                       \u0027validate_console_port\u0027,"},{"line_number":86,"context_line":"                       fake_validate_console_port)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @mock.patch(\u0027nova.objects.instance.Instance.get_by_uuid\u0027)"},{"line_number":89,"context_line":"    def test_multiple_tokens_for_instance(self, mock_get):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_1e43186d","line":86,"range":{"start_line":84,"start_character":0,"end_line":86,"end_character":50},"updated":"2017-03-23 07:42:27.000000000","message":"can you do this too. its hard to review one by one, file wise cleanup is better and fast to merge this effort.","commit_id":"5b067cf9ee98c0ec8d604c0a0dac981b97973e51"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21eded45a7d6b4d0e113ae9299cbdbcb977fa807","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                                       console_type):"},{"line_number":234,"context_line":"            return result"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        self.stubs.Set(self.manager.cells_rpcapi,"},{"line_number":237,"context_line":"                       \u0027validate_console_port\u0027,"},{"line_number":238,"context_line":"                       fake_validate_console_port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_3e46147b","line":238,"range":{"start_line":236,"start_character":0,"end_line":238,"end_character":50},"updated":"2017-03-23 07:42:27.000000000","message":"ditto","commit_id":"5b067cf9ee98c0ec8d604c0a0dac981b97973e51"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21411732ab0c292633e06fc234a3317ad662fff0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def _stub_validate_console_port(self, result):"},{"line_number":81,"context_line":"        def fake_validate_console_port(ctxt, instance, port, console_type):"},{"line_number":82,"context_line":"            return result"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        compute_rpcapi_patcher \u003d mock.patch.object("},{"line_number":85,"context_line":"            self.manager.compute_rpcapi, \u0027validate_console_port\u0027,"},{"line_number":86,"context_line":"            side_effect\u003dfake_validate_console_port)"},{"line_number":87,"context_line":"        compute_rpcapi_patcher.start()"},{"line_number":88,"context_line":"        self.addCleanup(compute_rpcapi_patcher.stop)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @mock.patch(\u0027nova.objects.instance.Instance.get_by_uuid\u0027)"},{"line_number":91,"context_line":"    def test_multiple_tokens_for_instance(self, mock_get):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_408abf69","line":88,"range":{"start_line":83,"start_character":0,"end_line":88,"end_character":52},"updated":"2017-03-29 09:01:07.000000000","message":"please use decorator like [1]. This way is complex and inconsistent across tests.\n\n1- https://github.com/openstack/nova/blob/9008f6d5613da6c296220b51d8eaa0bc51f05ffd/nova/tests/functional/api_sample_tests/test_networks.py#L70","commit_id":"c67db40ff39191e62d72181af4abcca998c3d150"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21411732ab0c292633e06fc234a3317ad662fff0","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                    [mock.call(b\u0027instance\u0027, mock.ANY)])"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def test_check_token_encoding(self):"},{"line_number":197,"context_line":"        with mock.patch.object(self.manager.mc,"},{"line_number":198,"context_line":"                               \"get\","},{"line_number":199,"context_line":"                               return_value\u003dNone) as mock_get:"},{"line_number":200,"context_line":"            self.manager.check_token(self.context, self.u_token)"},{"line_number":201,"context_line":"            mock_get.assert_called_once_with(test.MatchType(six.binary_type))"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_delete_tokens_for_instance_encoding(self):"},{"line_number":204,"context_line":"        with test.nested("}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_e0df9366","line":201,"range":{"start_line":197,"start_character":0,"end_line":201,"end_character":77},"updated":"2017-03-29 09:01:07.000000000","message":"even if you make it decorator, i will be very happy :).","commit_id":"c67db40ff39191e62d72181af4abcca998c3d150"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21411732ab0c292633e06fc234a3317ad662fff0","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                                       console_type):"},{"line_number":236,"context_line":"            return result"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        cells_rpcapi_patcher \u003d mock.patch.object("},{"line_number":239,"context_line":"            self.manager.cells_rpcapi, \u0027validate_console_port\u0027,"},{"line_number":240,"context_line":"            side_effect\u003dfake_validate_console_port)"},{"line_number":241,"context_line":"        cells_rpcapi_patcher.start()"},{"line_number":242,"context_line":"        self.addCleanup(cells_rpcapi_patcher.stop)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_c095af88","line":242,"range":{"start_line":238,"start_character":0,"end_line":242,"end_character":50},"updated":"2017-03-29 09:01:07.000000000","message":"ditto","commit_id":"c67db40ff39191e62d72181af4abcca998c3d150"}]}
