)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d0c08e7235cd7fd070884a7f298f4037c1837372","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit fix the below doc issue for adminPass"},{"line_number":10,"context_line":" -\u0027adminPass\u0027 attrbiure is only return in response if"},{"line_number":11,"context_line":"  \u0027enable_instance_password\u0027 configuration option is set to true"},{"line_number":12,"context_line":" - evacuate API stop accepting and returning adminPass from 2.14 microversion"},{"line_number":13,"context_line":"   so max version for this field is 2.13."},{"line_number":14,"context_line":" - if \u0027adminPass\u0027 is not present in request then, operation auto generate one."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I636657ed30b33da0a2df73b222c4ce5d8388a3d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_d662d616","line":13,"range":{"start_line":12,"start_character":3,"end_line":13,"end_character":39},"updated":"2017-03-24 07:35:55.000000000","message":"is this true?\n\nfrom \nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/evacuate.py#L102\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/evacuate.py#L65\n\nI think \n\nby the way, I will submit a patch to refactor the code a little bit...","commit_id":"fba506c93f96ebd2a543b931b63fabd7d44175f1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"27ce6327150524d31bcae6fe278c1ac64cd635b1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit fix the below doc issue for adminPass"},{"line_number":10,"context_line":" -\u0027adminPass\u0027 attrbiure is only return in response if"},{"line_number":11,"context_line":"  \u0027enable_instance_password\u0027 configuration option is set to true"},{"line_number":12,"context_line":" - evacuate API stop accepting and returning adminPass from 2.14 microversion"},{"line_number":13,"context_line":"   so max version for this field is 2.13."},{"line_number":14,"context_line":" - if \u0027adminPass\u0027 is not present in request then, operation auto generate one."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I636657ed30b33da0a2df73b222c4ce5d8388a3d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_1ac71548","line":13,"range":{"start_line":12,"start_character":3,"end_line":13,"end_character":39},"in_reply_to":"ffe62b97_d662d616","updated":"2017-03-25 06:51:09.000000000","message":"yea, accepting is not true here.","commit_id":"fba506c93f96ebd2a543b931b63fabd7d44175f1"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3f3f89083a7ba014f945c278460a471ee238619f","unresolved":false,"context_lines":[{"line_number":1085,"context_line":"  in: body"},{"line_number":1086,"context_line":"  required: false"},{"line_number":1087,"context_line":"  type: string"},{"line_number":1088,"context_line":"adminPass_evacuate:"},{"line_number":1089,"context_line":"  description: |"},{"line_number":1090,"context_line":"    An administrative password to access the evacuated instance."},{"line_number":1091,"context_line":"    If you set ``enable_instance_password`` configuration option to ``False``,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffe62b97_d913db5b","line":1088,"range":{"start_line":1088,"start_character":1,"end_line":1088,"end_character":18},"updated":"2017-03-27 10:05:39.000000000","message":"This should be \u0027adminPass\u0027?  this doesn\u0027t match in  https://review.openstack.org/#/c/449450/2/api-ref/source/servers-actions.inc@27","commit_id":"36fad8843e6ec723c711eac5b87118fea9fbf9e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1066070b487e96bce1b536853682e1516495dde8","unresolved":false,"context_lines":[{"line_number":1085,"context_line":"  in: body"},{"line_number":1086,"context_line":"  required: false"},{"line_number":1087,"context_line":"  type: string"},{"line_number":1088,"context_line":"adminPass_evacuate:"},{"line_number":1089,"context_line":"  description: |"},{"line_number":1090,"context_line":"    An administrative password to access the evacuated instance."},{"line_number":1091,"context_line":"    If you set ``enable_instance_password`` configuration option to ``False``,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffe62b97_5c90d943","line":1088,"range":{"start_line":1088,"start_character":1,"end_line":1088,"end_character":18},"in_reply_to":"ffe62b97_d913db5b","updated":"2017-03-27 10:38:59.000000000","message":"actually this is for \u0027evacuate\u0027 API where 2.14 restricted this in response. mentioned max_version: 2.13","commit_id":"36fad8843e6ec723c711eac5b87118fea9fbf9e2"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3f3f89083a7ba014f945c278460a471ee238619f","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"  type: string"},{"line_number":1112,"context_line":"adminPass_response:"},{"line_number":1113,"context_line":"  description: |"},{"line_number":1114,"context_line":"    The administrative password for the server. If you set ``enable_instance_password`` configuration"},{"line_number":1115,"context_line":"    option to ``False``, the API wouldn\u0027t return the ``adminPass`` field in response."},{"line_number":1116,"context_line":"  in: body"},{"line_number":1117,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffe62b97_56643822","line":1114,"range":{"start_line":1114,"start_character":61,"end_line":1114,"end_character":85},"updated":"2017-03-27 10:05:39.000000000","message":"The tricky thing is here that we needn\u0027t mention this configure option, that is for deployer, not the API user. Maybe we should just say, \u0027depend on the cloud configuration....\u0027\n\nAnd we should mention this returned only for request \u003c 2.14","commit_id":"36fad8843e6ec723c711eac5b87118fea9fbf9e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1066070b487e96bce1b536853682e1516495dde8","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"  type: string"},{"line_number":1112,"context_line":"adminPass_response:"},{"line_number":1113,"context_line":"  description: |"},{"line_number":1114,"context_line":"    The administrative password for the server. If you set ``enable_instance_password`` configuration"},{"line_number":1115,"context_line":"    option to ``False``, the API wouldn\u0027t return the ``adminPass`` field in response."},{"line_number":1116,"context_line":"  in: body"},{"line_number":1117,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ffe62b97_3ca515b6","line":1114,"range":{"start_line":1114,"start_character":61,"end_line":1114,"end_character":85},"in_reply_to":"ffe62b97_56643822","updated":"2017-03-27 10:38:59.000000000","message":"humm, i think with that options user can get to know on what all condition adminPass will be returned. \n\nAnd this is for all other API except \u0027evacuate\u0027 and 2.14 did not restrict this for those API.","commit_id":"36fad8843e6ec723c711eac5b87118fea9fbf9e2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"54cffedb1b38928f8c9773cba289d57994b76a47","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"  in: body"},{"line_number":1079,"context_line":"  required: true"},{"line_number":1080,"context_line":"  type: string"},{"line_number":1081,"context_line":"adminPass:"},{"line_number":1082,"context_line":"  description: |"},{"line_number":1083,"context_line":"    The administrative password of the server. If you omit this parameter, the operation"},{"line_number":1084,"context_line":"    generates a new password."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_d5c25e59","line":1081,"range":{"start_line":1081,"start_character":0,"end_line":1081,"end_character":10},"updated":"2017-03-27 20:06:34.000000000","message":"This patch tries to make this adminPass for both \"create a server\" and \"rebuild a server\" APIs. This name seems a little difficult to know which APIs this parameter works for.\n\nSo it would be better to rename adminPass to adminPass_create_request or something to avoid confusions.","commit_id":"f2ff8bc0d1cdfcd95158f076423f8855eb28c90e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c3fe6e2750fbb9574141d04f84b1cac7b4bf589a","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"  in: body"},{"line_number":1079,"context_line":"  required: true"},{"line_number":1080,"context_line":"  type: string"},{"line_number":1081,"context_line":"adminPass:"},{"line_number":1082,"context_line":"  description: |"},{"line_number":1083,"context_line":"    The administrative password of the server. If you omit this parameter, the operation"},{"line_number":1084,"context_line":"    generates a new password."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_32a63555","line":1081,"range":{"start_line":1081,"start_character":0,"end_line":1081,"end_character":10},"in_reply_to":"ffe62b97_d5c25e59","updated":"2017-03-28 02:54:27.000000000","message":"yea actually this is common for both request but yes it will be nice to state request in name.","commit_id":"f2ff8bc0d1cdfcd95158f076423f8855eb28c90e"}],"api-ref/source/servers-action-evacuate.inc":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3f3f89083a7ba014f945c278460a471ee238619f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Response"},{"line_number":40,"context_line":"--------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  - adminPass: adminPass_evacuate"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"ffe62b97_b62024b2","line":42,"updated":"2017-03-27 10:05:39.000000000","message":"we should have a note about the request \u003e 2.14, there will be no response.","commit_id":"36fad8843e6ec723c711eac5b87118fea9fbf9e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1066070b487e96bce1b536853682e1516495dde8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Response"},{"line_number":40,"context_line":"--------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  - adminPass: adminPass_evacuate"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"ffe62b97_1cb371ec","line":42,"in_reply_to":"ffe62b97_b62024b2","updated":"2017-03-27 10:38:59.000000000","message":"+1, Done","commit_id":"36fad8843e6ec723c711eac5b87118fea9fbf9e2"}]}
