)]}'
{"nova/api/openstack/compute/evacuate.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"379e63527a0a2acc1489088f04560856e11626d8","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            if force is True and not host:"},{"line_number":92,"context_line":"                message \u003d _(\"Can\u0027t force to a non-provided destination\")"},{"line_number":93,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmessage)"},{"line_number":94,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.14\u0027):"},{"line_number":95,"context_line":"            # on_shared_storage is not used since 2.14 and default to False"},{"line_number":96,"context_line":"            password \u003d self._get_password(req, evacuate_body, False)"},{"line_number":97,"context_line":"        else:"},{"line_number":98,"context_line":"            password \u003d self._get_password(req, evacuate_body,"},{"line_number":99,"context_line":"                                          on_shared_storage)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if host is not None:"},{"line_number":102,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_e48cf880","line":99,"range":{"start_line":94,"start_character":0,"end_line":99,"end_character":60},"updated":"2017-06-20 06:04:49.000000000","message":"on_shared_storage will be None always for 2.14(L45), and we can remove this if else from here-\n\n            password \u003d self._get_password(req, evacuate_body,\n                                          on_shared_storage)","commit_id":"6144b8f21889192127b450d9b62d3cbbae0d10ca"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"21a48aaf9abdeda2dd23a345f64010f918bbb90b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            if force is True and not host:"},{"line_number":92,"context_line":"                message \u003d _(\"Can\u0027t force to a non-provided destination\")"},{"line_number":93,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmessage)"},{"line_number":94,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.14\u0027):"},{"line_number":95,"context_line":"            # on_shared_storage is not used since 2.14 and default to False"},{"line_number":96,"context_line":"            password \u003d self._get_password(req, evacuate_body, False)"},{"line_number":97,"context_line":"        else:"},{"line_number":98,"context_line":"            password \u003d self._get_password(req, evacuate_body,"},{"line_number":99,"context_line":"                                          on_shared_storage)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if host is not None:"},{"line_number":102,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_9e004903","line":99,"range":{"start_line":94,"start_character":0,"end_line":99,"end_character":60},"in_reply_to":"7f231b9d_e48cf880","updated":"2017-07-27 06:50:24.000000000","message":"Done","commit_id":"6144b8f21889192127b450d9b62d3cbbae0d10ca"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9593ba636e2ef42af2e0e73a5ccaf2578fde42ee","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _get_on_shared_storage(self, req, evacuate_body):"},{"line_number":42,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.14\u0027):"},{"line_number":43,"context_line":"            return False"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            return strutils.bool_from_string(evacuate_body[\"onSharedStorage\"])"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_cc033e0d","line":43,"updated":"2017-07-31 13:03:38.000000000","message":"I would have separate this change from your refactor. The value returned by this function is transferred to the compute manager and to the virt drivers. Some of them could have considered True/False/None to handle different behavior and even if that is not the case, to have this isolated can help reviewer to ensure all is OK.","commit_id":"f46b32be5f147137c0bbc0db05b2ebba42cc57a2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3797fd895e13d5593be8a81c6ed8ba3a99a9914f","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _get_on_shared_storage(self, req, evacuate_body):"},{"line_number":42,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.14\u0027):"},{"line_number":43,"context_line":"            return False"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            return strutils.bool_from_string(evacuate_body[\"onSharedStorage\"])"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_09b15d90","line":43,"in_reply_to":"df3967d1_cc033e0d","updated":"2017-08-08 07:21:25.000000000","message":"+1 for that. I am not sure why None is not working.","commit_id":"f46b32be5f147137c0bbc0db05b2ebba42cc57a2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"485b5310ed4ba277e4a0512900334d392cb9e068","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.host_api \u003d compute.HostAPI()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _get_on_shared_storage(self, req, evacuate_body):"},{"line_number":42,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.14\u0027):"},{"line_number":43,"context_line":"            return None"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            return strutils.bool_from_string(evacuate_body[\"onSharedStorage\"])"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7f287b81_5a024d71","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":23},"updated":"2017-09-04 16:11:58.000000000","message":"Right, this is the check we\u0027re relying on","commit_id":"2ae7645521965862e116cb5c3a12a9c041e134d6"}],"nova/tests/functional/api_sample_tests/test_evacuate.py":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"51a8ebde48a6806e91b8f4bd97b1461e80e5e043","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                orig_image_ref\u003dmock.ANY, image_ref\u003dmock.ANY,"},{"line_number":116,"context_line":"                injected_files\u003dmock.ANY, new_pass\u003d\"MySecretPass\","},{"line_number":117,"context_line":"                orig_sys_metadata\u003dmock.ANY, bdms\u003dmock.ANY, recreate\u003dmock.ANY,"},{"line_number":118,"context_line":"                on_shared_storage\u003dNone, preserve_ephemeral\u003dmock.ANY,"},{"line_number":119,"context_line":"                host\u003d\u0027testHost\u0027, request_spec\u003dmock.ANY)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @mock.patch(\u0027nova.conductor.manager.ComputeTaskManager.rebuild_instance\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_72911ff1","line":118,"range":{"start_line":118,"start_character":16,"end_line":118,"end_character":38},"updated":"2017-07-28 15:33:02.000000000","message":"Looks like we missed one","commit_id":"23c3295d87c14f29ec0d42b64c93ac4db2e6e79c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e9e9c90cafe5f22595003e3339e5f59ec063588d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                orig_image_ref\u003dmock.ANY, image_ref\u003dmock.ANY,"},{"line_number":116,"context_line":"                injected_files\u003dmock.ANY, new_pass\u003d\"MySecretPass\","},{"line_number":117,"context_line":"                orig_sys_metadata\u003dmock.ANY, bdms\u003dmock.ANY, recreate\u003dmock.ANY,"},{"line_number":118,"context_line":"                on_shared_storage\u003dNone, preserve_ephemeral\u003dmock.ANY,"},{"line_number":119,"context_line":"                host\u003d\u0027testHost\u0027, request_spec\u003dmock.ANY)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @mock.patch(\u0027nova.conductor.manager.ComputeTaskManager.rebuild_instance\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df3967d1_2d73f117","line":118,"range":{"start_line":118,"start_character":16,"end_line":118,"end_character":38},"in_reply_to":"ff346bd7_72911ff1","updated":"2017-07-31 08:13:32.000000000","message":"ok...thanks not sure why I missed this one:(","commit_id":"23c3295d87c14f29ec0d42b64c93ac4db2e6e79c"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"aeb5e143d082c9f2bf52ad9857941ef4e6839a57","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        req_subs \u003d {"},{"line_number":71,"context_line":"            \u0027host\u0027: \u0027testHost\u0027,"},{"line_number":72,"context_line":"            \"adminPass\": \"MySecretPass\","},{"line_number":73,"context_line":"            \"onSharedStorage\": \u0027False\u0027"},{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":"        self._test_evacuate(req_subs, \u0027server-evacuate-req\u0027,"},{"line_number":76,"context_line":"                            \u0027server-evacuate-resp\u0027, 200)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f436f4f_7fb37f99","line":73,"range":{"start_line":73,"start_character":32,"end_line":73,"end_character":37},"updated":"2017-08-11 17:07:47.000000000","message":"This needs to be updated to None.","commit_id":"117c2acab8501c031a1f85dad577d12accd5f764"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"aeb5e143d082c9f2bf52ad9857941ef4e6839a57","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def test_server_evacuate_find_host(self, rebuild_mock):"},{"line_number":86,"context_line":"        req_subs \u003d {"},{"line_number":87,"context_line":"            \"adminPass\": \"MySecretPass\","},{"line_number":88,"context_line":"            \"onSharedStorage\": \u0027False\u0027"},{"line_number":89,"context_line":"        }"},{"line_number":90,"context_line":"        self._test_evacuate(req_subs, \u0027server-evacuate-find-host-req\u0027,"},{"line_number":91,"context_line":"                            \u0027server-evacuate-find-host-resp\u0027, 200)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f436f4f_ff640f24","line":88,"range":{"start_line":88,"start_character":32,"end_line":88,"end_character":37},"updated":"2017-08-11 17:07:47.000000000","message":"This needs to be updated to None.","commit_id":"117c2acab8501c031a1f85dad577d12accd5f764"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"36283ea80f1057530ff3069ce9c5030d7d49c804","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        req_subs \u003d {"},{"line_number":71,"context_line":"            \u0027host\u0027: \u0027testHost\u0027,"},{"line_number":72,"context_line":"            \"adminPass\": \"MySecretPass\","},{"line_number":73,"context_line":"            \"onSharedStorage\": \u0027None\u0027"},{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":"        self._test_evacuate(req_subs, \u0027server-evacuate-req\u0027,"},{"line_number":76,"context_line":"                            \u0027server-evacuate-resp\u0027, 200)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f287b81_061b471b","line":73,"range":{"start_line":73,"start_character":12,"end_line":73,"end_character":36},"updated":"2017-09-05 04:02:18.000000000","message":"why we are changing this input value. schema does not allow \u0027None\u0027 for onSharedStorage.\n\nTest should work as it is on this patch.","commit_id":"2ae7645521965862e116cb5c3a12a9c041e134d6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"36283ea80f1057530ff3069ce9c5030d7d49c804","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                orig_image_ref\u003dmock.ANY, image_ref\u003dmock.ANY,"},{"line_number":79,"context_line":"                injected_files\u003dmock.ANY, new_pass\u003d\"MySecretPass\","},{"line_number":80,"context_line":"                orig_sys_metadata\u003dmock.ANY, bdms\u003dmock.ANY, recreate\u003dmock.ANY,"},{"line_number":81,"context_line":"                on_shared_storage\u003dNone, preserve_ephemeral\u003dmock.ANY,"},{"line_number":82,"context_line":"                host\u003d\u0027testHost\u0027, request_spec\u003dmock.ANY)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @mock.patch(\u0027nova.conductor.manager.ComputeTaskManager.rebuild_instance\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f287b81_c6d2df34","line":81,"range":{"start_line":81,"start_character":16,"end_line":81,"end_character":38},"updated":"2017-09-05 04:02:18.000000000","message":"ditto","commit_id":"2ae7645521965862e116cb5c3a12a9c041e134d6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"36283ea80f1057530ff3069ce9c5030d7d49c804","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def test_server_evacuate_find_host(self, rebuild_mock):"},{"line_number":86,"context_line":"        req_subs \u003d {"},{"line_number":87,"context_line":"            \"adminPass\": \"MySecretPass\","},{"line_number":88,"context_line":"            \"onSharedStorage\": \u0027None\u0027"},{"line_number":89,"context_line":"        }"},{"line_number":90,"context_line":"        self._test_evacuate(req_subs, \u0027server-evacuate-find-host-req\u0027,"},{"line_number":91,"context_line":"                            \u0027server-evacuate-find-host-resp\u0027, 200)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f287b81_e615dbe6","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":37},"updated":"2017-09-05 04:02:18.000000000","message":"ditto","commit_id":"2ae7645521965862e116cb5c3a12a9c041e134d6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"36283ea80f1057530ff3069ce9c5030d7d49c804","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                orig_image_ref\u003dmock.ANY, image_ref\u003dmock.ANY,"},{"line_number":95,"context_line":"                injected_files\u003dmock.ANY, new_pass\u003d\"MySecretPass\","},{"line_number":96,"context_line":"                orig_sys_metadata\u003dmock.ANY, bdms\u003dmock.ANY, recreate\u003dmock.ANY,"},{"line_number":97,"context_line":"                on_shared_storage\u003dNone, preserve_ephemeral\u003dmock.ANY,"},{"line_number":98,"context_line":"                host\u003dNone, request_spec\u003dmock.ANY)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7f287b81_a6d5931d","line":97,"range":{"start_line":97,"start_character":16,"end_line":97,"end_character":37},"updated":"2017-09-05 04:02:18.000000000","message":"ditto","commit_id":"2ae7645521965862e116cb5c3a12a9c041e134d6"}]}