)]}'
{"placement-api-ref/source/inventories.inc":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"fabc58a0b2fa42e823972a8becf889f8370c0345","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Resource provider inventories"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Inventories are entities desribing resource provider resources (VCPUs,"},{"line_number":6,"context_line":"RAM, Disk, etc.) from quantative point of view. They can be listed,"},{"line_number":7,"context_line":"created, updated and deleted."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"ffe62b97_4f3ee4da","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":34},"updated":"2017-03-27 07:03:40.000000000","message":"describing","commit_id":"4047f3eb137061a45ce3e664e6b00f3a5f109fdb"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"fabc58a0b2fa42e823972a8becf889f8370c0345","unresolved":false,"context_lines":[{"line_number":6,"context_line":"RAM, Disk, etc.) from quantative point of view. They can be listed,"},{"line_number":7,"context_line":"created, updated and deleted."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"List resource provider inventories"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. rest_method:: GET /resource_providers/{uuid}/inventories"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"ffe62b97_f2635fdb","line":9,"updated":"2017-03-27 07:03:40.000000000","message":"better to add \u0027by uuid\u0027 in the end...","commit_id":"4047f3eb137061a45ce3e664e6b00f3a5f109fdb"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d220a2097e92ca98378b302c54ee1843b046427f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"List resource provider inventories"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. rest_method:: GET /resource_providers/{resource_provider_uuid}/inventories"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Normal Response Codes: 200"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dfeb2761_f6f91880","line":12,"updated":"2017-04-03 11:39:17.000000000","message":"I know you just changed this from uuid based on earlier review feedback, but I prefer {uuid} here, because it is a) short, b) what\u0027s used in the handler.DECLARATIONS which are used to do the testing in the tools/placement_api_docs.py so need to match that, c) {uuid} modifies the resource_providers before, so having it twice is redundant.","commit_id":"57884b29a26ab077dfebdf9a48cbe212f597ba3c"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"53c78899b7f6f3c949200e669deff8789c112ed8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"List resource provider inventories"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. rest_method:: GET /resource_providers/{resource_provider_uuid}/inventories"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Normal Response Codes: 200"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dfeb2761_5693fba3","line":12,"in_reply_to":"dfeb2761_f6f91880","updated":"2017-04-04 10:58:20.000000000","message":"Aggreed. My point was a more clear description for a user. Probably, resource_provider url part is enough for that\nalso didn\u0027t know it should be changed along with handler.py to support placement_api_docs.","commit_id":"57884b29a26ab077dfebdf9a48cbe212f597ba3c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7103f8fcb14a2008623540748c21813e3ccf78e7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Inventories are entities describing resource provider resources (VCPUs,"},{"line_number":6,"context_line":"RAM, Disk, etc.) from quantative point of view. They can be listed,"},{"line_number":7,"context_line":"created, updated and deleted."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"List resource provider inventories"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"bff0334d_d45cee4c","line":6,"updated":"2017-04-06 13:02:34.000000000","message":"from a","commit_id":"c5b49a43e7236b2988ba4767dca19bee2df45f69"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8c1335d364715ad12530931ecb34b1f1aeb091c7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Inventories are entities describing resource provider resources (VCPUs,"},{"line_number":6,"context_line":"RAM, Disk, etc.) from a quantative point of view. They can be listed,"},{"line_number":7,"context_line":"created, updated and deleted."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"List resource provider inventories"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"7ffa3b31_630ba9d5","line":6,"updated":"2017-04-20 17:12:27.000000000","message":"How about this instead?\n\nEach resource provider has inventory records for one or more classes of resources. An inventory record contains information about the total and reserved amounts of the resource and any consumption constraints for that resource against the provider.","commit_id":"af00abf9d606ca3eec897a6370b8f6ee2f696b6d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"91ae863230dd3bd198d567c1ba265421f391e38e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Normal Response Codes: 200"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Error response codes: itemNotFound(404)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Request"},{"line_number":20,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"5ff73747_aa9014ee","line":17,"updated":"2017-05-02 10:16:43.000000000","message":"I guess this a style we inherited from the nova api-ref but I\u0027m concerned that maybe we\u0027re not providing enough information about the various error responses. These don\u0027t render as anything special so I wonder if something like:\n\nError response codes:\n\n* 404: There resource provider identified by {uuid} was not found.\n\nmight be worth doing at some point (not in this series of changes, because I think we need to get some agreement on whether it is the right thing before doing it).","commit_id":"30bc459cd389efe58d2023f81a143386c1a9141a"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"b4236ee1b380926938df4b79fdf90f862b88565d","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Normal Response Codes: 200"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Error response codes: itemNotFound(404)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Request"},{"line_number":20,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"5ff73747_e8884823","line":17,"in_reply_to":"5ff73747_aa9014ee","updated":"2017-05-03 06:04:08.000000000","message":"Yeah, agree it\u0027s not enough information about errors in api call with the current representation. It will be a good follow-up.","commit_id":"30bc459cd389efe58d2023f81a143386c1a9141a"}],"placement-api-ref/source/parameters.yaml":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d220a2097e92ca98378b302c54ee1843b046427f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  required: true"},{"line_number":44,"context_line":"  description: |"},{"line_number":45,"context_line":"    An \"overcommit\" ratio for a particular class of resource."},{"line_number":46,"context_line":"    It\u0027s a multiplier for ``max_unit`` used to calculate limit for a resource."},{"line_number":47,"context_line":"    For example, for a vCPU resource with::"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        ``cpu_allocation_ratio`` \u003d 16"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_f63eb827","line":46,"updated":"2017-04-03 11:39:17.000000000","message":"this is wrong, it\u0027s a multiplier for ``total``","commit_id":"57884b29a26ab077dfebdf9a48cbe212f597ba3c"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"53c78899b7f6f3c949200e669deff8789c112ed8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  required: true"},{"line_number":44,"context_line":"  description: |"},{"line_number":45,"context_line":"    An \"overcommit\" ratio for a particular class of resource."},{"line_number":46,"context_line":"    It\u0027s a multiplier for ``max_unit`` used to calculate limit for a resource."},{"line_number":47,"context_line":"    For example, for a vCPU resource with::"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        ``cpu_allocation_ratio`` \u003d 16"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_56d89b7d","line":46,"in_reply_to":"dfeb2761_f63eb827","updated":"2017-04-04 10:58:20.000000000","message":"Done","commit_id":"57884b29a26ab077dfebdf9a48cbe212f597ba3c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d220a2097e92ca98378b302c54ee1843b046427f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    For example, for a vCPU resource with::"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        ``cpu_allocation_ratio`` \u003d 16"},{"line_number":50,"context_line":"        ``max_unit`` \u003d 8"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    Overall limit is equal to 128 vCPUs."},{"line_number":53,"context_line":"inventories:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_d639743f","line":50,"updated":"2017-04-03 11:39:17.000000000","message":"total here too","commit_id":"57884b29a26ab077dfebdf9a48cbe212f597ba3c"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"53c78899b7f6f3c949200e669deff8789c112ed8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    For example, for a vCPU resource with::"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        ``cpu_allocation_ratio`` \u003d 16"},{"line_number":50,"context_line":"        ``max_unit`` \u003d 8"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    Overall limit is equal to 128 vCPUs."},{"line_number":53,"context_line":"inventories:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_16e21330","line":50,"in_reply_to":"dfeb2761_d639743f","updated":"2017-04-04 10:58:20.000000000","message":"Done","commit_id":"57884b29a26ab077dfebdf9a48cbe212f597ba3c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d220a2097e92ca98378b302c54ee1843b046427f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  description: \u003e"},{"line_number":64,"context_line":"    An upper limit for the type of resource."},{"line_number":65,"context_line":"    It\u0027s used to ensure that a request for"},{"line_number":66,"context_line":"    more resource that can be provided as a single unit will not be accepted."},{"line_number":67,"context_line":"min_unit:"},{"line_number":68,"context_line":"  type: integer"},{"line_number":69,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_961c0cc2","line":66,"updated":"2017-04-03 11:39:17.000000000","message":"max_unit is the maximum amount any single allocation against an inventory can have","commit_id":"57884b29a26ab077dfebdf9a48cbe212f597ba3c"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"53c78899b7f6f3c949200e669deff8789c112ed8","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  description: \u003e"},{"line_number":64,"context_line":"    An upper limit for the type of resource."},{"line_number":65,"context_line":"    It\u0027s used to ensure that a request for"},{"line_number":66,"context_line":"    more resource that can be provided as a single unit will not be accepted."},{"line_number":67,"context_line":"min_unit:"},{"line_number":68,"context_line":"  type: integer"},{"line_number":69,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_f6d20f5c","line":66,"in_reply_to":"dfeb2761_961c0cc2","updated":"2017-04-04 10:58:20.000000000","message":"Done","commit_id":"57884b29a26ab077dfebdf9a48cbe212f597ba3c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d220a2097e92ca98378b302c54ee1843b046427f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  in: body"},{"line_number":70,"context_line":"  required: true"},{"line_number":71,"context_line":"  description: \u003e"},{"line_number":72,"context_line":"    A lower limit for the type of resource."},{"line_number":73,"context_line":"reserved:"},{"line_number":74,"context_line":"  type: integer"},{"line_number":75,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_567c44ea","line":72,"updated":"2017-04-03 11:39:17.000000000","message":"min_unit is the minimum amount any single allocation against an inventory can have","commit_id":"57884b29a26ab077dfebdf9a48cbe212f597ba3c"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"53c78899b7f6f3c949200e669deff8789c112ed8","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  in: body"},{"line_number":70,"context_line":"  required: true"},{"line_number":71,"context_line":"  description: \u003e"},{"line_number":72,"context_line":"    A lower limit for the type of resource."},{"line_number":73,"context_line":"reserved:"},{"line_number":74,"context_line":"  type: integer"},{"line_number":75,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_d6d5cb44","line":72,"in_reply_to":"dfeb2761_567c44ea","updated":"2017-04-04 10:58:20.000000000","message":"Done","commit_id":"57884b29a26ab077dfebdf9a48cbe212f597ba3c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d220a2097e92ca98378b302c54ee1843b046427f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  required: true"},{"line_number":77,"context_line":"  description: \u003e"},{"line_number":78,"context_line":"    An amount of resource not being involved in the allocation of requested"},{"line_number":79,"context_line":"    resouces."},{"line_number":80,"context_line":"resource_provider_generation:"},{"line_number":81,"context_line":"  type: integer"},{"line_number":82,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_7662a840","line":79,"updated":"2017-04-03 11:39:17.000000000","message":"The amount of inventory total reserved for system use and unavailable for allocations.","commit_id":"57884b29a26ab077dfebdf9a48cbe212f597ba3c"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"53c78899b7f6f3c949200e669deff8789c112ed8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  required: true"},{"line_number":77,"context_line":"  description: \u003e"},{"line_number":78,"context_line":"    An amount of resource not being involved in the allocation of requested"},{"line_number":79,"context_line":"    resouces."},{"line_number":80,"context_line":"resource_provider_generation:"},{"line_number":81,"context_line":"  type: integer"},{"line_number":82,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_b6cc87bc","line":79,"in_reply_to":"dfeb2761_7662a840","updated":"2017-04-04 10:58:20.000000000","message":"Done","commit_id":"57884b29a26ab077dfebdf9a48cbe212f597ba3c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d220a2097e92ca98378b302c54ee1843b046427f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  in: body"},{"line_number":122,"context_line":"  required: true"},{"line_number":123,"context_line":"  description: \u003e"},{"line_number":124,"context_line":"    An amount for the type of resource."},{"line_number":125,"context_line":"version_id:"},{"line_number":126,"context_line":"  type: string"},{"line_number":127,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_b64f10bc","line":124,"updated":"2017-04-03 11:39:17.000000000","message":"The real/physical total inventory of the resource.","commit_id":"57884b29a26ab077dfebdf9a48cbe212f597ba3c"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"53c78899b7f6f3c949200e669deff8789c112ed8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  in: body"},{"line_number":122,"context_line":"  required: true"},{"line_number":123,"context_line":"  description: \u003e"},{"line_number":124,"context_line":"    An amount for the type of resource."},{"line_number":125,"context_line":"version_id:"},{"line_number":126,"context_line":"  type: string"},{"line_number":127,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_96cf43af","line":124,"in_reply_to":"dfeb2761_b64f10bc","updated":"2017-04-04 10:58:20.000000000","message":"Done","commit_id":"57884b29a26ab077dfebdf9a48cbe212f597ba3c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7103f8fcb14a2008623540748c21813e3ccf78e7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    The name of a resource provider to filter the list."},{"line_number":15,"context_line":"resource_provider_uuid_query:"},{"line_number":16,"context_line":"  type: string"},{"line_number":17,"context_line":"  in: query"},{"line_number":18,"context_line":"  required: false"},{"line_number":19,"context_line":"  description: \u003e"},{"line_number":20,"context_line":"    The uuid of a resource provider to filter the list."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_175c9823","side":"PARENT","line":17,"updated":"2017-04-06 13:02:34.000000000","message":"does \u0027query\u0027 also mean in the path of the URL, or just as a parameter?","commit_id":"640b152004fe3d9c43c26538809c3ac796f20eba"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"f6d6b6ecadede4ab62d10f4714ad1c3c90e23e92","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    The name of a resource provider to filter the list."},{"line_number":15,"context_line":"resource_provider_uuid_query:"},{"line_number":16,"context_line":"  type: string"},{"line_number":17,"context_line":"  in: query"},{"line_number":18,"context_line":"  required: false"},{"line_number":19,"context_line":"  description: \u003e"},{"line_number":20,"context_line":"    The uuid of a resource provider to filter the list."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_d84adc25","side":"PARENT","line":17,"in_reply_to":"bff0334d_175c9823","updated":"2017-04-06 15:25:29.000000000","message":"Yes, it definitely should be in: path.","commit_id":"640b152004fe3d9c43c26538809c3ac796f20eba"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7103f8fcb14a2008623540748c21813e3ccf78e7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  in: body"},{"line_number":54,"context_line":"  required: true"},{"line_number":55,"context_line":"  description: \u003e"},{"line_number":56,"context_line":"    The UUID for one resource provider."},{"line_number":57,"context_line":"resource_providers:"},{"line_number":58,"context_line":"  type: array"},{"line_number":59,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_17613837","side":"PARENT","line":56,"updated":"2017-04-06 13:02:34.000000000","message":"Clobbering this description will mean use the one about filtering above and it is not filtering when it is in the path of the URI","commit_id":"640b152004fe3d9c43c26538809c3ac796f20eba"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"f6d6b6ecadede4ab62d10f4714ad1c3c90e23e92","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  in: body"},{"line_number":54,"context_line":"  required: true"},{"line_number":55,"context_line":"  description: \u003e"},{"line_number":56,"context_line":"    The UUID for one resource provider."},{"line_number":57,"context_line":"resource_providers:"},{"line_number":58,"context_line":"  type: array"},{"line_number":59,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_8b4ac052","side":"PARENT","line":56,"in_reply_to":"bff0334d_17613837","updated":"2017-04-06 15:25:29.000000000","message":"Hm, do you think resource_provider_uuid in path, query, body could have a different description?","commit_id":"640b152004fe3d9c43c26538809c3ac796f20eba"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ad5fa218087bc70a13ae1ba5763b8f1130e4b2a8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  in: body"},{"line_number":54,"context_line":"  required: true"},{"line_number":55,"context_line":"  description: \u003e"},{"line_number":56,"context_line":"    The UUID for one resource provider."},{"line_number":57,"context_line":"resource_providers:"},{"line_number":58,"context_line":"  type: array"},{"line_number":59,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_0be7d0e6","side":"PARENT","line":56,"in_reply_to":"bff0334d_8b4ac052","updated":"2017-04-06 15:38:30.000000000","message":"I think it is okay to have the same description as long as that description does not include \"filter the list\"","commit_id":"640b152004fe3d9c43c26538809c3ac796f20eba"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7103f8fcb14a2008623540748c21813e3ccf78e7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  required: false"},{"line_number":14,"context_line":"  description: \u003e"},{"line_number":15,"context_line":"    The name of a resource provider to filter the list."},{"line_number":16,"context_line":"resource_provider_uuid_query: \u0026resource_provider_uuid"},{"line_number":17,"context_line":"  type: string"},{"line_number":18,"context_line":"  in: query"},{"line_number":19,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_b7f3ac9e","line":16,"updated":"2017-04-06 13:02:34.000000000","message":"If you\u0027re going to make this an anchor (which you may not want to do, given comments below) please make the name and the anchor name the same.\n\nIt might be that you want a parent resource_provider_uuid with an anchor, and then children that are _query and _query_required or something like that.","commit_id":"c5b49a43e7236b2988ba4767dca19bee2df45f69"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7103f8fcb14a2008623540748c21813e3ccf78e7","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Overall limit is equal to 128 vCPUs."},{"line_number":50,"context_line":"inventories:"},{"line_number":51,"context_line":"  type: array"},{"line_number":52,"context_line":"  in: body"},{"line_number":53,"context_line":"  required: true"},{"line_number":54,"context_line":"  description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_b79e0c61","line":51,"updated":"2017-04-06 13:02:34.000000000","message":"it\u0027s a dict of inventory objects, see your get-inventories.json\n\n(the reason it is a dict is a) to make it easy to pick a single resource class from the results, b) because any rp can only have one inventory of each class","commit_id":"c5b49a43e7236b2988ba4767dca19bee2df45f69"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ad5fa218087bc70a13ae1ba5763b8f1130e4b2a8","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Overall limit is equal to 128 vCPUs."},{"line_number":50,"context_line":"inventories:"},{"line_number":51,"context_line":"  type: array"},{"line_number":52,"context_line":"  in: body"},{"line_number":53,"context_line":"  required: true"},{"line_number":54,"context_line":"  description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_6bc2dc35","line":51,"in_reply_to":"bff0334d_8b1c006b","updated":"2017-04-06 15:38:30.000000000","message":"Sorry, I was talking python but we want jsonschema types here, so \"object\"","commit_id":"c5b49a43e7236b2988ba4767dca19bee2df45f69"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"f6d6b6ecadede4ab62d10f4714ad1c3c90e23e92","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Overall limit is equal to 128 vCPUs."},{"line_number":50,"context_line":"inventories:"},{"line_number":51,"context_line":"  type: array"},{"line_number":52,"context_line":"  in: body"},{"line_number":53,"context_line":"  required: true"},{"line_number":54,"context_line":"  description: \u003e"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_8b1c006b","line":51,"in_reply_to":"bff0334d_b79e0c61","updated":"2017-04-06 15:25:29.000000000","message":"I\u0027ll try dict, looks like it could be an arbitrary value.\n\nNova types:\ntype: array\ntype: boolean\ntype: float\ntype: integer\ntype: none\ntype: object\ntype: string","commit_id":"c5b49a43e7236b2988ba4767dca19bee2df45f69"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8c1335d364715ad12530931ecb34b1f1aeb091c7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  in: body"},{"line_number":43,"context_line":"  required: true"},{"line_number":44,"context_line":"  description: |"},{"line_number":45,"context_line":"    An \"overcommit\" ratio for a particular class of resource."},{"line_number":46,"context_line":"    It\u0027s a multiplier for ``total`` used to calculate limit for a resource."},{"line_number":47,"context_line":"    For example, for a vCPU resource with::"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7ffa3b31_430c2deb","line":45,"updated":"2017-04-20 17:12:27.000000000","message":"s/class of resource/class of resource on the provider.","commit_id":"af00abf9d606ca3eec897a6370b8f6ee2f696b6d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8c1335d364715ad12530931ecb34b1f1aeb091c7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        ``cpu_allocation_ratio`` \u003d 16"},{"line_number":50,"context_line":"        ``total`` \u003d 8"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    Overall limit is equal to 128 vCPUs."},{"line_number":53,"context_line":"inventories:"},{"line_number":54,"context_line":"  type: object"},{"line_number":55,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7ffa3b31_23112105","line":52,"updated":"2017-04-20 17:12:27.000000000","message":"The above is overly confusing for a description of the allocation_ratio parameter. I would just say:\n\n \"It is used in determining whether consumption of the resource of the provider can exceed physical constraints.\"","commit_id":"af00abf9d606ca3eec897a6370b8f6ee2f696b6d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c430d5eed7f4a9894ba22f6d23e9f11109e83351","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  in: body"},{"line_number":56,"context_line":"  required: true"},{"line_number":57,"context_line":"  description: \u003e"},{"line_number":58,"context_line":"    An ``inventory`` objects dict."},{"line_number":59,"context_line":"max_unit: \u0026max_unit"},{"line_number":60,"context_line":"  type: integer"},{"line_number":61,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7ffa3b31_8c27a565","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":34},"updated":"2017-04-14 10:30:36.000000000","message":"Well, I\u0027d rather have said \"A dictionary of inventories keyed by resource classes\"","commit_id":"af00abf9d606ca3eec897a6370b8f6ee2f696b6d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8c1335d364715ad12530931ecb34b1f1aeb091c7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  in: body"},{"line_number":56,"context_line":"  required: true"},{"line_number":57,"context_line":"  description: \u003e"},{"line_number":58,"context_line":"    An ``inventory`` objects dict."},{"line_number":59,"context_line":"max_unit: \u0026max_unit"},{"line_number":60,"context_line":"  type: integer"},{"line_number":61,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7ffa3b31_03faa5bb","line":58,"updated":"2017-04-20 17:12:27.000000000","message":"agree with bauzas.","commit_id":"af00abf9d606ca3eec897a6370b8f6ee2f696b6d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c430d5eed7f4a9894ba22f6d23e9f11109e83351","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  in: body"},{"line_number":74,"context_line":"  required: true"},{"line_number":75,"context_line":"  description: \u003e"},{"line_number":76,"context_line":"    The amount of inventory total reserved for system use and unavailable"},{"line_number":77,"context_line":"    for allocations."},{"line_number":78,"context_line":"resource_class:"},{"line_number":79,"context_line":"  type: string"},{"line_number":80,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7ffa3b31_0c9ef562","line":77,"range":{"start_line":76,"start_character":0,"end_line":77,"end_character":20},"updated":"2017-04-14 10:30:36.000000000","message":"I\u0027d say \"The amount of a specific resource class that the resource provider reserves for itself and can\u0027t be allocated\"","commit_id":"af00abf9d606ca3eec897a6370b8f6ee2f696b6d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8c1335d364715ad12530931ecb34b1f1aeb091c7","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  required: true"},{"line_number":75,"context_line":"  description: \u003e"},{"line_number":76,"context_line":"    The amount of inventory total reserved for system use and unavailable"},{"line_number":77,"context_line":"    for allocations."},{"line_number":78,"context_line":"resource_class:"},{"line_number":79,"context_line":"  type: string"},{"line_number":80,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7ffa3b31_e3f699d7","line":77,"updated":"2017-04-20 17:12:27.000000000","message":"Just say simply \"The amount of the resource a provider has reserved for its own use.\"","commit_id":"af00abf9d606ca3eec897a6370b8f6ee2f696b6d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8c1335d364715ad12530931ecb34b1f1aeb091c7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  in: body"},{"line_number":81,"context_line":"  required: true"},{"line_number":82,"context_line":"  description: \u003e"},{"line_number":83,"context_line":"    The name of one resource class."},{"line_number":84,"context_line":"resource_provider_generation:"},{"line_number":85,"context_line":"  type: integer"},{"line_number":86,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7ffa3b31_c3ff1da9","line":83,"updated":"2017-04-20 17:12:27.000000000","message":"s/one/the/","commit_id":"af00abf9d606ca3eec897a6370b8f6ee2f696b6d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8c1335d364715ad12530931ecb34b1f1aeb091c7","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  description: \u003e"},{"line_number":117,"context_line":"    A representation of the divisible unit amount of the resource"},{"line_number":118,"context_line":"    that may be requested. For example, step_size \u003d 5 means"},{"line_number":119,"context_line":"    that only values divisible by 5 (5, 10, 15, etc.) can be requested."},{"line_number":120,"context_line":"total:"},{"line_number":121,"context_line":"  type: integer"},{"line_number":122,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7ffa3b31_a3fc11b5","line":119,"updated":"2017-04-20 17:12:27.000000000","message":"++ good.","commit_id":"af00abf9d606ca3eec897a6370b8f6ee2f696b6d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c430d5eed7f4a9894ba22f6d23e9f11109e83351","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  in: body"},{"line_number":123,"context_line":"  required: true"},{"line_number":124,"context_line":"  description: \u003e"},{"line_number":125,"context_line":"    The real/physical total inventory of the resource."},{"line_number":126,"context_line":"version_id:"},{"line_number":127,"context_line":"  type: string"},{"line_number":128,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7ffa3b31_4ccf5d7f","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":54},"updated":"2017-04-14 10:30:36.000000000","message":"I\u0027d rather have said \"the logical amount that the provider provides for the specific resource class\". At least something like that.","commit_id":"af00abf9d606ca3eec897a6370b8f6ee2f696b6d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8c1335d364715ad12530931ecb34b1f1aeb091c7","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  in: body"},{"line_number":123,"context_line":"  required: true"},{"line_number":124,"context_line":"  description: \u003e"},{"line_number":125,"context_line":"    The real/physical total inventory of the resource."},{"line_number":126,"context_line":"version_id:"},{"line_number":127,"context_line":"  type: string"},{"line_number":128,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7ffa3b31_832fd53d","line":125,"updated":"2017-04-20 17:12:27.000000000","message":"Instead, I\u0027d say:\n\n \"The actual amount of the resource that the provider can accomodate.\"","commit_id":"af00abf9d606ca3eec897a6370b8f6ee2f696b6d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"91ae863230dd3bd198d567c1ba265421f391e38e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  in: body"},{"line_number":115,"context_line":"  required: true"},{"line_number":116,"context_line":"  description: \u003e"},{"line_number":117,"context_line":"    A representation of the divisible unit amount of the resource"},{"line_number":118,"context_line":"    that may be requested. For example, step_size \u003d 5 means"},{"line_number":119,"context_line":"    that only values divisible by 5 (5, 10, 15, etc.) can be requested."},{"line_number":120,"context_line":"total:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5ff73747_ca2120b6","line":117,"updated":"2017-05-02 10:16:43.000000000","message":"s/unit//","commit_id":"30bc459cd389efe58d2023f81a143386c1a9141a"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"91ae863230dd3bd198d567c1ba265421f391e38e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  in: body"},{"line_number":123,"context_line":"  required: true"},{"line_number":124,"context_line":"  description: \u003e"},{"line_number":125,"context_line":"    The actual amount of the resource that the provider can accomodate."},{"line_number":126,"context_line":"version_id:"},{"line_number":127,"context_line":"  type: string"},{"line_number":128,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5ff73747_45a063f4","line":125,"updated":"2017-05-02 10:16:43.000000000","message":"I\u0027m not a fan of the word accommodate (also note the spelling, two \u0027m\u0027) here. It implies that the total is the amount of resource that can be provisioned; that\u0027s not true.\n\nTotal is the actual total of the resource and from that we subtract reserved for what the resource wants for itself. If it is something else that we just choose arbitrarily, then why bother having reserved?\n\nSo I suggest falling back to something simple like: \"The total amount of the resource.\"\n\nThe context helps expand on the true meaning of that, the definition isn\u0027t going to be used in isolation.","commit_id":"30bc459cd389efe58d2023f81a143386c1a9141a"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"b4236ee1b380926938df4b79fdf90f862b88565d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  in: body"},{"line_number":123,"context_line":"  required: true"},{"line_number":124,"context_line":"  description: \u003e"},{"line_number":125,"context_line":"    The actual amount of the resource that the provider can accomodate."},{"line_number":126,"context_line":"version_id:"},{"line_number":127,"context_line":"  type: string"},{"line_number":128,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5ff73747_88b544d0","line":125,"in_reply_to":"5ff73747_45a063f4","updated":"2017-05-03 06:04:08.000000000","message":"Will fix the spelling. Possibly we need come to conclusion in chat with Jay )","commit_id":"30bc459cd389efe58d2023f81a143386c1a9141a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"91b03817d23807db26f3429cde3ae96c96451348","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        allocation_ratio \u003d 16.0"},{"line_number":51,"context_line":"        total \u003d 8"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    Overall limit is equal to 128 vCPUs."},{"line_number":54,"context_line":"inventories:"},{"line_number":55,"context_line":"  type: object"},{"line_number":56,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ff0f0b1f_ef5aa14e","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":17},"updated":"2017-05-25 19:03:53.000000000","message":"I would prefer to not use the term \"limit\" here, because it\u0027s actually not a limit. The max_unit and min_unit are limits -- they indicate the range of requested amounts that are possible. In this case, though, what you are describing is the provider\u0027s \"capacity\".","commit_id":"72cd1e0e992346ee70e921e40b2e11da968031c9"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"56971fbfe179fd43110e55b8e69cdb69d6eeaa93","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        allocation_ratio \u003d 16.0"},{"line_number":51,"context_line":"        total \u003d 8"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    Overall limit is equal to 128 vCPUs."},{"line_number":54,"context_line":"inventories:"},{"line_number":55,"context_line":"  type: object"},{"line_number":56,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ff0f0b1f_d94b165d","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":17},"in_reply_to":"ff0f0b1f_ef5aa14e","updated":"2017-05-26 10:42:54.000000000","message":"Done","commit_id":"72cd1e0e992346ee70e921e40b2e11da968031c9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"45211dd5a695b27b31ef012bdf47742f1b91ae74","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        allocation_ratio \u003d 16.0"},{"line_number":51,"context_line":"        total \u003d 8"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    Overall capacity is equal to 128 vCPUs."},{"line_number":54,"context_line":"inventories:"},{"line_number":55,"context_line":"  type: object"},{"line_number":56,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_5c6251da","line":53,"updated":"2017-05-26 13:07:13.000000000","message":"good, thank you Andrey! :)","commit_id":"bc1cd809b3e1314b857477bb8e7dfb9548bd336e"}]}