)]}'
{"etc/nova/rootwrap.d/compute.filters":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"ac5da1de55ebbd03c41289ad7b671d0d84169cf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bfdaf3ff_c00ce3ed","updated":"2019-01-17 21:37:55.000000000","message":"Please don\u0027t add new rootwrap entries.  Use privsep instead.","commit_id":"c3306e36bd52e2d7db83e7bd88b3cdc64a3bceb5"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"ac5da1de55ebbd03c41289ad7b671d0d84169cf3","unresolved":false,"context_lines":[{"line_number":4116,"context_line":"        # the config drive here."},{"line_number":4117,"context_line":""},{"line_number":4118,"context_line":"        expect \u003d {\"ppc\": \"sda\", \"ppc64\": \"sda\","},{"line_number":4119,"context_line":"                  \"ppc64le\": \"sda\", \"aarch64\": \"sda\"}"},{"line_number":4120,"context_line":"        disk \u003d expect.get(blockinfo.libvirt_utils.get_arch({}), \"hda\")"},{"line_number":4121,"context_line":"        self.assertIsInstance(cfg.devices[2],"},{"line_number":4122,"context_line":"                              vconfig.LibvirtConfigGuestDisk)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfdaf3ff_0030ab9e","line":4119,"updated":"2019-01-17 21:37:55.000000000","message":"nit: This is a separate unrelated change","commit_id":"c3306e36bd52e2d7db83e7bd88b3cdc64a3bceb5"}],"nova/virt/configdrive.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"0673586ef56c4d1df73cf7eeea880fc90275e32a","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                      \u0027-s\u0027, CONFIGDRIVESIZE_BYTES,"},{"line_number":138,"context_line":"                      path + \u0027/root.hds\u0027,"},{"line_number":139,"context_line":"                      attempts\u003d1,"},{"line_number":140,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":141,"context_line":"        utils.execute(\u0027chown\u0027, \u0027-R\u0027,"},{"line_number":142,"context_line":"                      \u0027%(u)d:%(g)d\u0027 % {\u0027u\u0027: os.getuid(),"},{"line_number":143,"context_line":"                      \u0027g\u0027: os.getgid()},"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_87648123","line":140,"updated":"2017-04-10 23:24:38.000000000","message":"This would seem to generate an ext4 ploop image that the *guest* needs to mount/grok thereby adding ext4 as a supported filesystem type fro configdrive which is the reason this support was reverted in the past.\n\nIf that is incorrect can you please help us understand (and document) the setup here","commit_id":"9cc086f526fa91f1305ce99ade49c21311f8bdc6"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"9b4a57ca614cf379ca3f44b0e093e073d48f2e97","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                      \u0027-s\u0027, CONFIGDRIVESIZE_BYTES,"},{"line_number":138,"context_line":"                      path + \u0027/root.hds\u0027,"},{"line_number":139,"context_line":"                      attempts\u003d1,"},{"line_number":140,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":141,"context_line":"        utils.execute(\u0027chown\u0027, \u0027-R\u0027,"},{"line_number":142,"context_line":"                      \u0027%(u)d:%(g)d\u0027 % {\u0027u\u0027: os.getuid(),"},{"line_number":143,"context_line":"                      \u0027g\u0027: os.getgid()},"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_e54e9b36","line":140,"in_reply_to":"bff0334d_87648123","updated":"2017-04-11 08:44:37.000000000","message":"\u003e This would seem to generate an ext4 ploop image\n\nyep, this is correct\n\n\u003e that the *guest* needs to mount/grok \n\nThis is implied to be done by *host*. This is what \u003cfilesystem\u003e xml element is about\n\n\u003e adding ext4 as a supported filesystem type for configdrive\n\nthis is not necessary as it is opaque for guest and formatting is done on host side by ploop utility without specifying what filesystem to use and guest isn\u0027t allowed to mount arbirtrary block device whatever filesystem it has. Thus, we can document that filesystem config drive parameters are ignored in case of Virtuozzo containers and shouldn\u0027t be specified for containers at all and these parameters are VMs specific only.","commit_id":"9cc086f526fa91f1305ce99ade49c21311f8bdc6"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"ac5da1de55ebbd03c41289ad7b671d0d84169cf3","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                      path + \u0027/root.hds\u0027,"},{"line_number":139,"context_line":"                      attempts\u003d1,"},{"line_number":140,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":141,"context_line":"        utils.execute(\u0027chown\u0027, \u0027-R\u0027,"},{"line_number":142,"context_line":"                      \u0027%(u)d:%(g)d\u0027 % {\u0027u\u0027: os.getuid(),"},{"line_number":143,"context_line":"                      \u0027g\u0027: os.getgid()},"},{"line_number":144,"context_line":"                      path,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfdaf3ff_40eeb3ed","line":141,"updated":"2019-01-17 21:37:55.000000000","message":"This should be privsep.chown()","commit_id":"c3306e36bd52e2d7db83e7bd88b3cdc64a3bceb5"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"ac5da1de55ebbd03c41289ad7b671d0d84169cf3","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                        path + \u0027/DiskDescriptor.xml\u0027,"},{"line_number":153,"context_line":"                        run_as_root\u003dTrue)"},{"line_number":154,"context_line":"                if os.path.exists(mountdir):"},{"line_number":155,"context_line":"                    utils.execute(\u0027chown\u0027, \u0027-R\u0027,"},{"line_number":156,"context_line":"                            \u0027%(u)d:%(g)d\u0027 % {\u0027u\u0027: os.getuid(),"},{"line_number":157,"context_line":"                                             \u0027g\u0027: os.getgid()},"},{"line_number":158,"context_line":"                            mountdir,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfdaf3ff_20c36f5f","line":155,"updated":"2019-01-17 21:37:55.000000000","message":"Ditto privsep.chown()","commit_id":"c3306e36bd52e2d7db83e7bd88b3cdc64a3bceb5"}]}