)]}'
{"nova/virt/netutils.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"445b4bda3387f2af55118af572dee6309986b779","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        attached to"},{"line_number":263,"context_line":"    \"\"\""},{"line_number":264,"context_line":"    net_type \u003d \u0027\u0027"},{"line_number":265,"context_line":"    if subnet.get_meta(\u0027dhcp_server\u0027) is not None:"},{"line_number":266,"context_line":"        net_type \u003d \u0027_dhcp\u0027"},{"line_number":267,"context_line":"    if subnet.get_meta(\u0027ipv6_address_mode\u0027) is not None:"},{"line_number":268,"context_line":"        net_type \u003d \u0027_%s\u0027 % subnet.get_meta(\u0027ipv6_address_mode\u0027)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    ip \u003d subnet[\u0027ips\u0027][0]"},{"line_number":271,"context_line":"    address \u003d ip[\u0027address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_620564c2","line":268,"range":{"start_line":265,"start_character":0,"end_line":268,"end_character":63},"updated":"2017-04-06 13:14:58.000000000","message":"nit: Might make more sense as an if-else\n\n  if subnet.get_meta(\u0027ipv6_address_mode\u0027) is not None:\n      net_type \u003d \u0027_%s\u0027 % subnet.get_meta(\u0027ipv6_address_mode\u0027)\n  elif subnet.get_meta(\u0027dhcp_server\u0027) is not None:\n      net_type \u003d \u0027_dhcp\u0027\n\nAlso, I wonder if we need the \u0027is not None\u0027 check?","commit_id":"fc744203ea7ed0ad5afe455c389b2d8f4244a413"}]}