)]}'
{"nova/tests/unit/virt/libvirt/volume/test_fs.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"46fe2a7c4189a9c75735753cbe047e283d7acbf9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"class FSVolumeDriverSubclassSignatureTestCase(test.SubclassSignatureTestCase):"},{"line_number":34,"context_line":"    def _get_base_class(self):"},{"line_number":35,"context_line":"        # We do this because it has the side-effect of loading all the"},{"line_number":36,"context_line":"        # volume drivers"},{"line_number":37,"context_line":"        self.useFixture(fakelibvirt.FakeLibvirtFixture())"},{"line_number":38,"context_line":"        driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_6da6dead","line":36,"updated":"2017-04-21 12:57:16.000000000","message":"I am glad you put that comment there.","commit_id":"5ff12afad4170837aa59c1ee99d089a75c121e03"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1833b1454c6e4da93fbf6d608105a5fd2a25c885","unresolved":false,"context_lines":[{"line_number":30,"context_line":"FAKE_DEVICE_NAME \u003d \u0027fake-device\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class FSVolumeDriverSubclassSignatureTestCase(test.SubclassSignatureTestCase):"},{"line_number":34,"context_line":"    def _get_base_class(self):"},{"line_number":35,"context_line":"        # We do this because it has the side-effect of loading all the"},{"line_number":36,"context_line":"        # volume drivers"},{"line_number":37,"context_line":"        self.useFixture(fakelibvirt.FakeLibvirtFixture())"},{"line_number":38,"context_line":"        driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        return fs.LibvirtBaseFileSystemVolumeDriver"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class FakeFileSystemVolumeDriver(fs.LibvirtBaseFileSystemVolumeDriver):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_5c0250b6","line":40,"range":{"start_line":33,"start_character":0,"end_line":40,"end_character":51},"updated":"2017-05-15 21:22:26.000000000","message":"So is this only testing the LibvirtBaseFileSystemVolumeDriver subclasses? Because we\u0027re not catching the missing instance argument in the new veritas hyperscale driver:\n\nhttps://review.openstack.org/#/c/443951/","commit_id":"b66b7d4f9d63e7f45ebfc033696d06c632a33ff1"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"edbeb55d8e84eca4b5457f54e7cd4ec1106d5053","unresolved":false,"context_lines":[{"line_number":30,"context_line":"FAKE_DEVICE_NAME \u003d \u0027fake-device\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class FSVolumeDriverSubclassSignatureTestCase(test.SubclassSignatureTestCase):"},{"line_number":34,"context_line":"    def _get_base_class(self):"},{"line_number":35,"context_line":"        # We do this because it has the side-effect of loading all the"},{"line_number":36,"context_line":"        # volume drivers"},{"line_number":37,"context_line":"        self.useFixture(fakelibvirt.FakeLibvirtFixture())"},{"line_number":38,"context_line":"        driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        return fs.LibvirtBaseFileSystemVolumeDriver"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class FakeFileSystemVolumeDriver(fs.LibvirtBaseFileSystemVolumeDriver):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_2ebdfcb6","line":40,"range":{"start_line":33,"start_character":0,"end_line":40,"end_character":51},"in_reply_to":"1f013ff3_534d9170","updated":"2017-05-16 10:37:40.000000000","message":"Well I say should. Could would be more accurate. Patch is here:\n\nhttps://review.openstack.org/465022\n\nIncidentally there are likely other places this would be useful. The driver interface springs to mind.","commit_id":"b66b7d4f9d63e7f45ebfc033696d06c632a33ff1"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"588061825727e95efe51c8de7e95a3789d0707fb","unresolved":false,"context_lines":[{"line_number":30,"context_line":"FAKE_DEVICE_NAME \u003d \u0027fake-device\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class FSVolumeDriverSubclassSignatureTestCase(test.SubclassSignatureTestCase):"},{"line_number":34,"context_line":"    def _get_base_class(self):"},{"line_number":35,"context_line":"        # We do this because it has the side-effect of loading all the"},{"line_number":36,"context_line":"        # volume drivers"},{"line_number":37,"context_line":"        self.useFixture(fakelibvirt.FakeLibvirtFixture())"},{"line_number":38,"context_line":"        driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        return fs.LibvirtBaseFileSystemVolumeDriver"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class FakeFileSystemVolumeDriver(fs.LibvirtBaseFileSystemVolumeDriver):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_534d9170","line":40,"range":{"start_line":33,"start_character":0,"end_line":40,"end_character":51},"in_reply_to":"1f013ff3_5c0250b6","updated":"2017-05-16 09:43:06.000000000","message":"Yep, that should be testing the base driver. I\u0027ll follow up with a patch.","commit_id":"b66b7d4f9d63e7f45ebfc033696d06c632a33ff1"}],"nova/virt/libvirt/volume/disco.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"26011b7deba7e8e918fde9f13a75e0581026624b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        return conf"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def connect_volume(self, connection_info, disk_info, instance):"},{"line_number":53,"context_line":"        \"\"\"Connect a DISCO volume to a compute node.\"\"\""},{"line_number":54,"context_line":"        device_info \u003d self.connector.connect_volume(connection_info[\u0027data\u0027])"},{"line_number":55,"context_line":"        connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d device_info[\u0027path\u0027]"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_9a79ccfd","line":53,"range":{"start_line":53,"start_character":21,"end_line":53,"end_character":26},"updated":"2017-04-18 15:37:32.000000000","message":"this is almost as good as \u0027ploop\u0027","commit_id":"20743b67e2f4f8d466a1c95b9fc9e641bcfb2b32"}]}