)]}'
{"nova/policies/flavor_extra_specs.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"728fae931f49e5fd9f4de7fb7b1436a46aa8137e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    base.create_rule_default("},{"line_number":26,"context_line":"        POLICY_ROOT % \u0027show\u0027,"},{"line_number":27,"context_line":"        base.RULE_ADMIN_OR_OWNER,"},{"line_number":28,"context_line":"        \"Show an extra spec for a flavor\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"},{"line_number":31,"context_line":"                \u0027path\u0027: \u0027/flavors/{flavor_id}/os-extra_specs/\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_6f05eb13","line":28,"range":{"start_line":28,"start_character":14,"end_line":28,"end_character":22},"updated":"2017-03-28 08:31:05.000000000","message":"a single","commit_id":"da403b8b2ae0db844770abf4a78d79f2a72efc7e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"728fae931f49e5fd9f4de7fb7b1436a46aa8137e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    base.create_rule_default("},{"line_number":38,"context_line":"        POLICY_ROOT % \u0027create\u0027,"},{"line_number":39,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":40,"context_line":"        \"Create extra specs for a flavor\","},{"line_number":41,"context_line":"        ["},{"line_number":42,"context_line":"            {"},{"line_number":43,"context_line":"                \u0027path\u0027: \u0027/flavors/{flavor_id}/os-extra_specs/\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_fa6d3bcc","line":40,"range":{"start_line":40,"start_character":9,"end_line":40,"end_character":27},"updated":"2017-03-28 08:31:05.000000000","message":"This will both create and update, depending on whether the flavor has extra specs already or not?","commit_id":"da403b8b2ae0db844770abf4a78d79f2a72efc7e"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"97f7fe5ab57990d5109a64367b19e4632cf99882","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    base.create_rule_default("},{"line_number":38,"context_line":"        POLICY_ROOT % \u0027create\u0027,"},{"line_number":39,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":40,"context_line":"        \"Create extra specs for a flavor\","},{"line_number":41,"context_line":"        ["},{"line_number":42,"context_line":"            {"},{"line_number":43,"context_line":"                \u0027path\u0027: \u0027/flavors/{flavor_id}/os-extra_specs/\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_cad982f3","line":40,"range":{"start_line":40,"start_character":9,"end_line":40,"end_character":27},"in_reply_to":"ffe62b97_479c4b0e","updated":"2017-03-28 09:39:07.000000000","message":"So, what do you suggest?","commit_id":"da403b8b2ae0db844770abf4a78d79f2a72efc7e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"88d4161409239d12e317c3a4220ccc98a4417011","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    base.create_rule_default("},{"line_number":38,"context_line":"        POLICY_ROOT % \u0027create\u0027,"},{"line_number":39,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":40,"context_line":"        \"Create extra specs for a flavor\","},{"line_number":41,"context_line":"        ["},{"line_number":42,"context_line":"            {"},{"line_number":43,"context_line":"                \u0027path\u0027: \u0027/flavors/{flavor_id}/os-extra_specs/\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_479c4b0e","line":40,"range":{"start_line":40,"start_character":9,"end_line":40,"end_character":27},"in_reply_to":"ffe62b97_75901cee","updated":"2017-03-28 09:23:09.000000000","message":"Aye, I just saw that too. Yeah, let\u0027s not say the wrong thing in _two_ places :)","commit_id":"da403b8b2ae0db844770abf4a78d79f2a72efc7e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"36c84b3a84f6b6b0326d0cfd5b265f9968f255eb","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    base.create_rule_default("},{"line_number":38,"context_line":"        POLICY_ROOT % \u0027create\u0027,"},{"line_number":39,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":40,"context_line":"        \"Create extra specs for a flavor\","},{"line_number":41,"context_line":"        ["},{"line_number":42,"context_line":"            {"},{"line_number":43,"context_line":"                \u0027path\u0027: \u0027/flavors/{flavor_id}/os-extra_specs/\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_fde9b2b6","line":40,"range":{"start_line":40,"start_character":9,"end_line":40,"end_character":27},"in_reply_to":"ffe62b97_cad982f3","updated":"2017-03-28 09:51:10.000000000","message":"I would say something like the below _in the API guide_. For here, what you have is probably good enough tbh\n\n    Create extra specs for a flavor.\n\n    If extra specs already exist for the flavor, they will be overriden.","commit_id":"da403b8b2ae0db844770abf4a78d79f2a72efc7e"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"30f9b4416fa80de45abf3feaaba3cea296399ad3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    base.create_rule_default("},{"line_number":38,"context_line":"        POLICY_ROOT % \u0027create\u0027,"},{"line_number":39,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":40,"context_line":"        \"Create extra specs for a flavor\","},{"line_number":41,"context_line":"        ["},{"line_number":42,"context_line":"            {"},{"line_number":43,"context_line":"                \u0027path\u0027: \u0027/flavors/{flavor_id}/os-extra_specs/\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_75901cee","line":40,"range":{"start_line":40,"start_character":9,"end_line":40,"end_character":27},"in_reply_to":"ffe62b97_fa6d3bcc","updated":"2017-03-28 09:08:32.000000000","message":"I was referenced by api-ref, but looks like we should update api-ref as well","commit_id":"da403b8b2ae0db844770abf4a78d79f2a72efc7e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"728fae931f49e5fd9f4de7fb7b1436a46aa8137e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    base.create_rule_default("},{"line_number":52,"context_line":"        POLICY_ROOT % \u0027update\u0027,"},{"line_number":53,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":54,"context_line":"        \"Update an extra spec for a flavor\","},{"line_number":55,"context_line":"        ["},{"line_number":56,"context_line":"            {"},{"line_number":57,"context_line":"                \u0027path\u0027: \u0027/flavors/{flavor_id}/os-extra_specs/\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_2f1c8376","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":29},"updated":"2017-03-28 08:31:05.000000000","message":"Is this for updating a single extra spec, or multiple extra specs? The code suggests the latter [1]. However, I can\u0027t figure out how this differs from the \u0027create\u0027 method :/\n\n[1] https://github.com/openstack/nova/blob/4535e39/nova/api/openstack/compute/flavors_extraspecs.py#L91","commit_id":"da403b8b2ae0db844770abf4a78d79f2a72efc7e"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"30f9b4416fa80de45abf3feaaba3cea296399ad3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    base.create_rule_default("},{"line_number":52,"context_line":"        POLICY_ROOT % \u0027update\u0027,"},{"line_number":53,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":54,"context_line":"        \"Update an extra spec for a flavor\","},{"line_number":55,"context_line":"        ["},{"line_number":56,"context_line":"            {"},{"line_number":57,"context_line":"                \u0027path\u0027: \u0027/flavors/{flavor_id}/os-extra_specs/\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_b58a24bc","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":29},"in_reply_to":"ffe62b97_2f1c8376","updated":"2017-03-28 09:08:32.000000000","message":"I think this is similar as metadata, and hard to understand, we should provide extra_spec_key in url, which make it looks like update one flavor, but in fact, we should also provide key,value pairs in body and it only checks if the id is in the url, but we can still provide multiple key/values, I would think the idea of this API is update one, but somehow not implemented well...","commit_id":"da403b8b2ae0db844770abf4a78d79f2a72efc7e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"728fae931f49e5fd9f4de7fb7b1436a46aa8137e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    base.create_rule_default("},{"line_number":64,"context_line":"        POLICY_ROOT % \u0027delete\u0027,"},{"line_number":65,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":66,"context_line":"        \"Delete an extra spec for a flavor\","},{"line_number":67,"context_line":"        ["},{"line_number":68,"context_line":"            {"},{"line_number":69,"context_line":"                \u0027path\u0027: \u0027/flavors/{flavor_id}/os-extra_specs/\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_1a069f1e","line":66,"range":{"start_line":66,"start_character":16,"end_line":66,"end_character":24},"updated":"2017-03-28 08:31:05.000000000","message":"a single","commit_id":"da403b8b2ae0db844770abf4a78d79f2a72efc7e"}]}