)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8aa63f319c5e54c2d4ce0934da077194836f5ae1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"The VSPC implementation is available at"},{"line_number":17,"context_line":"https://github.com/openstack/vmware-vspc"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"blueprint vmware-console-log"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I7e40dc41b0354d414bc8eae331f8257959e1d123"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f515b1d_d941f5a7","line":19,"updated":"2017-10-02 21:06:08.000000000","message":"I cannot find the corresponding blueprint from launchpad.\nIn addition, Matt requires blueprint at least for small features like https://review.openstack.org/#/c/389482/","commit_id":"8727909edec4b8962ab123bd5d9fc10f9708745e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"72cfdec4eaa619a814dd15b538ac64b523b38fa7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Commit ace11d3 adds a serial port device to instances, so the serial"},{"line_number":10,"context_line":"console output can be sent to a virtual serial port concentrator (VSPC)."},{"line_number":11,"context_line":"This patch finishes the implementation by returning the output saved by"},{"line_number":12,"context_line":"VSPC to the end user. The config option \u0027serial_log_dir\u0027 should have the"},{"line_number":13,"context_line":"same value as in the VSPC configuration (i.e. it must point to the same"},{"line_number":14,"context_line":"directory)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f4b6375_195574fa","line":11,"updated":"2017-11-06 02:35:02.000000000","message":"Doesn\u0027t this mean you should mark serial console support marked as done for vcenter in the support matrix?\n\nhttps://docs.openstack.org/nova/latest/user/support-matrix.html#console_serial_log\n\nAlso, how about a release note for this?","commit_id":"da64284055505c269b802372c9f418355a30943c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"605608e5ceb84bc5befb0659b453f54ab190a436","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Commit ace11d3 adds a serial port device to instances, so the serial"},{"line_number":10,"context_line":"console output can be sent to a virtual serial port concentrator (VSPC)."},{"line_number":11,"context_line":"This patch finishes the implementation by returning the output saved by"},{"line_number":12,"context_line":"VSPC to the end user. The config option \u0027serial_log_dir\u0027 should have the"},{"line_number":13,"context_line":"same value as in the VSPC configuration (i.e. it must point to the same"},{"line_number":14,"context_line":"directory)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f4b6375_b17e7067","line":11,"in_reply_to":"3f4b6375_195574fa","updated":"2017-11-06 10:03:55.000000000","message":"Done","commit_id":"da64284055505c269b802372c9f418355a30943c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"713dae813fbfc17871fb6626d2a1ed5c181cee79","unresolved":false,"context_lines":[{"line_number":16,"context_line":"The VSPC implementation is available at"},{"line_number":17,"context_line":"https://github.com/openstack/vmware-vspc"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"blueprint vmware-console-log-complete"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I7e40dc41b0354d414bc8eae331f8257959e1d123"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f4b6375_d9147c46","line":19,"updated":"2017-11-06 02:29:09.000000000","message":"I haven\u0027t been tracking this blueprint for Queens. Looks like a simple feature parity blueprint, but since we\u0027re past the spec freeze deadline can you at least just add this to the November 16th nova meeting agenda (under open discussion) so we can discuss as a team adding this to the list of stuff to get done in Queens?","commit_id":"da64284055505c269b802372c9f418355a30943c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"605608e5ceb84bc5befb0659b453f54ab190a436","unresolved":false,"context_lines":[{"line_number":16,"context_line":"The VSPC implementation is available at"},{"line_number":17,"context_line":"https://github.com/openstack/vmware-vspc"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"blueprint vmware-console-log-complete"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I7e40dc41b0354d414bc8eae331f8257959e1d123"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f4b6375_f1886871","line":19,"in_reply_to":"3f4b6375_d9147c46","updated":"2017-11-06 10:03:55.000000000","message":"I have added it to the meeting agenda","commit_id":"da64284055505c269b802372c9f418355a30943c"}],"nova/conf/vmware.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ebda67abdeb856b76956a5816fc3f4fa9eb2444a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"This option is ignored if serial_port_service_uri is not specified."},{"line_number":93,"context_line":"* serial_port_service_uri"},{"line_number":94,"context_line":"\"\"\"),"},{"line_number":95,"context_line":"    cfg.StrOpt(\u0027serial_log_dir\u0027,"},{"line_number":96,"context_line":"               help\u003d\"\"\""},{"line_number":97,"context_line":"Specifies the directory where the Virtual Serial Port Concentrator is"},{"line_number":98,"context_line":"storing console log files."}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_0665bfe1","line":95,"updated":"2017-07-20 12:08:46.000000000","message":"no possible default for this?","commit_id":"7a479ec5c3d9f1d94ba26892cee6b0e330d5388c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"17aca75c7e3656eb17bac70695d14d0d5fabcd0b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"This option is ignored if serial_port_service_uri is not specified."},{"line_number":93,"context_line":"* serial_port_service_uri"},{"line_number":94,"context_line":"\"\"\"),"},{"line_number":95,"context_line":"    cfg.StrOpt(\u0027serial_log_dir\u0027,"},{"line_number":96,"context_line":"               help\u003d\"\"\""},{"line_number":97,"context_line":"Specifies the directory where the Virtual Serial Port Concentrator is"},{"line_number":98,"context_line":"storing console log files."}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_4bd97bf2","line":95,"in_reply_to":"1f1a1f67_0665bfe1","updated":"2017-07-20 14:02:34.000000000","message":"We use \u0027/opt/stack/data/vspc\u0027 in the devstack plugin and \u0027/var/log/vspc\u0027 in VIO. I will put the latter as default.","commit_id":"7a479ec5c3d9f1d94ba26892cee6b0e330d5388c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"72cfdec4eaa619a814dd15b538ac64b523b38fa7","unresolved":false,"context_lines":[{"line_number":93,"context_line":"* serial_port_service_uri"},{"line_number":94,"context_line":"\"\"\"),"},{"line_number":95,"context_line":"    cfg.StrOpt(\u0027serial_log_dir\u0027,"},{"line_number":96,"context_line":"               default\u003d\u0027/var/log/vspc\u0027,"},{"line_number":97,"context_line":"               help\u003d\"\"\""},{"line_number":98,"context_line":"Specifies the directory where the Virtual Serial Port Concentrator is"},{"line_number":99,"context_line":"storing console log files."}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_f92298a2","line":96,"range":{"start_line":96,"start_character":24,"end_line":96,"end_character":37},"updated":"2017-11-06 02:35:02.000000000","message":"The commit message says this must point to the same thing as the vspc, but the default in that code is not this:\n\nhttps://github.com/openstack/vmware-vspc/blob/master/etc/vspc.conf.sample#L8\n\nSo those should at least be the same, correct? And that should probably be made explicitly clear in the help text below?","commit_id":"da64284055505c269b802372c9f418355a30943c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"605608e5ceb84bc5befb0659b453f54ab190a436","unresolved":false,"context_lines":[{"line_number":93,"context_line":"* serial_port_service_uri"},{"line_number":94,"context_line":"\"\"\"),"},{"line_number":95,"context_line":"    cfg.StrOpt(\u0027serial_log_dir\u0027,"},{"line_number":96,"context_line":"               default\u003d\u0027/var/log/vspc\u0027,"},{"line_number":97,"context_line":"               help\u003d\"\"\""},{"line_number":98,"context_line":"Specifies the directory where the Virtual Serial Port Concentrator is"},{"line_number":99,"context_line":"storing console log files."}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_919934c5","line":96,"range":{"start_line":96,"start_character":24,"end_line":96,"end_character":37},"in_reply_to":"3f4b6375_f92298a2","updated":"2017-11-06 10:03:55.000000000","message":"Done","commit_id":"da64284055505c269b802372c9f418355a30943c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5150a7775d34242ec038d4912538e7f2703b047","unresolved":false,"context_lines":[{"line_number":93,"context_line":"* serial_port_service_uri"},{"line_number":94,"context_line":"\"\"\"),"},{"line_number":95,"context_line":"    cfg.StrOpt(\u0027serial_log_dir\u0027,"},{"line_number":96,"context_line":"               default\u003d\u0027/var/log/vspc\u0027,"},{"line_number":97,"context_line":"               help\u003d\"\"\""},{"line_number":98,"context_line":"Specifies the directory where the Virtual Serial Port Concentrator is"},{"line_number":99,"context_line":"storing console log files. It should match the \u0027serial_log_dir\u0027 config"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_83a235ad","line":96,"range":{"start_line":96,"start_character":24,"end_line":96,"end_character":37},"updated":"2017-11-16 15:04:19.000000000","message":"Why isn\u0027t this /opt/vmware/vspc as the default? Because that\u0027s the default value in the vspc repo:\n\nhttps://github.com/openstack/vmware-vspc/blob/master/etc/vspc.conf.sample#L8","commit_id":"257ec2b75f6c4709479c42d672e8698157ab118d"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"5dd55d5bbcbdb60d42a2a91afe034f679c1c0c0d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"* serial_port_service_uri"},{"line_number":94,"context_line":"\"\"\"),"},{"line_number":95,"context_line":"    cfg.StrOpt(\u0027serial_log_dir\u0027,"},{"line_number":96,"context_line":"               default\u003d\u0027/var/log/vspc\u0027,"},{"line_number":97,"context_line":"               help\u003d\"\"\""},{"line_number":98,"context_line":"Specifies the directory where the Virtual Serial Port Concentrator is"},{"line_number":99,"context_line":"storing console log files. It should match the \u0027serial_log_dir\u0027 config"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_c4da5776","line":96,"range":{"start_line":96,"start_character":24,"end_line":96,"end_character":37},"in_reply_to":"1f485f77_83a235ad","updated":"2017-11-17 14:08:05.000000000","message":"I thought I have fixed that but somehow I missed it. Done.","commit_id":"257ec2b75f6c4709479c42d672e8698157ab118d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5150a7775d34242ec038d4912538e7f2703b047","unresolved":false,"context_lines":[{"line_number":96,"context_line":"               default\u003d\u0027/var/log/vspc\u0027,"},{"line_number":97,"context_line":"               help\u003d\"\"\""},{"line_number":98,"context_line":"Specifies the directory where the Virtual Serial Port Concentrator is"},{"line_number":99,"context_line":"storing console log files. It should match the \u0027serial_log_dir\u0027 config"},{"line_number":100,"context_line":"value of VSPC."},{"line_number":101,"context_line":"\"\"\"),"},{"line_number":102,"context_line":"]"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_43a8bd8a","line":100,"range":{"start_line":99,"start_character":27,"end_line":100,"end_character":14},"updated":"2017-11-16 15:04:19.000000000","message":"This is fine as a reminder, but the defaults between nova and the library should match, don\u0027t you think?","commit_id":"257ec2b75f6c4709479c42d672e8698157ab118d"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"72cfdec4eaa619a814dd15b538ac64b523b38fa7","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            return"},{"line_number":270,"context_line":"        fname \u003d instance.uuid.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":271,"context_line":"        path \u003d os.path.join(CONF.vmware.serial_log_dir, fname)"},{"line_number":272,"context_line":"        if not os.path.exists(path):"},{"line_number":273,"context_line":"            return b\"\""},{"line_number":274,"context_line":"        with open(path, \u0027rb\u0027) as fp:"},{"line_number":275,"context_line":"            read_log_data, remaining \u003d nova.privsep.path.last_bytes("}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_792ea88c","line":272,"updated":"2017-11-06 02:35:02.000000000","message":"Couldn\u0027t this also mean a misconfiguration between nova and vspc? Log something for that? Should this file exist or it\u0027s optional?","commit_id":"da64284055505c269b802372c9f418355a30943c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"605608e5ceb84bc5befb0659b453f54ab190a436","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            return"},{"line_number":270,"context_line":"        fname \u003d instance.uuid.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":271,"context_line":"        path \u003d os.path.join(CONF.vmware.serial_log_dir, fname)"},{"line_number":272,"context_line":"        if not os.path.exists(path):"},{"line_number":273,"context_line":"            return b\"\""},{"line_number":274,"context_line":"        with open(path, \u0027rb\u0027) as fp:"},{"line_number":275,"context_line":"            read_log_data, remaining \u003d nova.privsep.path.last_bytes("}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_31b8400f","line":272,"in_reply_to":"3f4b6375_792ea88c","updated":"2017-11-06 10:03:55.000000000","message":"If VSPC is running and configured properly, the file should exist. I will add a warning message.","commit_id":"da64284055505c269b802372c9f418355a30943c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0bbfcc032e9a4ee0fb0a5cd8a6df797a5b0d16cb","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def get_console_output(self, context, instance):"},{"line_number":267,"context_line":"        if not CONF.vmware.serial_log_dir:"},{"line_number":268,"context_line":"            LOG.error(\"The \u0027serial_log_dir\u0027 config option is not set!\")"},{"line_number":269,"context_line":"            return"},{"line_number":270,"context_line":"        fname \u003d instance.uuid.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":271,"context_line":"        path \u003d os.path.join(CONF.vmware.serial_log_dir, fname)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff82abbf_3236bc05","line":268,"range":{"start_line":268,"start_character":68,"end_line":268,"end_character":69},"updated":"2017-11-21 08:47:38.000000000","message":"nit: not sure an exclamation mark is needed but meh.","commit_id":"d9c03b1ecbc79021cbd597e45a29b84587db0a67"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0bbfcc032e9a4ee0fb0a5cd8a6df797a5b0d16cb","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    def get_console_output(self, context, instance):"},{"line_number":267,"context_line":"        if not CONF.vmware.serial_log_dir:"},{"line_number":268,"context_line":"            LOG.error(\"The \u0027serial_log_dir\u0027 config option is not set!\")"},{"line_number":269,"context_line":"            return"},{"line_number":270,"context_line":"        fname \u003d instance.uuid.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":271,"context_line":"        path \u003d os.path.join(CONF.vmware.serial_log_dir, fname)"},{"line_number":272,"context_line":"        if not os.path.exists(path):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff82abbf_920d4840","line":269,"updated":"2017-11-21 08:47:38.000000000","message":"that could get a long number of ERROR logs if the operator doesn\u0027t provide the conf opt, but okay.","commit_id":"d9c03b1ecbc79021cbd597e45a29b84587db0a67"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0bbfcc032e9a4ee0fb0a5cd8a6df797a5b0d16cb","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        if not CONF.vmware.serial_log_dir:"},{"line_number":268,"context_line":"            LOG.error(\"The \u0027serial_log_dir\u0027 config option is not set!\")"},{"line_number":269,"context_line":"            return"},{"line_number":270,"context_line":"        fname \u003d instance.uuid.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":271,"context_line":"        path \u003d os.path.join(CONF.vmware.serial_log_dir, fname)"},{"line_number":272,"context_line":"        if not os.path.exists(path):"},{"line_number":273,"context_line":"            LOG.warning(\u0027The console log is missing. Check your VSPC \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff82abbf_adab4dd4","line":270,"updated":"2017-11-21 08:47:38.000000000","message":"well, I don\u0027t like to see a string modification for a UUID given UUIDs are having a RFC4122 format https://tools.ietf.org/html/rfc4122.html\n\nbut given it\u0027s only for logging, okay.","commit_id":"d9c03b1ecbc79021cbd597e45a29b84587db0a67"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"436aa29f4396103fbbf308a5af52e2d3b2887cd2","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        if not CONF.vmware.serial_log_dir:"},{"line_number":268,"context_line":"            LOG.error(\"The \u0027serial_log_dir\u0027 config option is not set!\")"},{"line_number":269,"context_line":"            return"},{"line_number":270,"context_line":"        fname \u003d instance.uuid.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":271,"context_line":"        path \u003d os.path.join(CONF.vmware.serial_log_dir, fname)"},{"line_number":272,"context_line":"        if not os.path.exists(path):"},{"line_number":273,"context_line":"            LOG.warning(\u0027The console log is missing. Check your VSPC \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff82abbf_2dd89d51","line":270,"in_reply_to":"ff82abbf_adab4dd4","updated":"2017-11-21 08:48:43.000000000","message":"I mean, it\u0027s more a VSPC problem if they modify the UUID string","commit_id":"d9c03b1ecbc79021cbd597e45a29b84587db0a67"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0bbfcc032e9a4ee0fb0a5cd8a6df797a5b0d16cb","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        if not os.path.exists(path):"},{"line_number":273,"context_line":"            LOG.warning(\u0027The console log is missing. Check your VSPC \u0027"},{"line_number":274,"context_line":"                        \u0027configuration\u0027, instance\u003dinstance)"},{"line_number":275,"context_line":"            return b\"\""},{"line_number":276,"context_line":"        with open(path, \u0027rb\u0027) as fp:"},{"line_number":277,"context_line":"            read_log_data, remaining \u003d nova.privsep.path.last_bytes("},{"line_number":278,"context_line":"                fp, MAX_CONSOLE_BYTES)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff82abbf_adc26d84","line":275,"range":{"start_line":275,"start_character":19,"end_line":275,"end_character":22},"updated":"2017-11-21 08:47:38.000000000","message":"huh. You know the six library can help you, right?\nhttps://pythonhosted.org/six/#six.b\n\n  [sbauza@sbauza nova]$ python3\n  Python 3.6.2 (default, Aug 11 2017, 11:59:59) \n  [GCC 7.1.1 20170622 (Red Hat 7.1.1-3)] on linux\n  Type \"help\", \"copyright\", \"credits\" or \"license\" for more \n  information.\n  \u003e\u003e\u003e type(b\u0027\u0027)\n  \u003cclass \u0027bytes\u0027\u003e\n  \u003e\u003e\u003e \n  [sbauza@sbauza nova]$ python\n  Python 2.7.13 (default, Jun 26 2017, 10:20:05) \n  [GCC 7.1.1 20170622 (Red Hat 7.1.1-3)] on linux2\n  Type \"help\", \"copyright\", \"credits\" or \"license\" for more \n  information.\n  \u003e\u003e\u003e type(b\u0027\u0027)\n  \u003ctype \u0027str\u0027\u003e","commit_id":"d9c03b1ecbc79021cbd597e45a29b84587db0a67"}],"releasenotes/notes/vmware-console-log-384fbb9a6aa095ad.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5150a7775d34242ec038d4912538e7f2703b047","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    VMware serial console log is completed. VSPC must be deployed along with"},{"line_number":5,"context_line":"    nova-compute and configured properly. The \u0027serial_log_dir\u0027 config option"},{"line_number":6,"context_line":"    must have the same value in both nova.conf and vspc.conf."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f485f77_c374ad38","line":4,"range":{"start_line":4,"start_character":44,"end_line":4,"end_character":48},"updated":"2017-11-16 15:04:19.000000000","message":"We should link to this https://github.com/openstack/vmware-vspc\n\nSo do something like:\n\n  `VSPC`_ must be deployed..\n\n  .. _VSPC: https://github.com/openstack/vmware-vspc","commit_id":"257ec2b75f6c4709479c42d672e8698157ab118d"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"5dd55d5bbcbdb60d42a2a91afe034f679c1c0c0d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    VMware serial console log is completed. VSPC must be deployed along with"},{"line_number":5,"context_line":"    nova-compute and configured properly. The \u0027serial_log_dir\u0027 config option"},{"line_number":6,"context_line":"    must have the same value in both nova.conf and vspc.conf."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f485f77_6402830c","line":4,"range":{"start_line":4,"start_character":44,"end_line":4,"end_character":48},"in_reply_to":"1f485f77_c374ad38","updated":"2017-11-17 14:08:05.000000000","message":"Done","commit_id":"257ec2b75f6c4709479c42d672e8698157ab118d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5150a7775d34242ec038d4912538e7f2703b047","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    VMware serial console log is completed. VSPC must be deployed along with"},{"line_number":5,"context_line":"    nova-compute and configured properly. The \u0027serial_log_dir\u0027 config option"},{"line_number":6,"context_line":"    must have the same value in both nova.conf and vspc.conf."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f485f77_e3c9e958","line":5,"range":{"start_line":5,"start_character":46,"end_line":5,"end_character":63},"updated":"2017-11-16 15:04:19.000000000","message":"``[vmware]/serial_log_dir``","commit_id":"257ec2b75f6c4709479c42d672e8698157ab118d"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"5dd55d5bbcbdb60d42a2a91afe034f679c1c0c0d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    VMware serial console log is completed. VSPC must be deployed along with"},{"line_number":5,"context_line":"    nova-compute and configured properly. The \u0027serial_log_dir\u0027 config option"},{"line_number":6,"context_line":"    must have the same value in both nova.conf and vspc.conf."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f485f77_44054710","line":5,"range":{"start_line":5,"start_character":46,"end_line":5,"end_character":63},"in_reply_to":"1f485f77_e3c9e958","updated":"2017-11-17 14:08:05.000000000","message":"Done","commit_id":"257ec2b75f6c4709479c42d672e8698157ab118d"}]}