)]}'
{"nova/policies/admin_password.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ff82ae512e301aefce4e5f846edc7a253afdc2ff","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \"Show or clear the encrypted administrative password of a server\","},{"line_number":33,"context_line":"        ["},{"line_number":34,"context_line":"            {"},{"line_number":35,"context_line":"                \u0027path\u0027: \u0027/servers/server_id/os-server-password\u0027,"},{"line_number":36,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":37,"context_line":"            },"},{"line_number":38,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_7280f2f5","line":35,"range":{"start_line":35,"start_character":34,"end_line":35,"end_character":43},"updated":"2017-03-29 12:07:10.000000000","message":"It should be \u0027{server_id}\u0027","commit_id":"04309ba9cef5c3c75c1cef2d833bdc880a6fc2a1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ff82ae512e301aefce4e5f846edc7a253afdc2ff","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \"Show or clear the encrypted administrative password of a server\","},{"line_number":33,"context_line":"        ["},{"line_number":34,"context_line":"            {"},{"line_number":35,"context_line":"                \u0027path\u0027: \u0027/servers/server_id/os-server-password\u0027,"},{"line_number":36,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":37,"context_line":"            },"},{"line_number":38,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_12c3e658","line":35,"range":{"start_line":35,"start_character":44,"end_line":35,"end_character":62},"updated":"2017-03-29 12:07:10.000000000","message":"this shoud be \u0027os-admin-password\u0027","commit_id":"04309ba9cef5c3c75c1cef2d833bdc880a6fc2a1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ff82ae512e301aefce4e5f846edc7a253afdc2ff","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":37,"context_line":"            },"},{"line_number":38,"context_line":"            {"},{"line_number":39,"context_line":"                \u0027path\u0027: \u0027/servers/server_id/os-server-password\u0027,"},{"line_number":40,"context_line":"                \u0027method\u0027: \u0027DELETE\u0027"},{"line_number":41,"context_line":"            }"},{"line_number":42,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_7297d249","line":39,"range":{"start_line":39,"start_character":44,"end_line":39,"end_character":62},"updated":"2017-03-29 12:07:10.000000000","message":"ditto","commit_id":"04309ba9cef5c3c75c1cef2d833bdc880a6fc2a1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"bb62c91deeb6484d34e21ea18d4b0a5f8bc41503","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":37,"context_line":"            },"},{"line_number":38,"context_line":"            {"},{"line_number":39,"context_line":"                \u0027path\u0027: \u0027/servers/server_id/os-admin-password\u0027,"},{"line_number":40,"context_line":"                \u0027method\u0027: \u0027DELETE\u0027"},{"line_number":41,"context_line":"            }"},{"line_number":42,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_c2058216","line":39,"range":{"start_line":39,"start_character":34,"end_line":39,"end_character":43},"updated":"2017-03-30 08:40:33.000000000","message":"This should be \u0027{server_id}\u0027 also. :)","commit_id":"8094c410d7f9616ec59f4b12f619aea227ad8afe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3a2852f38394e8d342250155679bafcfcccf401c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    base.create_rule_default("},{"line_number":30,"context_line":"        BASE_POLICY_NAME,"},{"line_number":31,"context_line":"        base.RULE_ADMIN_OR_OWNER,"},{"line_number":32,"context_line":"        \"Show or clear the encrypted administrative password of a server\","},{"line_number":33,"context_line":"        ["},{"line_number":34,"context_line":"            {"},{"line_number":35,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/os-admin-password\u0027,"},{"line_number":36,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":37,"context_line":"            },"},{"line_number":38,"context_line":"            {"},{"line_number":39,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/os-admin-password\u0027,"},{"line_number":40,"context_line":"                \u0027method\u0027: \u0027DELETE\u0027"},{"line_number":41,"context_line":"            }"},{"line_number":42,"context_line":"        ]"},{"line_number":43,"context_line":"    ),"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_0b3dc52b","line":42,"range":{"start_line":32,"start_character":0,"end_line":42,"end_character":8},"updated":"2017-03-30 09:46:55.000000000","message":"This policy is for changePassword action-\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/admin_password.py#L44\n\nI think we mixed \u0027os-server-password\u0027 one here","commit_id":"e10f18b64a87338800f50f3e4ab31cc65afa0f18"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"84cdecce48c305ea2106f23b6533c2db6aa61b63","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    base.create_rule_default("},{"line_number":30,"context_line":"        BASE_POLICY_NAME,"},{"line_number":31,"context_line":"        base.RULE_ADMIN_OR_OWNER,"},{"line_number":32,"context_line":"        \"Show or clear the encrypted administrative password of a server\","},{"line_number":33,"context_line":"        ["},{"line_number":34,"context_line":"            {"},{"line_number":35,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/os-admin-password\u0027,"},{"line_number":36,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":37,"context_line":"            },"},{"line_number":38,"context_line":"            {"},{"line_number":39,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/os-admin-password\u0027,"},{"line_number":40,"context_line":"                \u0027method\u0027: \u0027DELETE\u0027"},{"line_number":41,"context_line":"            }"},{"line_number":42,"context_line":"        ]"},{"line_number":43,"context_line":"    ),"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_8b61d514","line":42,"range":{"start_line":32,"start_character":0,"end_line":42,"end_character":8},"in_reply_to":"ffe62b97_0b3dc52b","updated":"2017-03-30 09:52:50.000000000","message":"Good point, this has little to do with encryption actually.\n\nhttps://developer.openstack.org/api-ref/compute/?expanded\u003dchange-administrative-password-changepassword-action-detail#change-administrative-password-changepassword-action\n\nThe URL is bad I think, its actually:\n\nPOST /servers/{server_id}/action (changePassword)\n\nIt is not this one:\nhttps://developer.openstack.org/api-ref/compute/#servers-password-servers-os-server-password","commit_id":"e10f18b64a87338800f50f3e4ab31cc65afa0f18"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"486a105aa911fd107542797bbc89e62f069d76b8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    base.create_rule_default("},{"line_number":30,"context_line":"        BASE_POLICY_NAME,"},{"line_number":31,"context_line":"        base.RULE_ADMIN_OR_OWNER,"},{"line_number":32,"context_line":"        \"Show or clear the encrypted administrative password of a server\","},{"line_number":33,"context_line":"        ["},{"line_number":34,"context_line":"            {"},{"line_number":35,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/os-admin-password\u0027,"},{"line_number":36,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":37,"context_line":"            },"},{"line_number":38,"context_line":"            {"},{"line_number":39,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/os-admin-password\u0027,"},{"line_number":40,"context_line":"                \u0027method\u0027: \u0027DELETE\u0027"},{"line_number":41,"context_line":"            }"},{"line_number":42,"context_line":"        ]"},{"line_number":43,"context_line":"    ),"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_f60de835","line":42,"range":{"start_line":32,"start_character":0,"end_line":42,"end_character":8},"in_reply_to":"ffe62b97_8b61d514","updated":"2017-03-30 09:56:38.000000000","message":"Good catch @Gmann","commit_id":"e10f18b64a87338800f50f3e4ab31cc65afa0f18"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"335954b871cfa6d1073d55c62efc66ab5645dfa2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    base.create_rule_default("},{"line_number":30,"context_line":"        BASE_POLICY_NAME,"},{"line_number":31,"context_line":"        base.RULE_ADMIN_OR_OWNER,"},{"line_number":32,"context_line":"        \"Show or clear the encrypted administrative password of a server\","},{"line_number":33,"context_line":"        ["},{"line_number":34,"context_line":"            {"},{"line_number":35,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/os-admin-password\u0027,"},{"line_number":36,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":37,"context_line":"            },"},{"line_number":38,"context_line":"            {"},{"line_number":39,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/os-admin-password\u0027,"},{"line_number":40,"context_line":"                \u0027method\u0027: \u0027DELETE\u0027"},{"line_number":41,"context_line":"            }"},{"line_number":42,"context_line":"        ]"},{"line_number":43,"context_line":"    ),"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_cf30fb0a","line":42,"range":{"start_line":32,"start_character":0,"end_line":42,"end_character":8},"in_reply_to":"ffe62b97_f60de835","updated":"2017-03-31 03:16:00.000000000","message":"Done","commit_id":"e10f18b64a87338800f50f3e4ab31cc65afa0f18"}]}