)]}'
{"nova/policies/hypervisors.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eef80a2863fb2e24fa284c47d97789d7aa9cac3f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \"\"\"Policy rule for hypervisor related APIs."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        This rule will be checked for the following APIs:"},{"line_number":35,"context_line":"        list all hypervisors, show details for hypervisors,"},{"line_number":36,"context_line":"        show summary statistics for all hypervisors over all"},{"line_number":37,"context_line":"        compute nodes, show details for a hypervisor, show"},{"line_number":38,"context_line":"        the uptime of a hypervisor, search hypervisor by"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_6f30e49f","line":35,"range":{"start_line":35,"start_character":30,"end_line":35,"end_character":58},"updated":"2017-03-30 06:15:57.000000000","message":"this seems duplicate of \u0027show details for a hypervisor\u0027 on reading hard to figure out just \u0027s\u0027 diff. how about list all hypervisors details","commit_id":"e434aed3823ad329e7bfc0de8d3791f59ca1a7e7"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"86b2bca696267f83d66f41af2d0af04d0239e536","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        show summary statistics for all hypervisors over all"},{"line_number":37,"context_line":"        compute nodes, show details for a hypervisor, show"},{"line_number":38,"context_line":"        the uptime of a hypervisor, search hypervisor by"},{"line_number":39,"context_line":"        id and list all servers on a hypervisor."},{"line_number":40,"context_line":"        \"\"\","},{"line_number":41,"context_line":"        ["},{"line_number":42,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_eafbc275","line":39,"range":{"start_line":39,"start_character":35,"end_line":39,"end_character":48},"updated":"2017-03-30 07:01:01.000000000","message":"It isn\u0027t \u0027a hypervisor\u0027 also, based on the hypervisor_hostname patter, it may be multiple hypervisors.","commit_id":"c14358bffc8cfcebb744928400332e234a92b1b2"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"86b2bca696267f83d66f41af2d0af04d0239e536","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        show summary statistics for all hypervisors over all"},{"line_number":37,"context_line":"        compute nodes, show details for a hypervisor, show"},{"line_number":38,"context_line":"        the uptime of a hypervisor, search hypervisor by"},{"line_number":39,"context_line":"        id and list all servers on a hypervisor."},{"line_number":40,"context_line":"        \"\"\","},{"line_number":41,"context_line":"        ["},{"line_number":42,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_8ad31601","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":10},"updated":"2017-03-30 07:01:01.000000000","message":"It isn\u0027t by id, it is by matching hypervisor_hostname pattern","commit_id":"c14358bffc8cfcebb744928400332e234a92b1b2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"805798c799f3741c2a133534160172fb60522e28","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":32,"context_line":"        \"\"\"Policy rule for hypervisor related APIs."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        This rule will be checked for the following APIs:"},{"line_number":35,"context_line":"        list all hypervisors, list all hypervisors with details,"},{"line_number":36,"context_line":"        show summary statistics for all hypervisors over all"},{"line_number":37,"context_line":"        compute nodes, show details for a hypervisor, show"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_96121cb4","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":8},"updated":"2017-03-30 10:10:51.000000000","message":"This all looks very strange in the policy file to me:\nhttp://docs-draft.openstack.org/94/451294/3/check/gate-nova-docs-ubuntu-xenial/65ec334//doc/build/html/sample_policy.html","commit_id":"0a391c9c6db233a34acf3962ae057cd6ec7bf065"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"66942a5752fa1537fa375f974ea60af24e389ed2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":32,"context_line":"        \"\"\"Policy rule for hypervisor related APIs."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        This rule will be checked for the following APIs:"},{"line_number":35,"context_line":"        list all hypervisors, list all hypervisors with details,"},{"line_number":36,"context_line":"        show summary statistics for all hypervisors over all"},{"line_number":37,"context_line":"        compute nodes, show details for a hypervisor, show"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_b203e00d","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":8},"in_reply_to":"ffe62b97_96121cb4","updated":"2017-03-31 03:27:31.000000000","message":"Done","commit_id":"0a391c9c6db233a34acf3962ae057cd6ec7bf065"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ec5203a0e2fe65efcad7ff5001b61206aa4e4ec5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":32,"context_line":"        \"\"\"Policy rule for hypervisor related APIs."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        This rule will be checked for the following APIs:"},{"line_number":35,"context_line":"        list all hypervisors, list all hypervisors with details,"},{"line_number":36,"context_line":"        show summary statistics for all hypervisors over all"},{"line_number":37,"context_line":"        compute nodes, show details for a hypervisor, show"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_d6742401","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":8},"in_reply_to":"ffe62b97_96121cb4","updated":"2017-03-30 10:12:33.000000000","message":"I would go for just removing this initial space here.","commit_id":"0a391c9c6db233a34acf3962ae057cd6ec7bf065"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"66942a5752fa1537fa375f974ea60af24e389ed2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":32,"context_line":"        \"\"\"Policy rule for hypervisor related APIs."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        This rule will be checked for the following APIs:"},{"line_number":35,"context_line":"        list all hypervisors, list all hypervisors with details,"},{"line_number":36,"context_line":"        show summary statistics for all hypervisors over all"},{"line_number":37,"context_line":"        compute nodes, show details for a hypervisor, show"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_d2fe6404","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":8},"in_reply_to":"ffe62b97_d6742401","updated":"2017-03-31 03:27:31.000000000","message":"Done","commit_id":"0a391c9c6db233a34acf3962ae057cd6ec7bf065"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ec5203a0e2fe65efcad7ff5001b61206aa4e4ec5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        hypervisor_hostname pattern and list all servers on"},{"line_number":40,"context_line":"        hypervisors that can match the provided hypervisor_hostname"},{"line_number":41,"context_line":"        pattern."},{"line_number":42,"context_line":"        \"\"\","},{"line_number":43,"context_line":"        ["},{"line_number":44,"context_line":"            {"},{"line_number":45,"context_line":"                \u0027path\u0027: \u0027/os-hypervisors\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_565a5483","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":8},"updated":"2017-03-30 10:12:33.000000000","message":"I would remove the empty line here, its inconsistent with the other descriptions.","commit_id":"0a391c9c6db233a34acf3962ae057cd6ec7bf065"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"66942a5752fa1537fa375f974ea60af24e389ed2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        hypervisor_hostname pattern and list all servers on"},{"line_number":40,"context_line":"        hypervisors that can match the provided hypervisor_hostname"},{"line_number":41,"context_line":"        pattern."},{"line_number":42,"context_line":"        \"\"\","},{"line_number":43,"context_line":"        ["},{"line_number":44,"context_line":"            {"},{"line_number":45,"context_line":"                \u0027path\u0027: \u0027/os-hypervisors\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_cf191b89","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":8},"in_reply_to":"ffe62b97_565a5483","updated":"2017-03-31 03:27:31.000000000","message":"Done","commit_id":"0a391c9c6db233a34acf3962ae057cd6ec7bf065"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ec5203a0e2fe65efcad7ff5001b61206aa4e4ec5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":55,"context_line":"            },"},{"line_number":56,"context_line":"            {"},{"line_number":57,"context_line":"                \u0027path\u0027: \u0027/os-hypervisors/{hypervisor_id}\u0027,"},{"line_number":58,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":59,"context_line":"            },"},{"line_number":60,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_96c57c0d","line":57,"range":{"start_line":57,"start_character":42,"end_line":57,"end_character":55},"updated":"2017-03-30 10:12:33.000000000","message":"I am fairly sure that isn\u0027t the id (yet).","commit_id":"0a391c9c6db233a34acf3962ae057cd6ec7bf065"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9202d29e03a351877a267d91a5ed498477c92261","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":55,"context_line":"            },"},{"line_number":56,"context_line":"            {"},{"line_number":57,"context_line":"                \u0027path\u0027: \u0027/os-hypervisors/{hypervisor_id}\u0027,"},{"line_number":58,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":59,"context_line":"            },"},{"line_number":60,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_42dfa40c","line":57,"range":{"start_line":57,"start_character":42,"end_line":57,"end_character":55},"in_reply_to":"ffe62b97_96c57c0d","updated":"2017-04-10 09:45:39.000000000","message":"A look at the docs [1] suggests it is\n\n[1] https://github.com/openstack/nova/blob/master/api-ref/source/os-hypervisors.inc","commit_id":"0a391c9c6db233a34acf3962ae057cd6ec7bf065"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1b6ec1e5736363a6b81558e9734592d80cf899ca","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"This rule will be checked for the following APIs:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"List all hypervisors, list all hypervisors with details, show summary"},{"line_number":37,"context_line":"statistics for all hypervisors over all compute nodes, show details for"},{"line_number":38,"context_line":"a hypervisor, show the uptime of a hypervisor, search hypervisor by"},{"line_number":39,"context_line":"hypervisor_hostname pattern and list all servers on hypervisors that"},{"line_number":40,"context_line":"can match the provided hypervisor_hostname pattern.\"\"\","},{"line_number":41,"context_line":"        ["},{"line_number":42,"context_line":"            {"},{"line_number":43,"context_line":"                \u0027path\u0027: \u0027/os-hypervisors\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_d8eb5110","line":40,"range":{"start_line":36,"start_character":0,"end_line":40,"end_character":55},"updated":"2017-04-12 09:42:41.000000000","message":"looks like badly indented due to long lines:\n\n\n# List all hypervisors, list all hypervisors with details, show\n# summary\n# statistics for all hypervisors over all compute nodes, show details\n# for\n# a hypervisor, show the uptime of a hypervisor, search hypervisor by\n# hypervisor_hostname pattern and list all servers on hypervisors that\n# can match the provided hypervisor_hostname pattern.\n\nhttp://docs-draft.openstack.org/94/451294/5/check/gate-nova-docs-ubuntu-xenial/1e73883//doc/build/html/sample_policy.html","commit_id":"71432460d335aa51aec40aeeb7873d911b5e4e69"}]}