)]}'
{"doc/source/code-review.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2a99eacd43ca0cc6f1d88a871c997ff683b92f87","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"A release note is required on changes that have upgrade impact, security"},{"line_number":251,"context_line":"impact, introduce a new feature, fix Critical bugs, or fix long-standing bugs"},{"line_number":252,"context_line":"with high importance. The :doc:`releasenotes` details how to create a release"},{"line_number":253,"context_line":"note, each available section and the type of content required in more detail."}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfeb2761_8d4980d1","line":252,"range":{"start_line":252,"start_character":22,"end_line":252,"end_character":54},"updated":"2017-04-03 22:02:04.000000000","message":"nit: The Release Notes doc details....","commit_id":"b050573409d835a360027679326af8eef5bf5936"}],"doc/source/releasenotes.rst":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8bbf684af3645550094515900aa337cb59a33d2e","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. _releasenotes:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Release Notes"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"What is reno ?"},{"line_number":7,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_172dc894","line":4,"updated":"2017-03-31 15:12:19.000000000","message":"Having looked at the code-review page, the goal of it is to tell code reviewers what to look out for when reviewing patches (when a reno is needed, requirements when notifications are involved) and so I think at least you need to add this heading back (copy it) back to code-review with a sentence explaining when a reno is needed and linking to this page for more information. Maybe something like, \"A release note is needed on changes that have upgrade impact, security impact, introduce a new feature, fix Critical bugs, or fix long-standing bugs with high importance.\" (summarized from the big list)","commit_id":"c94a45aefc11aa20cac0a28aa0da2fcd4662a402"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"37907b5845c1acb3e48186c767742079759ee293","unresolved":false,"context_lines":[{"line_number":14,"context_line":"A *reno file* is a YAML file written in the releasenotes/notes tree which is"},{"line_number":15,"context_line":"generated using the reno tool this way:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":".. code-block:: bash"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  $ tox -e venv -- reno new \u003cname-your-file\u003e"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"where usually ``\u003cname-your-file\u003e`` can be ``bp-\u003cblueprint_name\u003e`` for a"},{"line_number":22,"context_line":"blueprint or ``bug-XXXXXX`` for a bugfix."}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_db667852","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":44},"updated":"2017-03-31 09:24:51.000000000","message":"nit: Personally, I think this is bad advice. Your life will be so much easier if you just install reno.\n\n $ pip install reno","commit_id":"c94a45aefc11aa20cac0a28aa0da2fcd4662a402"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"37907b5845c1acb3e48186c767742079759ee293","unresolved":false,"context_lines":[{"line_number":33,"context_line":"of the note file entirely. If no section is needed, then you know you don\u0027t"},{"line_number":34,"context_line":"need to provide a release note :-)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* ``upgrade``"},{"line_number":37,"context_line":"    * The patch has an `UpgradeImpact \u003chttp://docs.openstack.org/infra/manual/developers.html#peer-review\u003e`_ tag"},{"line_number":38,"context_line":"    * A DB change needs some deployer modification (like a migration)"},{"line_number":39,"context_line":"    * A configuration option change (deprecation, removal or modified default)"},{"line_number":40,"context_line":"    * some specific changes that have a `DocImpact \u003chttp://docs.openstack.org/infra/manual/developers.html#peer-review\u003e`_ tag"},{"line_number":41,"context_line":"      but require further action from an deployer perspective"},{"line_number":42,"context_line":"    * any patch that requires an action from the deployer in general"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* ``security``"},{"line_number":45,"context_line":"    * If the patch fixes a known vulnerability"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* ``features``"},{"line_number":48,"context_line":"    * If the patch has an `APIImpact \u003chttp://docs.openstack.org/infra/manual/developers.html#peer-review\u003e`_ tag"},{"line_number":49,"context_line":"    * For nova-manage and python-novaclient changes, if it adds or changes a"},{"line_number":50,"context_line":"      new command, including adding new options to existing commands"},{"line_number":51,"context_line":"    * not all blueprints in general, just the ones impacting a `contractual API \u003chttp://docs.openstack.org/developer/nova/policies.html#public-contractual-apis\u003e`_"},{"line_number":52,"context_line":"    * a new virt driver is provided or an existing driver impacts the `HypervisorSupportMatrix \u003chttp://docs.openstack.org/developer/nova/support-matrix.html\u003e`_"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* ``critical``"},{"line_number":55,"context_line":"    * Bugfixes categorized as Critical in Launchpad *impacting users*"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* ``fixes``"},{"line_number":58,"context_line":"    * No clear definition of such bugfixes. Hairy long-standing bugs with high"},{"line_number":59,"context_line":"      importance that have been fixed are good candidates though."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Three sections are left intentionally unexplained (``prelude``, ``issues`` and"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_bb8294c7","line":59,"range":{"start_line":36,"start_character":0,"end_line":59,"end_character":65},"updated":"2017-03-31 09:24:51.000000000","message":"not related to this change, but this would make more sense as a definition list. Future work item? :)","commit_id":"c94a45aefc11aa20cac0a28aa0da2fcd4662a402"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8bbf684af3645550094515900aa337cb59a33d2e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"exactly what you are doing."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Notifications"},{"line_number":69,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":70,"context_line":"* Every new notification type shall use the new versioned notification"},{"line_number":71,"context_line":"  infrastructure documented in :doc:`notifications`"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_cc4a337f","line":71,"range":{"start_line":68,"start_character":0,"end_line":71,"end_character":51},"updated":"2017-03-31 15:12:19.000000000","message":"I think this part needed to stay where it was in code-review","commit_id":"c94a45aefc11aa20cac0a28aa0da2fcd4662a402"}]}