)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"56f8171206ac0be181fad6ae974e007744bd5d51","unresolved":false,"context_lines":[{"line_number":9,"context_line":"api sample tests for security group rules are missing and so"},{"line_number":10,"context_line":"their sample files."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit adds those which will be used ti fill the api-ref"},{"line_number":13,"context_line":"for this API."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I01c68d14ecdfd853b839b527c559c7aac675f336"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfeb2761_43272414","line":12,"range":{"start_line":12,"start_character":42,"end_line":12,"end_character":44},"updated":"2017-03-31 06:36:54.000000000","message":"to?","commit_id":"f5c24410dc83e8d48e2ca7e8b8e90e7f8ec11cb4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0053fcb1c0f8def9c3f6b595313c37fbecdf243c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"api sample tests for security group rules are missing and so"},{"line_number":10,"context_line":"their sample files."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit adds those which will be used ti fill the api-ref"},{"line_number":13,"context_line":"for this API."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I01c68d14ecdfd853b839b527c559c7aac675f336"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfeb2761_d2dde042","line":12,"range":{"start_line":12,"start_character":42,"end_line":12,"end_character":44},"in_reply_to":"dfeb2761_43272414","updated":"2017-04-04 07:28:00.000000000","message":"done.","commit_id":"f5c24410dc83e8d48e2ca7e8b8e90e7f8ec11cb4"}],"doc/api_samples/os-security-group-rules/security-group-rules-create-req.json":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"624cefa3fbf258fd52ffa6cf206efeea46625e02","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"security_group_rule\": {"},{"line_number":3,"context_line":"        \"parent_group_id\": \"11111111-1111-1111-1111-111111111111\","},{"line_number":4,"context_line":"        \"group_id\": \"11111111-1111-1111-1111-111111111111\","},{"line_number":5,"context_line":"        \"ip_protocol\": \"TCP\","},{"line_number":6,"context_line":"        \"from_port\": \"80\","},{"line_number":7,"context_line":"        \"to_port\": \"80\","}],"source_content_type":"application/json","patch_set":3,"id":"7ffa3b31_0b7eb06a","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":59},"updated":"2017-04-17 17:28:19.000000000","message":"I don\u0027t think it is a good sample as the same id of this group and the parent.","commit_id":"ac82dedc0f2d12d002c2631186366a7d6bcda16d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"835cc1508fd4973e12d1df3802456b0643f59906","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"security_group_rule\": {"},{"line_number":3,"context_line":"        \"parent_group_id\": \"11111111-1111-1111-1111-111111111111\","},{"line_number":4,"context_line":"        \"group_id\": \"11111111-1111-1111-1111-111111111111\","},{"line_number":5,"context_line":"        \"ip_protocol\": \"TCP\","},{"line_number":6,"context_line":"        \"from_port\": \"80\","},{"line_number":7,"context_line":"        \"to_port\": \"80\","}],"source_content_type":"application/json","patch_set":3,"id":"7ffa3b31_4b56ed5e","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":59},"in_reply_to":"7ffa3b31_0b7eb06a","updated":"2017-04-18 02:53:57.000000000","message":"ll change, thanks.","commit_id":"ac82dedc0f2d12d002c2631186366a7d6bcda16d"}],"nova/tests/functional/api_sample_tests/test_security_group_rules.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"56f8171206ac0be181fad6ae974e007744bd5d51","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    nova_group[\u0027id\u0027] \u003d UUID"},{"line_number":25,"context_line":"    nova_group[\u0027description\u0027] \u003d \u0027default\u0027"},{"line_number":26,"context_line":"    nova_group[\u0027name\u0027] \u003d \u0027default\u0027"},{"line_number":27,"context_line":"    nova_group[\u0027project_id\u0027] \u003d UUID "},{"line_number":28,"context_line":"    nova_group[\u0027rules\u0027] \u003d []"},{"line_number":29,"context_line":"    return nova_group"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_8382ccc7","line":27,"range":{"start_line":27,"start_character":35,"end_line":27,"end_character":36},"updated":"2017-03-31 06:36:54.000000000","message":"typo","commit_id":"f5c24410dc83e8d48e2ca7e8b8e90e7f8ec11cb4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0053fcb1c0f8def9c3f6b595313c37fbecdf243c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    nova_group[\u0027id\u0027] \u003d UUID"},{"line_number":25,"context_line":"    nova_group[\u0027description\u0027] \u003d \u0027default\u0027"},{"line_number":26,"context_line":"    nova_group[\u0027name\u0027] \u003d \u0027default\u0027"},{"line_number":27,"context_line":"    nova_group[\u0027project_id\u0027] \u003d UUID "},{"line_number":28,"context_line":"    nova_group[\u0027rules\u0027] \u003d []"},{"line_number":29,"context_line":"    return nova_group"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_12d4681f","line":27,"range":{"start_line":27,"start_character":35,"end_line":27,"end_character":36},"in_reply_to":"dfeb2761_8382ccc7","updated":"2017-04-04 07:28:00.000000000","message":"thanks, done","commit_id":"f5c24410dc83e8d48e2ca7e8b8e90e7f8ec11cb4"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"49dbb45d568a68d58a2a2d707574466ea3300fa5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.neutron \u003d fixtures.NeutronFixture(self)"},{"line_number":58,"context_line":"        self.useFixture(self.neutron)"},{"line_number":59,"context_line":"        super(SecurityGroupRulesSampleJsonTest, self).setUp()"},{"line_number":60,"context_line":"        path \u003d \u0027nova.network.security_group.neutron_driver.SecurityGroupAPI.\u0027"},{"line_number":61,"context_line":"        self.stub_out(path + \u0027get\u0027, fake_get)"},{"line_number":62,"context_line":"        self.stub_out(path + \u0027add_rules\u0027,"},{"line_number":63,"context_line":"                      fake_add_rules)"},{"line_number":64,"context_line":"        self.stub_out(path + \u0027get_rule\u0027,"},{"line_number":65,"context_line":"                      fake_get_rule)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_security_group_rules_create(self):"},{"line_number":68,"context_line":"        subs \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_db49ec60","line":65,"range":{"start_line":60,"start_character":8,"end_line":65,"end_character":36},"updated":"2017-04-14 05:03:45.000000000","message":"Should we put those into the NeutronFixture, and mock by the neutron_client?","commit_id":"ac82dedc0f2d12d002c2631186366a7d6bcda16d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"835cc1508fd4973e12d1df3802456b0643f59906","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.neutron \u003d fixtures.NeutronFixture(self)"},{"line_number":58,"context_line":"        self.useFixture(self.neutron)"},{"line_number":59,"context_line":"        super(SecurityGroupRulesSampleJsonTest, self).setUp()"},{"line_number":60,"context_line":"        path \u003d \u0027nova.network.security_group.neutron_driver.SecurityGroupAPI.\u0027"},{"line_number":61,"context_line":"        self.stub_out(path + \u0027get\u0027, fake_get)"},{"line_number":62,"context_line":"        self.stub_out(path + \u0027add_rules\u0027,"},{"line_number":63,"context_line":"                      fake_add_rules)"},{"line_number":64,"context_line":"        self.stub_out(path + \u0027get_rule\u0027,"},{"line_number":65,"context_line":"                      fake_get_rule)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_security_group_rules_create(self):"},{"line_number":68,"context_line":"        subs \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_eb71390e","line":65,"range":{"start_line":60,"start_character":8,"end_line":65,"end_character":36},"in_reply_to":"7ffa3b31_9534484c","updated":"2017-04-18 02:53:57.000000000","message":"yea, we can avoid each stub of them. ll move them in fixture.","commit_id":"ac82dedc0f2d12d002c2631186366a7d6bcda16d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0d9ab52b6dc68b3da25f6cd8875b38dc8f2f3cec","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.neutron \u003d fixtures.NeutronFixture(self)"},{"line_number":58,"context_line":"        self.useFixture(self.neutron)"},{"line_number":59,"context_line":"        super(SecurityGroupRulesSampleJsonTest, self).setUp()"},{"line_number":60,"context_line":"        path \u003d \u0027nova.network.security_group.neutron_driver.SecurityGroupAPI.\u0027"},{"line_number":61,"context_line":"        self.stub_out(path + \u0027get\u0027, fake_get)"},{"line_number":62,"context_line":"        self.stub_out(path + \u0027add_rules\u0027,"},{"line_number":63,"context_line":"                      fake_add_rules)"},{"line_number":64,"context_line":"        self.stub_out(path + \u0027get_rule\u0027,"},{"line_number":65,"context_line":"                      fake_get_rule)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_security_group_rules_create(self):"},{"line_number":68,"context_line":"        subs \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_9534484c","line":65,"range":{"start_line":60,"start_character":8,"end_line":65,"end_character":36},"in_reply_to":"7ffa3b31_db49ec60","updated":"2017-04-14 14:00:36.000000000","message":"That\u0027s probably not a bad idea. The NeutronFixture today is I think mostly geared toward the things used in nova/network/neutronv2/api.py like networks, subnets and ports, but it could also contain things neutron security groups and rules (which should actually also probably live in nova/network/neutronv2/api.py but that\u0027s a much bigger terrible change).","commit_id":"ac82dedc0f2d12d002c2631186366a7d6bcda16d"}]}