)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"fcf173ee644976ed4151315f0f7e891ee6ef0c2b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[placement] Add api-ref for PUT RP inventories"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This provides simple documentation of the response body and query"},{"line_number":10,"context_line":"parameters when updating resource provider inventories."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I720f5b6792b9f4ced905aef31715a835b07be504"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfeb2761_41847c0c","line":10,"updated":"2017-04-03 12:01:31.000000000","message":"paremeters when setting or replacing all inventories for a resource provider","commit_id":"8bf95ed1cd8a5aed9a99df9e3bcf7d37eb0ddb55"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"231d7bb5514d2b3fc6d39dfba76d6de66d730671","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[placement] Add api-ref for PUT RP inventories"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This provides simple documentation of the response body and query"},{"line_number":10,"context_line":"parameters when updating resource provider inventories."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I720f5b6792b9f4ced905aef31715a835b07be504"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfeb2761_9612a308","line":10,"in_reply_to":"dfeb2761_41847c0c","updated":"2017-04-04 11:01:05.000000000","message":"Done","commit_id":"8bf95ed1cd8a5aed9a99df9e3bcf7d37eb0ddb55"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"6b3b931a460f226b5ca7cecb6c86efc820f091c5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[placement] Add api-ref for PUT RP inventories"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This provides simple documentation of the response body and query"},{"line_number":10,"context_line":"parameters when setting or replacing all inventories for a resource provider."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I720f5b6792b9f4ced905aef31715a835b07be504"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5ff73747_05cdbbb5","line":9,"updated":"2017-05-02 10:22:54.000000000","message":"response and request bodies\n\nalso there are not query parameters on this method, are there?","commit_id":"8aa0d9c6aaf15ca990b653690ac97ed66286a920"}],"placement-api-ref/source/inventories.inc":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"fcf173ee644976ed4151315f0f7e891ee6ef0c2b","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Set all inventories for the resource provider identified by `{resource_provider_uuid}`."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. rest_method:: PUT /resource_providers/{resource_provider_uuid}/inventories"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Normal Response Codes: 200"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"dfeb2761_e178302c","line":101,"updated":"2017-04-03 12:01:31.000000000","message":"Unless we kill the test tool or change the code this needs to be {uuid}","commit_id":"8bf95ed1cd8a5aed9a99df9e3bcf7d37eb0ddb55"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"231d7bb5514d2b3fc6d39dfba76d6de66d730671","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Set all inventories for the resource provider identified by `{resource_provider_uuid}`."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. rest_method:: PUT /resource_providers/{resource_provider_uuid}/inventories"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Normal Response Codes: 200"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"dfeb2761_16fe93ad","line":101,"in_reply_to":"dfeb2761_e178302c","updated":"2017-04-04 11:01:05.000000000","message":"Done","commit_id":"8bf95ed1cd8a5aed9a99df9e3bcf7d37eb0ddb55"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"8d64b42fe6889024222572a5f298482cd5b81805","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Normal Response Codes: 200"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Error response codes: badRequest(400), itemNotFound(404), conflict(409)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Request"},{"line_number":57,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"bff0334d_a21c8c6a","line":54,"updated":"2017-04-06 13:10:27.000000000","message":"We don\u0027t provide a lot of information with the resource_provider_generation parameter, so I wonder if it might be useful to include some more prose here which describes how it is used in this request?\n\nThat needs to be somewhere in the docs, but I suppose we don\u0027t want to repeat it everywhere. Perhaps there\u0027s a way to have a generation.inc that we can include wherever it makes sense?","commit_id":"9152fff682465af59577393295ca553d94c08d9c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"0fee0fcfc526b1776ba323518540f3e8ed66023e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"Update resource provider inventories"},{"line_number":46,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Set all inventories for the resource provider identified by `{uuid}`."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. rest_method:: PUT /resource_providers/{uuid}/inventories"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"7ffa3b31_e08b2c1c","line":48,"updated":"2017-04-20 18:30:46.000000000","message":"s/Set all inventories/Replaces the set of inventory records/","commit_id":"58be31864520471be9ec10fd09b894b2a2c6cdd7"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"6b3b931a460f226b5ca7cecb6c86efc820f091c5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Update resource provider inventories"},{"line_number":47,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Replaces the set of inventory records for the resource provider identified by `{uuid}`."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. rest_method:: PUT /resource_providers/{uuid}/inventories"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"5ff73747_2558b7f7","line":49,"updated":"2017-05-02 10:22:54.000000000","message":"You could capture the \"replace or create\" aspect of this by instead saying:\n\n\"Set the inventory records for the resource...\"","commit_id":"8aa0d9c6aaf15ca990b653690ac97ed66286a920"}],"placement-api-ref/source/parameters.yaml":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"0fee0fcfc526b1776ba323518540f3e8ed66023e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Overall limit is equal to 128 vCPUs."},{"line_number":53,"context_line":"allocation_ratio_opt:"},{"line_number":54,"context_line":"  \u003c\u003c: *allocation_ratio"},{"line_number":55,"context_line":"  required: false"},{"line_number":56,"context_line":"inventories:"},{"line_number":57,"context_line":"  type: object"},{"line_number":58,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7ffa3b31_a081a4fd","line":55,"updated":"2017-04-20 18:30:46.000000000","message":"Am I missing something here? why not just put required: false under the allocation_ratio block instead of defining a separate variable for allocation_ratio_opt?","commit_id":"58be31864520471be9ec10fd09b894b2a2c6cdd7"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"d9d076e9394cb89b55e445bf941bc7d5a01fa8d5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Overall limit is equal to 128 vCPUs."},{"line_number":53,"context_line":"allocation_ratio_opt:"},{"line_number":54,"context_line":"  \u003c\u003c: *allocation_ratio"},{"line_number":55,"context_line":"  required: false"},{"line_number":56,"context_line":"inventories:"},{"line_number":57,"context_line":"  type: object"},{"line_number":58,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5ff73747_2f33f663","line":55,"in_reply_to":"7ffa3b31_a081a4fd","updated":"2017-05-02 09:24:47.000000000","message":"allocation_ratio is for response where that parameter is required. allocation_ratio_opt is for request where we can skip it. The same logic for other params.","commit_id":"58be31864520471be9ec10fd09b894b2a2c6cdd7"}],"placement-api-ref/source/update-inventories-request.json":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"0fee0fcfc526b1776ba323518540f3e8ed66023e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"reserved\": 10,"},{"line_number":7,"context_line":"            \"total\": 40"},{"line_number":8,"context_line":"        },"},{"line_number":9,"context_line":"        \"PCI_DEVICE\": {"},{"line_number":10,"context_line":"            \"allocation_ratio\": 1.0,"},{"line_number":11,"context_line":"            \"max_unit\": 30,"},{"line_number":12,"context_line":"            \"step_size\": 5,"}],"source_content_type":"application/json","patch_set":3,"id":"7ffa3b31_c090304d","line":9,"updated":"2017-04-20 18:30:46.000000000","message":"I partly agree with Sylvain, but for different reasons :) Can we make the examples reflective of reality here? I don\u0027t mind using PCI_DEVICE, but the total, step_size and max_unit amounts don\u0027t make any sense from a real-world perspective.\n\nHow about just add VCPU and MEMORY_MB blocks with real-world settings for step_size and max/min_unit?","commit_id":"58be31864520471be9ec10fd09b894b2a2c6cdd7"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"d9d076e9394cb89b55e445bf941bc7d5a01fa8d5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"reserved\": 10,"},{"line_number":7,"context_line":"            \"total\": 40"},{"line_number":8,"context_line":"        },"},{"line_number":9,"context_line":"        \"PCI_DEVICE\": {"},{"line_number":10,"context_line":"            \"allocation_ratio\": 1.0,"},{"line_number":11,"context_line":"            \"max_unit\": 30,"},{"line_number":12,"context_line":"            \"step_size\": 5,"}],"source_content_type":"application/json","patch_set":3,"id":"5ff73747_ef6e2e2d","line":9,"in_reply_to":"7ffa3b31_c090304d","updated":"2017-05-02 09:24:47.000000000","message":"Yes, replaced with vcpu and memory example trying to show all options behavior (with request/response).","commit_id":"58be31864520471be9ec10fd09b894b2a2c6cdd7"}],"placement-api-ref/source/update-inventories.json":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"71548284128878269f8a2f7828569b293a303234","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            \"step_size\": 1,"},{"line_number":9,"context_line":"            \"total\": 40"},{"line_number":10,"context_line":"        },"},{"line_number":11,"context_line":"        \"PCI_DEVICE\": {"},{"line_number":12,"context_line":"            \"allocation_ratio\": 1.0,"},{"line_number":13,"context_line":"            \"max_unit\": 30,"},{"line_number":14,"context_line":"            \"min_unit\": 0,"}],"source_content_type":"application/json","patch_set":3,"id":"7ffa3b31_8cb1e5e4","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":19},"updated":"2017-04-14 10:34:50.000000000","message":"nova RT doesn\u0027t provide this resource class yet, so I think we shouldn\u0027t provide it in our API docs yet (or it would confuse operators IMHO) even if it\u0027s in the standard RCs list.","commit_id":"58be31864520471be9ec10fd09b894b2a2c6cdd7"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"fa71f0352ab19b1a9f7dfa5da7f3ad10f0617e31","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            \"step_size\": 1,"},{"line_number":9,"context_line":"            \"total\": 40"},{"line_number":10,"context_line":"        },"},{"line_number":11,"context_line":"        \"PCI_DEVICE\": {"},{"line_number":12,"context_line":"            \"allocation_ratio\": 1.0,"},{"line_number":13,"context_line":"            \"max_unit\": 30,"},{"line_number":14,"context_line":"            \"min_unit\": 0,"}],"source_content_type":"application/json","patch_set":3,"id":"7ffa3b31_cdb3dc97","line":11,"in_reply_to":"7ffa3b31_8cb1e5e4","updated":"2017-04-20 10:39:34.000000000","message":"These are the placement api docs, and placement supports this resource class, so I\u0027m not sure I see what the issue is?","commit_id":"58be31864520471be9ec10fd09b894b2a2c6cdd7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"023909a853a44917c35d8fc7fa92c0350c388219","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            \"step_size\": 1,"},{"line_number":9,"context_line":"            \"total\": 40"},{"line_number":10,"context_line":"        },"},{"line_number":11,"context_line":"        \"PCI_DEVICE\": {"},{"line_number":12,"context_line":"            \"allocation_ratio\": 1.0,"},{"line_number":13,"context_line":"            \"max_unit\": 30,"},{"line_number":14,"context_line":"            \"min_unit\": 0,"}],"source_content_type":"application/json","patch_set":3,"id":"7ffa3b31_cf48662e","line":11,"in_reply_to":"7ffa3b31_cdb3dc97","updated":"2017-04-20 15:37:49.000000000","message":"The issue is that operators and developers don\u0027t really know if or why placement is different from Nova, they just look at docs to know how it works. And if they see things like that, they can just think that nova compute nodes provide that already.\n\nAnyway, it\u0027s just a quick modification, why should we discuss a lot whether it\u0027s good or not ? Just s/PCI_DEVICE/MEMORY_GB or whatever supported and I\u0027m +2.","commit_id":"58be31864520471be9ec10fd09b894b2a2c6cdd7"}]}