)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"886144595fff7024e5ad64a553334c47450caee2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the instance related notifications and refactors the sample file of"},{"line_number":11,"context_line":"instance.delete.start and instance.delete.end."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The common sample fragments defines an active instance as that is the"},{"line_number":14,"context_line":"most use common state in the instance action notifications. This way"},{"line_number":15,"context_line":"we can minimize the difference betweent the common sample and the"},{"line_number":16,"context_line":"generated notificaton. Still there will be differences. For example"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4b6375_298e372e","line":13,"range":{"start_line":13,"start_character":34,"end_line":13,"end_character":35},"updated":"2017-10-30 20:53:11.000000000","message":"define","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"11cd67087573039a3f69ce9ac038f035143070b6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the instance related notifications and refactors the sample file of"},{"line_number":11,"context_line":"instance.delete.start and instance.delete.end."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The common sample fragments defines an active instance as that is the"},{"line_number":14,"context_line":"most use common state in the instance action notifications. This way"},{"line_number":15,"context_line":"we can minimize the difference betweent the common sample and the"},{"line_number":16,"context_line":"generated notificaton. Still there will be differences. For example"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4b6375_9898ba6a","line":13,"range":{"start_line":13,"start_character":34,"end_line":13,"end_character":35},"in_reply_to":"3f4b6375_298e372e","updated":"2017-10-31 15:44:52.000000000","message":"Done","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"886144595fff7024e5ad64a553334c47450caee2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"instance.delete.start and instance.delete.end."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The common sample fragments defines an active instance as that is the"},{"line_number":14,"context_line":"most use common state in the instance action notifications. This way"},{"line_number":15,"context_line":"we can minimize the difference betweent the common sample and the"},{"line_number":16,"context_line":"generated notificaton. Still there will be differences. For example"},{"line_number":17,"context_line":"instance.delete.end notification will contain different instance status"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4b6375_89764b3e","line":14,"range":{"start_line":14,"start_character":5,"end_line":14,"end_character":9},"updated":"2017-10-30 20:53:11.000000000","message":"s/use //","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"11cd67087573039a3f69ce9ac038f035143070b6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"instance.delete.start and instance.delete.end."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The common sample fragments defines an active instance as that is the"},{"line_number":14,"context_line":"most use common state in the instance action notifications. This way"},{"line_number":15,"context_line":"we can minimize the difference betweent the common sample and the"},{"line_number":16,"context_line":"generated notificaton. Still there will be differences. For example"},{"line_number":17,"context_line":"instance.delete.end notification will contain different instance status"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4b6375_389d4657","line":14,"range":{"start_line":14,"start_character":5,"end_line":14,"end_character":9},"in_reply_to":"3f4b6375_89764b3e","updated":"2017-10-31 15:44:52.000000000","message":"Done","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"886144595fff7024e5ad64a553334c47450caee2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The common sample fragments defines an active instance as that is the"},{"line_number":14,"context_line":"most use common state in the instance action notifications. This way"},{"line_number":15,"context_line":"we can minimize the difference betweent the common sample and the"},{"line_number":16,"context_line":"generated notificaton. Still there will be differences. For example"},{"line_number":17,"context_line":"instance.delete.end notification will contain different instance status"},{"line_number":18,"context_line":"and some other deletion related fields are also set. To make sure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4b6375_69730f4f","line":15,"range":{"start_line":15,"start_character":31,"end_line":15,"end_character":39},"updated":"2017-10-30 20:53:11.000000000","message":"between","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"11cd67087573039a3f69ce9ac038f035143070b6","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The common sample fragments defines an active instance as that is the"},{"line_number":14,"context_line":"most use common state in the instance action notifications. This way"},{"line_number":15,"context_line":"we can minimize the difference betweent the common sample and the"},{"line_number":16,"context_line":"generated notificaton. Still there will be differences. For example"},{"line_number":17,"context_line":"instance.delete.end notification will contain different instance status"},{"line_number":18,"context_line":"and some other deletion related fields are also set. To make sure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4b6375_d8b752d8","line":15,"range":{"start_line":15,"start_character":31,"end_line":15,"end_character":39},"in_reply_to":"3f4b6375_69730f4f","updated":"2017-10-31 15:44:52.000000000","message":"Done","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"886144595fff7024e5ad64a553334c47450caee2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The common sample fragments defines an active instance as that is the"},{"line_number":14,"context_line":"most use common state in the instance action notifications. This way"},{"line_number":15,"context_line":"we can minimize the difference betweent the common sample and the"},{"line_number":16,"context_line":"generated notificaton. Still there will be differences. For example"},{"line_number":17,"context_line":"instance.delete.end notification will contain different instance status"},{"line_number":18,"context_line":"and some other deletion related fields are also set. To make sure"},{"line_number":19,"context_line":"the the sample matches with the generated notification we have to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4b6375_2993d751","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":21},"updated":"2017-10-30 20:53:11.000000000","message":"notification","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"11cd67087573039a3f69ce9ac038f035143070b6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The common sample fragments defines an active instance as that is the"},{"line_number":14,"context_line":"most use common state in the instance action notifications. This way"},{"line_number":15,"context_line":"we can minimize the difference betweent the common sample and the"},{"line_number":16,"context_line":"generated notificaton. Still there will be differences. For example"},{"line_number":17,"context_line":"instance.delete.end notification will contain different instance status"},{"line_number":18,"context_line":"and some other deletion related fields are also set. To make sure"},{"line_number":19,"context_line":"the the sample matches with the generated notification we have to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4b6375_58cb6252","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":21},"in_reply_to":"3f4b6375_2993d751","updated":"2017-10-31 15:44:52.000000000","message":"Done","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"886144595fff7024e5ad64a553334c47450caee2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"instance.delete.end notification will contain different instance status"},{"line_number":18,"context_line":"and some other deletion related fields are also set. To make sure"},{"line_number":19,"context_line":"the the sample matches with the generated notification we have to"},{"line_number":20,"context_line":"override some of the fields coming from the common sample frament."},{"line_number":21,"context_line":"Such override could be added in the test case directly to the"},{"line_number":22,"context_line":"_verify_notification() call as it is done in case of dynamic values"},{"line_number":23,"context_line":"like instance uuid. However the sample files not only used in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4b6375_e99c9f5e","line":20,"range":{"start_line":20,"start_character":58,"end_line":20,"end_character":65},"updated":"2017-10-30 20:53:11.000000000","message":"fragment","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"11cd67087573039a3f69ce9ac038f035143070b6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"instance.delete.end notification will contain different instance status"},{"line_number":18,"context_line":"and some other deletion related fields are also set. To make sure"},{"line_number":19,"context_line":"the the sample matches with the generated notification we have to"},{"line_number":20,"context_line":"override some of the fields coming from the common sample frament."},{"line_number":21,"context_line":"Such override could be added in the test case directly to the"},{"line_number":22,"context_line":"_verify_notification() call as it is done in case of dynamic values"},{"line_number":23,"context_line":"like instance uuid. However the sample files not only used in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4b6375_38c6664b","line":20,"range":{"start_line":20,"start_character":58,"end_line":20,"end_character":65},"in_reply_to":"3f4b6375_e99c9f5e","updated":"2017-10-31 15:44:52.000000000","message":"Done","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"886144595fff7024e5ad64a553334c47450caee2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"and some other deletion related fields are also set. To make sure"},{"line_number":19,"context_line":"the the sample matches with the generated notification we have to"},{"line_number":20,"context_line":"override some of the fields coming from the common sample frament."},{"line_number":21,"context_line":"Such override could be added in the test case directly to the"},{"line_number":22,"context_line":"_verify_notification() call as it is done in case of dynamic values"},{"line_number":23,"context_line":"like instance uuid. However the sample files not only used in the"},{"line_number":24,"context_line":"functional tests but also during the generation of teh notification"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4b6375_49b733da","line":21,"range":{"start_line":21,"start_character":5,"end_line":21,"end_character":13},"updated":"2017-10-30 20:53:11.000000000","message":"overrides","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"11cd67087573039a3f69ce9ac038f035143070b6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"and some other deletion related fields are also set. To make sure"},{"line_number":19,"context_line":"the the sample matches with the generated notification we have to"},{"line_number":20,"context_line":"override some of the fields coming from the common sample frament."},{"line_number":21,"context_line":"Such override could be added in the test case directly to the"},{"line_number":22,"context_line":"_verify_notification() call as it is done in case of dynamic values"},{"line_number":23,"context_line":"like instance uuid. However the sample files not only used in the"},{"line_number":24,"context_line":"functional tests but also during the generation of teh notification"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4b6375_b8dff60a","line":21,"range":{"start_line":21,"start_character":5,"end_line":21,"end_character":13},"in_reply_to":"3f4b6375_49b733da","updated":"2017-10-31 15:44:52.000000000","message":"Done","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"886144595fff7024e5ad64a553334c47450caee2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Such override could be added in the test case directly to the"},{"line_number":22,"context_line":"_verify_notification() call as it is done in case of dynamic values"},{"line_number":23,"context_line":"like instance uuid. However the sample files not only used in the"},{"line_number":24,"context_line":"functional tests but also during the generation of teh notification"},{"line_number":25,"context_line":"dev-ref. To have meaningful samples in the doc we have to do such"},{"line_number":26,"context_line":"overrides during the reference resolving and not directly in the"},{"line_number":27,"context_line":"test case."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4b6375_c9cfa355","line":24,"range":{"start_line":24,"start_character":51,"end_line":24,"end_character":54},"updated":"2017-10-30 20:53:11.000000000","message":"the","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"11cd67087573039a3f69ce9ac038f035143070b6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Such override could be added in the test case directly to the"},{"line_number":22,"context_line":"_verify_notification() call as it is done in case of dynamic values"},{"line_number":23,"context_line":"like instance uuid. However the sample files not only used in the"},{"line_number":24,"context_line":"functional tests but also during the generation of teh notification"},{"line_number":25,"context_line":"dev-ref. To have meaningful samples in the doc we have to do such"},{"line_number":26,"context_line":"overrides during the reference resolving and not directly in the"},{"line_number":27,"context_line":"test case."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4b6375_d805127c","line":24,"range":{"start_line":24,"start_character":51,"end_line":24,"end_character":54},"in_reply_to":"3f4b6375_c9cfa355","updated":"2017-10-31 15:44:52.000000000","message":"Sorry for not reading back what I write before the push. :)\nDone.","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12083e1fce82d6d208bb50efe847603a2bce10b0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"override some of the fields coming from the common sample fragment."},{"line_number":21,"context_line":"Such overrides could be added in the test case directly to the"},{"line_number":22,"context_line":"_verify_notification() call as it is done in case of dynamic values"},{"line_number":23,"context_line":"like instance uuid. However the sample files not only used in the"},{"line_number":24,"context_line":"functional tests but also during the generation of the notification"},{"line_number":25,"context_line":"dev-ref. To have meaningful samples in the doc we have to do such"},{"line_number":26,"context_line":"overrides during the reference resolving and not directly in the"},{"line_number":27,"context_line":"test case."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I0669a075c94ba2a435116791e3391d8d745bc639"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1f485f77_6d1e8d0d","line":27,"range":{"start_line":23,"start_character":20,"end_line":27,"end_character":10},"updated":"2017-11-11 00:36:22.000000000","message":"Totally agree with this.","commit_id":"4b783a206c912221b4c522ab29b54c94f189e7ec"}],"doc/notification_samples/common_payloads/FlavorPayload.json":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12083e1fce82d6d208bb50efe847603a2bce10b0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        \"is_public\": true,"},{"line_number":18,"context_line":"        \"vcpu_weight\": 0"},{"line_number":19,"context_line":"    },"},{"line_number":20,"context_line":"    \"nova_object.version\": \"1.3\","},{"line_number":21,"context_line":"    \"nova_object.namespace\": \"nova\""},{"line_number":22,"context_line":"}"}],"source_content_type":"application/json","patch_set":17,"id":"1f485f77_0d2ef942","line":20,"updated":"2017-11-11 00:36:22.000000000","message":"blurg I could approve this and then rebase my series... :)","commit_id":"4b783a206c912221b4c522ab29b54c94f189e7ec"}],"doc/notification_samples/instance-delete-end.json":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"886144595fff7024e5ad64a553334c47450caee2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"event_type\":\"instance.delete.end\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"$ref\":\"payloads/InstanceActionPayload.json#\","},{"line_number":5,"context_line":"        \"nova_object.data\":{"},{"line_number":6,"context_line":"            \"deleted_at\":\"2012-10-29T13:42:11Z\","},{"line_number":7,"context_line":"            \"ip_addresses\":[],"},{"line_number":8,"context_line":"            \"power_state\":\"pending\","},{"line_number":9,"context_line":"            \"state\":\"deleted\","},{"line_number":10,"context_line":"            \"terminated_at\":\"2012-10-29T13:42:11Z\""},{"line_number":11,"context_line":"        }"},{"line_number":12,"context_line":"    },"},{"line_number":13,"context_line":"    \"priority\":\"INFO\","}],"source_content_type":"application/json","patch_set":13,"id":"3f4b6375_a93a2731","line":10,"range":{"start_line":5,"start_character":28,"end_line":10,"end_character":50},"updated":"2017-10-30 20:53:11.000000000","message":"Yeah, I really like this. Basically, the only thing left in the sample file are the overrides, which makes it much, much clearer which are the attributes of the payload that are affected/changed by this particular notification type.","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"}],"doc/notification_samples/payloads/InstanceActionPayload.json":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a9b8db33740c119b498a728a419a0c06b13edc5d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"nova_object.data\":{"},{"line_number":3,"context_line":"        \"architecture\":\"x86_64\","},{"line_number":4,"context_line":"        \"availability_zone\": \"nova\","},{"line_number":5,"context_line":"        \"block_devices\": ["},{"line_number":6,"context_line":"            {\"$ref\": \"BlockDevicePayload.json#\"}"},{"line_number":7,"context_line":"        ],"},{"line_number":8,"context_line":"        \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":9,"context_line":"        \"deleted_at\":null,"},{"line_number":10,"context_line":"        \"display_name\":\"some-server\","},{"line_number":11,"context_line":"        \"display_description\":\"some-server\","},{"line_number":12,"context_line":"        \"fault\":null,"},{"line_number":13,"context_line":"        \"host\":\"compute\","},{"line_number":14,"context_line":"        \"host_name\":\"some-server\","},{"line_number":15,"context_line":"        \"ip_addresses\": ["},{"line_number":16,"context_line":"            {\"$ref\": \"IpPayload.json#\"}"},{"line_number":17,"context_line":"        ],"},{"line_number":18,"context_line":"        \"kernel_id\":\"\","},{"line_number":19,"context_line":"        \"key_name\": \"my-key\","},{"line_number":20,"context_line":"        \"launched_at\":\"2012-10-29T13:42:11Z\","},{"line_number":21,"context_line":"        \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":22,"context_line":"        \"metadata\":{},"},{"line_number":23,"context_line":"        \"locked\":false,"},{"line_number":24,"context_line":"        \"node\":\"fake-mini\","},{"line_number":25,"context_line":"        \"os_type\":null,"},{"line_number":26,"context_line":"        \"progress\":0,"},{"line_number":27,"context_line":"        \"ramdisk_id\":\"\","},{"line_number":28,"context_line":"        \"reservation_id\":\"r-npxv0e40\","},{"line_number":29,"context_line":"        \"state\":\"active\","},{"line_number":30,"context_line":"        \"task_state\":null,"},{"line_number":31,"context_line":"        \"power_state\":\"running\","},{"line_number":32,"context_line":"        \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":33,"context_line":"        \"terminated_at\":null,"},{"line_number":34,"context_line":"        \"auto_disk_config\":\"MANUAL\","},{"line_number":35,"context_line":"        \"flavor\": {\"$ref\": \"FlavorPayload.json#\"},"},{"line_number":36,"context_line":"        \"updated_at\": \"2012-10-29T13:42:11Z\","},{"line_number":37,"context_line":"        \"user_id\":\"fake\","},{"line_number":38,"context_line":"        \"uuid\":\"178b0921-8f85-4257-88b6-2e743b5a975c\""},{"line_number":39,"context_line":"    },"},{"line_number":40,"context_line":"    \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":41,"context_line":"    \"nova_object.namespace\":\"nova\","},{"line_number":42,"context_line":"    \"nova_object.version\":\"1.5\""},{"line_number":43,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_b9deced7","line":43,"range":{"start_line":1,"start_character":0,"end_line":43,"end_character":1},"updated":"2017-11-01 02:39:09.000000000","message":"how about keeping this with some name like \u0027common_payload\u0027 ?\n\nreason for that is if in future we have to push more common sample data of different notification sample or different file, then it will be more clear and easy to refer the more than 2 common data from single file.\n\nAlso it will be very clear about what ref is this for.\n\ncommon_payload \u003d {\n    \"nova_object.data\":{\n.....","commit_id":"e45939e2a254c7e16b558996948e491b49e5f973"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"91d45b06e29aeab2e41174ca08b5359208aba14b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"nova_object.data\":{"},{"line_number":3,"context_line":"        \"architecture\":\"x86_64\","},{"line_number":4,"context_line":"        \"availability_zone\": \"nova\","},{"line_number":5,"context_line":"        \"block_devices\": ["},{"line_number":6,"context_line":"            {\"$ref\": \"BlockDevicePayload.json#\"}"},{"line_number":7,"context_line":"        ],"},{"line_number":8,"context_line":"        \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":9,"context_line":"        \"deleted_at\":null,"},{"line_number":10,"context_line":"        \"display_name\":\"some-server\","},{"line_number":11,"context_line":"        \"display_description\":\"some-server\","},{"line_number":12,"context_line":"        \"fault\":null,"},{"line_number":13,"context_line":"        \"host\":\"compute\","},{"line_number":14,"context_line":"        \"host_name\":\"some-server\","},{"line_number":15,"context_line":"        \"ip_addresses\": ["},{"line_number":16,"context_line":"            {\"$ref\": \"IpPayload.json#\"}"},{"line_number":17,"context_line":"        ],"},{"line_number":18,"context_line":"        \"kernel_id\":\"\","},{"line_number":19,"context_line":"        \"key_name\": \"my-key\","},{"line_number":20,"context_line":"        \"launched_at\":\"2012-10-29T13:42:11Z\","},{"line_number":21,"context_line":"        \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":22,"context_line":"        \"metadata\":{},"},{"line_number":23,"context_line":"        \"locked\":false,"},{"line_number":24,"context_line":"        \"node\":\"fake-mini\","},{"line_number":25,"context_line":"        \"os_type\":null,"},{"line_number":26,"context_line":"        \"progress\":0,"},{"line_number":27,"context_line":"        \"ramdisk_id\":\"\","},{"line_number":28,"context_line":"        \"reservation_id\":\"r-npxv0e40\","},{"line_number":29,"context_line":"        \"state\":\"active\","},{"line_number":30,"context_line":"        \"task_state\":null,"},{"line_number":31,"context_line":"        \"power_state\":\"running\","},{"line_number":32,"context_line":"        \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":33,"context_line":"        \"terminated_at\":null,"},{"line_number":34,"context_line":"        \"auto_disk_config\":\"MANUAL\","},{"line_number":35,"context_line":"        \"flavor\": {\"$ref\": \"FlavorPayload.json#\"},"},{"line_number":36,"context_line":"        \"updated_at\": \"2012-10-29T13:42:11Z\","},{"line_number":37,"context_line":"        \"user_id\":\"fake\","},{"line_number":38,"context_line":"        \"uuid\":\"178b0921-8f85-4257-88b6-2e743b5a975c\""},{"line_number":39,"context_line":"    },"},{"line_number":40,"context_line":"    \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":41,"context_line":"    \"nova_object.namespace\":\"nova\","},{"line_number":42,"context_line":"    \"nova_object.version\":\"1.5\""},{"line_number":43,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_db00fe04","line":43,"range":{"start_line":1,"start_character":0,"end_line":43,"end_character":1},"in_reply_to":"3f4b6375_afa08b91","updated":"2017-11-04 04:58:42.000000000","message":"I see and agree. I think we can go with  \u0027common_payloads\u0027 path alternate so that we know what all common payload i have and can resuse.","commit_id":"e45939e2a254c7e16b558996948e491b49e5f973"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b6817fa046b2934414fa51b0e159b05229a45801","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"nova_object.data\":{"},{"line_number":3,"context_line":"        \"architecture\":\"x86_64\","},{"line_number":4,"context_line":"        \"availability_zone\": \"nova\","},{"line_number":5,"context_line":"        \"block_devices\": ["},{"line_number":6,"context_line":"            {\"$ref\": \"BlockDevicePayload.json#\"}"},{"line_number":7,"context_line":"        ],"},{"line_number":8,"context_line":"        \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":9,"context_line":"        \"deleted_at\":null,"},{"line_number":10,"context_line":"        \"display_name\":\"some-server\","},{"line_number":11,"context_line":"        \"display_description\":\"some-server\","},{"line_number":12,"context_line":"        \"fault\":null,"},{"line_number":13,"context_line":"        \"host\":\"compute\","},{"line_number":14,"context_line":"        \"host_name\":\"some-server\","},{"line_number":15,"context_line":"        \"ip_addresses\": ["},{"line_number":16,"context_line":"            {\"$ref\": \"IpPayload.json#\"}"},{"line_number":17,"context_line":"        ],"},{"line_number":18,"context_line":"        \"kernel_id\":\"\","},{"line_number":19,"context_line":"        \"key_name\": \"my-key\","},{"line_number":20,"context_line":"        \"launched_at\":\"2012-10-29T13:42:11Z\","},{"line_number":21,"context_line":"        \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":22,"context_line":"        \"metadata\":{},"},{"line_number":23,"context_line":"        \"locked\":false,"},{"line_number":24,"context_line":"        \"node\":\"fake-mini\","},{"line_number":25,"context_line":"        \"os_type\":null,"},{"line_number":26,"context_line":"        \"progress\":0,"},{"line_number":27,"context_line":"        \"ramdisk_id\":\"\","},{"line_number":28,"context_line":"        \"reservation_id\":\"r-npxv0e40\","},{"line_number":29,"context_line":"        \"state\":\"active\","},{"line_number":30,"context_line":"        \"task_state\":null,"},{"line_number":31,"context_line":"        \"power_state\":\"running\","},{"line_number":32,"context_line":"        \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":33,"context_line":"        \"terminated_at\":null,"},{"line_number":34,"context_line":"        \"auto_disk_config\":\"MANUAL\","},{"line_number":35,"context_line":"        \"flavor\": {\"$ref\": \"FlavorPayload.json#\"},"},{"line_number":36,"context_line":"        \"updated_at\": \"2012-10-29T13:42:11Z\","},{"line_number":37,"context_line":"        \"user_id\":\"fake\","},{"line_number":38,"context_line":"        \"uuid\":\"178b0921-8f85-4257-88b6-2e743b5a975c\""},{"line_number":39,"context_line":"    },"},{"line_number":40,"context_line":"    \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":41,"context_line":"    \"nova_object.namespace\":\"nova\","},{"line_number":42,"context_line":"    \"nova_object.version\":\"1.5\""},{"line_number":43,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_afa08b91","line":43,"range":{"start_line":1,"start_character":0,"end_line":43,"end_character":1},"in_reply_to":"3f4b6375_b9deced7","updated":"2017-11-02 15:23:43.000000000","message":"I would like to keep the sample fragments as pure json data files. Your suggestion would require to have some logic that creates a json fragment out of a sample file containing one or more named sample fragments. \n\nOne alternative would be to use the following pure json in this file:\n{\n   common_payload: {\"nova_object.data\": ...}\n   another_fragment: {...}\n}\nThat would require extending the jsonref implementation to allow not just file paths but json paths (after the #) in the ref to refer to a specific fragment.  Something like:\n{\"$ref\": \"payloads/InstanceActionPayload.json#common_payload\"}\n\nAnother alternative is to use one file per sample fragment. This is what I do right now. I can rename the current InstanceActionPayload.json to something like common_InstanceActionPayload.json. OR I can rename the current path \u0027payloads\u0027 to \u0027common_payloads\u0027 so that when somebody looks at the ref it will be clear that it refers to a common sample fragment. Like:\n{\"$ref\": \"common_payloads/InstanceActionPayload.json\"}\n\nWhat do you think about these alternatives?","commit_id":"e45939e2a254c7e16b558996948e491b49e5f973"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0ed5098e7413c7954e6ed8c6bdab5e37a10b92e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"nova_object.data\":{"},{"line_number":3,"context_line":"        \"architecture\":\"x86_64\","},{"line_number":4,"context_line":"        \"availability_zone\": \"nova\","},{"line_number":5,"context_line":"        \"block_devices\": ["},{"line_number":6,"context_line":"            {\"$ref\": \"BlockDevicePayload.json#\"}"},{"line_number":7,"context_line":"        ],"},{"line_number":8,"context_line":"        \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":9,"context_line":"        \"deleted_at\":null,"},{"line_number":10,"context_line":"        \"display_name\":\"some-server\","},{"line_number":11,"context_line":"        \"display_description\":\"some-server\","},{"line_number":12,"context_line":"        \"fault\":null,"},{"line_number":13,"context_line":"        \"host\":\"compute\","},{"line_number":14,"context_line":"        \"host_name\":\"some-server\","},{"line_number":15,"context_line":"        \"ip_addresses\": ["},{"line_number":16,"context_line":"            {\"$ref\": \"IpPayload.json#\"}"},{"line_number":17,"context_line":"        ],"},{"line_number":18,"context_line":"        \"kernel_id\":\"\","},{"line_number":19,"context_line":"        \"key_name\": \"my-key\","},{"line_number":20,"context_line":"        \"launched_at\":\"2012-10-29T13:42:11Z\","},{"line_number":21,"context_line":"        \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":22,"context_line":"        \"metadata\":{},"},{"line_number":23,"context_line":"        \"locked\":false,"},{"line_number":24,"context_line":"        \"node\":\"fake-mini\","},{"line_number":25,"context_line":"        \"os_type\":null,"},{"line_number":26,"context_line":"        \"progress\":0,"},{"line_number":27,"context_line":"        \"ramdisk_id\":\"\","},{"line_number":28,"context_line":"        \"reservation_id\":\"r-npxv0e40\","},{"line_number":29,"context_line":"        \"state\":\"active\","},{"line_number":30,"context_line":"        \"task_state\":null,"},{"line_number":31,"context_line":"        \"power_state\":\"running\","},{"line_number":32,"context_line":"        \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":33,"context_line":"        \"terminated_at\":null,"},{"line_number":34,"context_line":"        \"auto_disk_config\":\"MANUAL\","},{"line_number":35,"context_line":"        \"flavor\": {\"$ref\": \"FlavorPayload.json#\"},"},{"line_number":36,"context_line":"        \"updated_at\": \"2012-10-29T13:42:11Z\","},{"line_number":37,"context_line":"        \"user_id\":\"fake\","},{"line_number":38,"context_line":"        \"uuid\":\"178b0921-8f85-4257-88b6-2e743b5a975c\""},{"line_number":39,"context_line":"    },"},{"line_number":40,"context_line":"    \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":41,"context_line":"    \"nova_object.namespace\":\"nova\","},{"line_number":42,"context_line":"    \"nova_object.version\":\"1.5\""},{"line_number":43,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_35014506","line":43,"range":{"start_line":1,"start_character":0,"end_line":43,"end_character":1},"in_reply_to":"3f4b6375_db00fe04","updated":"2017-11-06 15:20:02.000000000","message":"Done","commit_id":"e45939e2a254c7e16b558996948e491b49e5f973"}],"doc/notification_samples/payloads/IpPayload.json":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a9b8db33740c119b498a728a419a0c06b13edc5d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"nova_object.name\": \"IpPayload\","},{"line_number":3,"context_line":"    \"nova_object.namespace\": \"nova\","},{"line_number":4,"context_line":"    \"nova_object.version\": \"1.0\","},{"line_number":5,"context_line":"    \"nova_object.data\": {"},{"line_number":6,"context_line":"        \"mac\": \"fa:16:3e:4c:2c:30\","},{"line_number":7,"context_line":"        \"address\": \"192.168.1.3\","},{"line_number":8,"context_line":"        \"port_uuid\": \"ce531f90-199f-48c0-816c-13e38010b442\","},{"line_number":9,"context_line":"        \"meta\": {},"},{"line_number":10,"context_line":"        \"version\": 4,"},{"line_number":11,"context_line":"        \"label\": \"private-network\","},{"line_number":12,"context_line":"        \"device_name\": \"tapce531f90-19\""},{"line_number":13,"context_line":"    }"},{"line_number":14,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_146927bd","line":14,"range":{"start_line":1,"start_character":0,"end_line":14,"end_character":1},"updated":"2017-11-01 02:39:09.000000000","message":"ditto like\n\ncommon_ip_payload \u003d {\n    \"nova_object.name\": \"IpPayload\",","commit_id":"e45939e2a254c7e16b558996948e491b49e5f973"}]}
