)]}'
{"doc/notification_samples/instance-pause-end.json":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"68dc6f80f83277aaa5a657c444a60fc2ee616962","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.pause.end\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"nova_object.data\":{"},{"line_number":5,"context_line":"            \"architecture\":\"x86_64\","},{"line_number":6,"context_line":"            \"availability_zone\": \"nova\","},{"line_number":7,"context_line":"            \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":8,"context_line":"            \"deleted_at\":null,"},{"line_number":9,"context_line":"            \"display_name\":\"some-server\","},{"line_number":10,"context_line":"            \"display_description\":\"some-server\","},{"line_number":11,"context_line":"            \"fault\":null,"},{"line_number":12,"context_line":"            \"host\":\"compute\","},{"line_number":13,"context_line":"            \"host_name\":\"some-server\","},{"line_number":14,"context_line":"            \"ip_addresses\": [{"},{"line_number":15,"context_line":"                \"nova_object.name\": \"IpPayload\","},{"line_number":16,"context_line":"                \"nova_object.namespace\": \"nova\","},{"line_number":17,"context_line":"                \"nova_object.version\": \"1.0\","},{"line_number":18,"context_line":"                \"nova_object.data\": {"},{"line_number":19,"context_line":"                    \"mac\": \"fa:16:3e:4c:2c:30\","},{"line_number":20,"context_line":"                    \"address\": \"192.168.1.3\","},{"line_number":21,"context_line":"                    \"port_uuid\": \"ce531f90-199f-48c0-816c-13e38010b442\","},{"line_number":22,"context_line":"                    \"meta\": {},"},{"line_number":23,"context_line":"                    \"version\": 4,"},{"line_number":24,"context_line":"                    \"label\": \"private-network\","},{"line_number":25,"context_line":"                    \"device_name\": \"tapce531f90-19\""},{"line_number":26,"context_line":"                }"},{"line_number":27,"context_line":"            }],"},{"line_number":28,"context_line":"            \"kernel_id\":\"\","},{"line_number":29,"context_line":"            \"launched_at\":\"2012-10-29T13:42:11Z\","},{"line_number":30,"context_line":"            \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":31,"context_line":"            \"metadata\":{},"},{"line_number":32,"context_line":"            \"locked\":false,"},{"line_number":33,"context_line":"            \"node\":\"fake-mini\","},{"line_number":34,"context_line":"            \"os_type\":null,"},{"line_number":35,"context_line":"            \"progress\":0,"},{"line_number":36,"context_line":"            \"ramdisk_id\":\"\","},{"line_number":37,"context_line":"            \"reservation_id\":\"r-npxv0e40\","},{"line_number":38,"context_line":"            \"state\":\"paused\","},{"line_number":39,"context_line":"            \"task_state\":null,"},{"line_number":40,"context_line":"            \"power_state\":\"running\","},{"line_number":41,"context_line":"            \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":42,"context_line":"            \"terminated_at\":null,"},{"line_number":43,"context_line":"            \"auto_disk_config\":\"MANUAL\","},{"line_number":44,"context_line":"            \"flavor\": {"},{"line_number":45,"context_line":"                \"nova_object.name\": \"FlavorPayload\","},{"line_number":46,"context_line":"                \"nova_object.data\": {"},{"line_number":47,"context_line":"                    \"flavorid\": \"a22d5517-147c-4147-a0d1-e698df5cd4e3\","},{"line_number":48,"context_line":"                    \"name\": \"test_flavor\","},{"line_number":49,"context_line":"                    \"root_gb\": 1,"},{"line_number":50,"context_line":"                    \"vcpus\": 1,"},{"line_number":51,"context_line":"                    \"ephemeral_gb\": 0,"},{"line_number":52,"context_line":"                    \"memory_mb\": 512,"},{"line_number":53,"context_line":"                    \"disabled\": false,"},{"line_number":54,"context_line":"                    \"rxtx_factor\": 1.0,"},{"line_number":55,"context_line":"                    \"extra_specs\": {"},{"line_number":56,"context_line":"                        \"hw:watchdog_action\": \"disabled\""},{"line_number":57,"context_line":"                    },"},{"line_number":58,"context_line":"                    \"projects\": null,"},{"line_number":59,"context_line":"                    \"swap\": 0,"},{"line_number":60,"context_line":"                    \"is_public\": true,"},{"line_number":61,"context_line":"                    \"vcpu_weight\": 0"},{"line_number":62,"context_line":"                },"},{"line_number":63,"context_line":"                \"nova_object.version\": \"1.3\","},{"line_number":64,"context_line":"                \"nova_object.namespace\": \"nova\""},{"line_number":65,"context_line":"            },"},{"line_number":66,"context_line":"            \"user_id\":\"fake\","},{"line_number":67,"context_line":"            \"uuid\":\"178b0921-8f85-4257-88b6-2e743b5a975c\""},{"line_number":68,"context_line":"        },"},{"line_number":69,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":70,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":71,"context_line":"        \"nova_object.version\":\"1.2\""},{"line_number":72,"context_line":"    },"},{"line_number":73,"context_line":"    \"payload\":{\"$ref\": \"payloads/InstanceActionPayload.json#\"},"},{"line_number":74,"context_line":"    \"priority\":\"INFO\","},{"line_number":75,"context_line":"    \"publisher_id\":\"nova-compute:compute\""}],"source_content_type":"application/json","patch_set":6,"id":"1f013ff3_725d19e8","line":72,"range":{"start_line":3,"start_character":0,"end_line":72,"end_character":6},"updated":"2017-05-16 17:07:47.000000000","message":"Why isn\u0027t all of this removed? More importantly, why aren\u0027t tests failing when we have two payloads?","commit_id":"87f9f9f6892eef68cf1c0a50b7868276fea5b687"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4e2f48a72389b6b05ddd72cae48bca29b8c51ed2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.pause.end\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"nova_object.data\":{"},{"line_number":5,"context_line":"            \"architecture\":\"x86_64\","},{"line_number":6,"context_line":"            \"availability_zone\": \"nova\","},{"line_number":7,"context_line":"            \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":8,"context_line":"            \"deleted_at\":null,"},{"line_number":9,"context_line":"            \"display_name\":\"some-server\","},{"line_number":10,"context_line":"            \"display_description\":\"some-server\","},{"line_number":11,"context_line":"            \"fault\":null,"},{"line_number":12,"context_line":"            \"host\":\"compute\","},{"line_number":13,"context_line":"            \"host_name\":\"some-server\","},{"line_number":14,"context_line":"            \"ip_addresses\": [{"},{"line_number":15,"context_line":"                \"nova_object.name\": \"IpPayload\","},{"line_number":16,"context_line":"                \"nova_object.namespace\": \"nova\","},{"line_number":17,"context_line":"                \"nova_object.version\": \"1.0\","},{"line_number":18,"context_line":"                \"nova_object.data\": {"},{"line_number":19,"context_line":"                    \"mac\": \"fa:16:3e:4c:2c:30\","},{"line_number":20,"context_line":"                    \"address\": \"192.168.1.3\","},{"line_number":21,"context_line":"                    \"port_uuid\": \"ce531f90-199f-48c0-816c-13e38010b442\","},{"line_number":22,"context_line":"                    \"meta\": {},"},{"line_number":23,"context_line":"                    \"version\": 4,"},{"line_number":24,"context_line":"                    \"label\": \"private-network\","},{"line_number":25,"context_line":"                    \"device_name\": \"tapce531f90-19\""},{"line_number":26,"context_line":"                }"},{"line_number":27,"context_line":"            }],"},{"line_number":28,"context_line":"            \"kernel_id\":\"\","},{"line_number":29,"context_line":"            \"launched_at\":\"2012-10-29T13:42:11Z\","},{"line_number":30,"context_line":"            \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":31,"context_line":"            \"metadata\":{},"},{"line_number":32,"context_line":"            \"locked\":false,"},{"line_number":33,"context_line":"            \"node\":\"fake-mini\","},{"line_number":34,"context_line":"            \"os_type\":null,"},{"line_number":35,"context_line":"            \"progress\":0,"},{"line_number":36,"context_line":"            \"ramdisk_id\":\"\","},{"line_number":37,"context_line":"            \"reservation_id\":\"r-npxv0e40\","},{"line_number":38,"context_line":"            \"state\":\"paused\","},{"line_number":39,"context_line":"            \"task_state\":null,"},{"line_number":40,"context_line":"            \"power_state\":\"running\","},{"line_number":41,"context_line":"            \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":42,"context_line":"            \"terminated_at\":null,"},{"line_number":43,"context_line":"            \"auto_disk_config\":\"MANUAL\","},{"line_number":44,"context_line":"            \"flavor\": {"},{"line_number":45,"context_line":"                \"nova_object.name\": \"FlavorPayload\","},{"line_number":46,"context_line":"                \"nova_object.data\": {"},{"line_number":47,"context_line":"                    \"flavorid\": \"a22d5517-147c-4147-a0d1-e698df5cd4e3\","},{"line_number":48,"context_line":"                    \"name\": \"test_flavor\","},{"line_number":49,"context_line":"                    \"root_gb\": 1,"},{"line_number":50,"context_line":"                    \"vcpus\": 1,"},{"line_number":51,"context_line":"                    \"ephemeral_gb\": 0,"},{"line_number":52,"context_line":"                    \"memory_mb\": 512,"},{"line_number":53,"context_line":"                    \"disabled\": false,"},{"line_number":54,"context_line":"                    \"rxtx_factor\": 1.0,"},{"line_number":55,"context_line":"                    \"extra_specs\": {"},{"line_number":56,"context_line":"                        \"hw:watchdog_action\": \"disabled\""},{"line_number":57,"context_line":"                    },"},{"line_number":58,"context_line":"                    \"projects\": null,"},{"line_number":59,"context_line":"                    \"swap\": 0,"},{"line_number":60,"context_line":"                    \"is_public\": true,"},{"line_number":61,"context_line":"                    \"vcpu_weight\": 0"},{"line_number":62,"context_line":"                },"},{"line_number":63,"context_line":"                \"nova_object.version\": \"1.3\","},{"line_number":64,"context_line":"                \"nova_object.namespace\": \"nova\""},{"line_number":65,"context_line":"            },"},{"line_number":66,"context_line":"            \"user_id\":\"fake\","},{"line_number":67,"context_line":"            \"uuid\":\"178b0921-8f85-4257-88b6-2e743b5a975c\""},{"line_number":68,"context_line":"        },"},{"line_number":69,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":70,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":71,"context_line":"        \"nova_object.version\":\"1.2\""},{"line_number":72,"context_line":"    },"},{"line_number":73,"context_line":"    \"payload\":{\"$ref\": \"payloads/InstanceActionPayload.json#\"},"},{"line_number":74,"context_line":"    \"priority\":\"INFO\","},{"line_number":75,"context_line":"    \"publisher_id\":\"nova-compute:compute\""}],"source_content_type":"application/json","patch_set":6,"id":"ff0f0b1f_1304bf16","line":72,"range":{"start_line":3,"start_character":0,"end_line":72,"end_character":6},"in_reply_to":"1f013ff3_121c9510","updated":"2017-05-18 12:47:43.000000000","message":"Removed the unnecessary payload keyword. I made a suggestion to run demjson as part of https://review.openstack.org/#/c/443677/","commit_id":"87f9f9f6892eef68cf1c0a50b7868276fea5b687"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"60308714c14409a42593ee946478ab7e9333951b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.pause.end\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"nova_object.data\":{"},{"line_number":5,"context_line":"            \"architecture\":\"x86_64\","},{"line_number":6,"context_line":"            \"availability_zone\": \"nova\","},{"line_number":7,"context_line":"            \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":8,"context_line":"            \"deleted_at\":null,"},{"line_number":9,"context_line":"            \"display_name\":\"some-server\","},{"line_number":10,"context_line":"            \"display_description\":\"some-server\","},{"line_number":11,"context_line":"            \"fault\":null,"},{"line_number":12,"context_line":"            \"host\":\"compute\","},{"line_number":13,"context_line":"            \"host_name\":\"some-server\","},{"line_number":14,"context_line":"            \"ip_addresses\": [{"},{"line_number":15,"context_line":"                \"nova_object.name\": \"IpPayload\","},{"line_number":16,"context_line":"                \"nova_object.namespace\": \"nova\","},{"line_number":17,"context_line":"                \"nova_object.version\": \"1.0\","},{"line_number":18,"context_line":"                \"nova_object.data\": {"},{"line_number":19,"context_line":"                    \"mac\": \"fa:16:3e:4c:2c:30\","},{"line_number":20,"context_line":"                    \"address\": \"192.168.1.3\","},{"line_number":21,"context_line":"                    \"port_uuid\": \"ce531f90-199f-48c0-816c-13e38010b442\","},{"line_number":22,"context_line":"                    \"meta\": {},"},{"line_number":23,"context_line":"                    \"version\": 4,"},{"line_number":24,"context_line":"                    \"label\": \"private-network\","},{"line_number":25,"context_line":"                    \"device_name\": \"tapce531f90-19\""},{"line_number":26,"context_line":"                }"},{"line_number":27,"context_line":"            }],"},{"line_number":28,"context_line":"            \"kernel_id\":\"\","},{"line_number":29,"context_line":"            \"launched_at\":\"2012-10-29T13:42:11Z\","},{"line_number":30,"context_line":"            \"image_uuid\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":31,"context_line":"            \"metadata\":{},"},{"line_number":32,"context_line":"            \"locked\":false,"},{"line_number":33,"context_line":"            \"node\":\"fake-mini\","},{"line_number":34,"context_line":"            \"os_type\":null,"},{"line_number":35,"context_line":"            \"progress\":0,"},{"line_number":36,"context_line":"            \"ramdisk_id\":\"\","},{"line_number":37,"context_line":"            \"reservation_id\":\"r-npxv0e40\","},{"line_number":38,"context_line":"            \"state\":\"paused\","},{"line_number":39,"context_line":"            \"task_state\":null,"},{"line_number":40,"context_line":"            \"power_state\":\"running\","},{"line_number":41,"context_line":"            \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":42,"context_line":"            \"terminated_at\":null,"},{"line_number":43,"context_line":"            \"auto_disk_config\":\"MANUAL\","},{"line_number":44,"context_line":"            \"flavor\": {"},{"line_number":45,"context_line":"                \"nova_object.name\": \"FlavorPayload\","},{"line_number":46,"context_line":"                \"nova_object.data\": {"},{"line_number":47,"context_line":"                    \"flavorid\": \"a22d5517-147c-4147-a0d1-e698df5cd4e3\","},{"line_number":48,"context_line":"                    \"name\": \"test_flavor\","},{"line_number":49,"context_line":"                    \"root_gb\": 1,"},{"line_number":50,"context_line":"                    \"vcpus\": 1,"},{"line_number":51,"context_line":"                    \"ephemeral_gb\": 0,"},{"line_number":52,"context_line":"                    \"memory_mb\": 512,"},{"line_number":53,"context_line":"                    \"disabled\": false,"},{"line_number":54,"context_line":"                    \"rxtx_factor\": 1.0,"},{"line_number":55,"context_line":"                    \"extra_specs\": {"},{"line_number":56,"context_line":"                        \"hw:watchdog_action\": \"disabled\""},{"line_number":57,"context_line":"                    },"},{"line_number":58,"context_line":"                    \"projects\": null,"},{"line_number":59,"context_line":"                    \"swap\": 0,"},{"line_number":60,"context_line":"                    \"is_public\": true,"},{"line_number":61,"context_line":"                    \"vcpu_weight\": 0"},{"line_number":62,"context_line":"                },"},{"line_number":63,"context_line":"                \"nova_object.version\": \"1.3\","},{"line_number":64,"context_line":"                \"nova_object.namespace\": \"nova\""},{"line_number":65,"context_line":"            },"},{"line_number":66,"context_line":"            \"user_id\":\"fake\","},{"line_number":67,"context_line":"            \"uuid\":\"178b0921-8f85-4257-88b6-2e743b5a975c\""},{"line_number":68,"context_line":"        },"},{"line_number":69,"context_line":"        \"nova_object.name\":\"InstanceActionPayload\","},{"line_number":70,"context_line":"        \"nova_object.namespace\":\"nova\","},{"line_number":71,"context_line":"        \"nova_object.version\":\"1.2\""},{"line_number":72,"context_line":"    },"},{"line_number":73,"context_line":"    \"payload\":{\"$ref\": \"payloads/InstanceActionPayload.json#\"},"},{"line_number":74,"context_line":"    \"priority\":\"INFO\","},{"line_number":75,"context_line":"    \"publisher_id\":\"nova-compute:compute\""}],"source_content_type":"application/json","patch_set":6,"id":"1f013ff3_121c9510","line":72,"range":{"start_line":3,"start_character":0,"end_line":72,"end_character":6},"in_reply_to":"1f013ff3_725d19e8","updated":"2017-05-16 17:12:26.000000000","message":"Looks like we could use jsonlint from the demjson package which is already in g-r:\n\nhttps://github.com/openstack/requirements/blob/master/global-requirements.txt#L361","commit_id":"87f9f9f6892eef68cf1c0a50b7868276fea5b687"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"48d79bd73fd632e0a6bf867c95f1ab94dad1b761","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"reservation_id\":\"r-npxv0e40\","},{"line_number":51,"context_line":"            \"state\":\"paused\","},{"line_number":52,"context_line":"            \"task_state\":null,"},{"line_number":53,"context_line":"            \"power_state\":\"running\","},{"line_number":54,"context_line":"            \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":55,"context_line":"            \"terminated_at\":null,"},{"line_number":56,"context_line":"            \"auto_disk_config\":\"MANUAL\","}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_d313bbb7","side":"PARENT","line":53,"range":{"start_line":53,"start_character":27,"end_line":53,"end_character":34},"updated":"2017-10-31 11:24:35.000000000","message":"It should be \u0027paused\u0027.","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"01727f260b6fc27c8f4b4ec8f9d50ec2f7a811bf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"reservation_id\":\"r-npxv0e40\","},{"line_number":51,"context_line":"            \"state\":\"paused\","},{"line_number":52,"context_line":"            \"task_state\":null,"},{"line_number":53,"context_line":"            \"power_state\":\"running\","},{"line_number":54,"context_line":"            \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":55,"context_line":"            \"terminated_at\":null,"},{"line_number":56,"context_line":"            \"auto_disk_config\":\"MANUAL\","}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_d894f2ea","side":"PARENT","line":53,"range":{"start_line":53,"start_character":27,"end_line":53,"end_character":34},"in_reply_to":"3f4b6375_d313bbb7","updated":"2017-10-31 15:46:31.000000000","message":"I cannot simply change that in the sample, it would break the functional test. In the functional test this sample is matched against the value in the emitted notification and that value contains power_state: running. This is not a bug in nova or in the notification sending. Nova actually refreshes the power_state of the instance during pause [1] but the FakeVirt driver used in the functional test does not smart enough to properly maintain a power_state of the simulated instances [2]. Fixing this is outside of the scope of the current patch series that only want to refactor the samples. If you have time you help me fixing these kind of problems in a separate patch series. If not I can try to do that later.  \n\n[1] https://github.com/openstack/nova/blob/39e7ca322626f4b197de54e1ed83ce046c5fef26/nova/compute/manager.py#L4363\n[2] https://github.com/openstack/nova/blob/master/nova/virt/fake.py#L263","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4fbd48bcf1828ac5ebc085f6d6f25b9ca96f40fe","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"reservation_id\":\"r-npxv0e40\","},{"line_number":51,"context_line":"            \"state\":\"paused\","},{"line_number":52,"context_line":"            \"task_state\":null,"},{"line_number":53,"context_line":"            \"power_state\":\"running\","},{"line_number":54,"context_line":"            \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":55,"context_line":"            \"terminated_at\":null,"},{"line_number":56,"context_line":"            \"auto_disk_config\":\"MANUAL\","}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_e4a828da","side":"PARENT","line":53,"range":{"start_line":53,"start_character":27,"end_line":53,"end_character":34},"in_reply_to":"3f4b6375_d894f2ea","updated":"2017-10-31 17:13:29.000000000","message":"Coincidentally I\u0027m already kind of working on this:\n\nhttps://review.openstack.org/#/c/509935/","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"01a03fd0a6d03c0b81ffe596221734b652d64248","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"reservation_id\":\"r-npxv0e40\","},{"line_number":51,"context_line":"            \"state\":\"paused\","},{"line_number":52,"context_line":"            \"task_state\":null,"},{"line_number":53,"context_line":"            \"power_state\":\"running\","},{"line_number":54,"context_line":"            \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":55,"context_line":"            \"terminated_at\":null,"},{"line_number":56,"context_line":"            \"auto_disk_config\":\"MANUAL\","}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_a30f9486","side":"PARENT","line":53,"range":{"start_line":53,"start_character":27,"end_line":53,"end_character":34},"in_reply_to":"3f4b6375_d894f2ea","updated":"2017-11-02 07:49:14.000000000","message":"IMO, the sample should follow actual notifications.\nAnd replacement should be implemented in functional tests.","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"48d79bd73fd632e0a6bf867c95f1ab94dad1b761","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"$ref\": \"payloads/InstanceActionPayload.json#\","},{"line_number":5,"context_line":"        \"nova_object.data\": {"},{"line_number":6,"context_line":"            \"state\": \"paused\""},{"line_number":7,"context_line":"        }"},{"line_number":8,"context_line":"    },"},{"line_number":9,"context_line":"    \"priority\":\"INFO\","}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_5327cb13","line":6,"updated":"2017-10-31 11:24:35.000000000","message":"Add \"power_state\":\"paused\"","commit_id":"598f2db9017c3829391b1ebb6c77ca4661ef14fc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"01727f260b6fc27c8f4b4ec8f9d50ec2f7a811bf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"$ref\": \"payloads/InstanceActionPayload.json#\","},{"line_number":5,"context_line":"        \"nova_object.data\": {"},{"line_number":6,"context_line":"            \"state\": \"paused\""},{"line_number":7,"context_line":"        }"},{"line_number":8,"context_line":"    },"},{"line_number":9,"context_line":"    \"priority\":\"INFO\","}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_b864964a","line":6,"in_reply_to":"3f4b6375_5327cb13","updated":"2017-10-31 15:46:31.000000000","message":"This patch wants to refactor of the sample file. The original sample has power_state: running in it. Changing this is outside of the scope of this patch series.","commit_id":"598f2db9017c3829391b1ebb6c77ca4661ef14fc"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"01a03fd0a6d03c0b81ffe596221734b652d64248","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"$ref\": \"payloads/InstanceActionPayload.json#\","},{"line_number":5,"context_line":"        \"nova_object.data\": {"},{"line_number":6,"context_line":"            \"state\": \"paused\""},{"line_number":7,"context_line":"        }"},{"line_number":8,"context_line":"    },"},{"line_number":9,"context_line":"    \"priority\":\"INFO\","}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_836db833","line":6,"in_reply_to":"3f4b6375_b864964a","updated":"2017-11-02 07:49:14.000000000","message":"\u003e Changing this is outside of the scope of this patch series.\n\nOkay.","commit_id":"598f2db9017c3829391b1ebb6c77ca4661ef14fc"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"01a03fd0a6d03c0b81ffe596221734b652d64248","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.pause.end\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"$ref\": \"payloads/InstanceActionPayload.json#\","},{"line_number":5,"context_line":"        \"nova_object.data\": {"},{"line_number":6,"context_line":"            \"state\": \"paused\""},{"line_number":7,"context_line":"        }"}],"source_content_type":"application/json","patch_set":15,"id":"3f4b6375_a3d2f4cf","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":53},"updated":"2017-11-02 07:49:14.000000000","message":"The functional tests fail. Add \"/\" at the beginning.\n\n  /payloads/InstanceActionPayload.json#","commit_id":"33e0e4150376f769b403094a14e68936905025b4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a10e9cf0755cff919421ed9b3caafb786ccf30fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.pause.end\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"$ref\": \"payloads/InstanceActionPayload.json#\","},{"line_number":5,"context_line":"        \"nova_object.data\": {"},{"line_number":6,"context_line":"            \"state\": \"paused\""},{"line_number":7,"context_line":"        }"}],"source_content_type":"application/json","patch_set":15,"id":"3f4b6375_ef01e36b","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":53},"in_reply_to":"3f4b6375_a3d2f4cf","updated":"2017-11-02 15:26:18.000000000","message":"yeah that was a mistake I made when I changed the first patch in the series. Now I\u0027ve fixed the path building in the first patch. Therefore all the subsequent patches will work without the need of the extra leading \u0027/\u0027","commit_id":"33e0e4150376f769b403094a14e68936905025b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"98f78214a0e7e9bcfea89421723a45ed8dfb8677","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.pause.end\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"$ref\": \"payloads/InstanceActionPayload.json#\","},{"line_number":5,"context_line":"        \"nova_object.data\": {"},{"line_number":6,"context_line":"            \"state\": \"paused\""},{"line_number":7,"context_line":"        }"}],"source_content_type":"application/json","patch_set":15,"id":"3f4b6375_1610ab4d","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":53},"in_reply_to":"3f4b6375_ef01e36b","updated":"2017-11-04 05:01:18.000000000","message":"yea it works now after base patch fix. we can leave those as it is.","commit_id":"33e0e4150376f769b403094a14e68936905025b4"}],"doc/notification_samples/instance-pause-start.json":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"01a03fd0a6d03c0b81ffe596221734b652d64248","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.pause.start\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"$ref\": \"payloads/InstanceActionPayload.json#\","},{"line_number":5,"context_line":"        \"nova_object.data\": {"},{"line_number":6,"context_line":"            \"task_state\": \"pausing\""},{"line_number":7,"context_line":"        }"}],"source_content_type":"application/json","patch_set":15,"id":"3f4b6375_43e1009b","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":53},"updated":"2017-11-02 07:49:14.000000000","message":"ditto","commit_id":"33e0e4150376f769b403094a14e68936905025b4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a10e9cf0755cff919421ed9b3caafb786ccf30fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.pause.start\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"$ref\": \"payloads/InstanceActionPayload.json#\","},{"line_number":5,"context_line":"        \"nova_object.data\": {"},{"line_number":6,"context_line":"            \"task_state\": \"pausing\""},{"line_number":7,"context_line":"        }"}],"source_content_type":"application/json","patch_set":15,"id":"3f4b6375_aff76b8b","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":53},"in_reply_to":"3f4b6375_43e1009b","updated":"2017-11-02 15:26:18.000000000","message":"Done","commit_id":"33e0e4150376f769b403094a14e68936905025b4"}],"doc/notification_samples/instance-unpause-end.json":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"01a03fd0a6d03c0b81ffe596221734b652d64248","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.unpause.end\","},{"line_number":3,"context_line":"    \"payload\":{\"$ref\": \"payloads/InstanceActionPayload.json#\"},"},{"line_number":4,"context_line":"    \"priority\":\"INFO\","},{"line_number":5,"context_line":"    \"publisher_id\":\"nova-compute:compute\""},{"line_number":6,"context_line":"}"}],"source_content_type":"application/json","patch_set":15,"id":"3f4b6375_03f1c86b","line":3,"range":{"start_line":3,"start_character":24,"end_line":3,"end_character":60},"updated":"2017-11-02 07:49:14.000000000","message":"ditto","commit_id":"33e0e4150376f769b403094a14e68936905025b4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a10e9cf0755cff919421ed9b3caafb786ccf30fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.unpause.end\","},{"line_number":3,"context_line":"    \"payload\":{\"$ref\": \"payloads/InstanceActionPayload.json#\"},"},{"line_number":4,"context_line":"    \"priority\":\"INFO\","},{"line_number":5,"context_line":"    \"publisher_id\":\"nova-compute:compute\""},{"line_number":6,"context_line":"}"}],"source_content_type":"application/json","patch_set":15,"id":"3f4b6375_8ff02f93","line":3,"range":{"start_line":3,"start_character":24,"end_line":3,"end_character":60},"in_reply_to":"3f4b6375_03f1c86b","updated":"2017-11-02 15:26:18.000000000","message":"Done","commit_id":"33e0e4150376f769b403094a14e68936905025b4"}],"doc/notification_samples/instance-unpause-start.json":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"48d79bd73fd632e0a6bf867c95f1ab94dad1b761","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"reservation_id\":\"r-npxv0e40\","},{"line_number":51,"context_line":"            \"state\":\"paused\","},{"line_number":52,"context_line":"            \"task_state\":\"unpausing\","},{"line_number":53,"context_line":"            \"power_state\":\"running\","},{"line_number":54,"context_line":"            \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":55,"context_line":"            \"terminated_at\":null,"},{"line_number":56,"context_line":"            \"auto_disk_config\":\"MANUAL\","}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_b3c03fe2","side":"PARENT","line":53,"range":{"start_line":53,"start_character":27,"end_line":53,"end_character":34},"updated":"2017-10-31 11:24:35.000000000","message":"It should be \"paused\".","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"01727f260b6fc27c8f4b4ec8f9d50ec2f7a811bf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \"reservation_id\":\"r-npxv0e40\","},{"line_number":51,"context_line":"            \"state\":\"paused\","},{"line_number":52,"context_line":"            \"task_state\":\"unpausing\","},{"line_number":53,"context_line":"            \"power_state\":\"running\","},{"line_number":54,"context_line":"            \"tenant_id\":\"6f70656e737461636b20342065766572\","},{"line_number":55,"context_line":"            \"terminated_at\":null,"},{"line_number":56,"context_line":"            \"auto_disk_config\":\"MANUAL\","}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_18596a59","side":"PARENT","line":53,"range":{"start_line":53,"start_character":27,"end_line":53,"end_character":34},"in_reply_to":"3f4b6375_b3c03fe2","updated":"2017-10-31 15:46:31.000000000","message":"See my reasoning in the pause.end sample file.","commit_id":"dae116bd8a815b61e3f8b521615e76d646f98db5"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"48d79bd73fd632e0a6bf867c95f1ab94dad1b761","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        \"$ref\": \"payloads/InstanceActionPayload.json#\","},{"line_number":5,"context_line":"        \"nova_object.data\": {"},{"line_number":6,"context_line":"            \"state\": \"paused\","},{"line_number":7,"context_line":"            \"task_state\": \"unpausing\""},{"line_number":8,"context_line":"        }"},{"line_number":9,"context_line":"    },"},{"line_number":10,"context_line":"    \"priority\":\"INFO\","}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_13ab931d","line":7,"updated":"2017-10-31 11:24:35.000000000","message":"Add \"power_state\":\"paused\"","commit_id":"598f2db9017c3829391b1ebb6c77ca4661ef14fc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"01727f260b6fc27c8f4b4ec8f9d50ec2f7a811bf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        \"$ref\": \"payloads/InstanceActionPayload.json#\","},{"line_number":5,"context_line":"        \"nova_object.data\": {"},{"line_number":6,"context_line":"            \"state\": \"paused\","},{"line_number":7,"context_line":"            \"task_state\": \"unpausing\""},{"line_number":8,"context_line":"        }"},{"line_number":9,"context_line":"    },"},{"line_number":10,"context_line":"    \"priority\":\"INFO\","}],"source_content_type":"application/json","patch_set":14,"id":"3f4b6375_b8337613","line":7,"in_reply_to":"3f4b6375_13ab931d","updated":"2017-10-31 15:46:31.000000000","message":"See my reasoning in the pause.end sample file","commit_id":"598f2db9017c3829391b1ebb6c77ca4661ef14fc"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"01a03fd0a6d03c0b81ffe596221734b652d64248","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.unpause.start\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"$ref\": \"payloads/InstanceActionPayload.json#\","},{"line_number":5,"context_line":"        \"nova_object.data\": {"},{"line_number":6,"context_line":"            \"state\": \"paused\","},{"line_number":7,"context_line":"            \"task_state\": \"unpausing\""}],"source_content_type":"application/json","patch_set":15,"id":"3f4b6375_e3f58c58","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":53},"updated":"2017-11-02 07:49:14.000000000","message":"ditto","commit_id":"33e0e4150376f769b403094a14e68936905025b4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a10e9cf0755cff919421ed9b3caafb786ccf30fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\":\"instance.unpause.start\","},{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"$ref\": \"payloads/InstanceActionPayload.json#\","},{"line_number":5,"context_line":"        \"nova_object.data\": {"},{"line_number":6,"context_line":"            \"state\": \"paused\","},{"line_number":7,"context_line":"            \"task_state\": \"unpausing\""}],"source_content_type":"application/json","patch_set":15,"id":"3f4b6375_6fedf3b5","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":53},"in_reply_to":"3f4b6375_e3f58c58","updated":"2017-11-02 15:26:18.000000000","message":"Done","commit_id":"33e0e4150376f769b403094a14e68936905025b4"}]}