)]}'
{"nova/tests/virt/vmwareapi/test_vmwareapi_vm_util.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8979c5d19fd9212525a9c6443762225e0c23a855","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # Test controller spec returned for lsiLogic sas adapter type"},{"line_number":254,"context_line":"        config_spec \u003d vm_util.create_controller_spec(fake.FakeFactory(), -101,"},{"line_number":255,"context_line":"                          adapter_type\u003d\"lsiLogicsas\")"},{"line_number":256,"context_line":"        self.assertEquals(\"ns0:VirtualLsiLogicSASController\","},{"line_number":257,"context_line":"                          config_spec.device.obj_name)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def test_get_vmdk_path_and_adapter_type(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2FQTI%3D","line":256,"updated":"2013-09-09 07:51:16.000000000","message":"Please use assertEqual instead of assertEquals (it is deprecated)","commit_id":"4cb3d02558fb007414302cf8c6adfd4d164a5b79"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8979c5d19fd9212525a9c6443762225e0c23a855","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        devices \u003d [disk, controller]"},{"line_number":271,"context_line":"        vmdk_info \u003d vm_util.get_vmdk_path_and_adapter_type(devices)"},{"line_number":272,"context_line":"        adapter_type \u003d vmdk_info[2]"},{"line_number":273,"context_line":"        self.assertEquals(\u0027lsiLogicsas\u0027, adapter_type)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def test_get_vmdk_adapter_type(self):"},{"line_number":276,"context_line":"        # Test for the adapter_type to be used in vmdk descriptor"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2FQS8%3D","line":273,"updated":"2013-09-09 07:51:16.000000000","message":"ditto","commit_id":"4cb3d02558fb007414302cf8c6adfd4d164a5b79"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8979c5d19fd9212525a9c6443762225e0c23a855","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        # Test for the adapter_type to be used in vmdk descriptor"},{"line_number":277,"context_line":"        # Adapter type in vmdk descriptor is same for LSI-SAS \u0026 LSILogic"},{"line_number":278,"context_line":"        vmdk_adapter_type \u003d vm_util.get_vmdk_adapter_type(\"lsiLogic\")"},{"line_number":279,"context_line":"        self.assertEquals(\"lsiLogic\", vmdk_adapter_type)"},{"line_number":280,"context_line":"        vmdk_adapter_type \u003d vm_util.get_vmdk_adapter_type(\"lsiLogicsas\")"},{"line_number":281,"context_line":"        self.assertEquals(\"lsiLogic\", vmdk_adapter_type)"},{"line_number":282,"context_line":"        vmdk_adapter_type \u003d vm_util.get_vmdk_adapter_type(\"dummyAdapter\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2FQS0%3D","line":279,"updated":"2013-09-09 07:51:16.000000000","message":"ditto","commit_id":"4cb3d02558fb007414302cf8c6adfd4d164a5b79"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8979c5d19fd9212525a9c6443762225e0c23a855","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        vmdk_adapter_type \u003d vm_util.get_vmdk_adapter_type(\"lsiLogic\")"},{"line_number":279,"context_line":"        self.assertEquals(\"lsiLogic\", vmdk_adapter_type)"},{"line_number":280,"context_line":"        vmdk_adapter_type \u003d vm_util.get_vmdk_adapter_type(\"lsiLogicsas\")"},{"line_number":281,"context_line":"        self.assertEquals(\"lsiLogic\", vmdk_adapter_type)"},{"line_number":282,"context_line":"        vmdk_adapter_type \u003d vm_util.get_vmdk_adapter_type(\"dummyAdapter\")"},{"line_number":283,"context_line":"        self.assertEquals(\"dummyAdapter\", vmdk_adapter_type)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2FQSw%3D","line":281,"updated":"2013-09-09 07:51:16.000000000","message":"ditto","commit_id":"4cb3d02558fb007414302cf8c6adfd4d164a5b79"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8979c5d19fd9212525a9c6443762225e0c23a855","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        vmdk_adapter_type \u003d vm_util.get_vmdk_adapter_type(\"lsiLogicsas\")"},{"line_number":281,"context_line":"        self.assertEquals(\"lsiLogic\", vmdk_adapter_type)"},{"line_number":282,"context_line":"        vmdk_adapter_type \u003d vm_util.get_vmdk_adapter_type(\"dummyAdapter\")"},{"line_number":283,"context_line":"        self.assertEquals(\"dummyAdapter\", vmdk_adapter_type)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2FQSs%3D","line":283,"updated":"2013-09-09 07:51:16.000000000","message":"ditto","commit_id":"4cb3d02558fb007414302cf8c6adfd4d164a5b79"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"acdcc924ec710ec642375761bad532de88cb6227","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                \u0027ns0:VirtualBusLogicController\u0027)"},{"line_number":122,"context_line":"    elif adapter_type \u003d\u003d \"lsiLogicsas\":"},{"line_number":123,"context_line":"        virtual_controller \u003d client_factory.create("},{"line_number":124,"context_line":"                                \u0027ns0:VirtualLsiLogicSASController\u0027)"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        virtual_controller \u003d client_factory.create("},{"line_number":127,"context_line":"                                \u0027ns0:VirtualLsiLogicController\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FTeI%3D","line":124,"updated":"2013-09-06 17:29:47.000000000","message":"I think if you use lsisas instead of making up this new one you can pass it through and not do the switch between lsilogicsas and lsilogic in vmops","commit_id":"ee5c1f37e9d3125502e1419bbb636a3b1f6da40f"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"07265db44a516bb4708670a7aafc4f146f3f8c31","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                \u0027ns0:VirtualBusLogicController\u0027)"},{"line_number":122,"context_line":"    elif adapter_type \u003d\u003d \"lsiLogicsas\":"},{"line_number":123,"context_line":"        virtual_controller \u003d client_factory.create("},{"line_number":124,"context_line":"                                \u0027ns0:VirtualLsiLogicSASController\u0027)"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        virtual_controller \u003d client_factory.create("},{"line_number":127,"context_line":"                                \u0027ns0:VirtualLsiLogicController\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FRsQ%3D","line":124,"in_reply_to":"AAAASn%2F%2FSjs%3D","updated":"2013-09-07 23:58:26.000000000","message":"I thought it was maybe undocumented as the vmksftools on esx do allow you to be specific in the adaptor type.  But looking at the code and at an booting windows image - the adaptor type is \"lsilogic\" so the magic you did in vmops is required","commit_id":"ee5c1f37e9d3125502e1419bbb636a3b1f6da40f"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"830b79571465117b25c485dda0cd88692ea79922","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                \u0027ns0:VirtualBusLogicController\u0027)"},{"line_number":122,"context_line":"    elif adapter_type \u003d\u003d \"lsiLogicsas\":"},{"line_number":123,"context_line":"        virtual_controller \u003d client_factory.create("},{"line_number":124,"context_line":"                                \u0027ns0:VirtualLsiLogicSASController\u0027)"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        virtual_controller \u003d client_factory.create("},{"line_number":127,"context_line":"                                \u0027ns0:VirtualLsiLogicController\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FSjs%3D","line":124,"in_reply_to":"AAAASn%2F%2FTZg%3D","updated":"2013-09-07 00:02:48.000000000","message":"I was concerned because as of 5.1 these are the supported enums, http://pubs.vmware.com/vsphere-51/index.jsp#com.vmware.wssdk.apiref.doc/vim.VirtualDiskManager.VirtualDiskAdapterType.html .","commit_id":"ee5c1f37e9d3125502e1419bbb636a3b1f6da40f"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"d287912ff1c53a68e6ea21190f6baa34a52cf479","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                \u0027ns0:VirtualBusLogicController\u0027)"},{"line_number":122,"context_line":"    elif adapter_type \u003d\u003d \"lsiLogicsas\":"},{"line_number":123,"context_line":"        virtual_controller \u003d client_factory.create("},{"line_number":124,"context_line":"                                \u0027ns0:VirtualLsiLogicSASController\u0027)"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        virtual_controller \u003d client_factory.create("},{"line_number":127,"context_line":"                                \u0027ns0:VirtualLsiLogicController\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FTZg%3D","line":124,"in_reply_to":"AAAASn%2F%2FTeI%3D","updated":"2013-09-06 18:04:16.000000000","message":"Hey Tracy, can you point me to some reference for lsisas. Let me check from my end too.","commit_id":"ee5c1f37e9d3125502e1419bbb636a3b1f6da40f"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"74f254ee6ac1d46d08b608542f99922b4e74428b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                \u0027ns0:VirtualBusLogicController\u0027)"},{"line_number":122,"context_line":"    elif adapter_type \u003d\u003d \"lsiLogicsas\":"},{"line_number":123,"context_line":"        virtual_controller \u003d client_factory.create("},{"line_number":124,"context_line":"                                \u0027ns0:VirtualLsiLogicSASController\u0027)"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        virtual_controller \u003d client_factory.create("},{"line_number":127,"context_line":"                                \u0027ns0:VirtualLsiLogicController\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FSjE%3D","line":124,"in_reply_to":"AAAASn%2F%2FTeI%3D","updated":"2013-09-07 00:15:06.000000000","message":"The VirtualDiskManager API does not recognize the lsilogicsas adapter type, so lsiLogic has to be used, which means the adapter_type string value has no bearing on what gets used in vmops when creating the disk. Not that there is anything wrong with calling it lsiSas either, as long as we support a new value to indicate a different _adapter_ has to be created for the VM.","commit_id":"ee5c1f37e9d3125502e1419bbb636a3b1f6da40f"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3d234621d302ad5697b4f78eaa60b76016c85045","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            image_size, image_properties \u003d _image_info"},{"line_number":168,"context_line":"            vmdk_file_size_in_kb \u003d int(image_size) / 1024"},{"line_number":169,"context_line":"            os_type \u003d image_properties.get(\"vmware_ostype\", \"otherGuest\")"},{"line_number":170,"context_line":"            adapter_type \u003d image_properties.get(\"vmware_adaptertype\","},{"line_number":171,"context_line":"                                                \"lsiLogic\")"},{"line_number":172,"context_line":"            # Adapter type in vmdk descriptor is same for LSI-SAS \u0026 LSILogic"},{"line_number":173,"context_line":"            if adapter_type \u003d\u003d \"lsiLogicsas\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FVU0%3D","line":170,"updated":"2013-09-06 06:24:36.000000000","message":"maybe it would be good to have lines 170 - 176 in a separate function.","commit_id":"ee5c1f37e9d3125502e1419bbb636a3b1f6da40f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3d234621d302ad5697b4f78eaa60b76016c85045","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                      \"%(adapter_type)s on the ESX host local store \""},{"line_number":256,"context_line":"                      \"%(data_store_name)s\") %"},{"line_number":257,"context_line":"                       {\"vmdk_file_size_in_kb\": vmdk_file_size_in_kb,"},{"line_number":258,"context_line":"                        \"adapter_type\": vmdk_adapter_type,"},{"line_number":259,"context_line":"                        \"data_store_name\": data_store_name},"},{"line_number":260,"context_line":"                      instance\u003dinstance)"},{"line_number":261,"context_line":"            vmdk_create_spec \u003d vm_util.get_vmdk_create_spec(client_factory,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FVVA%3D","line":258,"updated":"2013-09-06 06:24:36.000000000","message":"minor nit but consider changing the var name adapter_type to vmdk_adapter_type","commit_id":"ee5c1f37e9d3125502e1419bbb636a3b1f6da40f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3d234621d302ad5697b4f78eaa60b76016c85045","unresolved":false,"context_lines":[{"line_number":339,"context_line":"                      \"%(adapter_type)s on the ESX host local store \""},{"line_number":340,"context_line":"                      \"%(data_store_name)s to disk type %(disk_type)s\") %"},{"line_number":341,"context_line":"                       {\"vmdk_file_size_in_kb\": vmdk_file_size_in_kb,"},{"line_number":342,"context_line":"                        \"adapter_type\": vmdk_adapter_type,"},{"line_number":343,"context_line":"                        \"data_store_name\": data_store_name,"},{"line_number":344,"context_line":"                        \"disk_type\": disk_type},"},{"line_number":345,"context_line":"                      instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FVU8%3D","line":342,"updated":"2013-09-06 06:24:36.000000000","message":"ditto","commit_id":"ee5c1f37e9d3125502e1419bbb636a3b1f6da40f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3d234621d302ad5697b4f78eaa60b76016c85045","unresolved":false,"context_lines":[{"line_number":553,"context_line":"            os_type \u003d self._session._call_method(vim_util,"},{"line_number":554,"context_line":"                        \"get_dynamic_property\", vm_ref,"},{"line_number":555,"context_line":"                        \"VirtualMachine\", \"summary.config.guestId\")"},{"line_number":556,"context_line":"            # Adapter type in vmdk descriptor is same for LSI-SAS \u0026 LSILogic"},{"line_number":557,"context_line":"            if adapter_type \u003d\u003d \"lsiLogicsas\":"},{"line_number":558,"context_line":"                vmdk_adapter_type \u003d \"lsiLogic\""},{"line_number":559,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FVUw%3D","line":556,"updated":"2013-09-06 06:24:36.000000000","message":"why do we not do this update in get_vmdk_path_and_adapter_type?","commit_id":"ee5c1f37e9d3125502e1419bbb636a3b1f6da40f"}]}
