)]}'
{"nova/virt/libvirt/volume/quobyte.py":[{"author":{"_account_id":17814,"name":"fengzhr","email":"fengzhr@awcloud.com","username":"space"},"change_message_id":"f6ca82eb2887facf3f1cd089ee7e61b3af892dbf","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    LOG.debug(\u0027Mounting volume %s at mount point %s ...\u0027,"},{"line_number":57,"context_line":"              volume,"},{"line_number":58,"context_line":"              mnt_base)"},{"line_number":59,"context_line":"    utils.execute(*command, check_exit_code\u003d[0, 4])"},{"line_number":60,"context_line":"    LOG.info(_LI(\u0027Mounted volume: %s\u0027), volume)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_3b570ecd","side":"PARENT","line":59,"range":{"start_line":59,"start_character":45,"end_line":59,"end_character":46},"updated":"2017-04-05 12:00:59.000000000","message":"What about 0? You don\u0027t mention it but you delete it,too. It may makes someone confused.","commit_id":"952ed57415b983f5de9c605ebdeef91c0f19d20c"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"c9f5752757b9367da79e52b936f795ea1e6c973e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    LOG.debug(\u0027Mounting volume %s at mount point %s ...\u0027,"},{"line_number":57,"context_line":"              volume,"},{"line_number":58,"context_line":"              mnt_base)"},{"line_number":59,"context_line":"    utils.execute(*command, check_exit_code\u003d[0, 4])"},{"line_number":60,"context_line":"    LOG.info(_LI(\u0027Mounted volume: %s\u0027), volume)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_dbd822f0","side":"PARENT","line":59,"range":{"start_line":59,"start_character":45,"end_line":59,"end_character":46},"in_reply_to":"dfeb2761_3b570ecd","updated":"2017-04-05 12:15:01.000000000","message":"[0] is the default value for that argument. But i can add a corresponding comment to the patch message if that is confusing.","commit_id":"952ed57415b983f5de9c605ebdeef91c0f19d20c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2b4d8558c1896afe57f8f1d42d91e9cfa9321778","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        if mounted:"},{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                validate_volume(mount_path)"},{"line_number":122,"context_line":"            except OSError as exc:"},{"line_number":123,"context_line":"                if exc.errno \u003d\u003d errno.ENOTCONN:"},{"line_number":124,"context_line":"                    mounted \u003d False"},{"line_number":125,"context_line":"                    LOG.info(\u0027Fixing previous mount %s which was not\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_6ae9b118","line":122,"range":{"start_line":122,"start_character":12,"end_line":122,"end_character":34},"updated":"2017-06-21 18:59:34.000000000","message":"validate_volume() doesn\u0027t raise this exception, this \"except\" block still is necessary?","commit_id":"443511e806457474b38cdf458f1582757b447539"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9be8afd5efa805e33e2908c448172f9d56f7ea92","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        if mounted:"},{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                validate_volume(mount_path)"},{"line_number":122,"context_line":"            except OSError as exc:"},{"line_number":123,"context_line":"                if exc.errno \u003d\u003d errno.ENOTCONN:"},{"line_number":124,"context_line":"                    mounted \u003d False"},{"line_number":125,"context_line":"                    LOG.info(\u0027Fixing previous mount %s which was not\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_f136bae7","line":122,"range":{"start_line":122,"start_character":12,"end_line":122,"end_character":34},"in_reply_to":"5f201791_11db841b","updated":"2017-06-22 17:11:11.000000000","message":"Thanks, got it.","commit_id":"443511e806457474b38cdf458f1582757b447539"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"86464654f173a1a668de0cd2e90e82adb5d6abec","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        if mounted:"},{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                validate_volume(mount_path)"},{"line_number":122,"context_line":"            except OSError as exc:"},{"line_number":123,"context_line":"                if exc.errno \u003d\u003d errno.ENOTCONN:"},{"line_number":124,"context_line":"                    mounted \u003d False"},{"line_number":125,"context_line":"                    LOG.info(\u0027Fixing previous mount %s which was not\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_11db841b","line":122,"range":{"start_line":122,"start_character":12,"end_line":122,"end_character":34},"in_reply_to":"5f201791_6ae9b118","updated":"2017-06-22 09:55:40.000000000","message":"Actually this is not the best change to update this mount check. I\u0027ll move this to a more appropriate change to keep this more simple.\nThanks for pointing at this!","commit_id":"443511e806457474b38cdf458f1582757b447539"}]}