)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"0c572f00a3c80acd982055da240942453ad60387","unresolved":false,"context_lines":[{"line_number":10,"context_line":"we realized that the inheritance used in the notification payload classes"},{"line_number":11,"context_line":"has some drawbacks. When we need to introduce new leaf classes the content"},{"line_number":12,"context_line":"of the nova.obj_name field will change in the emited payload. This should"},{"line_number":13,"context_line":"be avoided if possible or at least we have to keep the version number"},{"line_number":14,"context_line":"increasing all the time."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie8c9317892f5593d473067d5dfc300a7e98795c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"3f1d235d_999ea961","line":14,"range":{"start_line":13,"start_character":26,"end_line":14,"end_character":24},"updated":"2017-06-30 12:26:57.000000000","message":"This sound different meaning with the doc \u0027If this cannot be avoided and the only change is\nthe renaming then the version of the new payload shall be the same as the old\npayload was before the rename.\u0027\n\nNot sure whether it is my English problem...","commit_id":"b5dc186e9f397fe42510954a5d0bf08c772520ab"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"57b47a15e9f763832d964bd1d88a5f136ba2b550","unresolved":false,"context_lines":[{"line_number":10,"context_line":"we realized that the inheritance used in the notification payload classes"},{"line_number":11,"context_line":"has some drawbacks. When we need to introduce new leaf classes the content"},{"line_number":12,"context_line":"of the nova.obj_name field will change in the emited payload. This should"},{"line_number":13,"context_line":"be avoided if possible or at least we have to keep the version number"},{"line_number":14,"context_line":"increasing all the time."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie8c9317892f5593d473067d5dfc300a7e98795c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1f1a1f67_dba83e8d","line":14,"range":{"start_line":13,"start_character":26,"end_line":14,"end_character":24},"in_reply_to":"3f1d235d_999ea961","updated":"2017-07-17 09:37:22.000000000","message":"I made the commit message more aligned with the doc change.","commit_id":"b5dc186e9f397fe42510954a5d0bf08c772520ab"}],"doc/source/notifications.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"98c69b87893cf44d8ee2d6780ef89ca29fa814cd","unresolved":false,"context_lines":[{"line_number":291,"context_line":"notification should be created with care to avoid future needs of adding extra"},{"line_number":292,"context_line":"level of inheritance that changes the name of the leaf class as that name is"},{"line_number":293,"context_line":"present in the payload class. If this cannot be avoided then the initial"},{"line_number":294,"context_line":"version of the new leaf payload class should be bigger than the version of the"},{"line_number":295,"context_line":"previous class was."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"What should be in the notification payload"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7ffa3b31_4dda1e4b","line":294,"range":{"start_line":294,"start_character":48,"end_line":294,"end_character":54},"updated":"2017-04-20 16:23:01.000000000","message":"bigger or higher? I assume the latter, if you\u0027re talking about the version rather than the actual payload itself.","commit_id":"e58d7a8fa8f6290db643b29f0a0003fe4fa42a9a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"28aec99030eba9719da5d0c87888fa07247c037f","unresolved":false,"context_lines":[{"line_number":291,"context_line":"notification should be created with care to avoid future needs of adding extra"},{"line_number":292,"context_line":"level of inheritance that changes the name of the leaf class as that name is"},{"line_number":293,"context_line":"present in the payload class. If this cannot be avoided then the initial"},{"line_number":294,"context_line":"version of the new leaf payload class should be bigger than the version of the"},{"line_number":295,"context_line":"previous class was."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"What should be in the notification payload"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7ffa3b31_80aa1216","line":294,"range":{"start_line":294,"start_character":48,"end_line":294,"end_character":54},"in_reply_to":"7ffa3b31_4dda1e4b","updated":"2017-04-21 11:59:20.000000000","message":"Good point. The version should be higher.","commit_id":"e58d7a8fa8f6290db643b29f0a0003fe4fa42a9a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5c5230eb05812ed69e22796b7e6e0a384628c46a","unresolved":false,"context_lines":[{"line_number":290,"context_line":"payload fragments in nova code. However the leaf classes used directly in a"},{"line_number":291,"context_line":"notification should be created with care to avoid future needs of adding extra"},{"line_number":292,"context_line":"level of inheritance that changes the name of the leaf class as that name is"},{"line_number":293,"context_line":"present in the payload class. If this cannot be avoided and the only change is"},{"line_number":294,"context_line":"the renaming then the version of the new payload shall be the same as the old"},{"line_number":295,"context_line":"payload was before the rename. If the renaming involves any other changes on"},{"line_number":296,"context_line":"the payload (e.g. adding new fields) then the version of the new payload shall"},{"line_number":297,"context_line":"be higher than the old payload was."},{"line_number":298,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"7f231b9d_8f116d07","line":295,"range":{"start_line":293,"start_character":56,"end_line":295,"end_character":30},"updated":"2017-06-14 14:56:52.000000000","message":"Please link to https://review.openstack.org/#/c/463001/ as an example. The prose could be hard to parse and looking at examples would help clarify.","commit_id":"fe6af0ca7547f847b07193eb8799fa0f7a2a2d50"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5c5230eb05812ed69e22796b7e6e0a384628c46a","unresolved":false,"context_lines":[{"line_number":293,"context_line":"present in the payload class. If this cannot be avoided and the only change is"},{"line_number":294,"context_line":"the renaming then the version of the new payload shall be the same as the old"},{"line_number":295,"context_line":"payload was before the rename. If the renaming involves any other changes on"},{"line_number":296,"context_line":"the payload (e.g. adding new fields) then the version of the new payload shall"},{"line_number":297,"context_line":"be higher than the old payload was."},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"What should be in the notification payload"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7f231b9d_6ffa91bd","line":296,"range":{"start_line":296,"start_character":13,"end_line":296,"end_character":35},"updated":"2017-06-14 14:56:52.000000000","message":"Please link to https://review.openstack.org/#/c/453077/ for the example on this case.","commit_id":"fe6af0ca7547f847b07193eb8799fa0f7a2a2d50"}]}