)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d0ff91e421b7697dce18ec472ddb2746f7196996","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        self._sync_power_pool \u003d eventlet.GreenPool("},{"line_number":517,"context_line":"            size\u003dCONF.sync_power_state_pool_size)"},{"line_number":518,"context_line":"        self._syncs_in_progress \u003d {}"},{"line_number":519,"context_line":"        if CONF.scheduler.driver \u003d\u003d \u0027filter_scheduler\u0027:"},{"line_number":520,"context_line":"            self.send_instance_updates \u003d ("},{"line_number":521,"context_line":"                CONF.filter_scheduler.track_instance_changes)"},{"line_number":522,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_6787a411","line":519,"updated":"2017-04-06 20:37:01.000000000","message":"We should do the same thing in the scheduler host manager:\n\nhttps://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L359","commit_id":"c081d1340d4d4da9e23d4f59a7764c0576cd5481"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"d1c19c4cea1159a0c802184b986d6ae25d7edf49","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                CONF.filter_scheduler.track_instance_changes)"},{"line_number":522,"context_line":"        else:"},{"line_number":523,"context_line":"            # If we\u0027re not using the filter scheduler, don\u0027t send rpc noise."},{"line_number":524,"context_line":"            self.send_instance_updates \u003d False"},{"line_number":525,"context_line":"        if CONF.max_concurrent_builds !\u003d 0:"},{"line_number":526,"context_line":"            self._build_semaphore \u003d eventlet.semaphore.Semaphore("},{"line_number":527,"context_line":"                CONF.max_concurrent_builds)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_2dc17d81","line":524,"updated":"2017-04-06 21:36:12.000000000","message":"Readability counts!\n\n    self.send_instance_updates \u003d (CONF.filter_scheduler.track_instance_changes and \n        (CONF.scheduler.driver \u003d\u003d \u0027filter_scheduler\u0027))","commit_id":"c081d1340d4d4da9e23d4f59a7764c0576cd5481"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4d57debc70e1f8813d8bd0aa272fe7b9720aba36","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                CONF.filter_scheduler.track_instance_changes)"},{"line_number":522,"context_line":"        else:"},{"line_number":523,"context_line":"            # If we\u0027re not using the filter scheduler, don\u0027t send rpc noise."},{"line_number":524,"context_line":"            self.send_instance_updates \u003d False"},{"line_number":525,"context_line":"        if CONF.max_concurrent_builds !\u003d 0:"},{"line_number":526,"context_line":"            self._build_semaphore \u003d eventlet.semaphore.Semaphore("},{"line_number":527,"context_line":"                CONF.max_concurrent_builds)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_ff4a18aa","line":524,"in_reply_to":"bff0334d_2dc17d81","updated":"2017-04-06 22:08:37.000000000","message":"That is infinitely less readable to me.","commit_id":"c081d1340d4d4da9e23d4f59a7764c0576cd5481"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"34b3a2d8b4444a9f765d36a07ee8ed3bb7c39d4f","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        # NOTE(mriedem): This same logic, unfortunate as it may be, is also"},{"line_number":520,"context_line":"        # in the scheduler HostManager, so if you change something here, you"},{"line_number":521,"context_line":"        # should also see if it needs to be changed there."},{"line_number":522,"context_line":"        if CONF.scheduler.driver \u003d\u003d \u0027filter_scheduler\u0027:"},{"line_number":523,"context_line":"            self.send_instance_updates \u003d ("},{"line_number":524,"context_line":"                CONF.filter_scheduler.track_instance_changes)"},{"line_number":525,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_552108fb","line":522,"updated":"2017-05-29 20:34:58.000000000","message":"I\u0027m not super happy with checking a scheduler option here.\nSome possible operators could not having modified nova.conf for all the compute nodes if they would like to use a separate driver. That said, since only the ChanceScheduler is not using the instance updates, we could maybe modify the above something like :\n\nif not CONF.scheduler.driver \u003d\u003d \u0027chance_scheduler\":\n\nwhich would mean that only operators using the ChanceScheduler should need to make sure to modify the compute nodes too, that\u0027s it.","commit_id":"f27b0ddccff77e5f7a5484b0ff819c756bd19568"}],"nova/conf/compute.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"d1c19c4cea1159a0c802184b986d6ae25d7edf49","unresolved":false,"context_lines":[{"line_number":811,"context_line":""},{"line_number":812,"context_line":"If the CONF option \u0027filter_scheduler/track_instance_changes\u0027 is"},{"line_number":813,"context_line":"False or the filter_scheduler is not used, the sync calls will not be made."},{"line_number":814,"context_line":"So, changing this option will have no effect."},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"If the out of sync situations are not very common, this interval"},{"line_number":817,"context_line":"can be increased to lower the number of RPC messages being sent."}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_ad310da5","line":814,"range":{"start_line":814,"start_character":2,"end_line":814,"end_character":3},"updated":"2017-04-06 21:36:12.000000000","message":"As long as you\u0027re editing, please remove this comma.","commit_id":"c081d1340d4d4da9e23d4f59a7764c0576cd5481"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4d57debc70e1f8813d8bd0aa272fe7b9720aba36","unresolved":false,"context_lines":[{"line_number":811,"context_line":""},{"line_number":812,"context_line":"If the CONF option \u0027filter_scheduler/track_instance_changes\u0027 is"},{"line_number":813,"context_line":"False or the filter_scheduler is not used, the sync calls will not be made."},{"line_number":814,"context_line":"So, changing this option will have no effect."},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"If the out of sync situations are not very common, this interval"},{"line_number":817,"context_line":"can be increased to lower the number of RPC messages being sent."}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_1f77fc04","line":814,"range":{"start_line":814,"start_character":2,"end_line":814,"end_character":3},"in_reply_to":"bff0334d_ad310da5","updated":"2017-04-06 22:08:37.000000000","message":"Done","commit_id":"c081d1340d4d4da9e23d4f59a7764c0576cd5481"}],"nova/scheduler/host_manager.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"34b3a2d8b4444a9f765d36a07ee8ed3bb7c39d4f","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        # NOTE(mriedem): This same logic, unfortunate as it may be, is also"},{"line_number":359,"context_line":"        # in the ComputeManager, so if you change something here, you should"},{"line_number":360,"context_line":"        # also see if it needs to be changed there."},{"line_number":361,"context_line":"        if CONF.scheduler.driver \u003d\u003d \u0027filter_scheduler\u0027:"},{"line_number":362,"context_line":"            self.track_instance_changes \u003d ("},{"line_number":363,"context_line":"                CONF.filter_scheduler.track_instance_changes)"},{"line_number":364,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_152b90eb","line":361,"range":{"start_line":361,"start_character":8,"end_line":361,"end_character":55},"updated":"2017-05-29 20:34:58.000000000","message":"unfortunately, you also need to accept the CachingScheduler driver even if it\u0027s caching the HostStates.","commit_id":"f27b0ddccff77e5f7a5484b0ff819c756bd19568"}],"releasenotes/notes/track_instance_changes-compute-fc80ee6599e7db3c.yaml":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"34b3a2d8b4444a9f765d36a07ee8ed3bb7c39d4f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    HostManager in the scheduler service will not pull instances from all"},{"line_number":7,"context_line":"    compute nodes on startup. This is related to the"},{"line_number":8,"context_line":"    ``[DEFAULT]/scheduler_instance_sync_interval`` and"},{"line_number":9,"context_line":"    ``[filter_scheduler]/track_instance_changes`` configuration options."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df140735_f57dbce7","line":9,"updated":"2017-05-29 20:34:58.000000000","message":"you should add an upgrade note for saying that before upgrading to Pike, you need to modify all your nova.conf files for all your computes if needed.","commit_id":"f27b0ddccff77e5f7a5484b0ff819c756bd19568"}]}