)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"26cf2ad57f6ad400b63f172d80ea58cf452a45ff","unresolved":false,"context_lines":[{"line_number":2407,"context_line":"                    pci_mapping \u003d self._get_pci_mapping_for_migration(context,"},{"line_number":2408,"context_line":"                        instance, migration)"},{"line_number":2409,"context_line":""},{"line_number":2410,"context_line":"                if pci_mapping:"},{"line_number":2411,"context_line":"                    pci_slot \u003d binding_profile.get(\u0027pci_slot\u0027)"},{"line_number":2412,"context_line":"                    new_dev \u003d pci_mapping.get(pci_slot)"},{"line_number":2413,"context_line":"                    if not new_dev:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_2744ea1a","line":2410,"range":{"start_line":2410,"start_character":16,"end_line":2410,"end_character":31},"updated":"2017-04-18 10:03:45.000000000","message":"I don\u0027t think that this is correct check.\nwe should do the pci mapping only if we have migration variable. So you just need to check before Line 2400 if migration is not None.\nThis way if pci_mapping is None but we have a migration object we can tell if we have a problem in the code of the migration.","commit_id":"1b56beeb9712ab45b4246450cda9a0a857a5f1ce"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"c3a078ba8d573aca79af47cd3e1cc8f12e51d866","unresolved":false,"context_lines":[{"line_number":2407,"context_line":"                    pci_mapping \u003d self._get_pci_mapping_for_migration(context,"},{"line_number":2408,"context_line":"                        instance, migration)"},{"line_number":2409,"context_line":""},{"line_number":2410,"context_line":"                if pci_mapping:"},{"line_number":2411,"context_line":"                    pci_slot \u003d binding_profile.get(\u0027pci_slot\u0027)"},{"line_number":2412,"context_line":"                    new_dev \u003d pci_mapping.get(pci_slot)"},{"line_number":2413,"context_line":"                    if not new_dev:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_61b40936","line":2410,"range":{"start_line":2410,"start_character":16,"end_line":2410,"end_character":31},"in_reply_to":"7ffa3b31_2744ea1a","updated":"2017-04-18 21:53:06.000000000","message":"Thanks Moshe, that\u0027s reasonable","commit_id":"1b56beeb9712ab45b4246450cda9a0a857a5f1ce"},{"author":{"_account_id":17814,"name":"fengzhr","email":"fengzhr@awcloud.com","username":"space"},"change_message_id":"711ccaba84392e19dbd72c01ee1384a11cad4355","unresolved":false,"context_lines":[{"line_number":2404,"context_line":"            # resize is happening on the same host, a new PCI device can be"},{"line_number":2405,"context_line":"            # allocated."},{"line_number":2406,"context_line":"            vnic_type \u003d p.get(\u0027binding:vnic_type\u0027)"},{"line_number":2407,"context_line":"            if (vnic_type in network_model.VNIC_TYPES_SRIOV"},{"line_number":2408,"context_line":"                    and migration is not None):"},{"line_number":2409,"context_line":"                if not pci_mapping:"},{"line_number":2410,"context_line":"                    pci_mapping \u003d self._get_pci_mapping_for_migration(context,"},{"line_number":2411,"context_line":"                        instance, migration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_285ff20e","line":2408,"range":{"start_line":2407,"start_character":16,"end_line":2408,"end_character":45},"updated":"2017-04-19 11:43:21.000000000","message":"\"if vnic_type in network_model.VNIC_TYPES_SRIOV \\\n       and migration is not None\"\nI think it\u0027s better to use line breaks.","commit_id":"c2ff276c841934ff147aab836a4bd099297fb46b"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"f69134ec23d38b968bc50844175da394e121ab47","unresolved":false,"context_lines":[{"line_number":2404,"context_line":"            # resize is happening on the same host, a new PCI device can be"},{"line_number":2405,"context_line":"            # allocated."},{"line_number":2406,"context_line":"            vnic_type \u003d p.get(\u0027binding:vnic_type\u0027)"},{"line_number":2407,"context_line":"            if (vnic_type in network_model.VNIC_TYPES_SRIOV"},{"line_number":2408,"context_line":"                    and migration is not None):"},{"line_number":2409,"context_line":"                if not pci_mapping:"},{"line_number":2410,"context_line":"                    pci_mapping \u003d self._get_pci_mapping_for_migration(context,"},{"line_number":2411,"context_line":"                        instance, migration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_e6981d1c","line":2408,"range":{"start_line":2407,"start_character":16,"end_line":2408,"end_character":45},"in_reply_to":"5ff73747_f0469c7c","updated":"2017-04-26 17:44:52.000000000","message":"Done.  Link to new review: https://review.openstack.org/#/c/460233/","commit_id":"c2ff276c841934ff147aab836a4bd099297fb46b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1dcb5e188acc5c7401bd043e99a606c82e862314","unresolved":false,"context_lines":[{"line_number":2404,"context_line":"            # resize is happening on the same host, a new PCI device can be"},{"line_number":2405,"context_line":"            # allocated."},{"line_number":2406,"context_line":"            vnic_type \u003d p.get(\u0027binding:vnic_type\u0027)"},{"line_number":2407,"context_line":"            if (vnic_type in network_model.VNIC_TYPES_SRIOV"},{"line_number":2408,"context_line":"                    and migration is not None):"},{"line_number":2409,"context_line":"                if not pci_mapping:"},{"line_number":2410,"context_line":"                    pci_mapping \u003d self._get_pci_mapping_for_migration(context,"},{"line_number":2411,"context_line":"                        instance, migration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_f0469c7c","line":2408,"range":{"start_line":2407,"start_character":16,"end_line":2408,"end_character":45},"in_reply_to":"7ffa3b31_282460ae","updated":"2017-04-26 15:00:56.000000000","message":"It would have been (still would be) good to update the comment block above to explain why we exclude migrations that are None. This code is already a confusing jumble of conditionals, and needs to be documented better.","commit_id":"c2ff276c841934ff147aab836a4bd099297fb46b"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eaf965b9dec4d1f2c7db48044bee0f6e7d0d3d1e","unresolved":false,"context_lines":[{"line_number":2404,"context_line":"            # resize is happening on the same host, a new PCI device can be"},{"line_number":2405,"context_line":"            # allocated."},{"line_number":2406,"context_line":"            vnic_type \u003d p.get(\u0027binding:vnic_type\u0027)"},{"line_number":2407,"context_line":"            if (vnic_type in network_model.VNIC_TYPES_SRIOV"},{"line_number":2408,"context_line":"                    and migration is not None):"},{"line_number":2409,"context_line":"                if not pci_mapping:"},{"line_number":2410,"context_line":"                    pci_mapping \u003d self._get_pci_mapping_for_migration(context,"},{"line_number":2411,"context_line":"                        instance, migration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_cfce2659","line":2408,"range":{"start_line":2407,"start_character":16,"end_line":2408,"end_character":45},"in_reply_to":"7ffa3b31_285ff20e","updated":"2017-04-20 15:44:42.000000000","message":"Hi fengzhr, the pep8 style guide prefers parentheses over line breaks. https://www.python.org/dev/peps/pep-0008/#maximum-line-length","commit_id":"c2ff276c841934ff147aab836a4bd099297fb46b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"09b2342ae6c8d80b2b041a33f5d904db790424d2","unresolved":false,"context_lines":[{"line_number":2404,"context_line":"            # resize is happening on the same host, a new PCI device can be"},{"line_number":2405,"context_line":"            # allocated."},{"line_number":2406,"context_line":"            vnic_type \u003d p.get(\u0027binding:vnic_type\u0027)"},{"line_number":2407,"context_line":"            if (vnic_type in network_model.VNIC_TYPES_SRIOV"},{"line_number":2408,"context_line":"                    and migration is not None):"},{"line_number":2409,"context_line":"                if not pci_mapping:"},{"line_number":2410,"context_line":"                    pci_mapping \u003d self._get_pci_mapping_for_migration(context,"},{"line_number":2411,"context_line":"                        instance, migration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_282460ae","line":2408,"range":{"start_line":2407,"start_character":16,"end_line":2408,"end_character":45},"in_reply_to":"7ffa3b31_cfce2659","updated":"2017-04-20 16:38:51.000000000","message":"Yup, this is good as is","commit_id":"c2ff276c841934ff147aab836a4bd099297fb46b"}]}