)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a31468aa65dc5d9164500faff0d36097fa47e2ca","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                help\u003d\"\"\""},{"line_number":516,"context_line":"Specific cache modes to use for different disk types."},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"For example: file\u003ddirectsync,block\u003dnone,network\u003dwriteback"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"For local or direct-attached storage, it is recommended that you use"},{"line_number":521,"context_line":"writethrough (default) mode, as it ensures data integrity and has acceptable"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_5802370b","line":518,"updated":"2017-04-18 11:32:29.000000000","message":"Nit: would be good to include what the default looks like.","commit_id":"3d9a76bd71159a3e8ce0acdb27ec76381b1024fc"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"625969321315be063cfe1512fe014bd8422b0dd9","unresolved":false,"context_lines":[{"line_number":553,"context_line":"  I/O performance for applications running in the guest is good, but the data"},{"line_number":554,"context_line":"  is not protected in a power failure. As a result, this caching mode is"},{"line_number":555,"context_line":"  recommended only for temporary data where potential data loss is not a"},{"line_number":556,"context_line":"  concern."},{"line_number":557,"context_line":"* directsync: Like \"writethrough\", but it bypasses the host page cache."},{"line_number":558,"context_line":"* unsafe: Caching mode of unsafe ignores cache transfer operations"},{"line_number":559,"context_line":"  completely. As its name implies, this caching mode should be used only for"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_b05488ff","line":556,"updated":"2017-04-08 17:26:23.000000000","message":"This is nice and useful.\n\nFWIW, for all the above 6 caching mode descriptions, I usually resort to the equally clear, but more compact descriptions from Richard W.M. Jones here:\n\nhttps://rwmj.wordpress.com/2013/09/02/new-in-libguestfs-allow-cache-mode-to-be-selected/\n\nIt\u0027s just a preference.","commit_id":"3d9a76bd71159a3e8ce0acdb27ec76381b1024fc"}]}