)]}'
{"nova/cache_utils.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"89e6a2b56c01c0b85fd7efc5cd54dcb86f97f974","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _warn_if_null_backend():"},{"line_number":33,"context_line":"    if CONF.cache.backend \u003d\u003d \u0027dogpile.cache.null\u0027:"},{"line_number":34,"context_line":"        LOG.warning(\"Cache enabled with backend dogpile.cache.null.\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def get_memcached_client(expiration_time\u003d0):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_9d22fca3","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":69},"updated":"2017-04-18 03:11:58.000000000","message":"I guessed we need to use _() instead of _LW() instead according to https://review.openstack.org/#/c/447528/3/doc/source/i18n.rst\n\nDid you mean \"an end user\" of 447528 is API users, or containing operators? If it was API users, line 93\u0027s _() also should be removed.\n\nAnyways this patch seems inconsistent, or we need to update the guideline of 447528.","commit_id":"1cda41f4a305fae265fd78e0218d65823fdacbf3"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d0a94cca4abb7cc5ae7f16f298b97b7693a5294e","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _warn_if_null_backend():"},{"line_number":33,"context_line":"    if CONF.cache.backend \u003d\u003d \u0027dogpile.cache.null\u0027:"},{"line_number":34,"context_line":"        LOG.warning(\"Cache enabled with backend dogpile.cache.null.\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def get_memcached_client(expiration_time\u003d0):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_ebed928b","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":69},"in_reply_to":"7ffa3b31_7550510b","updated":"2017-04-19 04:48:14.000000000","message":"line 93\u0027s one might be a mistake, I feel. but it would be fine to remove it later to keep this patch scope.","commit_id":"1cda41f4a305fae265fd78e0218d65823fdacbf3"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"51606761ce686d558b14c5a8a7881c9a5c5e04be","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _warn_if_null_backend():"},{"line_number":33,"context_line":"    if CONF.cache.backend \u003d\u003d \u0027dogpile.cache.null\u0027:"},{"line_number":34,"context_line":"        LOG.warning(\"Cache enabled with backend dogpile.cache.null.\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def get_memcached_client(expiration_time\u003d0):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_9fbc1edd","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":69},"in_reply_to":"7ffa3b31_9d22fca3","updated":"2017-04-18 15:07:28.000000000","message":"We aren\u0027t translating logs, I don\u0027t understand why _ would be used here.","commit_id":"1cda41f4a305fae265fd78e0218d65823fdacbf3"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"985e54363a6c40c5f5ca28c92dd06dee57207134","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _warn_if_null_backend():"},{"line_number":33,"context_line":"    if CONF.cache.backend \u003d\u003d \u0027dogpile.cache.null\u0027:"},{"line_number":34,"context_line":"        LOG.warning(\"Cache enabled with backend dogpile.cache.null.\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def get_memcached_client(expiration_time\u003d0):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_7550510b","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":69},"in_reply_to":"7ffa3b31_9fbc1edd","updated":"2017-04-18 15:42:55.000000000","message":"Then we need to remove _() of line 93 also, right?","commit_id":"1cda41f4a305fae265fd78e0218d65823fdacbf3"}]}
