)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"703c1f8dd66854dd47931aeca1cf055e35170971","unresolved":false,"context_lines":[{"line_number":6526,"context_line":""},{"line_number":6527,"context_line":"@pick_context_manager_writer"},{"line_number":6528,"context_line":"def service_uuids_online_data_migration(context, max_count):"},{"line_number":6529,"context_line":"    from nova.objects import service"},{"line_number":6530,"context_line":""},{"line_number":6531,"context_line":"    count_all \u003d 0"},{"line_number":6532,"context_line":"    count_hit \u003d 0"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_29c5183d","line":6529,"updated":"2017-05-04 14:21:09.000000000","message":"any reason why this online data migration wouldn\u0027t be in the Service object like other migrations ?","commit_id":"841f1c2b6954bec9a52e4696a8e6947560256245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9aad2e21d6c6dfabacb18b0aa2147117695695d8","unresolved":false,"context_lines":[{"line_number":6526,"context_line":""},{"line_number":6527,"context_line":"@pick_context_manager_writer"},{"line_number":6528,"context_line":"def service_uuids_online_data_migration(context, max_count):"},{"line_number":6529,"context_line":"    from nova.objects import service"},{"line_number":6530,"context_line":""},{"line_number":6531,"context_line":"    count_all \u003d 0"},{"line_number":6532,"context_line":"    count_hit \u003d 0"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_46c28a35","line":6529,"in_reply_to":"3f044301_29c5183d","updated":"2017-05-04 16:47:42.000000000","message":"When I wrote this, this is how the online data migrations were done for adding a uuid field to the compute_nodes and aggregates table so I\u0027m following suit.","commit_id":"841f1c2b6954bec9a52e4696a8e6947560256245"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"94843e6805bd3fd1a6f07121e96412ed6e21af6f","unresolved":false,"context_lines":[{"line_number":6526,"context_line":""},{"line_number":6527,"context_line":"@pick_context_manager_writer"},{"line_number":6528,"context_line":"def service_uuids_online_data_migration(context, max_count):"},{"line_number":6529,"context_line":"    from nova.objects import service"},{"line_number":6530,"context_line":""},{"line_number":6531,"context_line":"    count_all \u003d 0"},{"line_number":6532,"context_line":"    count_hit \u003d 0"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_26953ee5","line":6529,"in_reply_to":"3f044301_46c28a35","updated":"2017-05-04 16:55:15.000000000","message":"I prefer them in the object file too, but we\u0027re all over the map here and not a big deal to beg a change, IMHO.","commit_id":"841f1c2b6954bec9a52e4696a8e6947560256245"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"94843e6805bd3fd1a6f07121e96412ed6e21af6f","unresolved":false,"context_lines":[{"line_number":6538,"context_line":"        service_obj \u003d service.Service._from_db_object("},{"line_number":6539,"context_line":"            context, service.Service(), db_service)"},{"line_number":6540,"context_line":"        if \u0027uuid\u0027 in service_obj:"},{"line_number":6541,"context_line":"            count_hit +\u003d 1"},{"line_number":6542,"context_line":"    return count_all, count_hit"},{"line_number":6543,"context_line":""},{"line_number":6544,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_06c362ef","line":6541,"updated":"2017-05-04 16:55:15.000000000","message":"Note, I thought this would end up with us always returning nonzero for this count, but it won\u0027t because we\u0027re only iterating records that started with uuid\u003d\u003dNULL so I think we\u0027re fine here.","commit_id":"841f1c2b6954bec9a52e4696a8e6947560256245"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d08ed6f368d99671b7bd5556cea928c82d1bc7ac","unresolved":false,"context_lines":[{"line_number":6538,"context_line":"        service_obj \u003d service.Service._from_db_object("},{"line_number":6539,"context_line":"            context, service.Service(), db_service)"},{"line_number":6540,"context_line":"        if \u0027uuid\u0027 in service_obj:"},{"line_number":6541,"context_line":"            count_hit +\u003d 1"},{"line_number":6542,"context_line":"    return count_all, count_hit"},{"line_number":6543,"context_line":""},{"line_number":6544,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_89d9c584","line":6541,"in_reply_to":"3f044301_06c362ef","updated":"2017-05-04 17:03:46.000000000","message":"Yeah this was copied from compute nodes or aggregates and confused me when I first looked at it too, but you\u0027re right about the up-front filtering.","commit_id":"841f1c2b6954bec9a52e4696a8e6947560256245"}]}