)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"56b40a5d62762393721da0c20b8d6aae28206fc8","unresolved":false,"context_lines":[{"line_number":2106,"context_line":"                network_info.wait(do_raise\u003dFalse)"},{"line_number":2107,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2108,"context_line":"                    reason\u003de.format_message())"},{"line_number":2109,"context_line":"\texcept cinder_exception.OverLimit as e:"},{"line_number":2110,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2111,"context_line":"                    reason\u003de.message)"},{"line_number":2112,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_707cb51e","line":2109,"range":{"start_line":2109,"start_character":0,"end_line":2109,"end_character":1},"updated":"2017-04-10 06:29:14.000000000","message":"Mixed indent","commit_id":"cd53edbfc3cd0ade00aaaf044b224b984e006915"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2e0f73accb1e4464ecb6598865d82b8645faa599","unresolved":false,"context_lines":[{"line_number":2099,"context_line":"                if network_info is not None:"},{"line_number":2100,"context_line":"                    network_info.wait(do_raise\u003dFalse)"},{"line_number":2101,"context_line":"        except (exception.UnexpectedTaskStateError,"},{"line_number":2102,"context_line":"                exception.VolumeLimitExceeded,"},{"line_number":2103,"context_line":"                exception.InvalidBDM) as e:"},{"line_number":2104,"context_line":"            # Make sure the async call finishes"},{"line_number":2105,"context_line":"            if network_info is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_9e2efc8f","line":2102,"range":{"start_line":2102,"start_character":26,"end_line":2102,"end_character":45},"updated":"2017-04-11 09:57:07.000000000","message":"I am curious why this is not good enough here.","commit_id":"93d2b868aeb0e733fb1de5efd76f910bbfeedf0d"},{"author":{"_account_id":24131,"name":"Abhishek Sharma M","email":"abmsharm@in.ibm.com","username":"abhi.sharma"},"change_message_id":"72db5fc7ce8a74ec966bb711830d7056f7ec9b08","unresolved":false,"context_lines":[{"line_number":2099,"context_line":"                if network_info is not None:"},{"line_number":2100,"context_line":"                    network_info.wait(do_raise\u003dFalse)"},{"line_number":2101,"context_line":"        except (exception.UnexpectedTaskStateError,"},{"line_number":2102,"context_line":"                exception.VolumeLimitExceeded,"},{"line_number":2103,"context_line":"                exception.InvalidBDM) as e:"},{"line_number":2104,"context_line":"            # Make sure the async call finishes"},{"line_number":2105,"context_line":"            if network_info is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_fe4508b5","line":2102,"range":{"start_line":2102,"start_character":26,"end_line":2102,"end_character":45},"in_reply_to":"bff0334d_9e2efc8f","updated":"2017-04-23 08:39:41.000000000","message":"VolumeLimitExceeded exception covers only \u0027volumes\u0027 quota. i.e., when we have exceeded maximum number of volumes per project. For the other two cinder related quotas (\u0027gigabytes\u0027 and \u0027per_volume_gigabytes\u0027) we need to catch other exceptions. \nOverLimit exception covers all the above 3 exceptions with respective error messages.","commit_id":"93d2b868aeb0e733fb1de5efd76f910bbfeedf0d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2e0f73accb1e4464ecb6598865d82b8645faa599","unresolved":false,"context_lines":[{"line_number":2106,"context_line":"                network_info.wait(do_raise\u003dFalse)"},{"line_number":2107,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2108,"context_line":"                    reason\u003de.format_message())"},{"line_number":2109,"context_line":"        except cinder_exception.OverLimit as e:"},{"line_number":2110,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2111,"context_line":"                    reason\u003de.message)"},{"line_number":2112,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_5b164657","line":2109,"updated":"2017-04-11 09:57:07.000000000","message":"I wouldn\u0027t expect to see this exception here, I would expect OverQuota exception instead, due to this code:\nhttps://github.com/openstack/nova/blob/5a6d4e089dca2515c0f7e083a8b903ac7a166773/nova/volume/cinder.py#L202\n\nMost of the time, that would then get converted to exception. VolumeLimitExceeded by the time it gets up here:\nhttps://github.com/openstack/nova/blob/3092d2adcb6bab0bf39b01ea0561ec7e6a3990fd/nova/compute/manager.py#L1585\n\nDo you have a log from when you saw the problem?","commit_id":"93d2b868aeb0e733fb1de5efd76f910bbfeedf0d"},{"author":{"_account_id":24131,"name":"Abhishek Sharma M","email":"abmsharm@in.ibm.com","username":"abhi.sharma"},"change_message_id":"72db5fc7ce8a74ec966bb711830d7056f7ec9b08","unresolved":false,"context_lines":[{"line_number":2106,"context_line":"                network_info.wait(do_raise\u003dFalse)"},{"line_number":2107,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2108,"context_line":"                    reason\u003de.format_message())"},{"line_number":2109,"context_line":"        except cinder_exception.OverLimit as e:"},{"line_number":2110,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2111,"context_line":"                    reason\u003de.message)"},{"line_number":2112,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_fe8f48ca","line":2109,"in_reply_to":"bff0334d_5b164657","updated":"2017-04-23 08:39:41.000000000","message":"at https://github.com/openstack/nova/blob/5a6d4e089dca2515c0f7e083a8b903ac7a166773/nova/volume/cinder.py#L202, after catching the OverLimit exception, we are raising OverQuota exception with overs\u003d\u0027volumes\u0027.\nBut here the overs could have been volumes, gigabytes or per_volume_gigabytes. In each case there would be different error messages specific to the quota exceeded","commit_id":"93d2b868aeb0e733fb1de5efd76f910bbfeedf0d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b18c0a91178153356c76beba15bd1fe9d950fcd9","unresolved":false,"context_lines":[{"line_number":2099,"context_line":"                if network_info is not None:"},{"line_number":2100,"context_line":"                    network_info.wait(do_raise\u003dFalse)"},{"line_number":2101,"context_line":"        except (exception.UnexpectedTaskStateError,"},{"line_number":2102,"context_line":"                exception.VolumeLimitExceeded,"},{"line_number":2103,"context_line":"                exception.InvalidBDM) as e:"},{"line_number":2104,"context_line":"            # Make sure the async call finishes"},{"line_number":2105,"context_line":"            if network_info is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_3a767fda","line":2102,"updated":"2017-04-24 09:21:08.000000000","message":"But from my reading of the code, I would except the error to have been converted to a VolumeLimitExceeded exception by here.\n\nSo I don\u0027t think the code you added below is reachable.\n\nI could be reading this all wrongly, what we really need here is a stack trace.","commit_id":"bb2c33078a3cd57c426ec97a12b0f0bb820b7265"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e1aa6cb088c541d172cd6746f7d8e0b071a819ee","unresolved":false,"context_lines":[{"line_number":2110,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2111,"context_line":"                    reason\u003de.message)"},{"line_number":2112,"context_line":"        except Exception:"},{"line_number":2113,"context_line":"            LOG.exception(_LE(\u0027Failure prepping block device\u0027),"},{"line_number":2114,"context_line":"                    instance\u003dinstance)"},{"line_number":2115,"context_line":"            # Make sure the async call finishes"},{"line_number":2116,"context_line":"            if network_info is not None:"},{"line_number":2117,"context_line":"                network_info.wait(do_raise\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_af7114e3","line":2114,"range":{"start_line":2113,"start_character":0,"end_line":2114,"end_character":38},"updated":"2017-04-24 23:22:28.000000000","message":"Maybe John wants to see the detail of Exception here by adding it into the log like\n\n except Exception as e:\n     LOG.exception(_LE(\u0027Failure prepping block device (%s)\u0027), e,\n             instance\u003dinstance)\n\nThat could be useful for our future when facing the similar problem.","commit_id":"bb2c33078a3cd57c426ec97a12b0f0bb820b7265"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e3da2e86071fdbedd3f37603e6f2402b1e6f7953","unresolved":false,"context_lines":[{"line_number":2108,"context_line":"                network_info.wait(do_raise\u003dFalse)"},{"line_number":2109,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2110,"context_line":"                    reason\u003de.format_message())"},{"line_number":2111,"context_line":"\texcept cinder_exception.OverLimit as e:"},{"line_number":2112,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2113,"context_line":"                    reason\u003de.message)"},{"line_number":2114,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_d3a71cbd","line":2111,"updated":"2017-04-26 21:31:20.000000000","message":"you need to use spaces instead of tabs for passing the pep8 check..","commit_id":"b5a1af05948b342edc7ce5f4b574f6a0cf5af598"}]}