)]}'
{"api-ref/source/parameters.yaml":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e5467ebd3c6179df495362131e9f982445e06724","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    .. note:: The URL returned may not be accessible to users and should not"},{"line_number":8,"context_line":"      be relied upon. Use microversion 2.43 or simply parse the image ID out"},{"line_number":9,"context_line":"      of the URL in the Location response header."},{"line_number":10,"context_line":"  in: header"},{"line_number":11,"context_line":"  required: true"},{"line_number":12,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7ffa3b31_c076da70","line":9,"updated":"2017-04-21 11:42:18.000000000","message":"The create_image returns a URL pointed to the glance. The create_backup returns a URL pointed to the nova image proxies API. We better to note that? The mess is the nova image api already deprecated. But the create_backup still returned it. should we change that? but yeah...the glance url may not works also...","commit_id":"03917c2603dca3b1a937ff03fb647385dcd773a3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"934fa129624e176322f2a254fd94f13af10978a3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    .. note:: The URL returned may not be accessible to users and should not"},{"line_number":8,"context_line":"      be relied upon. Use microversion 2.43 or simply parse the image ID out"},{"line_number":9,"context_line":"      of the URL in the Location response header."},{"line_number":10,"context_line":"  in: header"},{"line_number":11,"context_line":"  required: true"},{"line_number":12,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5ff73747_c6c8f875","line":9,"in_reply_to":"7ffa3b31_37c25f5a","updated":"2017-04-22 00:56:09.000000000","message":"yea, maybe worth a note to say that please strip the image ID off the URL in the old microversion.","commit_id":"03917c2603dca3b1a937ff03fb647385dcd773a3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e3e17afee1c182e65a1fc76986b82a8c33713c07","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    .. note:: The URL returned may not be accessible to users and should not"},{"line_number":8,"context_line":"      be relied upon. Use microversion 2.43 or simply parse the image ID out"},{"line_number":9,"context_line":"      of the URL in the Location response header."},{"line_number":10,"context_line":"  in: header"},{"line_number":11,"context_line":"  required: true"},{"line_number":12,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7ffa3b31_37c25f5a","line":9,"in_reply_to":"7ffa3b31_c076da70","updated":"2017-04-21 15:48:01.000000000","message":"I don\u0027t think we need to get into that level of detail of the internals of how this works, and is broken. The point is you get a Location header back with an unusable URL and clients are already just stripping the image ID off the URL and using it directly with the image API (or compute proxy to the image API).","commit_id":"03917c2603dca3b1a937ff03fb647385dcd773a3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ebb209e2ed29d495542384197db505d3da0ae4e4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  in: header"},{"line_number":11,"context_line":"  required: true"},{"line_number":12,"context_line":"  type: string"},{"line_number":13,"context_line":"  max_version: 2.42"},{"line_number":14,"context_line":"tag_location:"},{"line_number":15,"context_line":"  description: |"},{"line_number":16,"context_line":"    The location of the tag. It\u0027s individual tag URL which can be used for"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5ff73747_8edc3947","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":19},"updated":"2017-04-24 06:25:26.000000000","message":"this is shown as \"Deprecated in version 2.42\" [1] which looks confusing.\n\"Available till version 2.42\"\nvs\n\"is this deprecated in 2.42 ?\" \"this is not removed only deprecated from 2.42 ?\" \n\n..1 http://docs-draft.openstack.org/43/455443/4/check/gate-nova-api-ref/37fc907//api-ref/build/html/?expanded\u003dcreate-server-back-up-createbackup-action-detail\n\nbut that is same for all and can be clearup on os_api_ref (not specific to this patch). \n\nhttps://github.com/openstack/os-api-ref/blob/ac2ef89c6408577a5bbdc42c89c49776936b9b1e/os_api_ref/__init__.py#L446","commit_id":"37ae1c7385f31b53ca0bd0e27e4f7d82c4f95bbe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0a3667a4f89dcef1559ae46201089ee8e2188636","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  in: header"},{"line_number":11,"context_line":"  required: true"},{"line_number":12,"context_line":"  type: string"},{"line_number":13,"context_line":"  max_version: 2.42"},{"line_number":14,"context_line":"tag_location:"},{"line_number":15,"context_line":"  description: |"},{"line_number":16,"context_line":"    The location of the tag. It\u0027s individual tag URL which can be used for"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5ff73747_aecb751c","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":19},"in_reply_to":"5ff73747_8edc3947","updated":"2017-04-24 06:42:08.000000000","message":"https://review.openstack.org/#/c/459172/2","commit_id":"37ae1c7385f31b53ca0bd0e27e4f7d82c4f95bbe"}],"api-ref/source/servers-actions.inc":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ebb209e2ed29d495542384197db505d3da0ae4e4","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"  - Location: image_location"},{"line_number":254,"context_line":"  - image_id: snapshot_id_resp_2_43"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Create Image (createImage Action)"},{"line_number":258,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"5ff73747_2b5cf749","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":0},"updated":"2017-04-24 06:25:26.000000000","message":"now we can show the response example also - https://review.openstack.org/#/c/455443/4/doc/api_samples/os-create-backup/v2.43/create-backup-resp.json","commit_id":"37ae1c7385f31b53ca0bd0e27e4f7d82c4f95bbe"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7def953f171040e6bf9cfeb6c674220f186957f3","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"  - Location: image_location"},{"line_number":254,"context_line":"  - image_id: snapshot_id_resp_2_43"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Create Image (createImage Action)"},{"line_number":258,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"5ff73747_e41cccc2","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":0},"in_reply_to":"5ff73747_2b5cf749","updated":"2017-04-25 13:38:38.000000000","message":"Good point, I can add that.","commit_id":"37ae1c7385f31b53ca0bd0e27e4f7d82c4f95bbe"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ebb209e2ed29d495542384197db505d3da0ae4e4","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"  - Location: image_location"},{"line_number":329,"context_line":"  - image_id: snapshot_id_resp_2_43"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"Lock Server (lock Action)"},{"line_number":333,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"5ff73747_eb55ef1e","line":330,"range":{"start_line":330,"start_character":0,"end_line":330,"end_character":0},"updated":"2017-04-24 06:25:26.000000000","message":"ditto.","commit_id":"37ae1c7385f31b53ca0bd0e27e4f7d82c4f95bbe"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7def953f171040e6bf9cfeb6c674220f186957f3","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"  - Location: image_location"},{"line_number":329,"context_line":"  - image_id: snapshot_id_resp_2_43"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"Lock Server (lock Action)"},{"line_number":333,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"5ff73747_c479d0fc","line":330,"range":{"start_line":330,"start_character":0,"end_line":330,"end_character":0},"in_reply_to":"5ff73747_eb55ef1e","updated":"2017-04-25 13:38:38.000000000","message":"Done","commit_id":"37ae1c7385f31b53ca0bd0e27e4f7d82c4f95bbe"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"1e53c6cd63192b9c173e09364de5c13d7c97672e","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"**Example Create Server Back Up (createBackup Action)**"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":".. literalinclude:: ../../doc/api_samples/os-create-backup/create-backup-req.json"},{"line_number":246,"context_line":"   :language: javascript"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Response"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"5ff73747_0f1c7110","line":245,"updated":"2017-04-25 13:53:47.000000000","message":"Maybe use v2.43\u0027s request sample file also. but it\u0027s fine, they are same.","commit_id":"5ffc2b4d5997a369faa9411da40961df72320059"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4b0f2c3483387c4782641817984ec3a4040dc0f8","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"**Example Create Server Back Up (createBackup Action)**"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":".. literalinclude:: ../../doc/api_samples/os-create-backup/create-backup-req.json"},{"line_number":246,"context_line":"   :language: javascript"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Response"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"5ff73747_0fca316c","line":245,"in_reply_to":"5ff73747_0f1c7110","updated":"2017-04-25 13:54:48.000000000","message":"Yeah I thought about that, but figured I\u0027d just leave it since they are the same as you point out.","commit_id":"5ffc2b4d5997a369faa9411da40961df72320059"}],"nova/api/openstack/compute/rest_api_version_history.rst":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"71a2dcfedd1c81c2c3bf6fefad29998fd5510378","unresolved":false,"context_lines":[{"line_number":486,"context_line":"2.43"},{"line_number":487,"context_line":"----"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":490,"context_line":"  The ``os-hosts`` API is deprecated as of the 2.43 microversion. Requests"},{"line_number":491,"context_line":"  made with microversion \u003e\u003d 2.43 will result in a 404 error. To list and show"},{"line_number":492,"context_line":"  host details, use the ``os-hypervisors`` API. To enable or disable a"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5ff73747_f2124058","line":489,"range":{"start_line":489,"start_character":0,"end_line":489,"end_character":12},"updated":"2017-04-25 19:40:49.000000000","message":"Maybe you need to remove..","commit_id":"dd7cf3631322468bb85c4e5d3119c8e0b0c39a15"}],"nova/tests/functional/api_sample_tests/test_create_backup.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"63c1dffc96ed9f6e730a2caf3700998cdb94cd5d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % self.uuid,"},{"line_number":38,"context_line":"                                 \u0027create-backup-req\u0027, {})"},{"line_number":39,"context_line":"        self.assertEqual(202, response.status_code)"},{"line_number":40,"context_line":"        if not self.microversion or ("},{"line_number":41,"context_line":"            (api_version_request.APIVersionRequest(self.microversion) \u003c"},{"line_number":42,"context_line":"             api_version_request.APIVersionRequest(\u00272.45\u0027))):"},{"line_number":43,"context_line":"            # we should have gotten a location header back"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_0d17d4ef","line":40,"updated":"2017-04-25 16:13:55.000000000","message":"I would rather optimize for delete here and make this method only function for 2.45. The below method should override anyway, right?\n\nMostly this gets really complicated to unwind on deletes or changes because of the embedded version checks.","commit_id":"b30c9152ac80e4b837e86c8e1d967a1017e76b91"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9046f57c71eda6becb879deb3f74b863d8a33fec","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % self.uuid,"},{"line_number":38,"context_line":"                                 \u0027create-backup-req\u0027, {})"},{"line_number":39,"context_line":"        self.assertEqual(202, response.status_code)"},{"line_number":40,"context_line":"        if not self.microversion or ("},{"line_number":41,"context_line":"            (api_version_request.APIVersionRequest(self.microversion) \u003c"},{"line_number":42,"context_line":"             api_version_request.APIVersionRequest(\u00272.45\u0027))):"},{"line_number":43,"context_line":"            # we should have gotten a location header back"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_4dc71c47","line":40,"in_reply_to":"5ff73747_0d17d4ef","updated":"2017-04-25 16:18:57.000000000","message":"I\u0027m not terribly worried about optimizing for delete when this is the 2.45 microversion which probably means years, if ever, that we delete this code and 2.45 is a minimum.\n\nI could probably just copy/paste this test and adjust as necessary rather than try to re-use it, which is what\u0027s causing the issue you don\u0027t like.","commit_id":"b30c9152ac80e4b837e86c8e1d967a1017e76b91"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"c539f8340cd04ab03669ae154063bddaf9dd14c1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                                 \u0027create-backup-req\u0027, {})"},{"line_number":38,"context_line":"        self.assertEqual(202, response.status_code)"},{"line_number":39,"context_line":"        # we should have gotten a location header back"},{"line_number":40,"context_line":"        self.assertIn(\u0027location\u0027, response.headers)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class CreateBackupSamplesJsonTestv2_45(CreateBackupSamplesJsonTest):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5ff73747_e82ed641","line":40,"updated":"2017-04-25 16:36:39.000000000","message":"We should also probably ensure the body is empty, just to make sure bits of the 2.45 code don\u0027t slip back into here by accident.","commit_id":"68260f2c04fc6a655cf73770b438ee2ae6e61e5d"}],"nova/tests/functional/api_sample_tests/test_servers.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"347a71bfeeacf5e2bef7545b0ed43d329b536959","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        uuid \u003d self._post_server()"},{"line_number":374,"context_line":"        self._test_server_action(uuid, \u0027createImage\u0027,"},{"line_number":375,"context_line":"                                 \u0027server-action-create-image\u0027,"},{"line_number":376,"context_line":"                                 {\u0027name\u0027: \u0027foo-image\u0027})"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"class ServersCreateImageJsonTestv2_43(ServersCreateImageJsonTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_8049f260","line":376,"updated":"2017-04-21 11:37:25.000000000","message":"We should ensure a header returned?","commit_id":"03917c2603dca3b1a937ff03fb647385dcd773a3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e3e17afee1c182e65a1fc76986b82a8c33713c07","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        uuid \u003d self._post_server()"},{"line_number":374,"context_line":"        self._test_server_action(uuid, \u0027createImage\u0027,"},{"line_number":375,"context_line":"                                 \u0027server-action-create-image\u0027,"},{"line_number":376,"context_line":"                                 {\u0027name\u0027: \u0027foo-image\u0027})"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"class ServersCreateImageJsonTestv2_43(ServersCreateImageJsonTest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_f7299736","line":376,"in_reply_to":"7ffa3b31_8049f260","updated":"2017-04-21 15:48:01.000000000","message":"I could but the unit tests also verify that.","commit_id":"03917c2603dca3b1a937ff03fb647385dcd773a3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"347a71bfeeacf5e2bef7545b0ed43d329b536959","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        uuid \u003d self._post_server()"},{"line_number":386,"context_line":"        self._test_server_action("},{"line_number":387,"context_line":"            uuid, \u0027createImage\u0027, \u0027server-action-create-image\u0027,"},{"line_number":388,"context_line":"            {\u0027name\u0027: \u0027foo-image\u0027}, \u0027server-action-create-image-resp\u0027)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"class ServerStartStopJsonTest(ServersSampleBase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_207c5e81","line":388,"updated":"2017-04-21 11:37:25.000000000","message":"And we should ensure there is no Location header returned?","commit_id":"03917c2603dca3b1a937ff03fb647385dcd773a3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e3e17afee1c182e65a1fc76986b82a8c33713c07","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        uuid \u003d self._post_server()"},{"line_number":386,"context_line":"        self._test_server_action("},{"line_number":387,"context_line":"            uuid, \u0027createImage\u0027, \u0027server-action-create-image\u0027,"},{"line_number":388,"context_line":"            {\u0027name\u0027: \u0027foo-image\u0027}, \u0027server-action-create-image-resp\u0027)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"class ServerStartStopJsonTest(ServersSampleBase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_971a5314","line":388,"in_reply_to":"7ffa3b31_207c5e81","updated":"2017-04-21 15:48:01.000000000","message":"Same, the unit tests already check this. But I can look into adding it.","commit_id":"03917c2603dca3b1a937ff03fb647385dcd773a3"}]}