)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"39241b245403e60a463eb4d40773db170407fba5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Transform instance.volume_attach.error notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id3a9e51e6256945e9b859ce62938e140580732e0"},{"line_number":10,"context_line":"Implements: bp versioned-notification-transformation-pike"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7ffa3b31_fdbc7cbc","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":57},"updated":"2017-04-17 05:11:13.000000000","message":"In https://blueprints.launchpad.net/nova/+spec/versioned-notification-transformation-newton\nit is said that:\n\n\u003e Now it is time to start transforming our existing legacy notifications to the new format.\n\nIMO, this patch is not transformation of existing legacy notifications but adding a new notification.\nSo another blueprint may be required.","commit_id":"da47a904fc22a13e3bdf95d26b3e184dc72ab01c"}],"doc/notification_samples/instance-volume_attach-error.json":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"658473493b8243586ff197f05b98b528aa94ce0c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\": \"instance.volume_attach.error\","},{"line_number":3,"context_line":"    \"payload\": {"},{"line_number":4,"context_line":"        \"nova_object.data\": {"}],"source_content_type":"application/json","patch_set":8,"id":"5ff73747_11472ebf","line":1,"updated":"2017-05-02 20:33:44.000000000","message":"Don\u0027t you need this registered like the attach samples?\n\nhttps://review.openstack.org/#/c/401992/49/nova/notifications/objects/instance.py@364","commit_id":"0492bdec97b9d2c29fba6f3777d3e906a44cd131"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12aed64f1c2fdab80fb34cbba5a195d427d362fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"event_type\": \"instance.volume_attach.error\","},{"line_number":3,"context_line":"    \"payload\": {"},{"line_number":4,"context_line":"        \"nova_object.data\": {"}],"source_content_type":"application/json","patch_set":8,"id":"5ff73747_f1a60254","line":1,"in_reply_to":"5ff73747_11472ebf","updated":"2017-05-02 20:44:43.000000000","message":"Done","commit_id":"0492bdec97b9d2c29fba6f3777d3e906a44cd131"}],"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f1517956dcb80208d40eb546dcea03fa24af1c3e","unresolved":false,"context_lines":[{"line_number":805,"context_line":"    @mock.patch(\u0027nova.volume.cinder.API.attach\u0027)"},{"line_number":806,"context_line":"    def _test_attach_volume_error(self, server, mock_attach):"},{"line_number":807,"context_line":"        def attach_volume(*args, **kwargs):"},{"line_number":808,"context_line":"            raise exception.InvalidHypervisorType(\"Fake block size is not \""},{"line_number":809,"context_line":"                                                  \"supported.\")"},{"line_number":810,"context_line":"        mock_attach.side_effect \u003d attach_volume"},{"line_number":811,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5ff73747_8ecf9928","line":808,"range":{"start_line":808,"start_character":28,"end_line":808,"end_character":49},"updated":"2017-05-02 19:56:22.000000000","message":"It would be better to raise an exception that can actually come out of the cinder.API.attach method, like exception.CinderConnectionFailed:\n\nhttps://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L181","commit_id":"0492bdec97b9d2c29fba6f3777d3e906a44cd131"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12aed64f1c2fdab80fb34cbba5a195d427d362fd","unresolved":false,"context_lines":[{"line_number":805,"context_line":"    @mock.patch(\u0027nova.volume.cinder.API.attach\u0027)"},{"line_number":806,"context_line":"    def _test_attach_volume_error(self, server, mock_attach):"},{"line_number":807,"context_line":"        def attach_volume(*args, **kwargs):"},{"line_number":808,"context_line":"            raise exception.InvalidHypervisorType(\"Fake block size is not \""},{"line_number":809,"context_line":"                                                  \"supported.\")"},{"line_number":810,"context_line":"        mock_attach.side_effect \u003d attach_volume"},{"line_number":811,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5ff73747_d161c613","line":808,"range":{"start_line":808,"start_character":28,"end_line":808,"end_character":49},"in_reply_to":"5ff73747_8ecf9928","updated":"2017-05-02 20:44:43.000000000","message":"Done","commit_id":"0492bdec97b9d2c29fba6f3777d3e906a44cd131"}]}