)]}'
{"nova/objects/fields.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae40d6f8b345a8c6d4dc2e3e459a72cd434dab3e","unresolved":false,"context_lines":[{"line_number":427,"context_line":"class ImageSignatureKeyType(BaseNovaEnum):"},{"line_number":428,"context_line":"    # Represents the possible keypair types used for image signing"},{"line_number":429,"context_line":"    ALL \u003d ("},{"line_number":430,"context_line":"        \u0027RSA-PSS\u0027, \u0027ECC_SECP521R1\u0027, \u0027ECC_SECT409R1\u0027, \u0027ECC_SECT409K1\u0027,"},{"line_number":431,"context_line":"        \u0027ECC_SECT571R1\u0027, \u0027ECC_SECP384R1\u0027, \u0027ECC_SECT571K1\u0027, \u0027DSA\u0027"},{"line_number":432,"context_line":"    )"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_84cc3f35","line":430,"updated":"2017-04-12 12:51:52.000000000","message":"I bet if you sorted this, the hash might be fine.","commit_id":"eb5ae29dc5c52339feb2b15891bb9d2ac992af62"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"ade77a4badd0bb1e6003b8c5b98abf51dce5f865","unresolved":false,"context_lines":[{"line_number":427,"context_line":"class ImageSignatureKeyType(BaseNovaEnum):"},{"line_number":428,"context_line":"    # Represents the possible keypair types used for image signing"},{"line_number":429,"context_line":"    ALL \u003d ("},{"line_number":430,"context_line":"        \u0027RSA-PSS\u0027, \u0027ECC_SECP521R1\u0027, \u0027ECC_SECT409R1\u0027, \u0027ECC_SECT409K1\u0027,"},{"line_number":431,"context_line":"        \u0027ECC_SECT571R1\u0027, \u0027ECC_SECP384R1\u0027, \u0027ECC_SECT571K1\u0027, \u0027DSA\u0027"},{"line_number":432,"context_line":"    )"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_1f92b857","line":430,"in_reply_to":"bff0334d_84cc3f35","updated":"2017-04-12 13:06:29.000000000","message":"Done","commit_id":"eb5ae29dc5c52339feb2b15891bb9d2ac992af62"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"20d0d13d9b1daa69c0528880e9251e7d0fde86e5","unresolved":false,"context_lines":[{"line_number":427,"context_line":"class ImageSignatureKeyType(BaseNovaEnum):"},{"line_number":428,"context_line":"    # Represents the possible keypair types used for image signing"},{"line_number":429,"context_line":"    ALL \u003d ("},{"line_number":430,"context_line":"        \u0027DSA\u0027, \u0027ECC_SECP384R1\u0027, \u0027ECC_SECP521R1\u0027, \u0027ECC_SECT409K1\u0027,"},{"line_number":431,"context_line":"        \u0027ECC_SECT409R1\u0027, \u0027ECC_SECT571K1\u0027, \u0027ECC_SECT571R1\u0027, \u0027RSA-PSS\u0027"},{"line_number":432,"context_line":"    )"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_bfa505a1","line":431,"range":{"start_line":430,"start_character":8,"end_line":431,"end_character":68},"updated":"2017-04-12 15:57:52.000000000","message":"I am on the fence about this change.  What is the likelihood that this list would get out of sync with the values that are defined in cursive?\n\nPerhaps this is safer anyway -- if a method were added to cursive to return *all* possible values instead of just the ones supported by the system, and then that list was changed to reflect a new signature key type, it would break the nova tests for everyone because of that hashing test in test_objects.py","commit_id":"0bfc83b410f2593bde075fd4596adc8c38a33468"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"61773958b8a3dfcc20907c132f9140f10f595dfd","unresolved":false,"context_lines":[{"line_number":427,"context_line":"class ImageSignatureKeyType(BaseNovaEnum):"},{"line_number":428,"context_line":"    # Represents the possible keypair types used for image signing"},{"line_number":429,"context_line":"    ALL \u003d ("},{"line_number":430,"context_line":"        \u0027DSA\u0027, \u0027ECC_SECP384R1\u0027, \u0027ECC_SECP521R1\u0027, \u0027ECC_SECT409K1\u0027,"},{"line_number":431,"context_line":"        \u0027ECC_SECT409R1\u0027, \u0027ECC_SECT571K1\u0027, \u0027ECC_SECT571R1\u0027, \u0027RSA-PSS\u0027"},{"line_number":432,"context_line":"    )"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_d048b65c","line":431,"range":{"start_line":430,"start_character":8,"end_line":431,"end_character":68},"in_reply_to":"bff0334d_a5e976e3","updated":"2017-04-12 17:05:44.000000000","message":"Yes, it does seem to me now that it\u0027s best if these are static values.  If the corresponding values in cursive are ever updated to something different, probably better to just manually update them here so that the test for the hash value for the object can be updated as well.","commit_id":"0bfc83b410f2593bde075fd4596adc8c38a33468"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"b525e3e33db838b5afabcb15cf71e2fc1ca68831","unresolved":false,"context_lines":[{"line_number":427,"context_line":"class ImageSignatureKeyType(BaseNovaEnum):"},{"line_number":428,"context_line":"    # Represents the possible keypair types used for image signing"},{"line_number":429,"context_line":"    ALL \u003d ("},{"line_number":430,"context_line":"        \u0027DSA\u0027, \u0027ECC_SECP384R1\u0027, \u0027ECC_SECP521R1\u0027, \u0027ECC_SECT409K1\u0027,"},{"line_number":431,"context_line":"        \u0027ECC_SECT409R1\u0027, \u0027ECC_SECT571K1\u0027, \u0027ECC_SECT571R1\u0027, \u0027RSA-PSS\u0027"},{"line_number":432,"context_line":"    )"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_a5e976e3","line":431,"range":{"start_line":430,"start_character":8,"end_line":431,"end_character":68},"in_reply_to":"bff0334d_bfa505a1","updated":"2017-04-12 16:45:16.000000000","message":"The reasoning behind this change is admittedly a bit confusing; unfortunately, pulling the key types from cursive is pretty much directly opposed to the way these image meta objects have to work in Nova (i.e. they have to be pretty static). \n\nWe can\u0027t pull the key-types in dynamically for the exact reason this bug demonstrates; different crypto backends support more or less of the listed ECC key-types.","commit_id":"0bfc83b410f2593bde075fd4596adc8c38a33468"}],"nova/objects/image_meta.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"132d57953cc00dd335c04812c387db3ad57c1754","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    # Version 1.16: WatchdogActionField supports \u0027disabled\u0027 enum."},{"line_number":168,"context_line":"    # Version 1.17: Add lan9118 as valid nic for hw_vif_model property for qemu"},{"line_number":169,"context_line":"    # Version 1.18: Pull signature properties from cursive library"},{"line_number":170,"context_line":"    # Version 1.19: Revert to fixed key types to resolve bug 1681946"},{"line_number":171,"context_line":"    VERSION \u003d \u00271.19\u0027"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_046a6f18","line":170,"updated":"2017-04-12 12:51:32.000000000","message":"I don\u0027t think we need to bump the min version on this, just update the hash in the test.","commit_id":"eb5ae29dc5c52339feb2b15891bb9d2ac992af62"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"ade77a4badd0bb1e6003b8c5b98abf51dce5f865","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    # Version 1.16: WatchdogActionField supports \u0027disabled\u0027 enum."},{"line_number":168,"context_line":"    # Version 1.17: Add lan9118 as valid nic for hw_vif_model property for qemu"},{"line_number":169,"context_line":"    # Version 1.18: Pull signature properties from cursive library"},{"line_number":170,"context_line":"    # Version 1.19: Revert to fixed key types to resolve bug 1681946"},{"line_number":171,"context_line":"    VERSION \u003d \u00271.19\u0027"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_bf8cec35","line":170,"in_reply_to":"bff0334d_046a6f18","updated":"2017-04-12 13:06:29.000000000","message":"Done","commit_id":"eb5ae29dc5c52339feb2b15891bb9d2ac992af62"}]}