)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c5893299eeca0471dc0be20279e97d704726a303","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-08 11:49:12 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"conf: Gather \u0027live_migration_scheme\u0027, \u0027live_migration_inbound_addr\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As a human, I want to be able to view the related options together so I"},{"line_number":10,"context_line":"can more easily understand what they do."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_8693144e","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":35},"updated":"2018-07-10 01:17:31.000000000","message":"live_migration_tunnelled?\n\nbecause live_migration_inbound_addr is related to live_migration_tunnelled, not live_migration_scheme.","commit_id":"4b768363caa998fdf54dd958eb3f7ec5eba406b8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"82970e70d3bf2b3c3a43f35152738d69f5954db0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-08 11:49:12 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"conf: Gather \u0027live_migration_scheme\u0027, \u0027live_migration_inbound_addr\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As a human, I want to be able to view the related options together so I"},{"line_number":10,"context_line":"can more easily understand what they do."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_b396af93","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":35},"in_reply_to":"5f7c97a3_8693144e","updated":"2018-10-02 15:11:14.000000000","message":"Sort of :) We\u0027ve got two competing sets of options:\n\n- live_migration_uri\n\nThis one is deprecated for the reasons described in https://bugs.launchpad.net/nova/+bug/1677913. One of the later patches in this series does some additional work to help us finally remove this.\n\n- live_migration_scheme\n- live_migration_inbound_addr\n\nThese are alternatives added to allow us to deprecate the live_migration_uri. They split out the \u0027live_migration_uri\u0027 value into multiple different values. Thus far, we have scheme and host handled. The follow up patch I referred to above adds configuration values to handle the userinfo, port and querystring part of the URL (we ignore fragment).\n\nBoth of these groups of options are related to the \u0027tunneled\u0027 option.","commit_id":"4b768363caa998fdf54dd958eb3f7ec5eba406b8"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"eab2594d8a600f2d3704cbc1b012b89acc7c89de","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- live_migration_scheme, live_migration_inbound_addr (newer)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Group the latter two together. Note that all options require"},{"line_number":16,"context_line":"\u0027live_migration_tunnelled\u0027 be enabled to have any effect."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I37ed4dae3fc3d16fe19c8ebcd7b1c2210459b96f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f79a3b5_36836d58","line":16,"range":{"start_line":16,"start_character":30,"end_line":16,"end_character":37},"updated":"2018-10-02 15:43:00.000000000","message":"disabled","commit_id":"ec3ef0ccd02852e8035dbf6905ade9e02dfefcf0"}],"nova/conf/libvirt.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"dd9459feadef7955933c5aa511658a4bee8dbdd1","unresolved":false,"context_lines":[{"line_number":267,"context_line":"* \u0027xen\u0027: \u0027xenmigr://%s/system\u0027"},{"line_number":268,"context_line":"* \u0027parallels\u0027: \u0027parallels+tcp://%s/system\u0027"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Related options:"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"* ``live_migration_inbound_addr``: If ``live_migration_inbound_addr`` value"},{"line_number":273,"context_line":"  is not None and ``live_migration_tunnelled`` is False, the ip/hostname"},{"line_number":274,"context_line":"  address of target compute node is used instead of ``live_migration_uri`` as"},{"line_number":275,"context_line":"  the uri for live migration."},{"line_number":276,"context_line":"* ``live_migration_scheme``: If ``live_migration_uri`` is not set, the scheme"},{"line_number":277,"context_line":"  used for live migration is taken from ``live_migration_scheme`` instead."},{"line_number":278,"context_line":"\"\"\"),"},{"line_number":279,"context_line":"    cfg.StrOpt(\u0027live_migration_scheme\u0027,"},{"line_number":280,"context_line":"               help\u003d\"\"\""},{"line_number":281,"context_line":"URI scheme used for live migration."}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_fdac17ef","line":278,"range":{"start_line":270,"start_character":0,"end_line":278,"end_character":5},"updated":"2018-09-18 12:34:44.000000000","message":"But now this seems harder to understand, I think the idea is you should usually just set live_migration_inbound_addr and leave the rest of these with their default values?","commit_id":"692f42e11e2ae2703858db68b6bdc17abfba5f53"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"001c82bca87db9fbd8f94bb325f037392b3efe1b","unresolved":false,"context_lines":[{"line_number":267,"context_line":"* \u0027xen\u0027: \u0027xenmigr://%s/system\u0027"},{"line_number":268,"context_line":"* \u0027parallels\u0027: \u0027parallels+tcp://%s/system\u0027"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Related options:"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"* ``live_migration_inbound_addr``: If ``live_migration_inbound_addr`` value"},{"line_number":273,"context_line":"  is not None and ``live_migration_tunnelled`` is False, the ip/hostname"},{"line_number":274,"context_line":"  address of target compute node is used instead of ``live_migration_uri`` as"},{"line_number":275,"context_line":"  the uri for live migration."},{"line_number":276,"context_line":"* ``live_migration_scheme``: If ``live_migration_uri`` is not set, the scheme"},{"line_number":277,"context_line":"  used for live migration is taken from ``live_migration_scheme`` instead."},{"line_number":278,"context_line":"\"\"\"),"},{"line_number":279,"context_line":"    cfg.StrOpt(\u0027live_migration_scheme\u0027,"},{"line_number":280,"context_line":"               help\u003d\"\"\""},{"line_number":281,"context_line":"URI scheme used for live migration."}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_93bb73bc","line":278,"range":{"start_line":270,"start_character":0,"end_line":278,"end_character":5},"in_reply_to":"3f79a3b5_5362bbae","updated":"2018-10-02 15:21:07.000000000","message":"OK, I think I see your thinking now.\n\nI have a hard time thinking we want to list the deprecated one first.\n\nI was expecting the most common one to change should go first, i.e. live_migration_inbound_addr, but maybe that just isn\u0027t true.\n\ni.e. should we move the deprecated one last instead?","commit_id":"692f42e11e2ae2703858db68b6bdc17abfba5f53"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f9e48abaf5aeb3a520f060df98074f589277fb00","unresolved":false,"context_lines":[{"line_number":267,"context_line":"* \u0027xen\u0027: \u0027xenmigr://%s/system\u0027"},{"line_number":268,"context_line":"* \u0027parallels\u0027: \u0027parallels+tcp://%s/system\u0027"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Related options:"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"* ``live_migration_inbound_addr``: If ``live_migration_inbound_addr`` value"},{"line_number":273,"context_line":"  is not None and ``live_migration_tunnelled`` is False, the ip/hostname"},{"line_number":274,"context_line":"  address of target compute node is used instead of ``live_migration_uri`` as"},{"line_number":275,"context_line":"  the uri for live migration."},{"line_number":276,"context_line":"* ``live_migration_scheme``: If ``live_migration_uri`` is not set, the scheme"},{"line_number":277,"context_line":"  used for live migration is taken from ``live_migration_scheme`` instead."},{"line_number":278,"context_line":"\"\"\"),"},{"line_number":279,"context_line":"    cfg.StrOpt(\u0027live_migration_scheme\u0027,"},{"line_number":280,"context_line":"               help\u003d\"\"\""},{"line_number":281,"context_line":"URI scheme used for live migration."}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_93fdb30a","line":278,"range":{"start_line":270,"start_character":0,"end_line":278,"end_character":5},"in_reply_to":"3f79a3b5_93bb73bc","updated":"2018-10-02 15:35:54.000000000","message":"\u003e OK, I think I see your thinking now.\n \u003e \n \u003e I have a hard time thinking we want to list the deprecated one\n \u003e first.\n\nAgreed. I\u0027ve moved this now.\n\n \u003e I was expecting the most common one to change should go first, i.e.\n \u003e live_migration_inbound_addr, but maybe that just isn\u0027t true.\n\nI was putting them in URI order. I still think this makes sense, personally. As discussed on IRC, I\u0027m going to mark all of these as advanced since none of them need to be tweaked in most cases.\n\n \u003e i.e. should we move the deprecated one last instead?","commit_id":"692f42e11e2ae2703858db68b6bdc17abfba5f53"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"82970e70d3bf2b3c3a43f35152738d69f5954db0","unresolved":false,"context_lines":[{"line_number":267,"context_line":"* \u0027xen\u0027: \u0027xenmigr://%s/system\u0027"},{"line_number":268,"context_line":"* \u0027parallels\u0027: \u0027parallels+tcp://%s/system\u0027"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Related options:"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"* ``live_migration_inbound_addr``: If ``live_migration_inbound_addr`` value"},{"line_number":273,"context_line":"  is not None and ``live_migration_tunnelled`` is False, the ip/hostname"},{"line_number":274,"context_line":"  address of target compute node is used instead of ``live_migration_uri`` as"},{"line_number":275,"context_line":"  the uri for live migration."},{"line_number":276,"context_line":"* ``live_migration_scheme``: If ``live_migration_uri`` is not set, the scheme"},{"line_number":277,"context_line":"  used for live migration is taken from ``live_migration_scheme`` instead."},{"line_number":278,"context_line":"\"\"\"),"},{"line_number":279,"context_line":"    cfg.StrOpt(\u0027live_migration_scheme\u0027,"},{"line_number":280,"context_line":"               help\u003d\"\"\""},{"line_number":281,"context_line":"URI scheme used for live migration."}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_5362bbae","line":278,"range":{"start_line":270,"start_character":0,"end_line":278,"end_character":5},"in_reply_to":"3f79a3b5_fdac17ef","updated":"2018-10-02 15:11:14.000000000","message":"Nope. We\u0027ve got two competing sets of options here:\n\n- live_migration_uri\n\nThis one is deprecated for the reasons described in https://bugs.launchpad.net/nova/+bug/1677913. One of the later patches in this series does some additional work to help us finally remove this.\n\n- live_migration_scheme\n- live_migration_inbound_addr\n\nThese are alternatives added to allow us to deprecate the live_migration_uri. They split out the \u0027live_migration_uri\u0027 value into multiple different values. Thus far, we have scheme and host handled. The follow up patch I referred to above adds configuration values to handle the userinfo, port and querystring part of the URL (we ignore fragment).\n\nAll I\u0027m doing here is grouping the latter set together to make it easier to parse, which becomes especially important as we add more options.","commit_id":"692f42e11e2ae2703858db68b6bdc17abfba5f53"}]}