)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"845e2b54058a2956572ef44e728c6eef2108da70","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add Cinder v3 detach to local_cleanup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the new Cindr v3 detach call to the delete and"},{"line_number":10,"context_line":"detach at shelve offload cases by adding the necessary changes"},{"line_number":11,"context_line":"to the _local_cleanup_bdm_volumes function."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially Implements: blueprint cinder-new-attach-apis"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7ffa3b31_a0e404e1","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":29},"updated":"2017-04-20 18:33:58.000000000","message":"It\u0027s not just shelve offload but also when the compute host is down, but that\u0027s a nit.","commit_id":"5127e9931b1f840d971106611cd852d4e0212789"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"845e2b54058a2956572ef44e728c6eef2108da70","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds the new Cindr v3 detach call to the delete and"},{"line_number":10,"context_line":"detach at shelve offload cases by adding the necessary changes"},{"line_number":11,"context_line":"to the _local_cleanup_bdm_volumes function."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially Implements: blueprint cinder-new-attach-apis"},{"line_number":14,"context_line":"Change-Id: I84765f0156a75dead2b2621ff17c26ab00d9041e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7ffa3b31_c0e390d8","line":12,"updated":"2017-04-20 18:33:58.000000000","message":"Add:\n\nDepends-On: I91b9a60268354ffbed86b1e7d173906cfd7b97bd","commit_id":"5127e9931b1f840d971106611cd852d4e0212789"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0a64f01108c63e33214bfd59a2cf2c89cfafd1e6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"_local_cleanup_bdm_volumes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This method is called (eventually) by:"},{"line_number":13,"context_line":" - soft_delete [instance]"},{"line_number":14,"context_line":" - force_delete [instance]"},{"line_number":15,"context_line":" - delete [instance]"},{"line_number":16,"context_line":" - detach_volume [on an shelved/offloaded instance]"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"A new unit test is also added to test this."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f044301_20f08667","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":20},"updated":"2017-05-04 16:07:33.000000000","message":"This is a bit confusing. Yes it could be called from those but only if the compute host that the instance is running on is down. I think it\u0027s probably just simpler to say something like, \"A delete that is local to the API is when either the compute host that the instance is running on is down or the instance is shelved-offloaded. In either case the API can\u0027t perform an RPC cast to the compute service to delete the instance so it\u0027s deleted in the API service instead.\"","commit_id":"39c4b3f3fee5ac50188219e3f0fa144506bf63ee"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"81618eb7b7708978c5a9533763e02060fa4b90da","unresolved":false,"context_lines":[{"line_number":10,"context_line":"_local_cleanup_bdm_volumes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This method is called (eventually) by:"},{"line_number":13,"context_line":" - soft_delete [instance]"},{"line_number":14,"context_line":" - force_delete [instance]"},{"line_number":15,"context_line":" - delete [instance]"},{"line_number":16,"context_line":" - detach_volume [on an shelved/offloaded instance]"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"A new unit test is also added to test this."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f044301_63ab381d","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":20},"in_reply_to":"3f044301_20f08667","updated":"2017-05-04 16:33:29.000000000","message":"+1","commit_id":"39c4b3f3fee5ac50188219e3f0fa144506bf63ee"}],"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"845e2b54058a2956572ef44e728c6eef2108da70","unresolved":false,"context_lines":[{"line_number":2158,"context_line":"        for bdm in bdms:"},{"line_number":2159,"context_line":"            if bdm.is_volume:"},{"line_number":2160,"context_line":"                try:"},{"line_number":2161,"context_line":"                    if bdm.attachment_id:"},{"line_number":2162,"context_line":"                        self.volume_api.attachment_delete(context,"},{"line_number":2163,"context_line":"                                                          bdm.attachment_id)"},{"line_number":2164,"context_line":"                    else:"},{"line_number":2165,"context_line":"                        connector \u003d self._get_stashed_volume_connector("},{"line_number":2166,"context_line":"                            bdm, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_e007ac81","line":2163,"range":{"start_line":2161,"start_character":20,"end_line":2163,"end_character":76},"updated":"2017-04-20 18:33:58.000000000","message":"We need a test for when this is true.","commit_id":"5127e9931b1f840d971106611cd852d4e0212789"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"25f965c2fdc83e5484eeec5c5d8a9b113d732789","unresolved":false,"context_lines":[{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"    @mock.patch.object(objects.BlockDeviceMapping, \u0027destroy\u0027)"},{"line_number":1205,"context_line":"    def test_local_cleanup_bdm_volumes_with_attach_id(self, mock_destroy):"},{"line_number":1206,"context_line":"        \"\"\"Tests that we call volume_api.attachment delete when we have an"},{"line_number":1207,"context_line":"        attachment_id in the bdm."},{"line_number":1208,"context_line":"        \"\"\""},{"line_number":1209,"context_line":"        instance \u003d self._create_instance_obj()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_59c7a665","line":1206,"range":{"start_line":1206,"start_character":41,"end_line":1206,"end_character":58},"updated":"2017-04-27 04:50:05.000000000","message":"attachment_delete","commit_id":"670dfba138779ef6ec9c2f4aea6dc421d474caf6"}]}