)]}'
{"nova/compute/api.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"73381577f06475d3842525bd73fd859259fea95d","unresolved":false,"context_lines":[{"line_number":1834,"context_line":"                     instance\u003dinstance)"},{"line_number":1835,"context_line":"            return"},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"        # If there is an instance.host (or the instance is not"},{"line_number":1838,"context_line":"        # shelved-offloaded), the instance has been scheduled and"},{"line_number":1839,"context_line":"        # sent to a cell/compute which means it was pulled from the"},{"line_number":1840,"context_line":"        # cell db."},{"line_number":1841,"context_line":"        # Normal delete should be attempted."}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_e0ef48ae","line":1838,"range":{"start_line":1837,"start_character":10,"end_line":1838,"end_character":28},"updated":"2017-04-14 14:56:17.000000000","message":"This doesn\u0027t gel with the condition below, which my college logic course tells me should be translated thusly:\n\n if not (instance.host or vm_state \u003d\u003d SHELVED_OFFLOADED)\n \u003d\u003e\n if (not instance.host) and (vm_state !\u003d SHELVED_OFFLOADED)\n \u003d\u003e\n \"If there is *NO* instance.host *AND* the instance is *NOT* shelved-offloaded.\"\n\nI\u0027m not clear whether \"Normal delete should be attempted\" is referring to what\u0027s happening within the \u0027if\u0027 statement, but it kinda seems to be.  In which case the original statement was backwards in _both_ clauses.\n\nIn either case (unless I\u0027m missing something, which is likely) the edit wouldn\u0027t be correct.","commit_id":"97302b4fc73d98fa2582fcdb1b75996aeb25d588"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c20f9e762a574e1521f225985c1ac437e51594e8","unresolved":false,"context_lines":[{"line_number":1834,"context_line":"                     instance\u003dinstance)"},{"line_number":1835,"context_line":"            return"},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"        # If there is an instance.host (or the instance is not"},{"line_number":1838,"context_line":"        # shelved-offloaded), the instance has been scheduled and"},{"line_number":1839,"context_line":"        # sent to a cell/compute which means it was pulled from the"},{"line_number":1840,"context_line":"        # cell db."},{"line_number":1841,"context_line":"        # Normal delete should be attempted."}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_07a9237a","line":1838,"range":{"start_line":1837,"start_character":10,"end_line":1838,"end_character":28},"in_reply_to":"7ffa3b31_e0ef48ae","updated":"2017-04-15 00:47:26.000000000","message":"Yeah I think you\u0027re right, and I think this was correct to begin with, and I was just confusing myself with the negative logic. Also, shame on me because I actually wrote the part in parentheses for shelved offloaded.","commit_id":"97302b4fc73d98fa2582fcdb1b75996aeb25d588"}]}