)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"eac03fa5da523813de77a9e4072c5a0821eb1f72","unresolved":false,"context_lines":[{"line_number":3949,"context_line":"                    self.volume_api.attachment_delete(context,"},{"line_number":3950,"context_line":"                                                      bdm.attachment_id)"},{"line_number":3951,"context_line":"                    if keep_reserved:"},{"line_number":3952,"context_line":"                        self.volume_api.attachment_create(context,"},{"line_number":3953,"context_line":"                                                          bdm.volume_id,"},{"line_number":3954,"context_line":"                                                          instance.uuid)"},{"line_number":3955,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_0dfbf678","line":3952,"updated":"2017-04-20 16:27:31.000000000","message":"We don\u0027t want to create attachments in a method called _terminate_volume_connections. We\u0027ll need to handle this differently, but _terminate_volume_connections should just terminate connections (or delete the attachment which terminates the connection).","commit_id":"9ba099e4eadbedb605684a60f79fe974945e4528"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a96b2c65b21aca495786b66250683fa05baaa174","unresolved":false,"context_lines":[{"line_number":5573,"context_line":"        # because the instance is not running anymore on the current host"},{"line_number":5574,"context_line":"        attachment_id \u003d None"},{"line_number":5575,"context_line":"        if bdm.attachment_id:"},{"line_number":5576,"context_line":"            attachment_id \u003d self.volume_api.attachment_create("},{"line_number":5577,"context_line":"                context, bdm.volume_id, instance.uuid)"},{"line_number":5578,"context_line":"        self._terminate_volume_connections(context, instance, bdms)"},{"line_number":5579,"context_line":"        values \u003d {\u0027attachment_id\u0027: attachment_id}"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_8e59b05b","line":5576,"range":{"start_line":5576,"start_character":12,"end_line":5576,"end_character":25},"updated":"2017-05-16 10:56:13.000000000","message":"This is almost certainly the wrong place to create the attachment.\n\nThat needs to be done before we do the attach here:\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5291\n\n(i.e. driver.pre_live_migration)\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6718","commit_id":"cad0d2ef278b7cba9d3fce4563447bc1055e9875"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a96b2c65b21aca495786b66250683fa05baaa174","unresolved":false,"context_lines":[{"line_number":5575,"context_line":"        if bdm.attachment_id:"},{"line_number":5576,"context_line":"            attachment_id \u003d self.volume_api.attachment_create("},{"line_number":5577,"context_line":"                context, bdm.volume_id, instance.uuid)"},{"line_number":5578,"context_line":"        self._terminate_volume_connections(context, instance, bdms)"},{"line_number":5579,"context_line":"        values \u003d {\u0027attachment_id\u0027: attachment_id}"},{"line_number":5580,"context_line":"        bdm.update(values)"},{"line_number":5581,"context_line":"        bdm.save()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_ee3f14d4","line":5578,"updated":"2017-05-16 10:56:13.000000000","message":"Error handling isn\u0027t correct here, we could leave the attachment not recorded in the bdm, but I think we have a bigger issue here that trumps this problem.","commit_id":"cad0d2ef278b7cba9d3fce4563447bc1055e9875"}]}