)]}'
{"nova/api/openstack/compute/wsgi.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"997e0f4e18e1cdfa4ed62538a5896d6f9b42ee10","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    conf \u003d CONFIG_FILES[0]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    _setup_service(\u00270.0.0.0\u0027, NAME)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    return deploy.loadapp(\u0027config:%s\u0027 % conf, name\u003dNAME)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_9092eff5","line":73,"updated":"2017-04-17 17:17:51.000000000","message":"is there a reason to register this with 0.0.0.0? What about in a cluster env, wouldn\u0027t we want them all in agreement?\n\nAlso, what happens if there is an attempt to regress the service version?\n\nIf there is a failure here, should there be a default app that returns a reasonable 500 error?","commit_id":"c9707387317cdb8fb3d7eb84084c7b3d67bbcff9"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"103e9b17513c6fed13ed1f71ef2fcf8a5761e322","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    conf \u003d CONFIG_FILES[0]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    _setup_service(\u00270.0.0.0\u0027, NAME)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    return deploy.loadapp(\u0027config:%s\u0027 % conf, name\u003dNAME)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_abe33c05","line":73,"in_reply_to":"7ffa3b31_9092eff5","updated":"2017-04-17 17:36:15.000000000","message":"The choice of 0.0.0.0 is because I couldn\u0027t think of an alternative that makes any sense that preserves the concept of there being many: this makes them all in agreement and also have sane meaning. This value is the default value that the standalone nova-api would use from config: \u0027osapi_compute_listen\u0027 but I felt like using that config setting would not entirely make sense as we\u0027re not actually configuring the listening host here (that\u0027s all done in the WSGI server\u0027s config). At the same time: every single time any of multiple versions of the wsgi app process starts up, either on the current host or multiple hosts this code is going to run, so I thought perhaps it should be something that meant the same no matter what host it really was.\n\nHowever I don\u0027t understand enough what this stuff actually means (thus, in part, the WIP), so perhaps there is a better way.\n\nSo, while I remember the discussion of needing an app that returns a 500 under certain circumstances, I don\u0027t remember what those circumstances are. Is the issue here that we want to catch when someone accidentally adds an instance of osapi_compute that causes exception.ServiceTooOld because it is out of date? If that\u0027s the case I can add in the necessaries for that.\n\nAre we happy if, for example we have ten different nova-api servers, one of them is 500\u0027ing and the others are okay?","commit_id":"c9707387317cdb8fb3d7eb84084c7b3d67bbcff9"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d03ba85e005a1c588022c7472faf65da6caf158c","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    conf \u003d CONFIG_FILES[0]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    _setup_service(\u00270.0.0.0\u0027, NAME)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    return deploy.loadapp(\u0027config:%s\u0027 % conf, name\u003dNAME)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_595fef71","line":73,"in_reply_to":"7ffa3b31_abe33c05","updated":"2017-04-17 20:59:39.000000000","message":"I would expect that would allow something like HA proxy to take it out of rotation automatically.","commit_id":"c9707387317cdb8fb3d7eb84084c7b3d67bbcff9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"62ea39c23ef9168d3386d5c212a83a16f4ab4349","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    else:"},{"line_number":51,"context_line":"        try:"},{"line_number":52,"context_line":"            service_obj \u003d objects.Service(ctxt)"},{"line_number":53,"context_line":"            service_obj.host \u003d host"},{"line_number":54,"context_line":"            service_obj.binary \u003d \u0027nova-%s\u0027 % name"},{"line_number":55,"context_line":"            service_obj.topic \u003d None"},{"line_number":56,"context_line":"            service_obj.report_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_c670560b","line":53,"range":{"start_line":53,"start_character":31,"end_line":53,"end_character":35},"updated":"2017-04-20 13:19:20.000000000","message":"I think sneti had a patch up to switch this to use CONF.host\n\nIts not great, but I think that might be a better match to the \"use\" of this one.\n\nAs you say, the multiple worker thing is an issue, but at least CONF.host allows multiple hosts by default.","commit_id":"864b73eb97bd37f18bcbc374aa5852227bf3bb75"}]}