)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f67bd685e159e53cd7e71ee60cdce1fb0c8337c7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"checking of certificate validity during image signature"},{"line_number":12,"context_line":"verification, and (2) default_trusted_certificate_ids, which"},{"line_number":13,"context_line":"defines a deployment-wide default list of trusted certificates"},{"line_number":14,"context_line":"that should be used for certificate validation if not overriden by"},{"line_number":15,"context_line":"the user. Both options work with the verify_glance_signatures"},{"line_number":16,"context_line":"options defined in the glance configuration group."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5ff73747_1d764f3f","line":14,"updated":"2017-05-01 12:57:48.000000000","message":"s/overriden/overridden/ :)","commit_id":"5ea9a6a27e3782844542cc0087a00017b05feaff"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"90c44b70c2f497f5193ad6f4aa75000d34bc4d77","unresolved":false,"context_lines":[{"line_number":15,"context_line":"the user. Both options work with the verify_glance_signatures"},{"line_number":16,"context_line":"options defined in the glance configuration group."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DocImpact"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: If7b6e76519b0e37115a35b180b11959fe8a24582"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df140735_a63a3331","line":18,"updated":"2017-06-01 02:55:34.000000000","message":"This is unnecessary, it generates a bug report:\n\nhttps://bugs.launchpad.net/nova/+bug/1694735\n\nWe publish the config options automatically:\n\nhttps://docs.openstack.org/developer/nova/sample_config.html\n\nSo unless there is more to this, like the security guide needs to be updated in the openstack-manuals repo, I think we can invalidate that bug.","commit_id":"05bf7269414789496967d10270713253c9da1d6d"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"fad702174db0abb3f0ae08c853b6dab9fdb16258","unresolved":false,"context_lines":[{"line_number":15,"context_line":"the user. Both options work with the verify_glance_signatures"},{"line_number":16,"context_line":"options defined in the glance configuration group."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DocImpact"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: If7b6e76519b0e37115a35b180b11959fe8a24582"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df140735_f499ec6d","line":18,"in_reply_to":"df140735_a63a3331","updated":"2017-06-01 11:36:19.000000000","message":"Done","commit_id":"05bf7269414789496967d10270713253c9da1d6d"}],"nova/conf/glance.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"247536ff63b6cc6ea39dcf08028565712d26437f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"instance into an error state. This provides end users with stronger assurances"},{"line_number":80,"context_line":"of the integrity of the image data they are using to create servers."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Related options:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"* The options in the `key_manager` group, as the key_manager is used"},{"line_number":85,"context_line":"  for the signature validation."}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_bf5eba0f","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":15},"updated":"2017-04-18 15:03:48.000000000","message":"Since verify_glance_signatures is related to the two new options, should a couple bullet points be added here to mention the two new options as related but optional?  Or would that be too redundant?","commit_id":"f6ab51261c475c404218e1d50a4c48df6ccb1872"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"3ae468f9037adcb0f54d9830767670bae697be09","unresolved":false,"context_lines":[{"line_number":79,"context_line":"instance into an error state. This provides end users with stronger assurances"},{"line_number":80,"context_line":"of the integrity of the image data they are using to create servers."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Related options:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"* The options in the `key_manager` group, as the key_manager is used"},{"line_number":85,"context_line":"  for the signature validation."}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_bd0ebf2f","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":15},"in_reply_to":"7ffa3b31_1a7139aa","updated":"2017-04-18 16:54:51.000000000","message":"Maybe just something that says \"see enable_certificate_validation and default_trusted_certificate_ids below\". Honestly if I was looking through this file for info about the verify_glance_signatures opt I probably won\u0027t read about the other opts unless I knew they were related to verify_glance_signatures.","commit_id":"f6ab51261c475c404218e1d50a4c48df6ccb1872"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"51ebeba7d979aa4e974b7fd8692f817d4533173b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"instance into an error state. This provides end users with stronger assurances"},{"line_number":80,"context_line":"of the integrity of the image data they are using to create servers."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Related options:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"* The options in the `key_manager` group, as the key_manager is used"},{"line_number":85,"context_line":"  for the signature validation."}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_1a7139aa","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":15},"in_reply_to":"7ffa3b31_bf5eba0f","updated":"2017-04-18 16:29:40.000000000","message":"That feels redundant to me, given that these options are all grouped together. I\u0027m not opposed to it though.","commit_id":"f6ab51261c475c404218e1d50a4c48df6ccb1872"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"247536ff63b6cc6ea39dcf08028565712d26437f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"* The options in the `key_manager` group, as the key_manager is used"},{"line_number":85,"context_line":"  for the signature validation."},{"line_number":86,"context_line":"\"\"\"),"},{"line_number":87,"context_line":"    cfg.BoolOpt(\u0027enable_certificate_validation\u0027,"},{"line_number":88,"context_line":"        default\u003dFalse,"},{"line_number":89,"context_line":"        help\u003d\"\"\""},{"line_number":90,"context_line":"Enable certificate validation for image signature verification."}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_5ff3360b","line":87,"range":{"start_line":87,"start_character":17,"end_line":87,"end_character":46},"updated":"2017-04-18 15:03:48.000000000","message":"Are we wanting to deprecate this option?","commit_id":"f6ab51261c475c404218e1d50a4c48df6ccb1872"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"3ae468f9037adcb0f54d9830767670bae697be09","unresolved":false,"context_lines":[{"line_number":84,"context_line":"* The options in the `key_manager` group, as the key_manager is used"},{"line_number":85,"context_line":"  for the signature validation."},{"line_number":86,"context_line":"\"\"\"),"},{"line_number":87,"context_line":"    cfg.BoolOpt(\u0027enable_certificate_validation\u0027,"},{"line_number":88,"context_line":"        default\u003dFalse,"},{"line_number":89,"context_line":"        help\u003d\"\"\""},{"line_number":90,"context_line":"Enable certificate validation for image signature verification."}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_1d2373aa","line":87,"range":{"start_line":87,"start_character":17,"end_line":87,"end_character":46},"in_reply_to":"7ffa3b31_5a858159","updated":"2017-04-18 16:54:51.000000000","message":"I think we should deprecate it. It\u0027s not an option we intend to keep around long term; in fact it only exists to make the upgrade path easier.","commit_id":"f6ab51261c475c404218e1d50a4c48df6ccb1872"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"51ebeba7d979aa4e974b7fd8692f817d4533173b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"* The options in the `key_manager` group, as the key_manager is used"},{"line_number":85,"context_line":"  for the signature validation."},{"line_number":86,"context_line":"\"\"\"),"},{"line_number":87,"context_line":"    cfg.BoolOpt(\u0027enable_certificate_validation\u0027,"},{"line_number":88,"context_line":"        default\u003dFalse,"},{"line_number":89,"context_line":"        help\u003d\"\"\""},{"line_number":90,"context_line":"Enable certificate validation for image signature verification."}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_5a858159","line":87,"range":{"start_line":87,"start_character":17,"end_line":87,"end_character":46},"in_reply_to":"7ffa3b31_5ff3360b","updated":"2017-04-18 16:29:40.000000000","message":"That was discussed as a possibility on the spec. I\u0027m holding off until others chime in on it.","commit_id":"f6ab51261c475c404218e1d50a4c48df6ccb1872"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"209b7bc601bb4e143215c1b79bd0121ecaf114be","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    cfg.BoolOpt(\u0027enable_certificate_validation\u0027,"},{"line_number":90,"context_line":"        default\u003dFalse,"},{"line_number":91,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":92,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":93,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":94,"context_line":"This option is intended to ease the transition for deployments leveraging"},{"line_number":95,"context_line":"image signature verification. The intended state long-term is for signature"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_e3c05553","line":92,"range":{"start_line":92,"start_character":26,"end_line":92,"end_character":28},"updated":"2017-05-30 13:31:14.000000000","message":"wuh, wuh...\n\nThis should be 16.0.0","commit_id":"5ea9a6a27e3782844542cc0087a00017b05feaff"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f67bd685e159e53cd7e71ee60cdce1fb0c8337c7","unresolved":false,"context_lines":[{"line_number":130,"context_line":"Related options:"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* The value of this option may be used if both verify_glance_signatures and"},{"line_number":133,"context_line":"  enable_certificate_validation are enabled."},{"line_number":134,"context_line":"\"\"\"),"},{"line_number":135,"context_line":"    cfg.BoolOpt(\u0027debug\u0027,"},{"line_number":136,"context_line":"         default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_bd94fb37","line":133,"updated":"2017-05-01 12:57:48.000000000","message":"++ excellent help text for the above options, Peter.","commit_id":"5ea9a6a27e3782844542cc0087a00017b05feaff"}]}