)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"d52d02cd477680c998acd9abd31e273d5355257e","unresolved":false,"context_lines":[{"line_number":1801,"context_line":"        instance_ref[\u0027info_cache\u0027].update(info_cache)"},{"line_number":1802,"context_line":"    security_groups \u003d values.pop(\u0027security_groups\u0027, [])"},{"line_number":1803,"context_line":"    instance_ref[\u0027extra\u0027] \u003d models.InstanceExtra()"},{"line_number":1804,"context_line":"    instance_ref[\u0027extra\u0027].update("},{"line_number":1805,"context_line":"        {\u0027numa_topology\u0027: None,"},{"line_number":1806,"context_line":"         \u0027pci_requests\u0027: None,"},{"line_number":1807,"context_line":"         \u0027vcpu_model\u0027: None,"},{"line_number":1808,"context_line":"         \u0027trusted_certs\u0027: None,"},{"line_number":1809,"context_line":"         })"},{"line_number":1810,"context_line":"    instance_ref[\u0027extra\u0027].update(values.pop(\u0027extra\u0027, {}))"},{"line_number":1811,"context_line":"    instance_ref.update(values)"},{"line_number":1812,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"df3967d1_05ee30b3","line":1809,"range":{"start_line":1804,"start_character":0,"end_line":1809,"end_character":11},"updated":"2017-08-04 04:17:18.000000000","message":"Is this really necessary if L1810 empties instance_ref[\u0027extra\u0027] immediately afterwards?","commit_id":"da746b451a515d6b84e12a3de963d022c63a93ba"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"dfe55571d22ff93b1fdf7eb6a620c2dfaee04f14","unresolved":false,"context_lines":[{"line_number":1801,"context_line":"        instance_ref[\u0027info_cache\u0027].update(info_cache)"},{"line_number":1802,"context_line":"    security_groups \u003d values.pop(\u0027security_groups\u0027, [])"},{"line_number":1803,"context_line":"    instance_ref[\u0027extra\u0027] \u003d models.InstanceExtra()"},{"line_number":1804,"context_line":"    instance_ref[\u0027extra\u0027].update("},{"line_number":1805,"context_line":"        {\u0027numa_topology\u0027: None,"},{"line_number":1806,"context_line":"         \u0027pci_requests\u0027: None,"},{"line_number":1807,"context_line":"         \u0027vcpu_model\u0027: None,"},{"line_number":1808,"context_line":"         \u0027trusted_certs\u0027: None,"},{"line_number":1809,"context_line":"         })"},{"line_number":1810,"context_line":"    instance_ref[\u0027extra\u0027].update(values.pop(\u0027extra\u0027, {}))"},{"line_number":1811,"context_line":"    instance_ref.update(values)"},{"line_number":1812,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"df3967d1_827568fc","line":1809,"range":{"start_line":1804,"start_character":0,"end_line":1809,"end_character":11},"in_reply_to":"df3967d1_05ee30b3","updated":"2017-08-04 13:47:56.000000000","message":"I don\u0027t think L1810 empties instance_ref[\u0027extra\u0027]. It just updates the key-value pairs of instance_ref[\u0027extra\u0027] with the key-value pairs in values[\u0027extra\u0027].","commit_id":"da746b451a515d6b84e12a3de963d022c63a93ba"}],"nova/db/sqlalchemy/migrate_repo/versions/363_add_trusted_certs.py":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"c5d0ce6f48d84c797abe91bd61a334da4755f37a","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    for prefix in (\u0027\u0027, \u0027shadow_\u0027):"},{"line_number":25,"context_line":"        table \u003d Table(prefix + \u0027instance_extra\u0027, meta, autoload\u003dTrue)"},{"line_number":26,"context_line":"        new_column \u003d Column(\u0027trusted_certs\u0027, Text, nullable\u003dTrue)"},{"line_number":27,"context_line":"        if not hasattr(table.c, \u0027trusted_certs\u0027):"},{"line_number":28,"context_line":"            table.create_column(new_column)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_d1e8d07c","line":26,"updated":"2017-07-28 12:20:19.000000000","message":"It seems like we\u0027re adding the trusted_certs to the database as a column, but we have listed trusted_certs as a non-column field. Am I misunderstanding the terminology here?","commit_id":"6473977f83ad65cd6c2795244a05b5529ce036b2"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"473a2768906070baa14e36f151fd8079d655cf2f","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    for prefix in (\u0027\u0027, \u0027shadow_\u0027):"},{"line_number":25,"context_line":"        table \u003d Table(prefix + \u0027instance_extra\u0027, meta, autoload\u003dTrue)"},{"line_number":26,"context_line":"        new_column \u003d Column(\u0027trusted_certs\u0027, Text, nullable\u003dTrue)"},{"line_number":27,"context_line":"        if not hasattr(table.c, \u0027trusted_certs\u0027):"},{"line_number":28,"context_line":"            table.create_column(new_column)"}],"source_content_type":"text/x-python","patch_set":20,"id":"df3967d1_3134904a","line":26,"in_reply_to":"ff346bd7_d1e8d07c","updated":"2017-07-28 17:41:25.000000000","message":"I think we need to move trusted_certs from INSTANCE_OPTIONAL_NON_COLUMN_FIELDS to INSTANCE_OPTIONAL_JOINED_FIELDS. We want to store the trusted_certs in the database so that we can retrieve them later.","commit_id":"6473977f83ad65cd6c2795244a05b5529ce036b2"}],"nova/objects/instance.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d658e3aa5fd8c3f673ab6534a6751dfc5f72ccfe","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        \u0027migration_context\u0027: fields.ObjectField(\u0027MigrationContext\u0027,"},{"line_number":213,"context_line":"                                                nullable\u003dTrue),"},{"line_number":214,"context_line":"        \u0027keypairs\u0027: fields.ObjectField(\u0027KeyPairList\u0027),"},{"line_number":215,"context_line":"        \u0027trusted_certificate_ids\u0027: fields.ObjectField("},{"line_number":216,"context_line":"            \u0027TrustedCertificateIDList\u0027, nullable\u003dTrue),"},{"line_number":217,"context_line":"        }"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_d1622f0a","line":215,"updated":"2017-04-28 16:46:01.000000000","message":"Can we come up with a shorter less hateful name than this? trusted_certs maybe?\n\nAlso, it looks like this is a super complicated object hierarchy to just store a list of uuids. Do we need all of that or can we just have a ListOfStrings here?","commit_id":"66560a3290827685852f67c576b9ac8a23dfb41f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e32d75dab432522c79e9ac97de1b37defa8490c0","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        trusted_certs \u003d updates.pop(\u0027trusted_certs\u0027, None)"},{"line_number":528,"context_line":"        expected_attrs.append(\u0027trusted_certs\u0027)"},{"line_number":529,"context_line":"        if trusted_certs:"},{"line_number":530,"context_line":"            updates[\u0027extra\u0027][\u0027trusted_certs\u0027] \u003d ("},{"line_number":531,"context_line":"                trusted_certs._to_json())"},{"line_number":532,"context_line":"        else:"},{"line_number":533,"context_line":"            updates[\u0027extra\u0027][\u0027trusted_certs\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_083966d5","line":530,"updated":"2017-05-01 17:21:12.000000000","message":"Do we really want to store these in extra? They\u0027re just a list of strings, so they may be better as row stores, keyed by instance uuid. Will we ever need to query for instances by trusted cert? Like, will we ever need to say \"give me a list of instances that trust $cert, which was compromised\" or something like that? Storing this as JSON makes that basically impossible.\n\nAlso note that you haven\u0027t actually created a column for this in InstanceExtra, unless I\u0027m missing something. That is the source of some of the errors in your test output.","commit_id":"c45c2b735a3d0feb7d143d9dc69cfdc5fce183c9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e32d75dab432522c79e9ac97de1b37defa8490c0","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        expected_attrs.append(\u0027trusted_certs\u0027)"},{"line_number":529,"context_line":"        if trusted_certs:"},{"line_number":530,"context_line":"            updates[\u0027extra\u0027][\u0027trusted_certs\u0027] \u003d ("},{"line_number":531,"context_line":"                trusted_certs._to_json())"},{"line_number":532,"context_line":"        else:"},{"line_number":533,"context_line":"            updates[\u0027extra\u0027][\u0027trusted_certs\u0027] \u003d None"},{"line_number":534,"context_line":"        flavor \u003d updates.pop(\u0027flavor\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_a89dd2bc","line":531,"updated":"2017-05-01 17:21:12.000000000","message":"trusted_certs is just a list of strings here, right? It won\u0027t have a _to_json() for you to call. If you need to store is as json, you\u0027d need something like this here:\n\n updates[\u0027extra\u0027][\u0027trusted_certs\u0027] \u003d json.dumps(updates.pop(\u0027trusted_certs\u0027, None))","commit_id":"c45c2b735a3d0feb7d143d9dc69cfdc5fce183c9"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"baca0183b2a1c92f93f4d5eee19605826268f398","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        return instance"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def _trusted_certs_from_db_inst(cls, expected_attrs, db_inst):"},{"line_number":459,"context_line":"        if \u0027trusted_certs\u0027 in expected_attrs:"},{"line_number":460,"context_line":"            cls[\u0027trusted_certs\u0027] \u003d db_inst[\u0027trusted_certs\u0027]"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    @staticmethod"},{"line_number":463,"context_line":"    @db.select_db_reader_mode"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_c17fdf63","line":460,"range":{"start_line":459,"start_character":0,"end_line":460,"end_character":59},"updated":"2017-06-05 17:54:28.000000000","message":"Can we replace lines 452-453 with this block of code, since that\u0027s the only place this function is called?","commit_id":"84a75ea8de66d032593baf29ed7453cd3e5c96be"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0700fd3db89ce34bf1d37938944a5de9b740a9b4","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":221,"context_line":"        super(Instance, self).obj_make_compatible(primitive, target_version)"},{"line_number":222,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":223,"context_line":"        if target_version \u003c (2, 4) and \u0027trusted_certs\u0027 in primitive:"},{"line_number":224,"context_line":"            del primitive[\u0027trusted_certs\u0027]"},{"line_number":225,"context_line":"        if target_version \u003c (2, 3) and \u0027device_metadata\u0027 in primitive:"},{"line_number":226,"context_line":"            del primitive[\u0027device_metadata\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_df84ee60","line":223,"updated":"2017-06-22 14:07:48.000000000","message":"How about a test for this?","commit_id":"fed7ae3963c77e2bc67d901564afe2512634f277"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0700fd3db89ce34bf1d37938944a5de9b740a9b4","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                    objects.Service, db_inst[\u0027services\u0027])"},{"line_number":450,"context_line":"            instance[\u0027services\u0027] \u003d services"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        instance._trusted_certs_from_db_inst(expected_attrs,"},{"line_number":453,"context_line":"                                             db_inst)"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        instance.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_ff8c4a80","line":452,"updated":"2017-06-22 14:07:48.000000000","message":"There is no test for this. Since this field cloud be lazy-loaded via the obj_load_attr method, you could do a test where you have an instance in the db with trusted_certs in whatever joined table (instance extras?) but without the attribute set on the object, so then when you try to access the field on the object it would load it up from the database.","commit_id":"fed7ae3963c77e2bc67d901564afe2512634f277"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0700fd3db89ce34bf1d37938944a5de9b740a9b4","unresolved":false,"context_lines":[{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def _trusted_certs_from_db_inst(cls, expected_attrs, db_inst):"},{"line_number":459,"context_line":"        if \u0027trusted_certs\u0027 in expected_attrs:"},{"line_number":460,"context_line":"            cls[\u0027trusted_certs\u0027] \u003d db_inst[\u0027trusted_certs\u0027]"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    @staticmethod"},{"line_number":463,"context_line":"    @db.select_db_reader_mode"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_ff5e8a10","line":460,"range":{"start_line":460,"start_character":12,"end_line":460,"end_character":15},"updated":"2017-06-22 14:07:48.000000000","message":"This is kind of weird, and it\u0027s different from how other fields are handled above, like services and tags. Can we just be consistent in how those are handled?","commit_id":"fed7ae3963c77e2bc67d901564afe2512634f277"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"691d96a5afa6427bac53bea2c9e1f3452cf9119f","unresolved":false,"context_lines":[{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def _trusted_certs_from_db_inst(cls, expected_attrs, db_inst):"},{"line_number":459,"context_line":"        if \u0027trusted_certs\u0027 in expected_attrs:"},{"line_number":460,"context_line":"            cls[\u0027trusted_certs\u0027] \u003d db_inst[\u0027trusted_certs\u0027]"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    @staticmethod"},{"line_number":463,"context_line":"    @db.select_db_reader_mode"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_8501ec6c","line":460,"range":{"start_line":460,"start_character":12,"end_line":460,"end_character":15},"in_reply_to":"5f201791_355543c7","updated":"2017-07-06 20:47:45.000000000","message":"Perhaps you can consolidate some of the code in _from_db_object so that you can fit these two extra lines in.","commit_id":"fed7ae3963c77e2bc67d901564afe2512634f277"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"2b9204c82ba45554e77589e7d258363e5d975e19","unresolved":false,"context_lines":[{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def _trusted_certs_from_db_inst(cls, expected_attrs, db_inst):"},{"line_number":459,"context_line":"        if \u0027trusted_certs\u0027 in expected_attrs:"},{"line_number":460,"context_line":"            cls[\u0027trusted_certs\u0027] \u003d db_inst[\u0027trusted_certs\u0027]"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    @staticmethod"},{"line_number":463,"context_line":"    @db.select_db_reader_mode"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_355543c7","line":460,"range":{"start_line":460,"start_character":12,"end_line":460,"end_character":15},"in_reply_to":"5f201791_3a9f7060","updated":"2017-06-22 15:04:59.000000000","message":"@Matt I think I see what you mean now. The reason this is a separate function, and not simply included as additional code in _from_db_object is that adding another if statement to that function fails the cyclomatic complexity pep8 rule.","commit_id":"fed7ae3963c77e2bc67d901564afe2512634f277"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"30252540b110b480908565a558fa9c7a71e0a1b9","unresolved":false,"context_lines":[{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def _trusted_certs_from_db_inst(cls, expected_attrs, db_inst):"},{"line_number":459,"context_line":"        if \u0027trusted_certs\u0027 in expected_attrs:"},{"line_number":460,"context_line":"            cls[\u0027trusted_certs\u0027] \u003d db_inst[\u0027trusted_certs\u0027]"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    @staticmethod"},{"line_number":463,"context_line":"    @db.select_db_reader_mode"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_3a9f7060","line":460,"range":{"start_line":460,"start_character":12,"end_line":460,"end_character":15},"in_reply_to":"5f201791_ff5e8a10","updated":"2017-06-22 14:48:45.000000000","message":"Right now trusted_certs is listed in_INSTANCE_OPTIONAL_NON_COLUMN_FIELDS, unlike tags and services which are listed in _INSTANCE_OPTIONAL_JOINED_FIELDS., so I\u0027m trying to follow the patterns of how things like ec2_ids are handled. Should trusted_certs be in that same category with the _INSTANCE_OPTIONAL_JOINED_FIELDS?","commit_id":"fed7ae3963c77e2bc67d901564afe2512634f277"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"747665765f11ce18bd1d3c43cc902835c8100a51","unresolved":false,"context_lines":[{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    def _trusted_certs_from_db_inst(cls, expected_attrs, db_inst):"},{"line_number":460,"context_line":"        if \u0027trusted_certs\u0027 in expected_attrs:"},{"line_number":461,"context_line":"            cls[\u0027trusted_certs\u0027] \u003d db_inst[\u0027trusted_certs\u0027]"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    @staticmethod"},{"line_number":464,"context_line":"    @db.select_db_reader_mode"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_05bf1caa","line":461,"range":{"start_line":461,"start_character":35,"end_line":461,"end_character":59},"updated":"2017-07-06 20:47:56.000000000","message":"Should this be?:\n  db_inst[\u0027extra\u0027].get(\u0027trusted_certs\u0027)","commit_id":"ee4a9cd531419e7655a21511265719f160164eda"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"58d6d6e0409f61b09b1875b335e38927d074fec7","unresolved":false,"context_lines":[{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    def _trusted_certs_from_db_inst(cls, expected_attrs, db_inst):"},{"line_number":460,"context_line":"        if \u0027trusted_certs\u0027 in expected_attrs:"},{"line_number":461,"context_line":"            cls[\u0027trusted_certs\u0027] \u003d db_inst[\u0027trusted_certs\u0027]"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    @staticmethod"},{"line_number":464,"context_line":"    @db.select_db_reader_mode"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_8a62c6d7","line":461,"range":{"start_line":461,"start_character":35,"end_line":461,"end_character":59},"in_reply_to":"3f1d235d_05bf1caa","updated":"2017-07-10 17:10:49.000000000","message":"I don\u0027t think so, trusted_certs is an optional field, but is not in the instance extra.","commit_id":"ee4a9cd531419e7655a21511265719f160164eda"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"abf49d7f6f0f619699872f6960d03ccb29980e64","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                    objects.Service, db_inst[\u0027services\u0027])"},{"line_number":451,"context_line":"            instance[\u0027services\u0027] \u003d services"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        if \u0027trusted_certs\u0027 in expected_attrs:"},{"line_number":454,"context_line":"            instance[\u0027trusted_certs\u0027] \u003d db_inst[\u0027trusted_certs\u0027]"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        instance.obj_reset_changes()"},{"line_number":457,"context_line":"        return instance"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f1a1f67_5d1a4f17","line":454,"range":{"start_line":453,"start_character":0,"end_line":454,"end_character":64},"updated":"2017-07-20 21:03:31.000000000","message":"pep8 is currently failing because \"\u0027Instance._from_db_object\u0027 is too complex (35)\". In other words, we have too many if-statements in this function. I\u0027m looking for ways to reduce the complexity of this function and noticed that we are checking the assignment of `have_extra` in multiple places (e.g., L375, L381, L387, etc.) when I don\u0027t think that that is actually necessary. Does anyone disagree?","commit_id":"de9590027e9c614740d8f75c7bbe3a46ca33aa06"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"c8274438494b24b4a7bc65ecd109dae1eff9d83a","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                    objects.Service, db_inst[\u0027services\u0027])"},{"line_number":451,"context_line":"            instance[\u0027services\u0027] \u003d services"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        if \u0027trusted_certs\u0027 in expected_attrs:"},{"line_number":454,"context_line":"            instance[\u0027trusted_certs\u0027] \u003d db_inst[\u0027trusted_certs\u0027]"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        instance.obj_reset_changes()"},{"line_number":457,"context_line":"        return instance"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f1a1f67_1d2a97e6","line":454,"range":{"start_line":453,"start_character":0,"end_line":454,"end_character":64},"in_reply_to":"1f1a1f67_5d1a4f17","updated":"2017-07-20 21:13:24.000000000","message":"Would it be valid to put lines 366-454 under one giant if-statement?\n\n  if have_extra:\n    # Look for and act on expected_attrs\n\nThis would take away a handful of if-else\u0027s\n\n@Matt","commit_id":"de9590027e9c614740d8f75c7bbe3a46ca33aa06"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"384c28d502c64f308a85119694cbcf79f2ebe8de","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"                self.tags \u003d objects.TagList(self._context)"},{"line_number":1100,"context_line":"            else:"},{"line_number":1101,"context_line":"                self._load_tags()"},{"line_number":1102,"context_line":"        else:"},{"line_number":1103,"context_line":"            # FIXME(comstud): This should be optimized to only load the attr."},{"line_number":1104,"context_line":"            self._load_generic(attrname)"},{"line_number":1105,"context_line":"        self.obj_reset_changes([attrname])"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"    def get_flavor(self, namespace\u003dNone):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_77f08dca","line":1104,"range":{"start_line":1102,"start_character":0,"end_line":1104,"end_character":40},"updated":"2017-07-24 21:57:22.000000000","message":"Do we need to load our trusted_certs here?","commit_id":"a037e3d63fe45c93ed9ea651ce61feb6c6a6ce0f"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"ac4d5632af9f1a997e728862b5709de28d671dbb","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"                self.tags \u003d objects.TagList(self._context)"},{"line_number":1100,"context_line":"            else:"},{"line_number":1101,"context_line":"                self._load_tags()"},{"line_number":1102,"context_line":"        else:"},{"line_number":1103,"context_line":"            # FIXME(comstud): This should be optimized to only load the attr."},{"line_number":1104,"context_line":"            self._load_generic(attrname)"},{"line_number":1105,"context_line":"        self.obj_reset_changes([attrname])"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"    def get_flavor(self, namespace\u003dNone):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_063c4ee0","line":1104,"range":{"start_line":1102,"start_character":0,"end_line":1104,"end_character":40},"in_reply_to":"ff346bd7_77f08dca","updated":"2017-07-25 17:53:41.000000000","message":"I think so. I\u0027d guess that\u0027s why you\u0027re seeing the \"Instance object has no attribute \u0027trusted_certs\u0027 \" errors.","commit_id":"a037e3d63fe45c93ed9ea651ce61feb6c6a6ce0f"}],"nova/objects/trusted_certificates.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d658e3aa5fd8c3f673ab6534a6751dfc5f72ccfe","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"@base.NovaObjectRegistry.register"},{"line_number":18,"context_line":"class TrustedCertificateID(base.NovaPersistentObject):"},{"line_number":19,"context_line":"    # Version 1.0: Initial version"},{"line_number":20,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_b1afa328","line":18,"updated":"2017-04-28 16:46:01.000000000","message":"If this is being loaded from extra, then it probably shouldn\u0027t be a persistent object. That just brings in things like the created_at stamps and such.","commit_id":"66560a3290827685852f67c576b9ac8a23dfb41f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d658e3aa5fd8c3f673ab6534a6751dfc5f72ccfe","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    fields \u003d {"},{"line_number":23,"context_line":"        \u0027id\u0027: fields.IntegerField(read_only\u003dTrue),"},{"line_number":24,"context_line":"        \u0027certificate_uuid\u0027: fields.UUIDField()"},{"line_number":25,"context_line":"    }"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_71535b3a","line":23,"updated":"2017-04-28 16:46:01.000000000","message":"Do we really need an integer id here?","commit_id":"66560a3290827685852f67c576b9ac8a23dfb41f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d658e3aa5fd8c3f673ab6534a6751dfc5f72ccfe","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    fields \u003d {"},{"line_number":42,"context_line":"        \u0027instance_uuid\u0027: fields.UUIDField(),"},{"line_number":43,"context_line":"        \u0027trusted_certs\u0027: fields.ListOfObjects(\u0027TrustedCertificateID\u0027)"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_912dc7a9","line":42,"updated":"2017-04-28 16:46:01.000000000","message":"If we can only look this up by getting it from the instance object itself I don\u0027t think we need to store this here.","commit_id":"66560a3290827685852f67c576b9ac8a23dfb41f"}],"tox.ini":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"ba861cde465ef55f42a107bb80bb7a002ab79530","unresolved":false,"context_lines":[{"line_number":182,"context_line":"# to 25 and run \u0027tox -epep8\u0027."},{"line_number":183,"context_line":"# 34 is currently the most complex thing we have"},{"line_number":184,"context_line":"# TODO(jogo): get this number down to 25 or so"},{"line_number":185,"context_line":"max-complexity\u003d36"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"[hacking]"},{"line_number":188,"context_line":"local-check-factory \u003d nova.hacking.checks.factory"}],"source_content_type":"text/x-properties","patch_set":16,"id":"ff346bd7_89cbffa3","line":185,"updated":"2017-07-23 03:48:02.000000000","message":"I don\u0027t like this solution, but I think reducing complexity of _from_db_object() should be handled in a separate patch","commit_id":"39d6ffd0f57f8d440deba2e816f85c4eea153177"}]}
