)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0651528a1bb7a4c6408f455f178bbde88cfdfdc4","unresolved":false,"context_lines":[{"line_number":277,"context_line":"               help\u003d\"\"\""},{"line_number":278,"context_line":"URI scheme used for live migration."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"Override the default libvirt live migration scheme. If this option is unset,"},{"line_number":281,"context_line":"nova will automatically choose a sensible default based on the hypervisor"},{"line_number":282,"context_line":"(``virt_type``). It is not recommended that you change this unless you are very"},{"line_number":283,"context_line":"sure that hypervisor supports a particular scheme."}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_c0714c46","side":"PARENT","line":280,"updated":"2017-08-03 14:25:45.000000000","message":"Please, also consider the note here.","commit_id":"fd7b079a2438ac137a3276f6ebaf764c58064761"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8c733b5b845c640fbb4b0bdb63bf7042942a1246","unresolved":false,"context_lines":[{"line_number":273,"context_line":"  default, auto-generated target URI."},{"line_number":274,"context_line":"\"\"\"),"},{"line_number":275,"context_line":"    cfg.StrOpt(\u0027live_migration_scheme\u0027,"},{"line_number":276,"context_line":"               default\u003d\u0027tcp\u0027,"},{"line_number":277,"context_line":"               advanced\u003dTrue,"},{"line_number":278,"context_line":"               help\u003d\"\"\""},{"line_number":279,"context_line":"URI scheme used for live migration."}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_e06a107f","line":276,"updated":"2017-08-03 14:22:34.000000000","message":"I would have not changed this. It depends of the hypervisor configured to be used by libvirt. Basically some of them could not accept such scheme.\n\nSo you are defaulting to something which is only available for QEMU/KVM where that option should be considered as general. So I don\u0027t think it\u0027s something we want even if in the code we currently use that option only for QEMU/KVM...","commit_id":"edade4b91d8cef5ef6c2bc29b452dcdfe2c8c344"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"013d308748b419f63169768fca2485b2abc8a682","unresolved":false,"context_lines":[{"line_number":273,"context_line":"  default, auto-generated target URI."},{"line_number":274,"context_line":"\"\"\"),"},{"line_number":275,"context_line":"    cfg.StrOpt(\u0027live_migration_scheme\u0027,"},{"line_number":276,"context_line":"               default\u003d\u0027tcp\u0027,"},{"line_number":277,"context_line":"               advanced\u003dTrue,"},{"line_number":278,"context_line":"               help\u003d\"\"\""},{"line_number":279,"context_line":"URI scheme used for live migration."}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_538c6234","line":276,"in_reply_to":"9f436f4f_884299aa","updated":"2017-08-21 15:41:42.000000000","message":"You should just abandon this change. It\u0027s preferable to keep the default value of this option working in a general sense and so for all hypervisors.","commit_id":"edade4b91d8cef5ef6c2bc29b452dcdfe2c8c344"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"042361e9facee9433b79c2401030e0d2fc91f8d7","unresolved":false,"context_lines":[{"line_number":273,"context_line":"  default, auto-generated target URI."},{"line_number":274,"context_line":"\"\"\"),"},{"line_number":275,"context_line":"    cfg.StrOpt(\u0027live_migration_scheme\u0027,"},{"line_number":276,"context_line":"               default\u003d\u0027tcp\u0027,"},{"line_number":277,"context_line":"               advanced\u003dTrue,"},{"line_number":278,"context_line":"               help\u003d\"\"\""},{"line_number":279,"context_line":"URI scheme used for live migration."}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_884299aa","line":276,"in_reply_to":"df3967d1_e06a107f","updated":"2017-08-21 15:18:38.000000000","message":"Correct. This value is only used by the QEMU/KVM driver [1], which is why I thought this was a good move. I guess I should update the below text first.\n\n[1] https://review.openstack.org/#/c/457716/4/nova/virt/libvirt/driver.py@674","commit_id":"edade4b91d8cef5ef6c2bc29b452dcdfe2c8c344"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9cd0397ab040995ab98f5e0d540a92f44e603e95","unresolved":false,"context_lines":[{"line_number":278,"context_line":"               help\u003d\"\"\""},{"line_number":279,"context_line":"URI scheme used for live migration."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"Override the default libvirt live migration scheme. If this option is unset,"},{"line_number":282,"context_line":"nova will automatically choose a sensible default based on the hypervisor"},{"line_number":283,"context_line":"(``virt_type``). It is not recommended that you change this unless you are very"},{"line_number":284,"context_line":"sure that hypervisor supports a particular scheme."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Refer to the `libvirt documentation"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_89c80422","line":283,"range":{"start_line":281,"start_character":0,"end_line":283,"end_character":16},"updated":"2017-08-14 20:14:15.000000000","message":"I think sahid has a good point here.\n\nWhen you say, \"a default hardcoded outside of the configuration option\" do you mean that it\u0027s hardcoded to default \u0027tcp\u0027 in only the libvirt driver? Or for all drivers?","commit_id":"edade4b91d8cef5ef6c2bc29b452dcdfe2c8c344"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"042361e9facee9433b79c2401030e0d2fc91f8d7","unresolved":false,"context_lines":[{"line_number":278,"context_line":"               help\u003d\"\"\""},{"line_number":279,"context_line":"URI scheme used for live migration."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"Override the default libvirt live migration scheme. If this option is unset,"},{"line_number":282,"context_line":"nova will automatically choose a sensible default based on the hypervisor"},{"line_number":283,"context_line":"(``virt_type``). It is not recommended that you change this unless you are very"},{"line_number":284,"context_line":"sure that hypervisor supports a particular scheme."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Refer to the `libvirt documentation"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_e826c516","line":283,"range":{"start_line":281,"start_character":0,"end_line":283,"end_character":16},"in_reply_to":"9f436f4f_89c80422","updated":"2017-08-21 15:18:38.000000000","message":"\u003e do you mean that it\u0027s hardcoded to default \u0027tcp\u0027 in only the libvirt driver? Or for all drivers?\n\nJust libvirt. These configuration values are only used by the libvirt driver (see the filename) and, per above, this particular value is only used when QEMU/KVM is used.","commit_id":"edade4b91d8cef5ef6c2bc29b452dcdfe2c8c344"}]}