)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7992,"name":"Kartik Bommepally","email":"kbommepally@vmware.com","username":"kartikaditya"},"change_message_id":"a73e82b48750f6c34f0d97fd643178dee4f2e8b1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The creation of the connection information required by Cinder to"},{"line_number":10,"context_line":"delete the volume accessed a resource that did not exist (as it had"},{"line_number":11,"context_line":"been deleted). This would result in the instance being in a \u0027DELETING\u0027"},{"line_number":12,"context_line":"state and the Cinder volume not being deleted."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixes bug 1223074"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAASn%2F%2FLok%3D","line":11,"updated":"2013-09-10 14:06:51.000000000","message":"Edit the commit msg\n\n\"....This would result in the instance being in a \u0027DELETING\u0027\nstate and the Cinder volume in \u0027in-use\u0027 state.\"\n\nThe cinder volume is not expected to be deleted by the plugin and will be done by the manager iff the bdm is marked for deletion on instance termination.","commit_id":"f434cd8b1874eaec83e8bd2f2346a352bfe16413"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"522ed9b93ef6a71255cd273d550cb9beb9e7cf34","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The creation of the connection information required by Cinder to"},{"line_number":10,"context_line":"delete the volume accessed a resource that did not exist (as it had"},{"line_number":11,"context_line":"been deleted). This would result in the instance being in a \u0027DELETING\u0027"},{"line_number":12,"context_line":"state and the Cinder volume not being deleted."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixes bug 1223074"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAASn%2F%2FLfg%3D","line":11,"in_reply_to":"AAAASn%2F%2FLok%3D","updated":"2013-09-10 14:53:03.000000000","message":"Done","commit_id":"f434cd8b1874eaec83e8bd2f2346a352bfe16413"}],"nova/tests/virt/vmwareapi/test_vmwareapi.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"76f1643ad31512997fb8362ccf3224c71c07376e","unresolved":false,"context_lines":[{"line_number":816,"context_line":"        self.assertEqual(connector[\u0027ip\u0027], \u0027test_url\u0027)"},{"line_number":817,"context_line":"        self.assertEqual(connector[\u0027host\u0027], \u0027test_url\u0027)"},{"line_number":818,"context_line":"        self.assertEqual(connector[\u0027initiator\u0027], \u0027iscsi-name\u0027)"},{"line_number":819,"context_line":"        self.assertTrue(\u0027instance\u0027 in connector)"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def test_connection_info_get_after_destroy(self):"},{"line_number":822,"context_line":"        self._create_vm()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2F380%3D","line":819,"updated":"2013-09-17 20:52:30.000000000","message":"This should be assertIn() which makes it much easier to debug later from log files only.","commit_id":"138cd811b7d1d756d770c7110f30794cad383b07"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"83896770ce101891a7bcf048ad32bb6e4d6e55ff","unresolved":false,"context_lines":[{"line_number":816,"context_line":"        self.assertEqual(connector[\u0027ip\u0027], \u0027test_url\u0027)"},{"line_number":817,"context_line":"        self.assertEqual(connector[\u0027host\u0027], \u0027test_url\u0027)"},{"line_number":818,"context_line":"        self.assertEqual(connector[\u0027initiator\u0027], \u0027iscsi-name\u0027)"},{"line_number":819,"context_line":"        self.assertTrue(\u0027instance\u0027 in connector)"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def test_connection_info_get_after_destroy(self):"},{"line_number":822,"context_line":"        self._create_vm()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2F3IU%3D","line":819,"in_reply_to":"AAAAS3%2F%2F380%3D","updated":"2013-09-18 04:56:54.000000000","message":"Done","commit_id":"138cd811b7d1d756d770c7110f30794cad383b07"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"76f1643ad31512997fb8362ccf3224c71c07376e","unresolved":false,"context_lines":[{"line_number":825,"context_line":"        self.assertEqual(connector[\u0027ip\u0027], \u0027test_url\u0027)"},{"line_number":826,"context_line":"        self.assertEqual(connector[\u0027host\u0027], \u0027test_url\u0027)"},{"line_number":827,"context_line":"        self.assertEqual(connector[\u0027initiator\u0027], \u0027iscsi-name\u0027)"},{"line_number":828,"context_line":"        self.assertFalse(\u0027instance\u0027 in connector)"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"class VMwareAPIHostTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2F38k%3D","line":828,"updated":"2013-09-17 20:52:30.000000000","message":"Same here.","commit_id":"138cd811b7d1d756d770c7110f30794cad383b07"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"83896770ce101891a7bcf048ad32bb6e4d6e55ff","unresolved":false,"context_lines":[{"line_number":825,"context_line":"        self.assertEqual(connector[\u0027ip\u0027], \u0027test_url\u0027)"},{"line_number":826,"context_line":"        self.assertEqual(connector[\u0027host\u0027], \u0027test_url\u0027)"},{"line_number":827,"context_line":"        self.assertEqual(connector[\u0027initiator\u0027], \u0027iscsi-name\u0027)"},{"line_number":828,"context_line":"        self.assertFalse(\u0027instance\u0027 in connector)"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"class VMwareAPIHostTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2F3IQ%3D","line":828,"in_reply_to":"AAAAS3%2F%2F38k%3D","updated":"2013-09-18 04:56:54.000000000","message":"Done","commit_id":"138cd811b7d1d756d770c7110f30794cad383b07"}],"nova/virt/vmwareapi/volumeops.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"9d8fba0bd02ff69007e15ced863a5a5088d6c57f","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        iqn \u003d volume_util.get_host_iqn(self._session, self._cluster)"},{"line_number":173,"context_line":"        connector \u003d {\u0027ip\u0027: CONF.vmware.host_ip,"},{"line_number":174,"context_line":"                     \u0027initiator\u0027: iqn,"},{"line_number":175,"context_line":"                     \u0027host\u0027: CONF.vmware.host_ip}"},{"line_number":176,"context_line":"        if vm_ref:"},{"line_number":177,"context_line":"            connector[\u0027instance\u0027] \u003d vm_ref.value"},{"line_number":178,"context_line":"        return connector"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FLWk%3D","line":175,"updated":"2013-09-10 15:26:50.000000000","message":"I\u0027m not sure, but I think this might be a mistake.\n\nIs the connector for vCenter or the ESXi host underneath vCenter? IIRC iqn are associated with the physical host not the virtual SDK end point and this sore spot is where I see a lot of bugs coming from. The SDK is interacting at a different IP from the physical hardware and that can require you to calculate the physical \n\nI think the connector might be talking about something attached to the ESX host. In which case you need to use \u0027get_host_name_for_vm\u0027 in vm_util.py to get the ESX host that the VM is running on right this moment.","commit_id":"138cd811b7d1d756d770c7110f30794cad383b07"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ac8b05892f73ad4bb2b0b9624dad1686d6cf53bb","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        iqn \u003d volume_util.get_host_iqn(self._session, self._cluster)"},{"line_number":173,"context_line":"        connector \u003d {\u0027ip\u0027: CONF.vmware.host_ip,"},{"line_number":174,"context_line":"                     \u0027initiator\u0027: iqn,"},{"line_number":175,"context_line":"                     \u0027host\u0027: CONF.vmware.host_ip}"},{"line_number":176,"context_line":"        if vm_ref:"},{"line_number":177,"context_line":"            connector[\u0027instance\u0027] \u003d vm_ref.value"},{"line_number":178,"context_line":"        return connector"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FLJw%3D","line":175,"in_reply_to":"AAAASn%2F%2FLWk%3D","updated":"2013-09-10 16:23:06.000000000","message":"The specific bug here is dealing with the case when the VM was deleted prior to getting the vm_ref. This causes and exception.\nThe point that you have raised is indeed a bug and could actually be https://bugs.launchpad.net/nova/+bug/1193980.\nThis seems to have been addressed by:https://review.openstack.org/#/c/35633/14/nova/virt/vmwareapi/volumeops.py (line 114).","commit_id":"138cd811b7d1d756d770c7110f30794cad383b07"}]}