)]}'
{"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"660ce7eda59e6b01811461d35858f374fe4abab8","unresolved":false,"context_lines":[{"line_number":6159,"context_line":"                              \u0027clear_events_for_instance\u0027),"},{"line_number":6160,"context_line":"            mock.patch.object(self.compute, \u0027update_available_resource\u0027),"},{"line_number":6161,"context_line":"            mock.patch.object(migration_obj, \u0027save\u0027),"},{"line_number":6162,"context_line":"            mock.patch(\u0027nova.compute.manager.LOG.info\u0027),"},{"line_number":6163,"context_line":"        ) as ("},{"line_number":6164,"context_line":"            post_live_migration, unfilter_instance,"},{"line_number":6165,"context_line":"            migrate_instance_start, post_live_migration_at_destination,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_fdf707d4","line":6162,"updated":"2017-04-21 20:28:36.000000000","message":"I generally don\u0027t like us mocking and checking for log messages, but..","commit_id":"15dfd4f94b4567a1f7002036dd8ca1c0daa0b4c7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9c170c838a22bcf2ab6074a97d95a0534fc10cd3","unresolved":false,"context_lines":[{"line_number":6159,"context_line":"                              \u0027clear_events_for_instance\u0027),"},{"line_number":6160,"context_line":"            mock.patch.object(self.compute, \u0027update_available_resource\u0027),"},{"line_number":6161,"context_line":"            mock.patch.object(migration_obj, \u0027save\u0027),"},{"line_number":6162,"context_line":"            mock.patch(\u0027nova.compute.manager.LOG.info\u0027),"},{"line_number":6163,"context_line":"        ) as ("},{"line_number":6164,"context_line":"            post_live_migration, unfilter_instance,"},{"line_number":6165,"context_line":"            migrate_instance_start, post_live_migration_at_destination,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_bd473fbd","line":6162,"in_reply_to":"5ff73747_fdf707d4","updated":"2017-04-21 20:49:20.000000000","message":"yeh, please don\u0027t do that. You can actually get access to the log stream with one of the fixtures and just look for if it\u0027s in there. A mock is going to be weird especially if anything ever refactors.","commit_id":"15dfd4f94b4567a1f7002036dd8ca1c0daa0b4c7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"660ce7eda59e6b01811461d35858f374fe4abab8","unresolved":false,"context_lines":[{"line_number":6251,"context_line":"            self.assertEqual(\u0027completed\u0027, migration_obj.status)"},{"line_number":6252,"context_line":"            # assert we did not log a success message"},{"line_number":6253,"context_line":"            for call in mock_log_info.call_args_list:"},{"line_number":6254,"context_line":"                if \u0027Migrating instance to %s finished successfully.\u0027 \u003d\u003d \\"},{"line_number":6255,"context_line":"                        call[0][0]:"},{"line_number":6256,"context_line":"                    # we found what we were looking for"},{"line_number":6257,"context_line":"                    self.fail(\u0027Should not log success info message.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_bd017fb2","line":6254,"updated":"2017-04-21 20:28:36.000000000","message":"Would be nice to just assert that \"successful\" wasn\u0027t logged or something, otherwise we just have to change this if we change the other one a little.","commit_id":"15dfd4f94b4567a1f7002036dd8ca1c0daa0b4c7"}]}