)]}'
{"nova/tests/unit/volume/test_cinder.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cd1eaed59745d712df518a86f03985dfb286f738","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        # fake out the volume not found error"},{"line_number":310,"context_line":"        mock_cinderclient.return_value.attachments.create.side_effect \u003d ("},{"line_number":311,"context_line":"            cinder_exception.NotFound(404))"},{"line_number":312,"context_line":"        self.assertRaises(exception.VolumeNotFound, self.api.attachment_create,"},{"line_number":313,"context_line":"                          self.ctx, uuids.volume_id, uuids.instance_id)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    @mock.patch(\u0027nova.volume.cinder.cinderclient\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_833bd9cf","line":312,"range":{"start_line":312,"start_character":36,"end_line":312,"end_character":50},"updated":"2017-05-30 13:23:31.000000000","message":"ah, we\u0027re creating an attachment from scratch so it\u0027s the volume that could be missing","commit_id":"05c4b7b9daab1e8a0d91a7e1c6547e75ba1661d7"}],"nova/volume/cinder.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a2bd1e3079c47e13e52df42fdddc1494a8fb04c6","unresolved":false,"context_lines":[{"line_number":495,"context_line":"        )"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    @translate_volume_exception"},{"line_number":498,"context_line":"    def attachment_create(self, context, volume_id, connector, instance_id):"},{"line_number":499,"context_line":"        \"\"\"Create a volume attachment. This requires microversion \u003e\u003d 3.27."},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        :param context: The nova request context."}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_d58e57cf","line":498,"range":{"start_line":498,"start_character":52,"end_line":498,"end_character":61},"updated":"2017-04-23 23:00:58.000000000","message":"This is optional so should probably be a kwarg that defaults to None.","commit_id":"b9c1999611b9f1b292c8d36fd89577c299c01924"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e359b3cf66a9503be92938d507c0bf4ed26e460c","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        \"\"\""},{"line_number":521,"context_line":"        try:"},{"line_number":522,"context_line":"            return cinderclient(context).attachments.create("},{"line_number":523,"context_line":"                volume_id, connector, instance_id)"},{"line_number":524,"context_line":"        except cinder_exception.ClientException as ex:"},{"line_number":525,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":526,"context_line":"                LOG.error((\u0027Create attachment failed for volume \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_69c03a2b","line":523,"updated":"2017-04-27 15:59:59.000000000","message":"So we don\u0027t need any micro-version negotiation here? The client does that for us?","commit_id":"c92818be4fe18c85631cdf567e3725efc77529cb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"75b178f940c8f1b925afd1c7ecfdbd37bb300db0","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        \"\"\""},{"line_number":521,"context_line":"        try:"},{"line_number":522,"context_line":"            return cinderclient(context).attachments.create("},{"line_number":523,"context_line":"                volume_id, connector, instance_id)"},{"line_number":524,"context_line":"        except cinder_exception.ClientException as ex:"},{"line_number":525,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":526,"context_line":"                LOG.error((\u0027Create attachment failed for volume \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_e03218f2","line":523,"in_reply_to":"5ff73747_69c03a2b","updated":"2017-04-27 18:13:43.000000000","message":"No, I intentionally omitted that for now, depending on how we actually add the support for getting the client with the 3.27 microversion. My thinking was if 3.27 is available, we\u0027re going to create the client at the version, so it\u0027s already requesting that. If that version is not available, we\u0027re never attaching new volumes the new way anyway and wouldn\u0027t get here.","commit_id":"c92818be4fe18c85631cdf567e3725efc77529cb"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0ed781daa1140892d40e1b4ac726ad1385a776c7","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        \"\"\""},{"line_number":521,"context_line":"        try:"},{"line_number":522,"context_line":"            return cinderclient(context).attachments.create("},{"line_number":523,"context_line":"                volume_id, connector, instance_id)"},{"line_number":524,"context_line":"        except cinder_exception.ClientException as ex:"},{"line_number":525,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":526,"context_line":"                LOG.error((\u0027Create attachment failed for volume \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_eeb0abdf","line":523,"in_reply_to":"5ff73747_e03218f2","updated":"2017-04-28 14:04:46.000000000","message":"Yeah, that makes sense. KISS.","commit_id":"c92818be4fe18c85631cdf567e3725efc77529cb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cd1eaed59745d712df518a86f03985dfb286f738","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        return cinderclient(context).volumes.migrate_volume_completion("},{"line_number":407,"context_line":"            old_volume_id, new_volume_id, error)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    @translate_volume_exception"},{"line_number":410,"context_line":"    def create(self, context, size, name, description, snapshot\u003dNone,"},{"line_number":411,"context_line":"               image_id\u003dNone, volume_type\u003dNone, metadata\u003dNone,"},{"line_number":412,"context_line":"               availability_zone\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_c37d516f","line":409,"range":{"start_line":409,"start_character":5,"end_line":409,"end_character":31},"updated":"2017-05-30 13:23:31.000000000","message":"Per comments on below and previous page, this probably shouldn\u0027t be raising a volume exception, given that that\u0027s apparently for issues with existing volumes. Not related to this change though so meh","commit_id":"05c4b7b9daab1e8a0d91a7e1c6547e75ba1661d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ab6a2eb66841c5c4e5fff402d711449afdc3b7e3","unresolved":false,"context_lines":[{"line_number":494,"context_line":"             \u0027progress\u0027: \u002790%\u0027}"},{"line_number":495,"context_line":"        )"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    @translate_volume_exception"},{"line_number":498,"context_line":"    def attachment_create(self, context, volume_id, instance_id,"},{"line_number":499,"context_line":"                          connector\u003dNone):"},{"line_number":500,"context_line":"        \"\"\"Create a volume attachment. This requires microversion \u003e\u003d 3.27."}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_68d782c1","line":497,"range":{"start_line":497,"start_character":5,"end_line":497,"end_character":31},"updated":"2017-05-30 13:19:21.000000000","message":"shouldn\u0027t this be translate_attachment_exception?","commit_id":"05c4b7b9daab1e8a0d91a7e1c6547e75ba1661d7"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"c89cc840297c93d3c6d5825e5fbade3ebda2804b","unresolved":false,"context_lines":[{"line_number":494,"context_line":"             \u0027progress\u0027: \u002790%\u0027}"},{"line_number":495,"context_line":"        )"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    @translate_volume_exception"},{"line_number":498,"context_line":"    def attachment_create(self, context, volume_id, instance_id,"},{"line_number":499,"context_line":"                          connector\u003dNone):"},{"line_number":500,"context_line":"        \"\"\"Create a volume attachment. This requires microversion \u003e\u003d 3.27."}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_a35edde3","line":497,"range":{"start_line":497,"start_character":5,"end_line":497,"end_character":31},"in_reply_to":"df140735_68d782c1","updated":"2017-05-30 13:25:41.000000000","message":"It\u0027s good here as we don\u0027t have an attachment at the time of this call. So it\u0027s the volume that\u0027s not found, etc.","commit_id":"05c4b7b9daab1e8a0d91a7e1c6547e75ba1661d7"}]}