)]}'
{"nova/tests/unit/volume/test_cinder.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"753e5eaf31a01bda0f15af96542d56bcca65a013","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        mock_cinderclient.return_value.attachments.update.return_value \u003d ("},{"line_number":331,"context_line":"            fake_attachment)"},{"line_number":332,"context_line":"        result \u003d self.api.attachment_update("},{"line_number":333,"context_line":"            self.ctx, uuids.attachment_id, connector\u003d{})"},{"line_number":334,"context_line":"        self.assertEqual(fake_attachment, result)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    @mock.patch(\u0027nova.volume.cinder.cinderclient\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_2a07d6cc","line":333,"range":{"start_line":333,"start_character":53,"end_line":333,"end_character":55},"updated":"2017-04-27 07:43:18.000000000","message":"Currently this results in a HTTPBadRequest, see here: https://github.com/openstack/cinder/blob/master/cinder/api/v3/attachments.py#L217","commit_id":"0a5d1f72aec8e4283feb5b4ceac8e8ae56477f61"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3c3ed6a7fcba14af1d9960b4dccd7e1a97a04104","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        mock_cinderclient.return_value.attachments.update.return_value \u003d ("},{"line_number":331,"context_line":"            fake_attachment)"},{"line_number":332,"context_line":"        result \u003d self.api.attachment_update("},{"line_number":333,"context_line":"            self.ctx, uuids.attachment_id, connector\u003d{})"},{"line_number":334,"context_line":"        self.assertEqual(fake_attachment, result)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    @mock.patch(\u0027nova.volume.cinder.cinderclient\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_c05ddc15","line":333,"range":{"start_line":333,"start_character":53,"end_line":333,"end_character":55},"in_reply_to":"5ff73747_2a07d6cc","updated":"2017-04-27 18:14:59.000000000","message":"Yup, didn\u0027t realize, I\u0027ll adjust.","commit_id":"0a5d1f72aec8e4283feb5b4ceac8e8ae56477f61"}],"nova/volume/cinder.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"753e5eaf31a01bda0f15af96542d56bcca65a013","unresolved":false,"context_lines":[{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        :param context: The nova request context."},{"line_number":539,"context_line":"        :param attachment_id: UUID of the volume attachment to update."},{"line_number":540,"context_line":"        :param connector: host connector dict; if None, the attachment is"},{"line_number":541,"context_line":"            \"terminated\", else a new connection is made and the resulting"},{"line_number":542,"context_line":"            object should have the connection_info attribute set."},{"line_number":543,"context_line":"        :returns: cinderclient.v3.attachments.VolumeAttachment object"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_6abdde00","line":540,"range":{"start_line":540,"start_character":50,"end_line":540,"end_character":54},"updated":"2017-04-27 07:43:18.000000000","message":"Currently you must specify the connector for update: https://github.com/openstack/cinder/blob/master/cinder/api/v3/attachments.py#L217\n\nBy design the idea was to finalize the attachment process with this call and create new attachments in edge cases Nova has to keep the volume reserved and have the desired step in the API layer.","commit_id":"0a5d1f72aec8e4283feb5b4ceac8e8ae56477f61"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3c3ed6a7fcba14af1d9960b4dccd7e1a97a04104","unresolved":false,"context_lines":[{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        :param context: The nova request context."},{"line_number":539,"context_line":"        :param attachment_id: UUID of the volume attachment to update."},{"line_number":540,"context_line":"        :param connector: host connector dict; if None, the attachment is"},{"line_number":541,"context_line":"            \"terminated\", else a new connection is made and the resulting"},{"line_number":542,"context_line":"            object should have the connection_info attribute set."},{"line_number":543,"context_line":"        :returns: cinderclient.v3.attachments.VolumeAttachment object"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_4072ecae","line":540,"range":{"start_line":540,"start_character":50,"end_line":540,"end_character":54},"in_reply_to":"5ff73747_49c0dee1","updated":"2017-04-27 18:14:59.000000000","message":"OK I\u0027ll change, I didn\u0027t realize that.","commit_id":"0a5d1f72aec8e4283feb5b4ceac8e8ae56477f61"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ab1b09cecb0b9b3626f462bdc8d2d9d75046ca51","unresolved":false,"context_lines":[{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        :param context: The nova request context."},{"line_number":539,"context_line":"        :param attachment_id: UUID of the volume attachment to update."},{"line_number":540,"context_line":"        :param connector: host connector dict; if None, the attachment is"},{"line_number":541,"context_line":"            \"terminated\", else a new connection is made and the resulting"},{"line_number":542,"context_line":"            object should have the connection_info attribute set."},{"line_number":543,"context_line":"        :returns: cinderclient.v3.attachments.VolumeAttachment object"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_49c0dee1","line":540,"range":{"start_line":540,"start_character":50,"end_line":540,"end_character":54},"in_reply_to":"5ff73747_6abdde00","updated":"2017-04-27 16:01:36.000000000","message":"I honestly prefer keeping it clean, as it is in Cinder today.","commit_id":"0a5d1f72aec8e4283feb5b4ceac8e8ae56477f61"}]}