)]}'
{"api-ref/source/index.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f1d0c9064c87cca3b9e52ae930f3b27c54cd5e78","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Compute API in the past, but no longer exist."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":".. include:: os-certificates.inc"},{"line_number":81,"context_line":".. include:: os-cloudpipe.inc"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f044301_164a8c26","line":81,"updated":"2017-05-03 22:59:12.000000000","message":"Remove cloudpipe from the api guide too:\n\nhttps://github.com/openstack/nova/blob/master/api-guide/source/general_info.rst","commit_id":"43914cb0cf95c8d78977f75f48f65c96324fa6b2"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"13b66e96e6481ca6fcb0976cf5112770f8bcd496","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Compute API in the past, but no longer exist."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":".. include:: os-certificates.inc"},{"line_number":81,"context_line":".. include:: os-cloudpipe.inc"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f044301_f6ccc062","line":81,"in_reply_to":"3f044301_164a8c26","updated":"2017-05-03 23:15:45.000000000","message":"Done","commit_id":"43914cb0cf95c8d78977f75f48f65c96324fa6b2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f81e38ca8e269dbb00e396167ff724796ccfe96e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Compute API in the past, but no longer exist."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":".. include:: os-certificates.inc"},{"line_number":81,"context_line":".. include:: os-cloudpipe.inc"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f044301_56aa5485","line":81,"in_reply_to":"3f044301_164a8c26","updated":"2017-05-03 23:01:12.000000000","message":"We should also update this to mention it was removed in the 16.0.0 Pike release:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/api-ref/source/os-certificates.inc#n11\n\nLike we did for os-certificates:\n\nhttps://developer.openstack.org/api-ref/compute/#root-certificates-os-certificates-deprecated","commit_id":"43914cb0cf95c8d78977f75f48f65c96324fa6b2"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"13b66e96e6481ca6fcb0976cf5112770f8bcd496","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Compute API in the past, but no longer exist."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":".. include:: os-certificates.inc"},{"line_number":81,"context_line":".. include:: os-cloudpipe.inc"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f044301_b6d638f1","line":81,"in_reply_to":"3f044301_56aa5485","updated":"2017-05-03 23:15:45.000000000","message":"Done","commit_id":"43914cb0cf95c8d78977f75f48f65c96324fa6b2"}],"nova/api/openstack/compute/cloudpipe.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f1d0c9064c87cca3b9e52ae930f3b27c54cd5e78","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_utils import fileutils"},{"line_number":18,"context_line":"from webob import exc"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from nova.api.openstack.compute.schemas import cloudpipe"},{"line_number":21,"context_line":"from nova.api.openstack import extensions"},{"line_number":22,"context_line":"from nova.api.openstack import wsgi"},{"line_number":23,"context_line":"from nova.api import validation"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_96045cc8","side":"PARENT","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":56},"updated":"2017-05-03 22:59:12.000000000","message":"You can delete these schemas too.","commit_id":"700ab86f8d88d4c089406f9c30a61a49e847ff1b"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"13b66e96e6481ca6fcb0976cf5112770f8bcd496","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_utils import fileutils"},{"line_number":18,"context_line":"from webob import exc"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from nova.api.openstack.compute.schemas import cloudpipe"},{"line_number":21,"context_line":"from nova.api.openstack import extensions"},{"line_number":22,"context_line":"from nova.api.openstack import wsgi"},{"line_number":23,"context_line":"from nova.api import validation"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_760af08a","side":"PARENT","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":56},"in_reply_to":"3f044301_96045cc8","updated":"2017-05-03 23:15:45.000000000","message":"Done","commit_id":"700ab86f8d88d4c089406f9c30a61a49e847ff1b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f1d0c9064c87cca3b9e52ae930f3b27c54cd5e78","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        Parameters: {cloudpipe: {\u0027project_id\u0027: \u0027\u0027}}"},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        raise exc.HTTPGone"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @extensions.expected_errors((410))"},{"line_number":40,"context_line":"    def index(self, req):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_96fe9c03","line":37,"range":{"start_line":37,"start_character":18,"end_line":37,"end_character":26},"updated":"2017-05-03 22:59:12.000000000","message":"This always throws me as I think this is raising the type rather than an instance of the exception class, like in java, but python is OK with this. It just looks odd to not be HTTPGone().","commit_id":"43914cb0cf95c8d78977f75f48f65c96324fa6b2"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"13b66e96e6481ca6fcb0976cf5112770f8bcd496","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        Parameters: {cloudpipe: {\u0027project_id\u0027: \u0027\u0027}}"},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        raise exc.HTTPGone"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @extensions.expected_errors((410))"},{"line_number":40,"context_line":"    def index(self, req):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_3604687b","line":37,"range":{"start_line":37,"start_character":18,"end_line":37,"end_character":26},"in_reply_to":"3f044301_96fe9c03","updated":"2017-05-03 23:15:45.000000000","message":"Done","commit_id":"43914cb0cf95c8d78977f75f48f65c96324fa6b2"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"39f97efb7ea39b83c8b812d48d5babbc7e91051a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from nova.api.openstack import wsgi"},{"line_number":21,"context_line":"import nova.conf"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"ALIAS \u003d \u0027os-cloudpipe\u0027"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_2d7652da","line":23,"updated":"2017-05-04 07:51:11.000000000","message":"nit. This can be removed.","commit_id":"273f08b9484144a7857451cf6bc51deb0caed0fb"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"39f97efb7ea39b83c8b812d48d5babbc7e91051a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class CloudpipeController(wsgi.Controller):"},{"line_number":29,"context_line":"    \"\"\"Handle creating and listing cloudpipe instances.\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @extensions.expected_errors((410))"},{"line_number":32,"context_line":"    def create(self, req, body):"},{"line_number":33,"context_line":"        \"\"\"Create a new cloudpipe instance, if none exists."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_ed918af3","line":31,"range":{"start_line":31,"start_character":32,"end_line":31,"end_character":37},"updated":"2017-05-04 07:51:11.000000000","message":"There is extra \u0027()\u0027., but it is fine.","commit_id":"273f08b9484144a7857451cf6bc51deb0caed0fb"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1226aea07a0889eda060c3ffd1e5a1d30449b065","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        Parameters: {cloudpipe: {\u0027project_id\u0027: \u0027\u0027}}"},{"line_number":33,"context_line":"        \"\"\""},{"line_number":34,"context_line":"        raise exc.HTTPGone()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @extensions.expected_errors((410))"},{"line_number":37,"context_line":"    def index(self, req):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_b18e382c","line":34,"updated":"2017-05-04 08:56:35.000000000","message":"Did we want any error string with the gone? I guess probably not.","commit_id":"acdc2da0e3b0255e9884c8a8f1bfe38367c2094c"}],"nova/cloudpipe/pipelib.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f1d0c9064c87cca3b9e52ae930f3b27c54cd5e78","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def is_vpn_image(image_id):"},{"line_number":46,"context_line":"    return image_id \u003d\u003d CONF.cloudpipe.vpn_image_id"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _load_boot_script():"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_16ae0ce7","side":"PARENT","line":46,"range":{"start_line":46,"start_character":23,"end_line":46,"end_character":37},"updated":"2017-05-03 22:59:12.000000000","message":"You can remove the config options too:\n\nhttps://github.com/openstack/nova/blob/master/nova/conf/cloudpipe.py\n\n--\n\nLess obvious but it also looks like this option is dependent on the cloudpipe stuff:\n\nhttps://github.com/openstack/nova/blob/master/nova/conf/network.py#L190\n\nIt\u0027s probably just better to leave the vpn_ip option until we remove nova-network, or just update the help text for that option saying it\u0027s effectively no longer used as cloudpipe has been removed.","commit_id":"700ab86f8d88d4c089406f9c30a61a49e847ff1b"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"13b66e96e6481ca6fcb0976cf5112770f8bcd496","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def is_vpn_image(image_id):"},{"line_number":46,"context_line":"    return image_id \u003d\u003d CONF.cloudpipe.vpn_image_id"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _load_boot_script():"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_b672b810","side":"PARENT","line":46,"range":{"start_line":46,"start_character":23,"end_line":46,"end_character":37},"in_reply_to":"3f044301_16ae0ce7","updated":"2017-05-03 23:15:45.000000000","message":"Done","commit_id":"700ab86f8d88d4c089406f9c30a61a49e847ff1b"}],"nova/conf/cloudpipe.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1b4aec81295c9ee1eddd4195009feb95b7f074c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3f044301_111ccc68","side":"PARENT","updated":"2017-05-04 08:49:21.000000000","message":"Are we allowed to delete configuration options without any warning, even if they no longer do anything?","commit_id":"700ab86f8d88d4c089406f9c30a61a49e847ff1b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f2439f33be739d7cb626eeee26688538c05e410c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3f044301_d12d4447","side":"PARENT","in_reply_to":"3f044301_111ccc68","updated":"2017-05-04 08:52:59.000000000","message":"Well, I would say its OK, because of the nova-network deprecation.\n\nI mean the strict answer is no, but this one seems OK to overlook.","commit_id":"700ab86f8d88d4c089406f9c30a61a49e847ff1b"}],"nova/conf/network.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f2439f33be739d7cb626eeee26688538c05e410c","unresolved":false,"context_lines":[{"line_number":195,"context_line":"nova-network is deprecated, as are any related configuration options."},{"line_number":196,"context_line":"\"\"\","},{"line_number":197,"context_line":"        help\u003d\"\"\""},{"line_number":198,"context_line":"This option is no longer used since the /os-cloudpipe API was removed in the"},{"line_number":199,"context_line":"16.0.0 Pike release. This is the public IP address for the cloudpipe VPN"},{"line_number":200,"context_line":"servers. It defaults to the IP address of the host."},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_f15040d7","line":198,"range":{"start_line":198,"start_character":54,"end_line":198,"end_character":69},"updated":"2017-05-04 08:52:59.000000000","message":"It wasn\u0027t actually remove, it was just deprecated.","commit_id":"acdc2da0e3b0255e9884c8a8f1bfe38367c2094c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1226aea07a0889eda060c3ffd1e5a1d30449b065","unresolved":false,"context_lines":[{"line_number":195,"context_line":"nova-network is deprecated, as are any related configuration options."},{"line_number":196,"context_line":"\"\"\","},{"line_number":197,"context_line":"        help\u003d\"\"\""},{"line_number":198,"context_line":"This option is no longer used since the /os-cloudpipe API was removed in the"},{"line_number":199,"context_line":"16.0.0 Pike release. This is the public IP address for the cloudpipe VPN"},{"line_number":200,"context_line":"servers. It defaults to the IP address of the host."},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_111bac1b","line":198,"range":{"start_line":198,"start_character":54,"end_line":198,"end_character":69},"in_reply_to":"3f044301_f15040d7","updated":"2017-05-04 08:56:35.000000000","message":"heh, wrong side. I see what you mean now.","commit_id":"acdc2da0e3b0255e9884c8a8f1bfe38367c2094c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1b4aec81295c9ee1eddd4195009feb95b7f074c2","unresolved":false,"context_lines":[{"line_number":187,"context_line":"* ``use_neutron``"},{"line_number":188,"context_line":"* ``network_size``"},{"line_number":189,"context_line":"\"\"\"),"},{"line_number":190,"context_line":"    cfg.StrOpt(\"vpn_ip\","},{"line_number":191,"context_line":"        default\u003d\"$my_ip\","},{"line_number":192,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":193,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":194,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":195,"context_line":"nova-network is deprecated, as are any related configuration options."},{"line_number":196,"context_line":"\"\"\","},{"line_number":197,"context_line":"        help\u003d\"\"\""},{"line_number":198,"context_line":"This option is no longer used since the /os-cloudpipe API was removed in the"},{"line_number":199,"context_line":"16.0.0 Pike release. This is the public IP address for the cloudpipe VPN"},{"line_number":200,"context_line":"servers. It defaults to the IP address of the host."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Please note that this option is only used when using nova-network instead of"},{"line_number":203,"context_line":"Neutron in your deployment. It also will be ignored if the configuration option"},{"line_number":204,"context_line":"for `network_manager` is not set to the default of"},{"line_number":205,"context_line":"\u0027nova.network.manager.VlanManager\u0027."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Possible values:"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* Any valid IP address. The default is ``$my_ip``, the IP address of the VM."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Related options:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"* ``network_manager``"},{"line_number":214,"context_line":"* ``use_neutron``"},{"line_number":215,"context_line":"* ``vpn_start``"},{"line_number":216,"context_line":"\"\"\"),"},{"line_number":217,"context_line":"    cfg.PortOpt(\"vpn_start\","},{"line_number":218,"context_line":"        default\u003d1000,"},{"line_number":219,"context_line":"        deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_d14c2478","line":216,"range":{"start_line":190,"start_character":0,"end_line":216,"end_character":5},"updated":"2017-05-04 08:49:21.000000000","message":"This option is deprecated long enough. You *can* just remove this","commit_id":"acdc2da0e3b0255e9884c8a8f1bfe38367c2094c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1226aea07a0889eda060c3ffd1e5a1d30449b065","unresolved":false,"context_lines":[{"line_number":187,"context_line":"* ``use_neutron``"},{"line_number":188,"context_line":"* ``network_size``"},{"line_number":189,"context_line":"\"\"\"),"},{"line_number":190,"context_line":"    cfg.StrOpt(\"vpn_ip\","},{"line_number":191,"context_line":"        default\u003d\"$my_ip\","},{"line_number":192,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":193,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":194,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":195,"context_line":"nova-network is deprecated, as are any related configuration options."},{"line_number":196,"context_line":"\"\"\","},{"line_number":197,"context_line":"        help\u003d\"\"\""},{"line_number":198,"context_line":"This option is no longer used since the /os-cloudpipe API was removed in the"},{"line_number":199,"context_line":"16.0.0 Pike release. This is the public IP address for the cloudpipe VPN"},{"line_number":200,"context_line":"servers. It defaults to the IP address of the host."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Please note that this option is only used when using nova-network instead of"},{"line_number":203,"context_line":"Neutron in your deployment. It also will be ignored if the configuration option"},{"line_number":204,"context_line":"for `network_manager` is not set to the default of"},{"line_number":205,"context_line":"\u0027nova.network.manager.VlanManager\u0027."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Possible values:"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* Any valid IP address. The default is ``$my_ip``, the IP address of the VM."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Related options:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"* ``network_manager``"},{"line_number":214,"context_line":"* ``use_neutron``"},{"line_number":215,"context_line":"* ``vpn_start``"},{"line_number":216,"context_line":"\"\"\"),"},{"line_number":217,"context_line":"    cfg.PortOpt(\"vpn_start\","},{"line_number":218,"context_line":"        default\u003d1000,"},{"line_number":219,"context_line":"        deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_f11720ed","line":216,"range":{"start_line":190,"start_character":0,"end_line":216,"end_character":5},"in_reply_to":"3f044301_d14c2478","updated":"2017-05-04 08:56:35.000000000","message":"Yeah, +1","commit_id":"acdc2da0e3b0255e9884c8a8f1bfe38367c2094c"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c156e3e45ea77988f33d1a3d4487efcdccb817a9","unresolved":false,"context_lines":[{"line_number":187,"context_line":"* ``use_neutron``"},{"line_number":188,"context_line":"* ``network_size``"},{"line_number":189,"context_line":"\"\"\"),"},{"line_number":190,"context_line":"    cfg.StrOpt(\"vpn_ip\","},{"line_number":191,"context_line":"        default\u003d\"$my_ip\","},{"line_number":192,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":193,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":194,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":195,"context_line":"nova-network is deprecated, as are any related configuration options."},{"line_number":196,"context_line":"\"\"\","},{"line_number":197,"context_line":"        help\u003d\"\"\""},{"line_number":198,"context_line":"This option is no longer used since the /os-cloudpipe API was removed in the"},{"line_number":199,"context_line":"16.0.0 Pike release. This is the public IP address for the cloudpipe VPN"},{"line_number":200,"context_line":"servers. It defaults to the IP address of the host."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Please note that this option is only used when using nova-network instead of"},{"line_number":203,"context_line":"Neutron in your deployment. It also will be ignored if the configuration option"},{"line_number":204,"context_line":"for `network_manager` is not set to the default of"},{"line_number":205,"context_line":"\u0027nova.network.manager.VlanManager\u0027."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Possible values:"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"* Any valid IP address. The default is ``$my_ip``, the IP address of the VM."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Related options:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"* ``network_manager``"},{"line_number":214,"context_line":"* ``use_neutron``"},{"line_number":215,"context_line":"* ``vpn_start``"},{"line_number":216,"context_line":"\"\"\"),"},{"line_number":217,"context_line":"    cfg.PortOpt(\"vpn_start\","},{"line_number":218,"context_line":"        default\u003d1000,"},{"line_number":219,"context_line":"        deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_dfb782d8","line":216,"range":{"start_line":190,"start_character":0,"end_line":216,"end_character":5},"in_reply_to":"3f044301_f11720ed","updated":"2017-05-04 15:04:08.000000000","message":"See mriedem\u0027s comment on rev 6.","commit_id":"acdc2da0e3b0255e9884c8a8f1bfe38367c2094c"}],"nova/policies/cloudpipe.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1b4aec81295c9ee1eddd4195009feb95b7f074c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3f044301_b17ab885","side":"PARENT","updated":"2017-05-04 08:49:21.000000000","message":"Likewise for policy: can we just delete these without warning?","commit_id":"700ab86f8d88d4c089406f9c30a61a49e847ff1b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1226aea07a0889eda060c3ffd1e5a1d30449b065","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3f044301_91b57cf1","side":"PARENT","in_reply_to":"3f044301_b17ab885","updated":"2017-05-04 08:56:35.000000000","message":"As its now unused, I don\u0027t mind us just dropping it.\n\nAnyways, we don\u0027t really have good infrastructure to deal with policy deprecation (yet).","commit_id":"700ab86f8d88d4c089406f9c30a61a49e847ff1b"}],"nova/tests/unit/api/openstack/compute/test_cloudpipe_update.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"39f97efb7ea39b83c8b812d48d5babbc7e91051a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        self.controller \u003d clup_v21.CloudpipeController()"},{"line_number":27,"context_line":"        self.req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def _check_status(self, expected_status, res, controller_method):"},{"line_number":30,"context_line":"        self.assertEqual(expected_status, controller_method.wsgi_code)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_cloudpipe_configure_project(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_8832f4a6","line":29,"updated":"2017-05-04 07:51:11.000000000","message":"This is useless?","commit_id":"273f08b9484144a7857451cf6bc51deb0caed0fb"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"39f97efb7ea39b83c8b812d48d5babbc7e91051a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def _check_status(self, expected_status, res, controller_method):"},{"line_number":30,"context_line":"        self.assertEqual(expected_status, controller_method.wsgi_code)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_cloudpipe_configure_project(self):"},{"line_number":33,"context_line":"        body \u003d {\"configure_project\": {\"vpn_ip\": \"1.2.3.4\", \"vpn_port\": 222}}"},{"line_number":34,"context_line":"        self.assertRaises(webob.exc.HTTPGone, self.controller.update,"},{"line_number":35,"context_line":"                          self.req, \u0027configure-project\u0027, body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_68f20809","line":32,"updated":"2017-05-04 07:51:11.000000000","message":"we can just merge this into test_cloudpipe.py","commit_id":"273f08b9484144a7857451cf6bc51deb0caed0fb"}],"nova/virt/libvirt/firewall.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f1d0c9064c87cca3b9e52ae930f3b27c54cd5e78","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        self._define_filter(self._filter_container(\u0027nova-nodhcp\u0027, filter_set))"},{"line_number":216,"context_line":"        filter_set.append(\u0027allow-dhcp-server\u0027)"},{"line_number":217,"context_line":"        self._define_filter(self._filter_container(\u0027nova-base\u0027, filter_set))"},{"line_number":218,"context_line":"        self._define_filter(self._filter_container(\u0027nova-vpn\u0027,"},{"line_number":219,"context_line":"                                                   [\u0027allow-dhcp-server\u0027]))"},{"line_number":220,"context_line":"        self._define_filter(self.nova_dhcp_filter())"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        self.static_filters_configured \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_566ff4c4","line":219,"range":{"start_line":218,"start_character":8,"end_line":219,"end_character":74},"updated":"2017-05-03 22:59:12.000000000","message":"I\u0027d think you could remove this too.","commit_id":"43914cb0cf95c8d78977f75f48f65c96324fa6b2"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"13b66e96e6481ca6fcb0976cf5112770f8bcd496","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        self._define_filter(self._filter_container(\u0027nova-nodhcp\u0027, filter_set))"},{"line_number":216,"context_line":"        filter_set.append(\u0027allow-dhcp-server\u0027)"},{"line_number":217,"context_line":"        self._define_filter(self._filter_container(\u0027nova-base\u0027, filter_set))"},{"line_number":218,"context_line":"        self._define_filter(self._filter_container(\u0027nova-vpn\u0027,"},{"line_number":219,"context_line":"                                                   [\u0027allow-dhcp-server\u0027]))"},{"line_number":220,"context_line":"        self._define_filter(self.nova_dhcp_filter())"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        self.static_filters_configured \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_3660e832","line":219,"range":{"start_line":218,"start_character":8,"end_line":219,"end_character":74},"in_reply_to":"3f044301_566ff4c4","updated":"2017-05-03 23:15:45.000000000","message":"Done","commit_id":"43914cb0cf95c8d78977f75f48f65c96324fa6b2"}],"releasenotes/notes/remove-cloudpipe-api-f7aea9372046ecfc.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1b4aec81295c9ee1eddd4195009feb95b7f074c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The deprecated /os-cloudpipe API endpoint has been removed. Whenever calls"},{"line_number":4,"context_line":"    are made to that endpoint it now returns a 410 response."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f044301_f15f200c","line":3,"range":{"start_line":3,"start_character":19,"end_line":3,"end_character":32},"updated":"2017-05-04 08:49:21.000000000","message":"nit: Could you surround this with backticks (``/os-cloudpipe``). A link to the docs for same would be helpful too","commit_id":"acdc2da0e3b0255e9884c8a8f1bfe38367c2094c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1b4aec81295c9ee1eddd4195009feb95b7f074c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The deprecated /os-cloudpipe API endpoint has been removed. Whenever calls"},{"line_number":4,"context_line":"    are made to that endpoint it now returns a 410 response."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f044301_d19ae4c3","line":4,"range":{"start_line":4,"start_character":47,"end_line":4,"end_character":51},"updated":"2017-05-04 08:49:21.000000000","message":"**410 (Gone)** ?","commit_id":"acdc2da0e3b0255e9884c8a8f1bfe38367c2094c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1b4aec81295c9ee1eddd4195009feb95b7f074c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The deprecated /os-cloudpipe API endpoint has been removed. Whenever calls"},{"line_number":4,"context_line":"    are made to that endpoint it now returns a 410 response."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f044301_b19f58b3","line":4,"range":{"start_line":3,"start_character":64,"end_line":4,"end_character":33},"updated":"2017-05-04 08:49:21.000000000","message":"This endpoint now returns...","commit_id":"acdc2da0e3b0255e9884c8a8f1bfe38367c2094c"}]}