)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"6ac09d842f5bbabcd13e43b48162b19f56106f8e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: update LibvirtConfigGuestDeviceAddress to provide XML"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is adding a method format_dom() to the config object"},{"line_number":10,"context_line":"LibvirtConfigGuestDeviceAddress. That in the aim to provide full"},{"line_number":11,"context_line":"description of the controller used by the device."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1686116"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df140735_4d6290da","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":64},"updated":"2017-06-07 17:32:37.000000000","message":"Not entirely sure what \"That in the aim to provide\" means. Perhaps you mean \"This aims to provide a description of...\"?","commit_id":"724ca8227a23a918d1810f866af661ac2a0730a3"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1771096c2076b7bb49fb3c108a579d9445704803","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"            root_name\u003d\u0027address\u0027, **kwargs)"},{"line_number":1159,"context_line":"        self.type \u003d type"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"    def format_dom(self):"},{"line_number":1162,"context_line":"        xml \u003d super(LibvirtConfigGuestDeviceAddress, self).format_dom()"},{"line_number":1163,"context_line":"        xml.set(\"type\", self.type)"},{"line_number":1164,"context_line":"        return xml"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"    @staticmethod"},{"line_number":1167,"context_line":"    def parse_dom(xmldoc):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_558eb0d0","line":1164,"range":{"start_line":1161,"start_character":0,"end_line":1164,"end_character":18},"updated":"2017-05-03 11:02:41.000000000","message":"Unrelated change?\n\nYou probably need tests for this too, even if it\u0027s required here","commit_id":"f983bab011ea964fe221c74705274cbb1cf3c93d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7b3ea3ba2ecc7d96e20b1395eef7e5e7f308ca8d","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"    def format_dom(self):"},{"line_number":1162,"context_line":"        xml \u003d super(LibvirtConfigGuestDeviceAddress, self).format_dom()"},{"line_number":1163,"context_line":"        xml.set(\"type\", self.type)"},{"line_number":1164,"context_line":"        return xml"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"    @staticmethod"},{"line_number":1167,"context_line":"    def parse_dom(xmldoc):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_f45f0e0c","line":1164,"in_reply_to":"3f044301_8e9e7d05","updated":"2017-05-04 09:20:54.000000000","message":"LibvirtConfigGuestDeviceAddress is an abstract class, we never instance it. Also we do not want to move that field because it is used by LibvirtConfigGuestDeviceAddressPCI.","commit_id":"f983bab011ea964fe221c74705274cbb1cf3c93d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b38deb78131376901aaffe7a69a4011ce9dc8cc2","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"    def format_dom(self):"},{"line_number":1162,"context_line":"        xml \u003d super(LibvirtConfigGuestDeviceAddress, self).format_dom()"},{"line_number":1163,"context_line":"        xml.set(\"type\", self.type)"},{"line_number":1164,"context_line":"        return xml"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"    @staticmethod"},{"line_number":1167,"context_line":"    def parse_dom(xmldoc):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_8e9e7d05","line":1164,"in_reply_to":"3f044301_a85ff0e3","updated":"2017-05-04 08:40:42.000000000","message":"It does make sense. If \u0027type\u0027 is useful enough/necessary to go into the parent class, we should probably test it there though :) If not, maybe move \u0027type\u0027 into \u0027LibvirtConfigGuestDeviceAddressDrive\u0027 along with \u0027controller\u0027, \u0027bus\u0027, etc.","commit_id":"f983bab011ea964fe221c74705274cbb1cf3c93d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6ed4701d271c53a455d855e82b5d8c699950906","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"    def format_dom(self):"},{"line_number":1162,"context_line":"        xml \u003d super(LibvirtConfigGuestDeviceAddress, self).format_dom()"},{"line_number":1163,"context_line":"        xml.set(\"type\", self.type)"},{"line_number":1164,"context_line":"        return xml"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"    @staticmethod"},{"line_number":1167,"context_line":"    def parse_dom(xmldoc):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_591496a0","line":1164,"in_reply_to":"3f044301_f45f0e0c","updated":"2017-05-05 09:35:17.000000000","message":"Ah, OK and \u0027LibvirtConfigGuestDeviceAddressPCI\u0027 doesn\u0027t have/need a \u0027format_dom\u0027 function. That\u0027s fair enough","commit_id":"f983bab011ea964fe221c74705274cbb1cf3c93d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"765f1641c9a254195b6049e0b85a0ce38943fa77","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"    def format_dom(self):"},{"line_number":1162,"context_line":"        xml \u003d super(LibvirtConfigGuestDeviceAddress, self).format_dom()"},{"line_number":1163,"context_line":"        xml.set(\"type\", self.type)"},{"line_number":1164,"context_line":"        return xml"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"    @staticmethod"},{"line_number":1167,"context_line":"    def parse_dom(xmldoc):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_a85ff0e3","line":1164,"in_reply_to":"5ff73747_32568c08","updated":"2017-05-04 07:37:23.000000000","message":"Oh I see, actually LibvirtConfigGuestDeviceAddressDrive inherits LibvirtConfigGuestDeviceAddress. If you look at the constructor it\u0027s where we pass the \u0027type\u0027 which is by the end printed to the XML.\n\nBasically if you remove that code the test [0] is going to fail, so that is why I\u0027m saying it\u0027s already tested and related. Does it make sense?","commit_id":"f983bab011ea964fe221c74705274cbb1cf3c93d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"691f6fc2729ec4a6a07611d5d064f29860946480","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"    def format_dom(self):"},{"line_number":1162,"context_line":"        xml \u003d super(LibvirtConfigGuestDeviceAddress, self).format_dom()"},{"line_number":1163,"context_line":"        xml.set(\"type\", self.type)"},{"line_number":1164,"context_line":"        return xml"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"    @staticmethod"},{"line_number":1167,"context_line":"    def parse_dom(xmldoc):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_be038c73","line":1164,"in_reply_to":"5ff73747_558eb0d0","updated":"2017-05-03 14:13:06.000000000","message":"It\u0027s already tested here [0] line 1038 so you can see the type correctly set.\n\n[0] https://review.openstack.org/#/c/459737/1/nova/tests/unit/virt/libvirt/test_config.py","commit_id":"f983bab011ea964fe221c74705274cbb1cf3c93d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6d272271744d8b676995a2c90c4fdb1782351cb3","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"    def format_dom(self):"},{"line_number":1162,"context_line":"        xml \u003d super(LibvirtConfigGuestDeviceAddress, self).format_dom()"},{"line_number":1163,"context_line":"        xml.set(\"type\", self.type)"},{"line_number":1164,"context_line":"        return xml"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"    @staticmethod"},{"line_number":1167,"context_line":"    def parse_dom(xmldoc):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_32568c08","line":1164,"in_reply_to":"5ff73747_be038c73","updated":"2017-05-03 16:12:28.000000000","message":"That\u0027s testing LibvirtConfigGuestDeviceAddressDrive though. This is LibvirtConfigGuestDeviceAddress (no \u0027Drive\u0027)?","commit_id":"f983bab011ea964fe221c74705274cbb1cf3c93d"}]}