)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"448acc5f241f0416c1b6eab985df46cbe8b1ea96","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-07 04:18:50 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: rearange how scsi controller is defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit make just cleaner how we configure the"},{"line_number":10,"context_line":"scsi controller."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df140735_ed63a4b0","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":17},"updated":"2017-06-07 17:36:14.000000000","message":"s/rearange/rearrange/","commit_id":"215add554adb88d9ded4267f07968d8a7d166a45"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7dcb56e704983594cbfc0d042d040303a31fae4","unresolved":false,"context_lines":[{"line_number":3662,"context_line":"    @staticmethod"},{"line_number":3663,"context_line":"    def _get_scsi_controller(image_meta):"},{"line_number":3664,"context_line":"        \"\"\"Return scsi controller or None based on image meta\"\"\""},{"line_number":3665,"context_line":"        # TODO(sahid): should raise an exception for an invalid controller"},{"line_number":3666,"context_line":"        if image_meta.properties.get(\u0027hw_scsi_model\u0027):"},{"line_number":3667,"context_line":"            hw_scsi_model \u003d image_meta.properties.hw_scsi_model"},{"line_number":3668,"context_line":"            scsi_controller \u003d vconfig.LibvirtConfigGuestController()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_d549a08b","line":3665,"range":{"start_line":3665,"start_character":56,"end_line":3665,"end_character":74},"updated":"2017-05-03 11:06:00.000000000","message":"as an aside, what qualifies as an \"invalid controller\"?","commit_id":"95850b0ccfc605019b00606ab53021c529fb8b15"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f70a6ffa0ac380d4e90dd1a4c701a5bb79dabc78","unresolved":false,"context_lines":[{"line_number":3662,"context_line":"    @staticmethod"},{"line_number":3663,"context_line":"    def _get_scsi_controller(image_meta):"},{"line_number":3664,"context_line":"        \"\"\"Return scsi controller or None based on image meta\"\"\""},{"line_number":3665,"context_line":"        # TODO(sahid): should raise an exception for an invalid controller"},{"line_number":3666,"context_line":"        if image_meta.properties.get(\u0027hw_scsi_model\u0027):"},{"line_number":3667,"context_line":"            hw_scsi_model \u003d image_meta.properties.hw_scsi_model"},{"line_number":3668,"context_line":"            scsi_controller \u003d vconfig.LibvirtConfigGuestController()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_100edf8c","line":3665,"in_reply_to":"5ff73747_be382c3d","updated":"2017-05-16 09:32:18.000000000","message":"super nit, if you respin add that list or the URL to the TODO, just so others can follow up if you don\u0027t get around to it.","commit_id":"95850b0ccfc605019b00606ab53021c529fb8b15"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"101d5feef56c0790aeb72e3e0172198437af4546","unresolved":false,"context_lines":[{"line_number":3662,"context_line":"    @staticmethod"},{"line_number":3663,"context_line":"    def _get_scsi_controller(image_meta):"},{"line_number":3664,"context_line":"        \"\"\"Return scsi controller or None based on image meta\"\"\""},{"line_number":3665,"context_line":"        # TODO(sahid): should raise an exception for an invalid controller"},{"line_number":3666,"context_line":"        if image_meta.properties.get(\u0027hw_scsi_model\u0027):"},{"line_number":3667,"context_line":"            hw_scsi_model \u003d image_meta.properties.hw_scsi_model"},{"line_number":3668,"context_line":"            scsi_controller \u003d vconfig.LibvirtConfigGuestController()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_be382c3d","line":3665,"in_reply_to":"5ff73747_d549a08b","updated":"2017-05-03 14:14:30.000000000","message":"The valid controllers are:  \u0027auto\u0027, \u0027buslogic\u0027, \u0027ibmvscsi\u0027, \u0027lsilogic\u0027, \u0027lsisas1068\u0027, \u0027lsisas1078\u0027, \u0027virtio-scsi\u0027 or \u0027vmpvscsi\u0027.\n\nhttps://libvirt.org/formatdomain.html#elementsControllers","commit_id":"95850b0ccfc605019b00606ab53021c529fb8b15"}]}