)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"534fed30ca995ea404499a6e602c2c321d4aec47","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Added kvm_hidden feature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Image kvm_hidden property helps libvirt set in xml instance file"},{"line_number":10,"context_line":"property, which will hide on guest host KVM hypervisor signature."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Adam Kijak \u003cadam.kijak@corp.ovh.com\u003e"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5ff73747_199acc60","line":10,"updated":"2017-05-02 08:03:43.000000000","message":"DocImpact is probable needed also","commit_id":"2c1d0ecaff87f66b2e4fb5db020d1dc510099b69"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"144472c403b8fdb8bca79930161f56ac89151b88","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Adam Kijak \u003cadam.kijak@corp.ovh.com\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"DocImpact-Group: openstack/glance"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ie8227fececa40e502aaa39d77de2a1cd0cd72682"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ff0f0b1f_6269df23","line":14,"updated":"2017-05-18 15:08:33.000000000","message":"Please call out the actual doc impact - I\u0027m assuming the manuals need to be updated for the new image meta property.\n\nIs there a related change to add this to glance\u0027s metadata schema? https://github.com/openstack/glance/tree/master/etc/metadefs","commit_id":"6243e90c432a8870473a7a9374a1b6df5e247940"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"b05beda7b4a228e87f312f7083198535c2c1e7a9","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Adam Kijak \u003cadam.kijak@corp.ovh.com\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"DocImpact-Group: openstack/glance"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ie8227fececa40e502aaa39d77de2a1cd0cd72682"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ff0f0b1f_c9631ab1","line":14,"in_reply_to":"ff0f0b1f_6269df23","updated":"2017-05-19 07:46:37.000000000","message":"Created PS for glance:\nhttps://review.openstack.org/466219","commit_id":"6243e90c432a8870473a7a9374a1b6df5e247940"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"144472c403b8fdb8bca79930161f56ac89151b88","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Co-Authored-By: Adam Kijak \u003cadam.kijak@corp.ovh.com\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"DocImpact-Group: openstack/glance"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ie8227fececa40e502aaa39d77de2a1cd0cd72682"},{"line_number":18,"context_line":"Closes-Bug: #1686093"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ff0f0b1f_c282ebc8","line":15,"updated":"2017-05-18 15:08:33.000000000","message":"I have no idea what this tag does.","commit_id":"6243e90c432a8870473a7a9374a1b6df5e247940"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"b05beda7b4a228e87f312f7083198535c2c1e7a9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Co-Authored-By: Adam Kijak \u003cadam.kijak@corp.ovh.com\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"DocImpact-Group: openstack/glance"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ie8227fececa40e502aaa39d77de2a1cd0cd72682"},{"line_number":18,"context_line":"Closes-Bug: #1686093"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ff0f0b1f_0950f2d3","line":15,"in_reply_to":"ff0f0b1f_c282ebc8","updated":"2017-05-19 07:46:37.000000000","message":"According to...\"documentation\" (there was mentioned about functionality but I can\u0027t find any example in our gerrit repo) it should notify another team about doc impact.\n\nNow I added DocImpact into glance commit message. (https://review.openstack.org/466219)","commit_id":"6243e90c432a8870473a7a9374a1b6df5e247940"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"144472c403b8fdb8bca79930161f56ac89151b88","unresolved":false,"context_lines":[{"line_number":15,"context_line":"DocImpact-Group: openstack/glance"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ie8227fececa40e502aaa39d77de2a1cd0cd72682"},{"line_number":18,"context_line":"Closes-Bug: #1686093"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ff0f0b1f_22e1a79b","line":18,"updated":"2017-05-18 15:08:33.000000000","message":"This isn\u0027t a bug, it\u0027s a new feature, and therefore should be a blueprint rather than a bug.","commit_id":"6243e90c432a8870473a7a9374a1b6df5e247940"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"b05beda7b4a228e87f312f7083198535c2c1e7a9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"DocImpact-Group: openstack/glance"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ie8227fececa40e502aaa39d77de2a1cd0cd72682"},{"line_number":18,"context_line":"Closes-Bug: #1686093"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ff0f0b1f_e9601ea8","line":18,"in_reply_to":"ff0f0b1f_22e1a79b","updated":"2017-05-19 07:46:37.000000000","message":"Agree.\nCan I leave Closes-bug or I must create blueprint extra for it?","commit_id":"6243e90c432a8870473a7a9374a1b6df5e247940"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fb361afcde6fbd685420b5331b8318a686c52d64","unresolved":false,"context_lines":[{"line_number":15,"context_line":"DocImpact-Group: openstack/glance"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ie8227fececa40e502aaa39d77de2a1cd0cd72682"},{"line_number":18,"context_line":"Closes-Bug: #1686093"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ff0f0b1f_13db78ed","line":18,"in_reply_to":"ff0f0b1f_e9601ea8","updated":"2017-05-19 13:10:23.000000000","message":"It\u0027s not a bug, it\u0027s a feature, so it should have a blueprint.","commit_id":"6243e90c432a8870473a7a9374a1b6df5e247940"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3eb9c51c2d096fc141290c684f9d211e82ba1e27","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Added kvm_hidden feature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Image kvm_hidden property helps libvirt set in xml instance file"},{"line_number":10,"context_line":"property, which will hide on guest host KVM hypervisor signature."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Adam Kijak \u003cadam.kijak@corp.ovh.com\u003e"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ff0f0b1f_7698621a","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":64},"updated":"2017-05-19 13:44:01.000000000","message":"Can you provide a use case for this? Why is this necessary? Why would someone want to do this?","commit_id":"52af0304d7fa05de40ac2aba6eda05dbbf72d4d7"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"a049001f58ec4239e842b0acdb7fadf095eb80db","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Added kvm_hidden feature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Image kvm_hidden property helps libvirt set in xml instance file"},{"line_number":10,"context_line":"property, which will hide on guest host KVM hypervisor signature."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Adam Kijak \u003cadam.kijak@corp.ovh.com\u003e"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ff0f0b1f_f93b45c5","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":64},"in_reply_to":"ff0f0b1f_7698621a","updated":"2017-05-19 13:52:26.000000000","message":"The original QEMU commit that added this feature[*] will tell you the purpose of this:\n\n  \"The latest Nvidia driver (337.88) specifically checks\n  for KVM as the hypervisor and reports Code 43 for the\n  driver  in a Windows guest when found.  Removing or \n  changing the KVM signature is sufficient for the driver \n  to load and work.\"\n\n\nThis can be observed when \u0027-cpu kvm\u003doff\u0027 is supplied to the QEMU command-line.  And from within the guest, if you run the `cpuid` binary, you shouldn\u0027t see the KVM signature (\"KVMKVMKVM   \").  \n\nThe signature can normally be seen from within the guest, when you run:\n\n    $ cpuid | grep -i hypervisor_id\n    hypervisor_id \u003d \"KVMKVMKVM   \"\n\n\n[*] http://git.qemu.org/?p\u003dqemu.git;a\u003dcommitdiff;h\u003df522d2a","commit_id":"52af0304d7fa05de40ac2aba6eda05dbbf72d4d7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"25828e1c8d3e04531c18d4147619cb939b5a9aa4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie8227fececa40e502aaa39d77de2a1cd0cd72682"},{"line_number":17,"context_line":"Closes-Bug: #1686093"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ff0f0b1f_73f3d474","line":17,"updated":"2017-05-19 13:11:01.000000000","message":"This isn\u0027t a bug. Please create a blueprint for this. It doesn\u0027t need a spec.","commit_id":"52af0304d7fa05de40ac2aba6eda05dbbf72d4d7"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bda3837e6822b4c819566f9a1f8955decb7d74e9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Pawlik \u003cdaniel.pawlik@corp.ovh.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-22 10:13:33 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add hide hypervisor id on guest host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Image hide_hypervisor_id property helps libvirt set in xml instance file"},{"line_number":10,"context_line":"property, which will hide on guest host KVM hypervisor signature"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ff0f0b1f_924e0536","line":7,"updated":"2017-05-23 13:57:49.000000000","message":"The title should a) use `hide_hypervisor_id` (the real property name); and b) mention that this is an image_meta property.","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bda3837e6822b4c819566f9a1f8955decb7d74e9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add hide hypervisor id on guest host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Image hide_hypervisor_id property helps libvirt set in xml instance file"},{"line_number":10,"context_line":"property, which will hide on guest host KVM hypervisor signature"},{"line_number":11,"context_line":"(\"KVMKVMKVM\\0\\0\\0\")."},{"line_number":12,"context_line":"According to the commit message in QEMU repository [1]:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ff0f0b1f_52662dc3","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":54},"updated":"2017-05-23 13:57:49.000000000","message":"an","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05df23e0474f008f03f3f0c88dd672f1b3eb5ae9","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Co-Authored-By: Adam Kijak \u003cadam.kijak@corp.ovh.com\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"DocImpact"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Implements: blueprint add-kvm-hidden-feature"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"ff0f0b1f_85efcf1c","line":24,"updated":"2017-05-23 21:26:12.000000000","message":"This flag is going to automatically generate a nova bug report, so please mention that the documentation impact is that we need to document the new image metadata in https://docs.openstack.org/cli-reference/glance-property-keys.html.","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e85dde2fd70b3bd44ebb98ae3b9cd1ae882ee110","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Co-Authored-By: Adam Kijak \u003cadam.kijak@corp.ovh.com\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"DocImpact"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Implements: blueprint add-kvm-hidden-feature"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"ff0f0b1f_06f3b475","line":24,"in_reply_to":"ff0f0b1f_85efcf1c","updated":"2017-05-24 14:05:04.000000000","message":"Done","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c765655f6f1c3df25a0f336207cf4c04b1c48456","unresolved":false,"context_lines":[{"line_number":17,"context_line":"changing the KVM signature is sufficient for the driver"},{"line_number":18,"context_line":"to load and work.\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DocImpact: New feature ``hide_hypervisor_id`` image property should be added"},{"line_number":21,"context_line":"in the glance-property-keys page of the cli-reference docs [2]."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[1]: http://git.qemu.org/?p\u003dqemu.git;a\u003dcommitdiff;h\u003df522d2a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"df140735_dc37a1e3","line":20,"range":{"start_line":20,"start_character":25,"end_line":20,"end_character":43},"updated":"2017-05-27 13:59:19.000000000","message":"img_hide_hypervisor_id","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5d5da8455497d6de7feefd60912bab7a0bae290f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"changing the KVM signature is sufficient for the driver"},{"line_number":18,"context_line":"to load and work.\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DocImpact: New feature ``hide_hypervisor_id`` image property should be added"},{"line_number":21,"context_line":"in the glance-property-keys page of the cli-reference docs [2]."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[1]: http://git.qemu.org/?p\u003dqemu.git;a\u003dcommitdiff;h\u003df522d2a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"df140735_87830405","line":20,"range":{"start_line":20,"start_character":25,"end_line":20,"end_character":43},"in_reply_to":"df140735_dc37a1e3","updated":"2017-05-29 07:53:21.000000000","message":"Done","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cd81181a2c34f20ce406b8f04213b857353295c6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Pawlik \u003cdaniel.pawlik@corp.ovh.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-29 09:53:10 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add `hide_hypervisor_id` image property"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Image hide_hypervisor_id property helps libvirt set an xml instance file"},{"line_number":10,"context_line":"property, which will hide on guest host KVM hypervisor signature"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"df140735_e9bbaae2","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":23},"updated":"2017-05-29 15:25:44.000000000","message":"img_hide_hypervisor_id","commit_id":"2e1982c7196fc7d31c8e12bbbb035447ebed14c2"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e44ebc574bf4ddda1b423038b08a1513b24a496e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"for KVM as the hypervisor and reports Code 43 for the"},{"line_number":16,"context_line":"driver  in a Windows guest when found.  Removing or"},{"line_number":17,"context_line":"changing the KVM signature is sufficient for the driver"},{"line_number":18,"context_line":"to load and work.\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DocImpact: New feature ``img_hide_hypervisor_id`` image property should be"},{"line_number":21,"context_line":"added in the glance-property-keys page of the cli-reference docs [2]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"df140735_0dfff801","line":18,"updated":"2017-05-30 12:10:00.000000000","message":":( lame.","commit_id":"c7c08e590eb0ea2452a1a1d925297ba43fa609b0"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"c038e2517ccc8065ef4621ff1d1dec1faf78063e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"for KVM as the hypervisor and reports Code 43 for the"},{"line_number":16,"context_line":"driver  in a Windows guest when found.  Removing or"},{"line_number":17,"context_line":"changing the KVM signature is sufficient for the driver"},{"line_number":18,"context_line":"to load and work.\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DocImpact: New feature ``img_hide_hypervisor_id`` image property should be"},{"line_number":21,"context_line":"added in the glance-property-keys page of the cli-reference docs [2]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"df140735_6d47941f","line":18,"in_reply_to":"df140735_0dfff801","updated":"2017-05-31 07:43:01.000000000","message":";D","commit_id":"c7c08e590eb0ea2452a1a1d925297ba43fa609b0"}],"nova/objects/image_meta.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8eecb9e0b7846bcaf616b63fa31c50379147cf6b","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        \u0027img_signature_key_type\u0027: fields.ImageSignatureKeyTypeField(),"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        # boolean - hide KVM signature on instance"},{"line_number":422,"context_line":"        \u0027kvm_hidden\u0027: fields.FlexibleBooleanField(),"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        # string of username with admin privileges"},{"line_number":425,"context_line":"        \u0027os_admin_user\u0027: fields.StringField(),"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_646308b3","line":422,"range":{"start_line":422,"start_character":9,"end_line":422,"end_character":19},"updated":"2017-05-19 14:20:45.000000000","message":"Make this more generic by calling it something like hide_hypervisor_id.","commit_id":"52af0304d7fa05de40ac2aba6eda05dbbf72d4d7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05df23e0474f008f03f3f0c88dd672f1b3eb5ae9","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    # Maximum number of NUMA nodes permitted for the guest topology"},{"line_number":219,"context_line":"    NUMA_NODES_MAX \u003d 128"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    # \u0027hw_\u0027 - settings affecting the guest virtual machine hardware"},{"line_number":222,"context_line":"    # \u0027img_\u0027 - settings affecting the use of images by the compute node"},{"line_number":223,"context_line":"    # \u0027os_\u0027 - settings affecting the guest operating system setup"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    fields \u003d {"},{"line_number":226,"context_line":"        # name of guest hardware architecture eg i686, x86_64, ppc64"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_45809746","line":223,"range":{"start_line":221,"start_character":4,"end_line":223,"end_character":65},"updated":"2017-05-23 21:26:12.000000000","message":"You need to use one of these prefixes.","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e85dde2fd70b3bd44ebb98ae3b9cd1ae882ee110","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    # Maximum number of NUMA nodes permitted for the guest topology"},{"line_number":219,"context_line":"    NUMA_NODES_MAX \u003d 128"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    # \u0027hw_\u0027 - settings affecting the guest virtual machine hardware"},{"line_number":222,"context_line":"    # \u0027img_\u0027 - settings affecting the use of images by the compute node"},{"line_number":223,"context_line":"    # \u0027os_\u0027 - settings affecting the guest operating system setup"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    fields \u003d {"},{"line_number":226,"context_line":"        # name of guest hardware architecture eg i686, x86_64, ppc64"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_46aacc18","line":223,"range":{"start_line":221,"start_character":4,"end_line":223,"end_character":65},"in_reply_to":"ff0f0b1f_45809746","updated":"2017-05-24 14:05:04.000000000","message":"Done","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76482a8dfae7188b3715d0b0bd3a236aa7039b28","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    # Version 1.16: WatchdogActionField supports \u0027disabled\u0027 enum."},{"line_number":168,"context_line":"    # Version 1.17: Add lan9118 as valid nic for hw_vif_model property for qemu"},{"line_number":169,"context_line":"    # Version 1.18: Pull signature properties from cursive library"},{"line_number":170,"context_line":"    # Version 1.19: Added \u0027hide_hypervisor_id\u0027 type field"},{"line_number":171,"context_line":"    VERSION \u003d \u00271.19\u0027"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_992a5b8e","line":170,"range":{"start_line":170,"start_character":27,"end_line":170,"end_character":45},"updated":"2017-05-27 13:58:43.000000000","message":"img_hide_hypervisor_id","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5d5da8455497d6de7feefd60912bab7a0bae290f","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    # Version 1.16: WatchdogActionField supports \u0027disabled\u0027 enum."},{"line_number":168,"context_line":"    # Version 1.17: Add lan9118 as valid nic for hw_vif_model property for qemu"},{"line_number":169,"context_line":"    # Version 1.18: Pull signature properties from cursive library"},{"line_number":170,"context_line":"    # Version 1.19: Added \u0027hide_hypervisor_id\u0027 type field"},{"line_number":171,"context_line":"    VERSION \u003d \u00271.19\u0027"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_27279915","line":170,"range":{"start_line":170,"start_character":27,"end_line":170,"end_character":45},"in_reply_to":"df140735_992a5b8e","updated":"2017-05-29 07:53:21.000000000","message":"Done","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76482a8dfae7188b3715d0b0bd3a236aa7039b28","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                                                        target_version)"},{"line_number":176,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":177,"context_line":"        if target_version \u003c (1, 19):"},{"line_number":178,"context_line":"            primitive.pop(\u0027hide_hypervisor_id\u0027, None)"},{"line_number":179,"context_line":"        if target_version \u003c (1, 16) and \u0027hw_watchdog_action\u0027 in primitive:"},{"line_number":180,"context_line":"            # Check to see if hw_watchdog_action was set to \u0027disabled\u0027 and if"},{"line_number":181,"context_line":"            # so, remove it since not specifying it is the same behavior."}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_f92397bd","line":178,"range":{"start_line":178,"start_character":27,"end_line":178,"end_character":45},"updated":"2017-05-27 13:58:43.000000000","message":"This should be img_hide_hypervisor_id. You are missing a test for this. You can model a test after this example:\n\nhttps://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_image_meta.py#L311","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5d5da8455497d6de7feefd60912bab7a0bae290f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                                                        target_version)"},{"line_number":176,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":177,"context_line":"        if target_version \u003c (1, 19):"},{"line_number":178,"context_line":"            primitive.pop(\u0027hide_hypervisor_id\u0027, None)"},{"line_number":179,"context_line":"        if target_version \u003c (1, 16) and \u0027hw_watchdog_action\u0027 in primitive:"},{"line_number":180,"context_line":"            # Check to see if hw_watchdog_action was set to \u0027disabled\u0027 and if"},{"line_number":181,"context_line":"            # so, remove it since not specifying it is the same behavior."}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_271e780c","line":178,"range":{"start_line":178,"start_character":27,"end_line":178,"end_character":45},"in_reply_to":"df140735_f92397bd","updated":"2017-05-29 07:53:21.000000000","message":"Done","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"}],"nova/tests/unit/objects/test_image_meta.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cd81181a2c34f20ce406b8f04213b857353295c6","unresolved":false,"context_lines":[{"line_number":327,"context_line":"    def test_obj_make_compatible_img_hide_hypervisor_id(self):"},{"line_number":328,"context_line":"        \"\"\"Tests that checks if we pop img_hide_hypervisor_id.\"\"\""},{"line_number":329,"context_line":"        obj \u003d objects.ImageMetaProps(img_hide_hypervisor_id\u003dTrue)"},{"line_number":330,"context_line":"        primitive \u003d obj.obj_to_primitive(\u00271.0\u0027)"},{"line_number":331,"context_line":"        self.assertNotIn(\u0027img_hide_hypervisor_id\u0027,"},{"line_number":332,"context_line":"                         primitive[\u0027nova_object.data\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"df140735_69cf9a7f","line":330,"range":{"start_line":330,"start_character":42,"end_line":330,"end_character":45},"updated":"2017-05-29 15:25:44.000000000","message":"1.18 would be good but this works.","commit_id":"2e1982c7196fc7d31c8e12bbbb035447ebed14c2"}],"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"144472c403b8fdb8bca79930161f56ac89151b88","unresolved":false,"context_lines":[{"line_number":1999,"context_line":"        obj.features \u003d ["},{"line_number":2000,"context_line":"            config.LibvirtConfigGuestFeatureACPI(),"},{"line_number":2001,"context_line":"            config.LibvirtConfigGuestFeatureAPIC(),"},{"line_number":2002,"context_line":"            config.LibvirtConfigGuestFeaturePAE()"},{"line_number":2003,"context_line":"        ]"},{"line_number":2004,"context_line":""},{"line_number":2005,"context_line":"        disk \u003d config.LibvirtConfigGuestDisk()"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_a2eed785","line":2002,"updated":"2017-05-18 15:08:33.000000000","message":"This is an unnecessary change.","commit_id":"6243e90c432a8870473a7a9374a1b6df5e247940"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"b05beda7b4a228e87f312f7083198535c2c1e7a9","unresolved":false,"context_lines":[{"line_number":1999,"context_line":"        obj.features \u003d ["},{"line_number":2000,"context_line":"            config.LibvirtConfigGuestFeatureACPI(),"},{"line_number":2001,"context_line":"            config.LibvirtConfigGuestFeatureAPIC(),"},{"line_number":2002,"context_line":"            config.LibvirtConfigGuestFeaturePAE()"},{"line_number":2003,"context_line":"        ]"},{"line_number":2004,"context_line":""},{"line_number":2005,"context_line":"        disk \u003d config.LibvirtConfigGuestDisk()"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_69740e69","line":2002,"in_reply_to":"ff0f0b1f_a2eed785","updated":"2017-05-19 07:46:37.000000000","message":"ok","commit_id":"6243e90c432a8870473a7a9374a1b6df5e247940"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bda3837e6822b4c819566f9a1f8955decb7d74e9","unresolved":false,"context_lines":[{"line_number":4936,"context_line":"                                     image_meta,"},{"line_number":4937,"context_line":"                                     disk_info)"},{"line_number":4938,"context_line":""},{"line_number":4939,"context_line":"        self.assertIsInstance(cfg.features[2],"},{"line_number":4940,"context_line":"                              vconfig.LibvirtConfigGuestFeatureKvmHidden)"},{"line_number":4941,"context_line":""},{"line_number":4942,"context_line":"    @mock.patch.object("}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_f7dbf3e9","line":4939,"range":{"start_line":4939,"start_character":30,"end_line":4939,"end_character":45},"updated":"2017-05-23 13:57:49.000000000","message":"Seems a tad brittle, relying on the exact position of the feature in the config.  Perhaps something more like:\n\n self.assertTrue(any(isinstance(feat, vconfig.LibvirtConfigGuestFeatureKvmHidden) for feat in cfg.features)\n\n?","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"7edad452b13a190fe6c06bed378aa3886cd65b3d","unresolved":false,"context_lines":[{"line_number":4936,"context_line":"                                     image_meta,"},{"line_number":4937,"context_line":"                                     disk_info)"},{"line_number":4938,"context_line":""},{"line_number":4939,"context_line":"        self.assertIsInstance(cfg.features[2],"},{"line_number":4940,"context_line":"                              vconfig.LibvirtConfigGuestFeatureKvmHidden)"},{"line_number":4941,"context_line":""},{"line_number":4942,"context_line":"    @mock.patch.object("}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_34ca864d","line":4939,"range":{"start_line":4939,"start_character":30,"end_line":4939,"end_character":45},"in_reply_to":"ff0f0b1f_f7dbf3e9","updated":"2017-05-23 14:38:29.000000000","message":"I like your solution","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bda3837e6822b4c819566f9a1f8955decb7d74e9","unresolved":false,"context_lines":[{"line_number":4939,"context_line":"        self.assertIsInstance(cfg.features[2],"},{"line_number":4940,"context_line":"                              vconfig.LibvirtConfigGuestFeatureKvmHidden)"},{"line_number":4941,"context_line":""},{"line_number":4942,"context_line":"    @mock.patch.object("},{"line_number":4943,"context_line":"        host.Host, \"is_cpu_control_policy_capable\", return_value\u003dTrue)"},{"line_number":4944,"context_line":"    def test_get_guest_config_with_bogus_cpu_quota(self, is_able):"},{"line_number":4945,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027, group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_77f1236b","line":4942,"updated":"2017-05-23 13:57:49.000000000","message":"Do we want another test case (or add to an existing test case) that proves the feature is off/absent when the property is unset/false?","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"7edad452b13a190fe6c06bed378aa3886cd65b3d","unresolved":false,"context_lines":[{"line_number":4939,"context_line":"        self.assertIsInstance(cfg.features[2],"},{"line_number":4940,"context_line":"                              vconfig.LibvirtConfigGuestFeatureKvmHidden)"},{"line_number":4941,"context_line":""},{"line_number":4942,"context_line":"    @mock.patch.object("},{"line_number":4943,"context_line":"        host.Host, \"is_cpu_control_policy_capable\", return_value\u003dTrue)"},{"line_number":4944,"context_line":"    def test_get_guest_config_with_bogus_cpu_quota(self, is_able):"},{"line_number":4945,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027, group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_f442ceaa","line":4942,"in_reply_to":"ff0f0b1f_77f1236b","updated":"2017-05-23 14:38:29.000000000","message":"I guess it should be, but in other tests \"test_get_guest_config_with_* \" your suggested test are not available. So maybe we can leave it without new test?","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"37643f9958ea2ffa5a6b7929e683ef61c1cc868d","unresolved":false,"context_lines":[{"line_number":4939,"context_line":"        self.assertIsInstance(cfg.features[2],"},{"line_number":4940,"context_line":"                              vconfig.LibvirtConfigGuestFeatureKvmHidden)"},{"line_number":4941,"context_line":""},{"line_number":4942,"context_line":"    @mock.patch.object("},{"line_number":4943,"context_line":"        host.Host, \"is_cpu_control_policy_capable\", return_value\u003dTrue)"},{"line_number":4944,"context_line":"    def test_get_guest_config_with_bogus_cpu_quota(self, is_able):"},{"line_number":4945,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027, group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_f71bf0c6","line":4942,"in_reply_to":"ff0f0b1f_f442ceaa","updated":"2017-05-23 14:58:28.000000000","message":"I don\u0027t understand.  A new test case would be almost a straight copy of this one, but with:\n\n ...\n     \"properties\": {\"hide_hypervisor_id\": \"false\"}})\n ...\n self.assertFalse(any(isinstance(feat, vconfig.LibvirtConfigGuestFeatureKvmHidden) for feat in cfg.features))\n\n...and/or one with \"hide_hypervisor_id\" absent from \"properties\".","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"7ea10026611a210580b761f968281bfcb68b6223","unresolved":false,"context_lines":[{"line_number":4939,"context_line":"        self.assertIsInstance(cfg.features[2],"},{"line_number":4940,"context_line":"                              vconfig.LibvirtConfigGuestFeatureKvmHidden)"},{"line_number":4941,"context_line":""},{"line_number":4942,"context_line":"    @mock.patch.object("},{"line_number":4943,"context_line":"        host.Host, \"is_cpu_control_policy_capable\", return_value\u003dTrue)"},{"line_number":4944,"context_line":"    def test_get_guest_config_with_bogus_cpu_quota(self, is_able):"},{"line_number":4945,"context_line":"        self.flags(virt_type\u003d\u0027kvm\u0027, group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_fac053e3","line":4942,"in_reply_to":"ff0f0b1f_f71bf0c6","updated":"2017-05-24 13:58:51.000000000","message":"Done","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"78ce2702f2b6196e393f5bd387d58b68f6b20dfa","unresolved":false,"context_lines":[{"line_number":4181,"context_line":"            hv.vapic \u003d True"},{"line_number":4182,"context_line":"            guest.features.append(hv)"},{"line_number":4183,"context_line":""},{"line_number":4184,"context_line":"        if (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4185,"context_line":"                image_meta.properties.get(\u0027kvm_hidden\u0027)):"},{"line_number":4186,"context_line":"            guest.features.append(vconfig.LibvirtConfigGuestFeatureKvmHidden())"},{"line_number":4187,"context_line":""},{"line_number":4188,"context_line":"    def _check_number_of_serial_console(self, num_ports):"},{"line_number":4189,"context_line":"        virt_type \u003d CONF.libvirt.virt_type"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_a668fe86","line":4186,"range":{"start_line":4184,"start_character":8,"end_line":4186,"end_character":79},"updated":"2017-04-25 17:52:10.000000000","message":"what happens for qemu older then 2.1?\nif the request will not be ignored by libvirt when using older qemu versions you will need to wrap this in a version check.","commit_id":"f79f74bc6e2a5125c6c2865999ab2e8370238a74"},{"author":{"_account_id":19619,"name":"Michal Pryc","email":"mpryc@redhat.com","username":"migi"},"change_message_id":"4d553defb7eacf40081ecc6236289eafed4d1279","unresolved":false,"context_lines":[{"line_number":4181,"context_line":"            hv.vapic \u003d True"},{"line_number":4182,"context_line":"            guest.features.append(hv)"},{"line_number":4183,"context_line":""},{"line_number":4184,"context_line":"        # NOTE(danpawlik): KVM hidded feature is available since Qemu 2.1."},{"line_number":4185,"context_line":"        # In older Qemu version this feature will be ignored."},{"line_number":4186,"context_line":"        if (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4187,"context_line":"                image_meta.properties.get(\u0027kvm_hidden\u0027)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_4de145d0","line":4184,"updated":"2017-04-26 08:09:21.000000000","message":"It\u0027s since libvirt 1.2.8 (QEMU 2.1.0)","commit_id":"1127fc74f78803ce5e603ea4991a93b1d0575a89"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"f693e295822f468875c3e21e4e4ca08d4acdef6b","unresolved":false,"context_lines":[{"line_number":4181,"context_line":"            hv.vapic \u003d True"},{"line_number":4182,"context_line":"            guest.features.append(hv)"},{"line_number":4183,"context_line":""},{"line_number":4184,"context_line":"        # NOTE(danpawlik): KVM hidded feature is available since Qemu 2.1."},{"line_number":4185,"context_line":"        # In older Qemu version this feature will be ignored."},{"line_number":4186,"context_line":"        if (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4187,"context_line":"                image_meta.properties.get(\u0027kvm_hidden\u0027)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_0ceb3679","line":4184,"in_reply_to":"5ff73747_4de145d0","updated":"2017-04-26 13:11:48.000000000","message":"Done","commit_id":"1127fc74f78803ce5e603ea4991a93b1d0575a89"},{"author":{"_account_id":19619,"name":"Michal Pryc","email":"mpryc@redhat.com","username":"migi"},"change_message_id":"ac395e87429dd8e58b0096f945355ac024ed8f23","unresolved":false,"context_lines":[{"line_number":4181,"context_line":"            hv.vapic \u003d True"},{"line_number":4182,"context_line":"            guest.features.append(hv)"},{"line_number":4183,"context_line":""},{"line_number":4184,"context_line":"        # NOTE(danpawlik): KVM hidded feature is available since Qemu 2.1."},{"line_number":4185,"context_line":"        # In older Qemu version this feature will be ignored."},{"line_number":4186,"context_line":"        if (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4187,"context_line":"                image_meta.properties.get(\u0027kvm_hidden\u0027)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_885f3b0d","line":4184,"in_reply_to":"5ff73747_4de145d0","updated":"2017-04-26 08:09:45.000000000","message":"Please make explicit note and correct version.","commit_id":"1127fc74f78803ce5e603ea4991a93b1d0575a89"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"f693e295822f468875c3e21e4e4ca08d4acdef6b","unresolved":false,"context_lines":[{"line_number":4181,"context_line":"            hv.vapic \u003d True"},{"line_number":4182,"context_line":"            guest.features.append(hv)"},{"line_number":4183,"context_line":""},{"line_number":4184,"context_line":"        # NOTE(danpawlik): KVM hidded feature is available since Qemu 2.1."},{"line_number":4185,"context_line":"        # In older Qemu version this feature will be ignored."},{"line_number":4186,"context_line":"        if (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4187,"context_line":"                image_meta.properties.get(\u0027kvm_hidden\u0027)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_cc042e4d","line":4184,"in_reply_to":"5ff73747_885f3b0d","updated":"2017-04-26 13:11:48.000000000","message":"Done","commit_id":"1127fc74f78803ce5e603ea4991a93b1d0575a89"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d759930e921bd4ccf203aae0b6e01b7d18b6475e","unresolved":false,"context_lines":[{"line_number":4181,"context_line":"            hv.vapic \u003d True"},{"line_number":4182,"context_line":"            guest.features.append(hv)"},{"line_number":4183,"context_line":""},{"line_number":4184,"context_line":"        # NOTE(danpawlik): KVM hidded feature is available since libvrit 1.2.8"},{"line_number":4185,"context_line":"        # and Qemu 2.1.0. In older Qemu version this feature will be ignored."},{"line_number":4186,"context_line":"        if (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4187,"context_line":"                image_meta.properties.get(\u0027kvm_hidden\u0027)):"},{"line_number":4188,"context_line":"            guest.features.append(vconfig.LibvirtConfigGuestFeatureKvmHidden())"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_bc24a80e","line":4185,"range":{"start_line":4184,"start_character":0,"end_line":4185,"end_character":77},"updated":"2017-05-05 10:17:17.000000000","message":"We don\u0027t need to include this as we don\u0027t support anything less that these versions (see the MIN_LIBVIRT_VERSION, MIN_QEMU_VERSION parameters in this file)","commit_id":"4c6db8afbe9ade162262b98de2356791e518112b"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e97927e1f4c7029f01d7d64115ec34ed16eac36c","unresolved":false,"context_lines":[{"line_number":4181,"context_line":"            hv.vapic \u003d True"},{"line_number":4182,"context_line":"            guest.features.append(hv)"},{"line_number":4183,"context_line":""},{"line_number":4184,"context_line":"        # NOTE(danpawlik): KVM hidded feature is available since libvrit 1.2.8"},{"line_number":4185,"context_line":"        # and Qemu 2.1.0. In older Qemu version this feature will be ignored."},{"line_number":4186,"context_line":"        if (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4187,"context_line":"                image_meta.properties.get(\u0027kvm_hidden\u0027)):"},{"line_number":4188,"context_line":"            guest.features.append(vconfig.LibvirtConfigGuestFeatureKvmHidden())"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_a385a3af","line":4185,"range":{"start_line":4184,"start_character":0,"end_line":4185,"end_character":77},"in_reply_to":"3f044301_bc24a80e","updated":"2017-05-05 14:22:28.000000000","message":"Done","commit_id":"4c6db8afbe9ade162262b98de2356791e518112b"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"0b31e148b7443b45c9b6e83b67ce17f72550dfae","unresolved":false,"context_lines":[{"line_number":4182,"context_line":"            guest.features.append(hv)"},{"line_number":4183,"context_line":""},{"line_number":4184,"context_line":"        if (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4185,"context_line":"                image_meta.properties.get(\u0027kvm_hidden\u0027)):"},{"line_number":4186,"context_line":"            guest.features.append(vconfig.LibvirtConfigGuestFeatureKvmHidden())"},{"line_number":4187,"context_line":""},{"line_number":4188,"context_line":"    def _check_number_of_serial_console(self, num_ports):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_642e68fb","line":4185,"updated":"2017-05-19 14:34:45.000000000","message":"Based on the IRC discussion (on #openstack-nova), with Dan Smith, and Matt Riedemann, this property should be called, \u0027hide_hypervisor_id\u0027, as \"kvm_hidden\" is confusing (it can make people think: \"Oh, this will disable KVM completely!\"), which is not desirable. \n\nAnd at Nova-level, a hypervisor-agnostic config attribute is more sensible.","commit_id":"52af0304d7fa05de40ac2aba6eda05dbbf72d4d7"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"2779af9b572be80aa4a624fe024688eb830aa9fe","unresolved":false,"context_lines":[{"line_number":197,"context_line":"# versions. Over time, this will become a common min version"},{"line_number":198,"context_line":"# for all architectures/hypervisors, as this value rises to"},{"line_number":199,"context_line":"# meet them."},{"line_number":200,"context_line":"MIN_LIBVIRT_VERSION \u003d (1, 2, 9)"},{"line_number":201,"context_line":"MIN_QEMU_VERSION \u003d (2, 1, 0)"},{"line_number":202,"context_line":"# TODO(berrange): Re-evaluate this at start of each release cycle"},{"line_number":203,"context_line":"# to decide if we want to plan a future min version bump."}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_ad018eb1","line":200,"updated":"2017-05-24 08:12:29.000000000","message":"MIN_LIBVIRT_VERSION should be 1.2.8.\n\nSee here, and `grep` for the string \"hidden\":\n\nhttp://libvirt.org/formatdomain.html#elementsFeatures","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e85dde2fd70b3bd44ebb98ae3b9cd1ae882ee110","unresolved":false,"context_lines":[{"line_number":197,"context_line":"# versions. Over time, this will become a common min version"},{"line_number":198,"context_line":"# for all architectures/hypervisors, as this value rises to"},{"line_number":199,"context_line":"# meet them."},{"line_number":200,"context_line":"MIN_LIBVIRT_VERSION \u003d (1, 2, 9)"},{"line_number":201,"context_line":"MIN_QEMU_VERSION \u003d (2, 1, 0)"},{"line_number":202,"context_line":"# TODO(berrange): Re-evaluate this at start of each release cycle"},{"line_number":203,"context_line":"# to decide if we want to plan a future min version bump."}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_fa785390","line":200,"in_reply_to":"ff0f0b1f_ad018eb1","updated":"2017-05-24 14:05:04.000000000","message":"So it means that this feature should be also available in version 1.2.9 or :) ?","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"60b75513e1f642b8738f5694615680c25361f265","unresolved":false,"context_lines":[{"line_number":197,"context_line":"# versions. Over time, this will become a common min version"},{"line_number":198,"context_line":"# for all architectures/hypervisors, as this value rises to"},{"line_number":199,"context_line":"# meet them."},{"line_number":200,"context_line":"MIN_LIBVIRT_VERSION \u003d (1, 2, 9)"},{"line_number":201,"context_line":"MIN_QEMU_VERSION \u003d (2, 1, 0)"},{"line_number":202,"context_line":"# TODO(berrange): Re-evaluate this at start of each release cycle"},{"line_number":203,"context_line":"# to decide if we want to plan a future min version bump."},{"line_number":204,"context_line":"# MIN_LIBVIRT_VERSION can be updated to match this after"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_986a9517","line":201,"range":{"start_line":200,"start_character":0,"end_line":201,"end_character":28},"updated":"2017-05-24 01:08:06.000000000","message":"The blueprint says that the kvm hidden feature was added in qemu 2.1, which is our minimum required version, so that\u0027s good. Is there anything we\u0027d need with libvirt for this? I don\u0027t think so, but thought I should ask.","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"2779af9b572be80aa4a624fe024688eb830aa9fe","unresolved":false,"context_lines":[{"line_number":197,"context_line":"# versions. Over time, this will become a common min version"},{"line_number":198,"context_line":"# for all architectures/hypervisors, as this value rises to"},{"line_number":199,"context_line":"# meet them."},{"line_number":200,"context_line":"MIN_LIBVIRT_VERSION \u003d (1, 2, 9)"},{"line_number":201,"context_line":"MIN_QEMU_VERSION \u003d (2, 1, 0)"},{"line_number":202,"context_line":"# TODO(berrange): Re-evaluate this at start of each release cycle"},{"line_number":203,"context_line":"# to decide if we want to plan a future min version bump."},{"line_number":204,"context_line":"# MIN_LIBVIRT_VERSION can be updated to match this after"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_edfb06be","line":201,"range":{"start_line":200,"start_character":0,"end_line":201,"end_character":28},"in_reply_to":"ff0f0b1f_986a9517","updated":"2017-05-24 08:12:29.000000000","message":"As near as I know, nothing more, libvirt has the below XML attribute exposed since 1.2.8:\n\n    \u003ckvm\u003e\n      \u003chidden state\u003d\u0027on|off\u0027/\u003e\n    \u003c/kvm\u003e","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e85dde2fd70b3bd44ebb98ae3b9cd1ae882ee110","unresolved":false,"context_lines":[{"line_number":197,"context_line":"# versions. Over time, this will become a common min version"},{"line_number":198,"context_line":"# for all architectures/hypervisors, as this value rises to"},{"line_number":199,"context_line":"# meet them."},{"line_number":200,"context_line":"MIN_LIBVIRT_VERSION \u003d (1, 2, 9)"},{"line_number":201,"context_line":"MIN_QEMU_VERSION \u003d (2, 1, 0)"},{"line_number":202,"context_line":"# TODO(berrange): Re-evaluate this at start of each release cycle"},{"line_number":203,"context_line":"# to decide if we want to plan a future min version bump."},{"line_number":204,"context_line":"# MIN_LIBVIRT_VERSION can be updated to match this after"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_6967e3ea","line":201,"range":{"start_line":200,"start_character":0,"end_line":201,"end_character":28},"in_reply_to":"ff0f0b1f_edfb06be","updated":"2017-05-24 14:05:04.000000000","message":"Exactly.\nIMHO hidden state off is not necessary to include on instances where this feature is not required.","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"}],"releasenotes/notes/hide_hypervisor_id-6f93e7552336930d.yaml":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bda3837e6822b4c819566f9a1f8955decb7d74e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hide hypervisor id allows to hide signature for the gest."},{"line_number":5,"context_line":"    It enables disabling of some paravirualization features in the"},{"line_number":6,"context_line":"    guest as well as allowing certain drivers which test for the"},{"line_number":7,"context_line":"    hypervisor to load e.g. Nvidia driver [1]:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_37b5eb7e","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":22},"updated":"2017-05-23 13:57:49.000000000","message":"hide_hypervisor_id (the real name of the property)","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bda3837e6822b4c819566f9a1f8955decb7d74e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hide hypervisor id allows to hide signature for the gest."},{"line_number":5,"context_line":"    It enables disabling of some paravirualization features in the"},{"line_number":6,"context_line":"    guest as well as allowing certain drivers which test for the"},{"line_number":7,"context_line":"    hypervisor to load e.g. Nvidia driver [1]:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_f7b2d393","line":4,"range":{"start_line":4,"start_character":23,"end_line":4,"end_character":61},"updated":"2017-05-23 13:57:49.000000000","message":"hides the signature for the guest","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"cc86c92bfed488975ad78136941cf186b090fcf3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hide hypervisor id allows to hide signature for the gest."},{"line_number":5,"context_line":"    It enables disabling of some paravirualization features in the"},{"line_number":6,"context_line":"    guest as well as allowing certain drivers which test for the"},{"line_number":7,"context_line":"    hypervisor to load e.g. Nvidia driver [1]:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_1719c420","line":4,"range":{"start_line":4,"start_character":23,"end_line":4,"end_character":61},"in_reply_to":"ff0f0b1f_f7b2d393","updated":"2017-05-23 14:51:44.000000000","message":"Done","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bda3837e6822b4c819566f9a1f8955decb7d74e9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hide hypervisor id allows to hide signature for the gest."},{"line_number":5,"context_line":"    It enables disabling of some paravirualization features in the"},{"line_number":6,"context_line":"    guest as well as allowing certain drivers which test for the"},{"line_number":7,"context_line":"    hypervisor to load e.g. Nvidia driver [1]:"},{"line_number":8,"context_line":"    \"The latest Nvidia driver (337.88) specifically checks"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_b7a8db1f","line":5,"range":{"start_line":5,"start_character":7,"end_line":5,"end_character":27},"updated":"2017-05-23 13:57:49.000000000","message":"disables","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"cc86c92bfed488975ad78136941cf186b090fcf3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hide hypervisor id allows to hide signature for the gest."},{"line_number":5,"context_line":"    It enables disabling of some paravirualization features in the"},{"line_number":6,"context_line":"    guest as well as allowing certain drivers which test for the"},{"line_number":7,"context_line":"    hypervisor to load e.g. Nvidia driver [1]:"},{"line_number":8,"context_line":"    \"The latest Nvidia driver (337.88) specifically checks"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_f71530e6","line":5,"range":{"start_line":5,"start_character":7,"end_line":5,"end_character":27},"in_reply_to":"ff0f0b1f_b7a8db1f","updated":"2017-05-23 14:51:44.000000000","message":"Done","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bda3837e6822b4c819566f9a1f8955decb7d74e9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    hypervisor to load e.g. Nvidia driver [1]:"},{"line_number":8,"context_line":"    \"The latest Nvidia driver (337.88) specifically checks"},{"line_number":9,"context_line":"    for KVM as the hypervisor and reports Code 43 for the"},{"line_number":10,"context_line":"    driver  in a Windows guest when found.  Removing or"},{"line_number":11,"context_line":"    changing the KVM signature is sufficient for the driver"},{"line_number":12,"context_line":"    to load and work.\""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_d7746fd1","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":12},"updated":"2017-05-23 13:57:49.000000000","message":"remove extra space","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"cc86c92bfed488975ad78136941cf186b090fcf3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    hypervisor to load e.g. Nvidia driver [1]:"},{"line_number":8,"context_line":"    \"The latest Nvidia driver (337.88) specifically checks"},{"line_number":9,"context_line":"    for KVM as the hypervisor and reports Code 43 for the"},{"line_number":10,"context_line":"    driver  in a Windows guest when found.  Removing or"},{"line_number":11,"context_line":"    changing the KVM signature is sufficient for the driver"},{"line_number":12,"context_line":"    to load and work.\""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_77dfe039","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":12},"in_reply_to":"ff0f0b1f_d7746fd1","updated":"2017-05-23 14:51:44.000000000","message":"Done","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bda3837e6822b4c819566f9a1f8955decb7d74e9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    changing the KVM signature is sufficient for the driver"},{"line_number":12,"context_line":"    to load and work.\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    Signature can be also hide by adding in QEMU command line \"-cpu kvm\u003doff\""},{"line_number":15,"context_line":"    parameter."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    To verify if hiding hypervisor id is working on Linux based system by"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_977a77b7","line":14,"range":{"start_line":14,"start_character":26,"end_line":14,"end_character":30},"updated":"2017-05-23 13:57:49.000000000","message":"hidden","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"cc86c92bfed488975ad78136941cf186b090fcf3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    changing the KVM signature is sufficient for the driver"},{"line_number":12,"context_line":"    to load and work.\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    Signature can be also hide by adding in QEMU command line \"-cpu kvm\u003doff\""},{"line_number":15,"context_line":"    parameter."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    To verify if hiding hypervisor id is working on Linux based system by"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_57e85ce0","line":14,"range":{"start_line":14,"start_character":26,"end_line":14,"end_character":30},"in_reply_to":"ff0f0b1f_977a77b7","updated":"2017-05-23 14:51:44.000000000","message":"Done","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bda3837e6822b4c819566f9a1f8955decb7d74e9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    changing the KVM signature is sufficient for the driver"},{"line_number":12,"context_line":"    to load and work.\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    Signature can be also hide by adding in QEMU command line \"-cpu kvm\u003doff\""},{"line_number":15,"context_line":"    parameter."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    To verify if hiding hypervisor id is working on Linux based system by"},{"line_number":18,"context_line":"    using command:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_37384bec","line":15,"range":{"start_line":14,"start_character":41,"end_line":15,"end_character":13},"updated":"2017-05-23 13:57:49.000000000","message":"the QEMU command line option \"-cpu kvm\u003doff\"","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"cc86c92bfed488975ad78136941cf186b090fcf3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    changing the KVM signature is sufficient for the driver"},{"line_number":12,"context_line":"    to load and work.\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    Signature can be also hide by adding in QEMU command line \"-cpu kvm\u003doff\""},{"line_number":15,"context_line":"    parameter."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    To verify if hiding hypervisor id is working on Linux based system by"},{"line_number":18,"context_line":"    using command:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_37e5e809","line":15,"range":{"start_line":14,"start_character":41,"end_line":15,"end_character":13},"in_reply_to":"ff0f0b1f_37384bec","updated":"2017-05-23 14:51:44.000000000","message":"Done","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bda3837e6822b4c819566f9a1f8955decb7d74e9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    Signature can be also hide by adding in QEMU command line \"-cpu kvm\u003doff\""},{"line_number":15,"context_line":"    parameter."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    To verify if hiding hypervisor id is working on Linux based system by"},{"line_number":18,"context_line":"    using command:"},{"line_number":19,"context_line":"    cpuid | grep -i hypervisor_id"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_173d47dc","line":17,"range":{"start_line":17,"start_character":4,"end_line":17,"end_character":8},"updated":"2017-05-23 13:57:49.000000000","message":"V","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"cc86c92bfed488975ad78136941cf186b090fcf3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    Signature can be also hide by adding in QEMU command line \"-cpu kvm\u003doff\""},{"line_number":15,"context_line":"    parameter."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    To verify if hiding hypervisor id is working on Linux based system by"},{"line_number":18,"context_line":"    using command:"},{"line_number":19,"context_line":"    cpuid | grep -i hypervisor_id"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_f7ead0d5","line":17,"range":{"start_line":17,"start_character":4,"end_line":17,"end_character":8},"in_reply_to":"ff0f0b1f_173d47dc","updated":"2017-05-23 14:51:44.000000000","message":"Done","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bda3837e6822b4c819566f9a1f8955decb7d74e9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    parameter."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    To verify if hiding hypervisor id is working on Linux based system by"},{"line_number":18,"context_line":"    using command:"},{"line_number":19,"context_line":"    cpuid | grep -i hypervisor_id"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Result should not be:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_d7222fb9","line":18,"updated":"2017-05-23 13:57:49.000000000","message":"the","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"cc86c92bfed488975ad78136941cf186b090fcf3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    parameter."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    To verify if hiding hypervisor id is working on Linux based system by"},{"line_number":18,"context_line":"    using command:"},{"line_number":19,"context_line":"    cpuid | grep -i hypervisor_id"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Result should not be:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_d7bd8cd8","line":18,"in_reply_to":"ff0f0b1f_d7222fb9","updated":"2017-05-23 14:51:44.000000000","message":"Done","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bda3837e6822b4c819566f9a1f8955decb7d74e9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    Result should not be:"},{"line_number":22,"context_line":"    hypervisor_id \u003d \"KVMKVMKVM\\0\\0\\0\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    You can enable this feature by adding ``hide_hypervisor_id`` key"},{"line_number":25,"context_line":"    into image metadata."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    [1]: http://git.qemu.org/?p\u003dqemu.git;a\u003dcommitdiff;h\u003df522d2a"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_771b6380","line":24,"updated":"2017-05-23 13:57:49.000000000","message":"the","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"cc86c92bfed488975ad78136941cf186b090fcf3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    Result should not be:"},{"line_number":22,"context_line":"    hypervisor_id \u003d \"KVMKVMKVM\\0\\0\\0\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    You can enable this feature by adding ``hide_hypervisor_id`` key"},{"line_number":25,"context_line":"    into image metadata."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    [1]: http://git.qemu.org/?p\u003dqemu.git;a\u003dcommitdiff;h\u003df522d2a"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_97b3940a","line":24,"in_reply_to":"ff0f0b1f_771b6380","updated":"2017-05-23 14:51:44.000000000","message":"Done","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bda3837e6822b4c819566f9a1f8955decb7d74e9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    hypervisor_id \u003d \"KVMKVMKVM\\0\\0\\0\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    You can enable this feature by adding ``hide_hypervisor_id`` key"},{"line_number":25,"context_line":"    into image metadata."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    [1]: http://git.qemu.org/?p\u003dqemu.git;a\u003dcommitdiff;h\u003df522d2a"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_d70b4f27","line":25,"updated":"2017-05-23 13:57:49.000000000","message":"\"the \u0027properties\u0027 dict of\"?","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"cc86c92bfed488975ad78136941cf186b090fcf3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    hypervisor_id \u003d \"KVMKVMKVM\\0\\0\\0\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    You can enable this feature by adding ``hide_hypervisor_id`` key"},{"line_number":25,"context_line":"    into image metadata."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    [1]: http://git.qemu.org/?p\u003dqemu.git;a\u003dcommitdiff;h\u003df522d2a"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff0f0b1f_77b800e4","line":25,"in_reply_to":"ff0f0b1f_d70b4f27","updated":"2017-05-23 14:51:44.000000000","message":"Done","commit_id":"8a3fbb67ac841d268d150701b41a5ba036935639"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05df23e0474f008f03f3f0c88dd672f1b3eb5ae9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``hide_hypervisor_id`` hides the signature for the guest."},{"line_number":5,"context_line":"    It disables some paravirualization features in the"},{"line_number":6,"context_line":"    guest as well as allowing certain drivers which test for the"},{"line_number":7,"context_line":"    hypervisor to load e.g. Nvidia driver [1]:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff0f0b1f_25fa43bc","line":4,"range":{"start_line":4,"start_character":55,"end_line":4,"end_character":60},"updated":"2017-05-23 21:26:12.000000000","message":"I would also make a note that this is currently only supported in the libvirt compute driver.","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05df23e0474f008f03f3f0c88dd672f1b3eb5ae9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``hide_hypervisor_id`` hides the signature for the guest."},{"line_number":5,"context_line":"    It disables some paravirualization features in the"},{"line_number":6,"context_line":"    guest as well as allowing certain drivers which test for the"},{"line_number":7,"context_line":"    hypervisor to load e.g. Nvidia driver [1]:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff0f0b1f_c56707b7","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":26},"updated":"2017-05-23 21:26:12.000000000","message":"The new ``hide_hypervisor_id`` image metadata property\n\n--\n\nor whatever you call it after applying the prefix","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05df23e0474f008f03f3f0c88dd672f1b3eb5ae9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``hide_hypervisor_id`` hides the signature for the guest."},{"line_number":5,"context_line":"    It disables some paravirualization features in the"},{"line_number":6,"context_line":"    guest as well as allowing certain drivers which test for the"},{"line_number":7,"context_line":"    hypervisor to load e.g. Nvidia driver [1]:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff0f0b1f_05729f7b","line":4,"range":{"start_line":4,"start_character":37,"end_line":4,"end_character":46},"updated":"2017-05-23 21:26:12.000000000","message":"Which signature? Context please.","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e85dde2fd70b3bd44ebb98ae3b9cd1ae882ee110","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``hide_hypervisor_id`` hides the signature for the guest."},{"line_number":5,"context_line":"    It disables some paravirualization features in the"},{"line_number":6,"context_line":"    guest as well as allowing certain drivers which test for the"},{"line_number":7,"context_line":"    hypervisor to load e.g. Nvidia driver [1]:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff0f0b1f_b4443275","line":4,"range":{"start_line":4,"start_character":37,"end_line":4,"end_character":46},"in_reply_to":"ff0f0b1f_05729f7b","updated":"2017-05-24 14:05:04.000000000","message":"Done","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e85dde2fd70b3bd44ebb98ae3b9cd1ae882ee110","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``hide_hypervisor_id`` hides the signature for the guest."},{"line_number":5,"context_line":"    It disables some paravirualization features in the"},{"line_number":6,"context_line":"    guest as well as allowing certain drivers which test for the"},{"line_number":7,"context_line":"    hypervisor to load e.g. Nvidia driver [1]:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff0f0b1f_d419e6d6","line":4,"range":{"start_line":4,"start_character":55,"end_line":4,"end_character":60},"in_reply_to":"ff0f0b1f_25fa43bc","updated":"2017-05-24 14:05:04.000000000","message":"Done","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e85dde2fd70b3bd44ebb98ae3b9cd1ae882ee110","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``hide_hypervisor_id`` hides the signature for the guest."},{"line_number":5,"context_line":"    It disables some paravirualization features in the"},{"line_number":6,"context_line":"    guest as well as allowing certain drivers which test for the"},{"line_number":7,"context_line":"    hypervisor to load e.g. Nvidia driver [1]:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff0f0b1f_f4162aa8","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":26},"in_reply_to":"ff0f0b1f_c56707b7","updated":"2017-05-24 14:05:04.000000000","message":"Done","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05df23e0474f008f03f3f0c88dd672f1b3eb5ae9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    changing the KVM signature is sufficient for the driver"},{"line_number":12,"context_line":"    to load and work.\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    Signature can be also hidden by adding the QEMU command line"},{"line_number":15,"context_line":"    option \"-cpu kvm\u003doff\"."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    Verify if hiding hypervisor id is working on Linux based system by"},{"line_number":18,"context_line":"    using the command:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff0f0b1f_4511b703","line":15,"range":{"start_line":14,"start_character":4,"end_line":15,"end_character":26},"updated":"2017-05-23 21:26:12.000000000","message":"This doesn\u0027t apply to nova, right? I\u0027d remove this.","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e85dde2fd70b3bd44ebb98ae3b9cd1ae882ee110","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    changing the KVM signature is sufficient for the driver"},{"line_number":12,"context_line":"    to load and work.\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    Signature can be also hidden by adding the QEMU command line"},{"line_number":15,"context_line":"    option \"-cpu kvm\u003doff\"."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    Verify if hiding hypervisor id is working on Linux based system by"},{"line_number":18,"context_line":"    using the command:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff0f0b1f_0ff7475b","line":15,"range":{"start_line":14,"start_character":4,"end_line":15,"end_character":26},"in_reply_to":"ff0f0b1f_4511b703","updated":"2017-05-24 14:05:04.000000000","message":"Done","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05df23e0474f008f03f3f0c88dd672f1b3eb5ae9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    option \"-cpu kvm\u003doff\"."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    Verify if hiding hypervisor id is working on Linux based system by"},{"line_number":18,"context_line":"    using the command:"},{"line_number":19,"context_line":"    cpuid | grep -i hypervisor_id"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Result should not be:"},{"line_number":22,"context_line":"    hypervisor_id \u003d \"KVMKVMKVM\\0\\0\\0\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff0f0b1f_452ad72b","line":19,"range":{"start_line":18,"start_character":21,"end_line":19,"end_character":33},"updated":"2017-05-23 21:26:12.000000000","message":"We normally format this like:\n\nusing the command::\n\n  ``cpuid | grep -i hypervisor_id``","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e85dde2fd70b3bd44ebb98ae3b9cd1ae882ee110","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    option \"-cpu kvm\u003doff\"."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    Verify if hiding hypervisor id is working on Linux based system by"},{"line_number":18,"context_line":"    using the command:"},{"line_number":19,"context_line":"    cpuid | grep -i hypervisor_id"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Result should not be:"},{"line_number":22,"context_line":"    hypervisor_id \u003d \"KVMKVMKVM\\0\\0\\0\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff0f0b1f_093aa797","line":19,"range":{"start_line":18,"start_character":21,"end_line":19,"end_character":33},"in_reply_to":"ff0f0b1f_452ad72b","updated":"2017-05-24 14:05:04.000000000","message":"Done","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05df23e0474f008f03f3f0c88dd672f1b3eb5ae9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    cpuid | grep -i hypervisor_id"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Result should not be:"},{"line_number":22,"context_line":"    hypervisor_id \u003d \"KVMKVMKVM\\0\\0\\0\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    You can enable this feature by adding the ``hide_hypervisor_id`` key"},{"line_number":25,"context_line":"    into the \u0027properties\u0027 dict of image metadata."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff0f0b1f_25236358","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":37},"updated":"2017-05-23 21:26:12.000000000","message":"Enclose in `` `` for code style.","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e85dde2fd70b3bd44ebb98ae3b9cd1ae882ee110","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    cpuid | grep -i hypervisor_id"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    Result should not be:"},{"line_number":22,"context_line":"    hypervisor_id \u003d \"KVMKVMKVM\\0\\0\\0\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    You can enable this feature by adding the ``hide_hypervisor_id`` key"},{"line_number":25,"context_line":"    into the \u0027properties\u0027 dict of image metadata."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff0f0b1f_69c3638a","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":37},"in_reply_to":"ff0f0b1f_25236358","updated":"2017-05-24 14:05:04.000000000","message":"Done","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05df23e0474f008f03f3f0c88dd672f1b3eb5ae9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    Result should not be:"},{"line_number":22,"context_line":"    hypervisor_id \u003d \"KVMKVMKVM\\0\\0\\0\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    You can enable this feature by adding the ``hide_hypervisor_id`` key"},{"line_number":25,"context_line":"    into the \u0027properties\u0027 dict of image metadata."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    [1]: http://git.qemu.org/?p\u003dqemu.git;a\u003dcommitdiff;h\u003df522d2a"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff0f0b1f_85d90f58","line":25,"range":{"start_line":24,"start_character":4,"end_line":25,"end_character":49},"updated":"2017-05-23 21:26:12.000000000","message":"I\u0027d rewrite this as:\n\nYou can enable this feature by setting the ``hide_hypervisor_id\u003dtrue`` property in a Glance image.","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e85dde2fd70b3bd44ebb98ae3b9cd1ae882ee110","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    Result should not be:"},{"line_number":22,"context_line":"    hypervisor_id \u003d \"KVMKVMKVM\\0\\0\\0\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    You can enable this feature by adding the ``hide_hypervisor_id`` key"},{"line_number":25,"context_line":"    into the \u0027properties\u0027 dict of image metadata."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    [1]: http://git.qemu.org/?p\u003dqemu.git;a\u003dcommitdiff;h\u003df522d2a"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff0f0b1f_e9d7734a","line":25,"range":{"start_line":24,"start_character":4,"end_line":25,"end_character":49},"in_reply_to":"ff0f0b1f_85d90f58","updated":"2017-05-24 14:05:04.000000000","message":"Done","commit_id":"140aabb9a44e1843f497646419e9c8a98ea5dd6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76482a8dfae7188b3715d0b0bd3a236aa7039b28","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hypervisors are adding on guests host its own signature e.g. KVM is adding"},{"line_number":5,"context_line":"    ``KVMKVMKVM\\0\\0\\0``, Xen: ``XenVMMXenVMM``."},{"line_number":6,"context_line":"    Existing of hypervisors signatures enables some paravirualization"},{"line_number":7,"context_line":"    features on the guest as well as disallowing certain drivers which test"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_7cfe5506","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":59},"updated":"2017-05-27 13:58:43.000000000","message":"This is hard to parse. Maybe something like:\n\n\"Some hypervisors add a signature to their guests, e.g...\"","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5d5da8455497d6de7feefd60912bab7a0bae290f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hypervisors are adding on guests host its own signature e.g. KVM is adding"},{"line_number":5,"context_line":"    ``KVMKVMKVM\\0\\0\\0``, Xen: ``XenVMMXenVMM``."},{"line_number":6,"context_line":"    Existing of hypervisors signatures enables some paravirualization"},{"line_number":7,"context_line":"    features on the guest as well as disallowing certain drivers which test"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_a7dcc918","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":59},"in_reply_to":"df140735_7cfe5506","updated":"2017-05-29 07:53:21.000000000","message":"Done","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76482a8dfae7188b3715d0b0bd3a236aa7039b28","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hypervisors are adding on guests host its own signature e.g. KVM is adding"},{"line_number":5,"context_line":"    ``KVMKVMKVM\\0\\0\\0``, Xen: ``XenVMMXenVMM``."},{"line_number":6,"context_line":"    Existing of hypervisors signatures enables some paravirualization"},{"line_number":7,"context_line":"    features on the guest as well as disallowing certain drivers which test"},{"line_number":8,"context_line":"    for the hypervisor to load e.g. Nvidia driver [1]:"},{"line_number":9,"context_line":"    \"The latest Nvidia driver (337.88) specifically checks"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_3c08dd26","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":38},"updated":"2017-05-27 13:58:43.000000000","message":"The existence of a hypervisor signature","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76482a8dfae7188b3715d0b0bd3a236aa7039b28","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hypervisors are adding on guests host its own signature e.g. KVM is adding"},{"line_number":5,"context_line":"    ``KVMKVMKVM\\0\\0\\0``, Xen: ``XenVMMXenVMM``."},{"line_number":6,"context_line":"    Existing of hypervisors signatures enables some paravirualization"},{"line_number":7,"context_line":"    features on the guest as well as disallowing certain drivers which test"},{"line_number":8,"context_line":"    for the hypervisor to load e.g. Nvidia driver [1]:"},{"line_number":9,"context_line":"    \"The latest Nvidia driver (337.88) specifically checks"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_d909f331","line":6,"range":{"start_line":6,"start_character":52,"end_line":6,"end_character":69},"updated":"2017-05-27 13:58:43.000000000","message":"paravirtualization","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5d5da8455497d6de7feefd60912bab7a0bae290f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hypervisors are adding on guests host its own signature e.g. KVM is adding"},{"line_number":5,"context_line":"    ``KVMKVMKVM\\0\\0\\0``, Xen: ``XenVMMXenVMM``."},{"line_number":6,"context_line":"    Existing of hypervisors signatures enables some paravirualization"},{"line_number":7,"context_line":"    features on the guest as well as disallowing certain drivers which test"},{"line_number":8,"context_line":"    for the hypervisor to load e.g. Nvidia driver [1]:"},{"line_number":9,"context_line":"    \"The latest Nvidia driver (337.88) specifically checks"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_27d0b9f7","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":38},"in_reply_to":"df140735_3c08dd26","updated":"2017-05-29 07:53:21.000000000","message":"Done","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5d5da8455497d6de7feefd60912bab7a0bae290f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hypervisors are adding on guests host its own signature e.g. KVM is adding"},{"line_number":5,"context_line":"    ``KVMKVMKVM\\0\\0\\0``, Xen: ``XenVMMXenVMM``."},{"line_number":6,"context_line":"    Existing of hypervisors signatures enables some paravirualization"},{"line_number":7,"context_line":"    features on the guest as well as disallowing certain drivers which test"},{"line_number":8,"context_line":"    for the hypervisor to load e.g. Nvidia driver [1]:"},{"line_number":9,"context_line":"    \"The latest Nvidia driver (337.88) specifically checks"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_47ebadaf","line":6,"range":{"start_line":6,"start_character":52,"end_line":6,"end_character":69},"in_reply_to":"df140735_d909f331","updated":"2017-05-29 07:53:21.000000000","message":"Done","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76482a8dfae7188b3715d0b0bd3a236aa7039b28","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    changing the KVM signature is sufficient for the driver"},{"line_number":13,"context_line":"    to load and work.\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    The new ``hide_hypervisor_id`` image metadata property hides the"},{"line_number":16,"context_line":"    hipervisor signature for the guest."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    Currently only libvirt compute driver can hide hipervisor signature"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_1c0d1937","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":32},"updated":"2017-05-27 13:58:43.000000000","message":"img_hide_hypervisor_id","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5d5da8455497d6de7feefd60912bab7a0bae290f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    changing the KVM signature is sufficient for the driver"},{"line_number":13,"context_line":"    to load and work.\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    The new ``hide_hypervisor_id`` image metadata property hides the"},{"line_number":16,"context_line":"    hipervisor signature for the guest."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    Currently only libvirt compute driver can hide hipervisor signature"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_870ae587","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":32},"in_reply_to":"df140735_1c0d1937","updated":"2017-05-29 07:53:21.000000000","message":"Done","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76482a8dfae7188b3715d0b0bd3a236aa7039b28","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    to load and work.\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    The new ``hide_hypervisor_id`` image metadata property hides the"},{"line_number":16,"context_line":"    hipervisor signature for the guest."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    Currently only libvirt compute driver can hide hipervisor signature"},{"line_number":19,"context_line":"    for the guest host."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_fc114555","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":14},"updated":"2017-05-27 13:58:43.000000000","message":"hypervisor","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5d5da8455497d6de7feefd60912bab7a0bae290f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    to load and work.\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    The new ``hide_hypervisor_id`` image metadata property hides the"},{"line_number":16,"context_line":"    hipervisor signature for the guest."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    Currently only libvirt compute driver can hide hipervisor signature"},{"line_number":19,"context_line":"    for the guest host."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_c7efbdae","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":14},"in_reply_to":"df140735_fc114555","updated":"2017-05-29 07:53:21.000000000","message":"Done","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76482a8dfae7188b3715d0b0bd3a236aa7039b28","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    The new ``hide_hypervisor_id`` image metadata property hides the"},{"line_number":16,"context_line":"    hipervisor signature for the guest."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    Currently only libvirt compute driver can hide hipervisor signature"},{"line_number":19,"context_line":"    for the guest host."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    According to libvirt documentation, this feature needs"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_bc1bcd71","line":18,"range":{"start_line":18,"start_character":51,"end_line":18,"end_character":61},"updated":"2017-05-27 13:58:43.000000000","message":"hypervisor","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76482a8dfae7188b3715d0b0bd3a236aa7039b28","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    The new ``hide_hypervisor_id`` image metadata property hides the"},{"line_number":16,"context_line":"    hipervisor signature for the guest."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    Currently only libvirt compute driver can hide hipervisor signature"},{"line_number":19,"context_line":"    for the guest host."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    According to libvirt documentation, this feature needs"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_dc0e8131","line":18,"range":{"start_line":18,"start_character":19,"end_line":18,"end_character":26},"updated":"2017-05-27 13:58:43.000000000","message":"the libvirt","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5d5da8455497d6de7feefd60912bab7a0bae290f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    The new ``hide_hypervisor_id`` image metadata property hides the"},{"line_number":16,"context_line":"    hipervisor signature for the guest."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    Currently only libvirt compute driver can hide hipervisor signature"},{"line_number":19,"context_line":"    for the guest host."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    According to libvirt documentation, this feature needs"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_a72a89e4","line":18,"range":{"start_line":18,"start_character":51,"end_line":18,"end_character":61},"in_reply_to":"df140735_bc1bcd71","updated":"2017-05-29 07:53:21.000000000","message":"Done","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5d5da8455497d6de7feefd60912bab7a0bae290f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    The new ``hide_hypervisor_id`` image metadata property hides the"},{"line_number":16,"context_line":"    hipervisor signature for the guest."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    Currently only libvirt compute driver can hide hipervisor signature"},{"line_number":19,"context_line":"    for the guest host."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    According to libvirt documentation, this feature needs"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_e7f2c19a","line":18,"range":{"start_line":18,"start_character":19,"end_line":18,"end_character":26},"in_reply_to":"df140735_dc0e8131","updated":"2017-05-29 07:53:21.000000000","message":"Done","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76482a8dfae7188b3715d0b0bd3a236aa7039b28","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    Currently only libvirt compute driver can hide hipervisor signature"},{"line_number":19,"context_line":"    for the guest host."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    According to libvirt documentation, this feature needs"},{"line_number":22,"context_line":"    MIN_LIBVIRT_VERSION\u003d1.2.8 [2]."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    To verify if hiding hypervisor id is working on Linux based system::"},{"line_number":25,"context_line":"    ``cpuid | grep -i hypervisor_id``"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_5c2cb198","line":22,"range":{"start_line":21,"start_character":4,"end_line":22,"end_character":34},"updated":"2017-05-27 13:58:43.000000000","message":"I think we can omit this. The libvirt driver currently requires a minimum of libvirt 1.2.9:\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L199\n\nSo we\u0027re already covered. In other words, if you don\u0027t have libvirt\u003e\u003d1.2.9 nova-compute won\u0027t start anyway.","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5d5da8455497d6de7feefd60912bab7a0bae290f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    Currently only libvirt compute driver can hide hipervisor signature"},{"line_number":19,"context_line":"    for the guest host."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    According to libvirt documentation, this feature needs"},{"line_number":22,"context_line":"    MIN_LIBVIRT_VERSION\u003d1.2.8 [2]."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    To verify if hiding hypervisor id is working on Linux based system::"},{"line_number":25,"context_line":"    ``cpuid | grep -i hypervisor_id``"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_073b7538","line":22,"range":{"start_line":21,"start_character":4,"end_line":22,"end_character":34},"in_reply_to":"df140735_5c2cb198","updated":"2017-05-29 07:53:21.000000000","message":"Done","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76482a8dfae7188b3715d0b0bd3a236aa7039b28","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    The result should not be (for KVM hypervisor)::"},{"line_number":28,"context_line":"    ``hypervisor_id \u003d KVMKVMKVM\\0\\0\\0``"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    You can enable this feature by setting the ``hide_hypervisor_id\u003dtrue``"},{"line_number":31,"context_line":"    property in a Glance image."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    [1]: http://git.qemu.org/?p\u003dqemu.git;a\u003dcommitdiff;h\u003df522d2a"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_3c21fda0","line":30,"range":{"start_line":30,"start_character":49,"end_line":30,"end_character":67},"updated":"2017-05-27 13:58:43.000000000","message":"img_hide_hypervisor_id","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5d5da8455497d6de7feefd60912bab7a0bae290f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    The result should not be (for KVM hypervisor)::"},{"line_number":28,"context_line":"    ``hypervisor_id \u003d KVMKVMKVM\\0\\0\\0``"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    You can enable this feature by setting the ``hide_hypervisor_id\u003dtrue``"},{"line_number":31,"context_line":"    property in a Glance image."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    [1]: http://git.qemu.org/?p\u003dqemu.git;a\u003dcommitdiff;h\u003df522d2a"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"df140735_c7445dba","line":30,"range":{"start_line":30,"start_character":49,"end_line":30,"end_character":67},"in_reply_to":"df140735_3c21fda0","updated":"2017-05-29 07:53:21.000000000","message":"Done","commit_id":"ba3bb0a74c9245bb5b7b049d48d792620ff06d6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cd81181a2c34f20ce406b8f04213b857353295c6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    Currently only the libvirt compute driver can hide hypervisor signature"},{"line_number":19,"context_line":"    for the guest host."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    To verify if hiding hypervisor id is working on Linux based system::"},{"line_number":22,"context_line":"    ``cpuid | grep -i hypervisor_id``"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    The result should not be (for KVM hypervisor)::"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"df140735_09c6de68","line":21,"range":{"start_line":21,"start_character":70,"end_line":21,"end_character":72},"updated":"2017-05-29 15:25:44.000000000","message":"This doesn\u0027t render properly because there should be blank line an indent after it.","commit_id":"2e1982c7196fc7d31c8e12bbbb035447ebed14c2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cd81181a2c34f20ce406b8f04213b857353295c6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    To verify if hiding hypervisor id is working on Linux based system::"},{"line_number":22,"context_line":"    ``cpuid | grep -i hypervisor_id``"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    The result should not be (for KVM hypervisor)::"},{"line_number":25,"context_line":"    ``hypervisor_id \u003d KVMKVMKVM\\0\\0\\0``"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    You can enable this feature by setting the ``img_hide_hypervisor_id\u003dtrue``"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"df140735_e9a04aa8","line":24,"range":{"start_line":24,"start_character":49,"end_line":24,"end_character":51},"updated":"2017-05-29 15:25:44.000000000","message":"same","commit_id":"2e1982c7196fc7d31c8e12bbbb035447ebed14c2"}],"releasenotes/notes/kvm-hidden-feature-509dbaaa0c0a210b.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d759930e921bd4ccf203aae0b6e01b7d18b6475e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    KVM hidden feature allows to hide KVM hypervisor signature on the guest."},{"line_number":5,"context_line":"    This enables disabling of some paravirualization features in the"},{"line_number":6,"context_line":"    guest as well as allowing certain drivers which test for the"},{"line_number":7,"context_line":"    hypervisor to load."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f044301_3cc3f8ef","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":76},"updated":"2017-05-05 10:17:17.000000000","message":"Could you be a little clearer about how this works. It\u0027s an image metadata so we should mention that at least. Something like:\n\n    KVM\u0027s \"hidden\" feature is now supported. This feature allows...\n\n    You can can enable the feature by adding the ``kvm_hidden``\n    key to image metadata.\n\nor similar?","commit_id":"4c6db8afbe9ade162262b98de2356791e518112b"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e97927e1f4c7029f01d7d64115ec34ed16eac36c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    KVM hidden feature allows to hide KVM hypervisor signature on the guest."},{"line_number":5,"context_line":"    This enables disabling of some paravirualization features in the"},{"line_number":6,"context_line":"    guest as well as allowing certain drivers which test for the"},{"line_number":7,"context_line":"    hypervisor to load."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f044301_7e761009","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":76},"in_reply_to":"3f044301_3cc3f8ef","updated":"2017-05-05 14:22:28.000000000","message":"Done","commit_id":"4c6db8afbe9ade162262b98de2356791e518112b"}]}