)]}'
{"nova/virt/libvirt/volume.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a1b93fc07fd83a73de7ef368eeda024a58f069e6","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        if use_multipath is None:"},{"line_number":212,"context_line":"            use_multipath \u003d CONF.libvirt_iscsi_use_multipath"},{"line_number":213,"context_line":"        self.num_scan_tries \u003d num_scan_tries"},{"line_number":214,"context_line":"        self.use_multipath \u003d use_multipath"},{"line_number":215,"context_line":"        super(LibvirtISCSIVolumeDriver,"},{"line_number":216,"context_line":"              self).__init__(connection, is_block_dev\u003dFalse)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2F%2FoY%3D","line":214,"updated":"2013-10-24 05:40:37.000000000","message":"Couldn\u0027t you use or here?\n\n    self.num_scan_tries \u003d num_scan_tries or CONF.num_iscsi_scan_tries\n\netc","commit_id":"0e54b9877fff9bd45c9e6d277c5ef592665f70c2"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5f8624941c095be9872943bdbce880eeff4b8ca0","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        if use_multipath is None:"},{"line_number":212,"context_line":"            use_multipath \u003d CONF.libvirt_iscsi_use_multipath"},{"line_number":213,"context_line":"        self.num_scan_tries \u003d num_scan_tries"},{"line_number":214,"context_line":"        self.use_multipath \u003d use_multipath"},{"line_number":215,"context_line":"        super(LibvirtISCSIVolumeDriver,"},{"line_number":216,"context_line":"              self).__init__(connection, is_block_dev\u003dFalse)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2F7F4%3D","line":214,"in_reply_to":"AAAATn%2F%2F%2FoY%3D","updated":"2013-10-25 06:57:15.000000000","message":"This is a common pattern, and if i use what you suggest if argument is 0 then a value from CONF will be used and this is not correct.","commit_id":"0e54b9877fff9bd45c9e6d277c5ef592665f70c2"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a1b93fc07fd83a73de7ef368eeda024a58f069e6","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        iscsi_properties \u003d connection_info[\u0027data\u0027]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        libvirt_iscsi_use_multipath \u003d self.use_multipath"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        if libvirt_iscsi_use_multipath:"},{"line_number":250,"context_line":"            #multipath installed, discovering other targets if available"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2F%2FoM%3D","line":247,"updated":"2013-10-24 05:40:37.000000000","message":"Why the local variable?","commit_id":"0e54b9877fff9bd45c9e6d277c5ef592665f70c2"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5f8624941c095be9872943bdbce880eeff4b8ca0","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        iscsi_properties \u003d connection_info[\u0027data\u0027]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        libvirt_iscsi_use_multipath \u003d self.use_multipath"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        if libvirt_iscsi_use_multipath:"},{"line_number":250,"context_line":"            #multipath installed, discovering other targets if available"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2F7Fo%3D","line":247,"in_reply_to":"AAAATn%2F%2F%2FoM%3D","updated":"2013-10-25 06:57:15.000000000","message":"Ok, will do","commit_id":"0e54b9877fff9bd45c9e6d277c5ef592665f70c2"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a1b93fc07fd83a73de7ef368eeda024a58f069e6","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        else:"},{"line_number":269,"context_line":"            self._connect_to_iscsi_portal(iscsi_properties)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        host_device \u003d self._get_host_device(iscsi_properties)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        # The /dev/disk/by-path/... node is not always present immediately"},{"line_number":274,"context_line":"        # TODO(justinsb): This retry-with-delay is a pattern, move to utils?"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2F%2FoA%3D","line":271,"updated":"2013-10-24 05:40:37.000000000","message":"Ditto on why this needs to be a local variable.","commit_id":"0e54b9877fff9bd45c9e6d277c5ef592665f70c2"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5f8624941c095be9872943bdbce880eeff4b8ca0","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        else:"},{"line_number":269,"context_line":"            self._connect_to_iscsi_portal(iscsi_properties)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        host_device \u003d self._get_host_device(iscsi_properties)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        # The /dev/disk/by-path/... node is not always present immediately"},{"line_number":274,"context_line":"        # TODO(justinsb): This retry-with-delay is a pattern, move to utils?"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2F7Fg%3D","line":271,"in_reply_to":"AAAATn%2F%2F%2FoA%3D","updated":"2013-10-25 06:57:15.000000000","message":"host_device is used more than on?e, and to compute it several times is not a good idea.","commit_id":"0e54b9877fff9bd45c9e6d277c5ef592665f70c2"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"a1b93fc07fd83a73de7ef368eeda024a58f069e6","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            LOG.debug(_(\"Found iSCSI node %(disk_dev)s \""},{"line_number":296,"context_line":"                        \"(after %(tries)s rescans)\"),"},{"line_number":297,"context_line":"                      {\u0027disk_dev\u0027: disk_dev,"},{"line_number":298,"context_line":"                       \u0027tries\u0027: tries})"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        if libvirt_iscsi_use_multipath:"},{"line_number":301,"context_line":"            #we use the multipath device instead of the single path device"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2F%2Fn8%3D","line":298,"updated":"2013-10-24 05:40:37.000000000","message":"I wonder if this bit would be better off as a looping call?","commit_id":"0e54b9877fff9bd45c9e6d277c5ef592665f70c2"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5f8624941c095be9872943bdbce880eeff4b8ca0","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            LOG.debug(_(\"Found iSCSI node %(disk_dev)s \""},{"line_number":296,"context_line":"                        \"(after %(tries)s rescans)\"),"},{"line_number":297,"context_line":"                      {\u0027disk_dev\u0027: disk_dev,"},{"line_number":298,"context_line":"                       \u0027tries\u0027: tries})"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        if libvirt_iscsi_use_multipath:"},{"line_number":301,"context_line":"            #we use the multipath device instead of the single path device"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2F7FE%3D","line":298,"in_reply_to":"AAAATn%2F%2F%2Fn8%3D","updated":"2013-10-25 06:57:15.000000000","message":"Yes, but not in this change request.","commit_id":"0e54b9877fff9bd45c9e6d277c5ef592665f70c2"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"dbaaec30f18ba856cb8e5e559d6cc1304ab6e607","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        super(LibvirtISERVolumeDriver,"},{"line_number":521,"context_line":"              self).__init__(connection,"},{"line_number":522,"context_line":"                             num_scan_tries\u003dCONF.num_iser_scan_tries,"},{"line_number":523,"context_line":"                             use_multipath\u003dCONF.libvirt_iser_use_multipath)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    def _get_multipath_iqn(self, multipath_device):"},{"line_number":526,"context_line":"        entries \u003d self._get_iscsi_devices()"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2FYAE%3D","line":523,"updated":"2013-11-07 22:36:17.000000000","message":"I think this will be easier to read like so:\n\n         super(LibvirtISERVolumeDriver, self).__init__(\n             connection, num_scan_tries\u003dCONF.num_iser_scan_tries,\n             use_multipath\u003dCONF.libvirt_iser_use_multipath)","commit_id":"7f8707bf05656fcea0ec83348f4470b23b1cbada"},{"author":{"_account_id":7808,"name":"Xavier Queralt","email":"xqueralt@gmail.com","username":"xqueralt"},"change_message_id":"68448e67b887066cd581aa5190551f07d8aad327","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        if use_multipath is None:"},{"line_number":224,"context_line":"            use_multipath \u003d CONF.libvirt_iscsi_use_multipath"},{"line_number":225,"context_line":"        self.num_scan_tries \u003d num_scan_tries"},{"line_number":226,"context_line":"        self.use_multipath \u003d use_multipath"},{"line_number":227,"context_line":"        super(LibvirtISCSIVolumeDriver,"},{"line_number":228,"context_line":"              self).__init__(connection, is_block_dev\u003dFalse)"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2FWwU%3D","line":226,"updated":"2013-11-08 11:29:29.000000000","message":"I don\u0027t see the need of the new two constructor arguments as they aren\u0027t used anywhere else but the child class.\n\nYou can set the two attributes to the iscsi values after calling the parent\u0027s init and for the child class, also after calling the parent\u0027s init, set them to the iser values.","commit_id":"742627ba57acfba9d29fe22a94a4bda4ede13643"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"cef0f751b4b5611ab894299639f5c9f87c92f342","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        if use_multipath is None:"},{"line_number":224,"context_line":"            use_multipath \u003d CONF.libvirt_iscsi_use_multipath"},{"line_number":225,"context_line":"        self.num_scan_tries \u003d num_scan_tries"},{"line_number":226,"context_line":"        self.use_multipath \u003d use_multipath"},{"line_number":227,"context_line":"        super(LibvirtISCSIVolumeDriver,"},{"line_number":228,"context_line":"              self).__init__(connection, is_block_dev\u003dFalse)"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2FPrM%3D","line":226,"in_reply_to":"AAAATn%2F%2FWwU%3D","updated":"2013-11-12 10:45:39.000000000","message":"ok, will do","commit_id":"742627ba57acfba9d29fe22a94a4bda4ede13643"}]}